@Hosch250 I'm getting the gist of the article.

I'm unable to duplicate what is shown solely on whats shown in the inheritance diagram. Whatever is missing I try and code as best I can. Very helpful in connecting the pieces that I've started to understand.

@Hosch250 Duck check: with Figure 9 instead of 3 different Assert would it be better to have 3 tests with descriptive names? WorkspacesIsntEmpty, EnsureCorrectWorkspaceCreated, and EnsureAllCustomersWorkspaceCloses. That way instead of 3 reasons for a test to fail there's only 1 and you know exactly what went wrong.

@IvenBach sounds about right :)

#WarmFuzzies. Somehow in spite of my duckheadedness I'm piecing together this example. Fixing the red-squiglies-of-doom isn't as hard as it once was!

enjoying R#?

Oh... This isn't with R#. I only have that at home. This is all cave-man hands on fixing.

By using descriptive test names, that should allow me to replace the string message parameter.

        [TestMethod]
        [TestCategory("Code Metrics")]
        public void WeirdSub_HasNestingLevel_One()
        {
            var code = @"
Option Explicit

Public Sub WeirdSub()
    ' some comments
    Debug.Print ""An expression, that "" & _
            ""extends across multiple lines, with "" _
                & ""Line continuations that do weird stuff "" & _
         ""but shouldn't account for nesting""
    Debug.Print ""Just to confuse you""
End Sub
";
            using (var state = MockParser.ParseString(code, out var _))

^^ welcome to the weird edge-case tests for Code Metrics.

@IvenBach I asked about that a while back. Might even be the one that opened the issue on it. (Maybe not, I've slept since then and didn't go look.)

@FreeMan yep, you are github.com/rubberduck-vba/Rubberduck/issues/3173

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #3522: Code Metrics (WIP - Backend finished)

[rubberduck-vba/Rubberduck] build for commit 2801b01e on unknown branch: AppVeyor was unable to build non-mergeable pull request

BUILD FAILURE!

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #3522: Code Metrics (WIP - Backend finished)

non-mergeable yadda yadda

[rubberduck-vba/Rubberduck] build for commit 65bce471 on unknown branch: AppVeyor was unable to build non-mergeable pull request

BUILD FAILURE!

For all you Yanks, have a Merry Thanksgiving! The rest of y'all just enjoy your Thursday.

@FreeMan I'd rather a dupe be brought up than having something fall through the cracks.

Oh yeah, that sounds like an interesting amount of quite different people :D

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #3522: Code Metrics (WIP - Backend finished)

@FreeMan pffft. Thanksgiving was last month =)

enjoy yours nonetheless!

@Mat'sMug Eh?

World > USA

@Hosch250, so you're at IBM? I'll ping you tomorrow on ST then :P

@NelsonVides nah, Rolf Lear is - he used to be moderator on CR

(is.. maybe it's was actually... haven't heard of him in a while)

oh, I see

last I knew he completely switched toolstack, but still was at IBM

he got a lot of fancy new toys to play with

he with fancy toys and on the meantime IBM is just giving me ugly macros written in the early 2000 by random finances people and want me to fix everything :|

@NelsonVides No.

[rubberduck-vba/Rubberduck] build for commit 7fcdd7e4 on unknown branch: AppVeyor build succeeded

@NelsonVides you're lucky. I'm putting up with AS/400 iSeries stuff written in the previous century, and it's a royal PITA!

omg we still care about those

We run an AS/400 too, and the company has been saying it's on the way out the door for 15 years :)

hmmm ...

The guy in charge still swears its faster and less crashy than the others.

guys think about your grandchildrens coping with your code in the future and write good code xD

RD Question: Does the CW "DefaultInterfaces" convention not bind internal implementations of an interface?

because that would explain the binding-exception I got for making CodeMetricsAnalyst internal...

anybody to point out for me what @Vogel612 is talking about? I need to learn so darn much

Keywords: "Dependency Injection" "Inversion of Control" and "CastleWindsor"

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #3522: Code Metrics (WIP - Backend finished)

@Vogel612 you have internal interfaces?

it's possible CW only sees public stuff..

no. an internal implementation

an internal class Foo : ISomething then?

internal class Foo : IFoo

see: github.com/rubberduck-vba/Rubberduck/pull/3522/commits/…

IIRC CW is setup to only look at public classes

@Vogel612 googling everything, I have some reads for tonight then.

            foreach (var assembly in assembliesToRegister)
            {
                container.Register(Classes.FromAssembly(assembly)
                    .Where(type => type.Namespace != null
                                   && !type.Namespace.StartsWith("Rubberduck.VBEditor.SafeComWrappers")
                                   && !type.Name.Equals("SelectionChangeService")
                                   && !type.Name.EndsWith("Factory")
                                   && !type.Name.EndsWith("ConfigProvider")

does Classes.FromAssembly take other params?

(and does your class match the Where criteria)

it works when the class is made public

and FromAssembly does not take other params

hmm

since I'm not setting it up explicitly, that should be the relevant code...

this might become a problem the day we want to make things internal and only expose a public API for plug-ins

@Vogel612 IIRC it doesn't.

but eh, let's cross the bridge when we get to the river, and make it public for now :)

^^ that

that said .. maybe we should reopen #1600, if we intend to actually do it (cough)

[rubberduck-vba/Rubberduck] Vogel612 removed label status-declined from issue #1600: Make the project internals visible to the TestProject

[rubberduck-vba/Rubberduck] Vogel612 added label status-deferred to issue #1600: Make the project internals visible to the TestProject

[rubberduck-vba/Rubberduck] Vogel612 added label technical-debt to issue #1600: Make the project internals visible to the TestProject

[rubberduck-vba/Rubberduck] build for commit 8794aab7 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Vogel612 commented on issue #1600: Make the project internals visible to the TestProject

> Castle-Windsor doesn't bind the default interface convention for internal classes. See 8794aab7939186ae04701c5c32fd76417f9dd082 as a symptom. As soon as we make stuff internal, we will need to find a solution to that or we can't even do this

[rubberduck-vba/Rubberduck] Vogel612 reopened issue #1600: Make the project internals visible to the TestProject

@Mat'sMug Do you have any good tutorials for using Modals in Excel?

@Maldred hi!

modals, like, UserForm?

Yea! :)

I remember seeing a nice website/tutorial (I think that it was you) somewhere that did amazing explaining how to use them properly

I suppose you read this one?

this one also touches on the subject, but with a more explicit goal at abstraction and testability

That's exactly it!

yay!

Thank you so much :)

my pleasure!

By the way, I love your work and very much appreciate it

thanks :)

okay the blog really needs a ToC ...

^

@Vogel612 you have a WP account?

nope

aw

and no intent of making one

I'd make you admin lol

He's threatening you with that.

LOL

Hey @Mat'sMug, would you be able to answer a question I asked on SO?

busy at work ATM, maybe later... link?

Hey no worries, and that'd be great

I'll take a look tonight

*try to

[rubberduck-vba/Rubberduck] Vogel612 commented on pull request #3522: Code Metrics (WIP - Backend finished)

@Maldred Feel free to hang around this pond. Lots of good stuff.

[rubberduck-vba/Rubberduck] Vogel612 commented on pull request #3522: Code Metrics (WIP - Backend finished)

But I'm very interested in learning more

LOL at #2.

@Duga lol

@Hosch250 You there? I'm stuck on a part and can't figure it out.

@Mat'sMug some exception deep inside the presentation framework... edit not allowed...

Kind of.

gotta get the layout fixed first tho

I'm busy doubling the speed of processing a huge data set.

I'm on Figure 10 of msdn.microsoft.com/en-us/magazine/dd419663.aspx and keep getting errors. It's related to xmlns:vm="clr-namespace:DemoApp.ViewModel", specifically the .ViewModel part.

afk for a bit

Do you have that class defined?

Specifically, with that name in that namespace?

I only had everything in a singular namespace.

This was the first time that I had seen anything mentioned of the namespace.

I am using Hosch_MVVM_Article and when I tried editing AllCustomersView to be in the namespace Hosch_MVVM_Article.View I started getting errors and couldn't resolve them.

You need a class to exist in the namespace you are specifying.

TTGH

Making the changes and ensuring the files are in the new namespace doesn't resolve it.

I'll keep face-keyboarding for a solution.

Sorry, busy finishing something at work, then going home.

Be around tomorrow.

I took the time to read some more. stackoverflow.com/questions/26365466/wpf-data-template-vs-view and stackoverflow.com/questions/19864891/… lead me to believe the noncomprehension falls on me. I've read but can't fully understand what's going on.

@Vogel612 To make the default interface registration register internal classes, you have to change it. Classes only considers concrete public classes, IIRC.

Just have a short look at the registration by convention part of the CW documentation.