« first day (733 days earlier)      last day (2447 days later) » 

17:01
@Mat'sMug Does that look right?
Should I fix the others the same way?
what's the parser rule one level above moduleOption?
also, does this break the parser?
    Sub DoSomething()
    End Sub
(indented)
hi @Gareth!
moduleDeclarationsElement :
    attributeStmt
    | declareStmt
    | defDirective
	| enumerationStmt
	| eventStmt
	| constStmt
	| implementsStmt
	| variableStmt
	| moduleOption
	| typeStmt
@Mat'sMug Yes, didn't you see my comment?
I'd put the whiteSpace? there I think
@Hosch250 missed it
Oh, that makes sense.
if it breaks module body too, then move it up a level and see what you get
you're writing tests for that? ;-)
17:04
Sure.
@all hello.. Just on briefly
@Mat'sMug It doesn't break module bodies. " Dim b As Boolean" works just fine.
that's member body
to check for updates. Still trying to get the GUI working again. but just haven't had time since my move and other problems.
cheers all
@Mat'sMug Well, give me an example, then.
17:05
@Gareth no rush, no pressure :)
@Gareth I've always heard moves are tough.
moduleDeclarationsElement :
    attributeStmt
    | declareStmt
    | defDirective
	| enumerationStmt
	| eventStmt
	| constStmt
	| implementsStmt
	| variableStmt
	| moduleOption
	| typeStmt
;

moduleBody :
	(moduleBodyElement endOfStatement)*;
these two
huh, what's up with the indentation there
@Mat'sMug Chat tabs
no, they're actually in the code file
it's a thing
it's inconsistent
Oh. Help.
Want me to run a replace over the text?
17:08
yeah, might as well
@Gareth did you see the release notes for 2.0b?
> Extract Method refactoring has been completely rewritten and is now much more robust, thanks to the awesomeness of @grleachman (yes I mean it, Gareth!); user interface and function extraction should be back for next release.
if not for next release, then make that at some point in the future ;-)
@Hosch250 I'd suggest using whiteSpace* instead
@Vogel612 What's the difference?
I think ? is only one optional ws
and * is any number of (including zero)
@Mat'sMug Probably not next release. I plan on doing one early next week.
whiteSpace : (WS | LINE_CONTINUATION)+;
17:10
@Vogel612 It is working just fine here with 0 and 4 spaces.
I'm with birdie @Vogel612 here
OK.
It is working, though.
@Mat'sMug if birdy, then the mighty, aight?
OK, it is working perfectly with ?.
then don't mind me
17:12
moduleDeclarationsElement :
    whiteSpace?
    (attributeStmt
    | declareStmt
    | defDirective
	| enumerationStmt
	| eventStmt
	| constStmt
	| implementsStmt
	| variableStmt
	| moduleOption
	| typeStmt)
;
BBIAB
@Mat'sMug That fixes the sub one too.
@Hosch250 right, that's because whiteSpace already says "one or more"
fine then
cool! save and regenerate :)
Huh, it doesn't fix it for function.
Or sub-on-multiple-lines.
It fixes for sub-on-one-line.
did you add it to moduleBody?
17:15
No, doing that now.
Fixed.
moduleDeclarationsElement :
    whiteSpace?
    (attributeStmt
    | declareStmt
    | defDirective
	| enumerationStmt
	| eventStmt
	| constStmt
	| implementsStmt
	| variableStmt
	| moduleOption
	| typeStmt)
;
Huh.
what's the huh for?
It isn't replacing the spaces.
    var str = File.ReadAllText(file);
    str.Replace("\t", "    ");
I think the VBE might be doing that
To the .g4?
moduleDeclarationsElement :
    whiteSpace?
    (attributeStmt
    | declareStmt
    | defDirective
    | enumerationStmt
    | eventStmt
    | constStmt
    | implementsStmt
    | variableStmt
    | moduleOption
    | typeStmt)
;
Fixed.
moduleOption :
    OPTION_BASE whiteSpace numberLiteral                     # optionBaseStmt
    | OPTION_COMPARE whiteSpace (BINARY | TEXT | DATABASE)     # optionCompareStmt
    | OPTION_EXPLICIT                                         # optionExplicitStmt
    | OPTION_PRIVATE_MODULE                                 # optionPrivateModuleStmt
;
Well...
17:30
[Hosch250/Rubberduck] Hosch250 pushed commit 811a423b to Issue1742: Close #1742. Convert all tabs to spaces in VBAParser.g4.
@Mat'sMug Don't merge.
I forgot to add the tests.
Lunch time now, will add them when I get back.
not merging until @awgaya eyes it :)
gosh, I should eat too
[rubberduck-vba/Rubberduck] build for commit 811a423b on unknown branch: AppVeyor build succeeded
17:54
@Zak and @Mat'sMug Just wanted to say thanks for your help earlier. Worked perfectly :)
cool!
What's up, Duck?
18:13
@Hosch250 care to sync the PR?
I'm going for a walk, I need caffeine
thanks!
[Hosch250/Rubberduck] Hosch250 pushed commit 5cdd196a to Issue1742: Make code inspection settings update without reordering
Merge pull request #1740 from Hosch250/SettingsTweaks

Make code inspection settings update without reordering
Merge pull request #1743 from Hosch250/Issue1731

Prevent (mostly) SC crashes on merge
[Hosch250/Rubberduck] Hosch250 pushed commit 2e338474 to Issue1742: Merge branch 'next' into Issue1742
@Zak Want me to produce a release build just for you to download with this fix?
I'd kind of like to know as many bugs as possible before the next public release, and this seems to be a bit of a show-stopper for you.
[rubberduck-vba/Rubberduck] build for commit 2e338474 on unknown branch: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 811a423b to next: Close #1742. Convert all tabs to spaces in VBAParser.g4.
[rubberduck-vba/Rubberduck] Hosch250 pushed commit ee5654be to next: Add a few tests
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 2e338474 to next: Merge branch 'next' into Issue1742
Merge pull request #1746 from Hosch250/Issue1742

Allow leading spaces in a bunch of stmt types. Convert all tabs to spaces in VBAParser.g4.
18:27
@Hosch250 do the tests fail without the fix?
Don't know.
They should
Mind copying them in before you pull and checking?
That's why test-first matters ;-)
Will do though
> This is behaving like this because we add a bunch of components in a row and the sink calls the parses.
[rubberduck-vba/Rubberduck] build for commit 151566f4 on next: AppVeyor build succeeded
18:43
Merge pull request #1746 from Hosch250/Issue1742

Allow leading spaces in a bunch of stmt types. Convert all tabs to spaces in VBAParser.g4.
[Hosch250/Rubberduck] Hosch250 pushed commit e19a4ebc to Issue1744: Prevent hooks from requesting a parse for each component when opening a repo
> … a repo
[rubberduck-vba/Rubberduck] build for commit e19a4ebc on unknown branch: AppVeyor build succeeded
[Hosch250/Rubberduck] Hosch250 pushed commit 09e65aaf to Issue157: Close #157
[rubberduck-vba/Rubberduck] build for commit 09e65aaf on unknown branch: AppVeyor build succeeded
> ckuhn203 opened this issue on 23 Jan 2015 · 29 comments
wow
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 09e65aaf to next: Close #157
Merge pull request #1748 from Hosch250/Issue157

Discover SC projects by project ID rather than name
[rubberduck-vba/Rubberduck] build for commit 433ebcde on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit f916e83a on next: AppVeyor build succeeded
Well, RD already feels more stable now than last night.
yesterday, by Mat's Mug
besides, we have fewer bugs than yesterday, and more than tomorrow
19:44
> Just to help prevent this even more, I'm going to disable the sinks from firing parses when we load/unload components, as happens during branch switches.
Merge pull request #1747 from Hosch250/Issue1744

Prevent hooks from requesting a parse for each component when opening a repo
Merge pull request #1748 from Hosch250/Issue157

Discover SC projects by project ID rather than name
[Hosch250/Rubberduck] Hosch250 pushed commit 45b41839 to Issue1529: Disable sinks for each loaded component.
> Close #1529
[rubberduck-vba/Rubberduck] build for commit 45b41839 on unknown branch: AppVeyor build succeeded
20:01
1
Q: Excel VBA to parse JSON out of Google Maps API

S MeadenSome code that I wrote and broke into 5 separate questions on stack overflow. Some guy wanted to query Google Maps receive some JSON and then for each result found within that JSON do another query. I didn;t quite understand what he wanted at first and so actually there is some superfluous code...

20:24
[Hosch250/Rubberduck] Hosch250 pushed commit 8b399447 to SourceControlTweaks: Set added component status to Added instead of Unchanged
@Duga oooh nice!!
21:12
@Mat'sMug Got a PR that closes 3 issues.
[rubberduck-vba/Rubberduck] build for commit f630d321 on unknown branch: AppVeyor build succeeded
> Could this be #1406 all over again? I didn't submit the 2.0b installer to the Microsoft Malware Protection Center, @Hosch250 can you do that? Make sure you submit the exact same executable (download it from the GitHub release page to be sure).
@Mat'sMug No, this is simply because we didn't sign it.
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 45b41839 to next: Disable sinks for each loaded component.
Merge pull request #1749 from Hosch250/Issue1529

Disable sinks for each loaded component.
none of the previous builds were signed, why would it be a problem now?
21:17
Windows Defender didn't flag it as a virus, Windows just is warning us that we might be downloading something we don't want.
@Mat'sMug Because it was a problem then too?
Didn't you read my comment?
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 8b399447 to next: Set added component status to Added instead of Unchanged
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 7714d807 to next: Remove file from working directory when removed from VBE
[rubberduck-vba/Rubberduck] Hosch250 pushed commit f630d321 to next: Remove repository if the directory cannot be found.
21:18
1.4.x wasn't white-listed either
Merge pull request #1750 from Hosch250/SourceControlTweaks

Source control tweaks
> @retailcoder nope, this is different. It's basically that "Do you really wish to run this software named ... published by ..." you also get when running freshly downloaded .exe files or similar

Basically a digital signing process needs to be completed to tell the one opening the setup: "This is from Rubberduck-VBA, 5 realz"
@Mat'sMug And I had the same issue with Windows flagging it as not being signed.
mkay
make sure you document the process in a wiki page then
OK.
@Mat'sMug I'm going to create a file to sign it and password protect it.
Want me to email it to you, raw password and all?
I don't have access to those fancy password protection stuff :/
[rubberduck-vba/Rubberduck] build for commit cf807b83 on next: AppVeyor build succeeded
Merge pull request #1749 from Hosch250/Issue1529

Disable sinks for each loaded component.
Merge pull request #1750 from Hosch250/SourceControlTweaks

Source control tweaks
[Hosch250/Rubberduck] Hosch250 pushed commit e1699d03 to SignBuild: Add signing key to .dll
[rubberduck-vba/Rubberduck] build for commit 7ad4a9f6 on next: AppVeyor build succeeded
21:28
@Hosch250 sure
@Mat'sMug The PR has the signed file.
I'll email you the password.
I signed each .dll with the same key--hope that is OK.
[rubberduck-vba/Rubberduck] build for commit e1699d03 on unknown branch: AppVeyor build failed
BUILD FAILURE!
not good
?
They don't have the file.
We'll have to not sign the debug builds.
> Unable to get MD5 checksum for the key file "RubberduckSigningKey.pfx". Could not find file 'C:\projects\rubberduck\Rubberduck.SettingsProvider\RubberduckSigningKey.pfx'.
or we could include it in the build environment somehow?
21:35
maybe you don't want to make your signing key public
cough
or would that defeat the purpose of signing ...yeah
[Hosch250/Rubberduck] Hosch250 pushed commit a06aac1d to SignBuild: Left the key in, but disabled signing
@Mat'sMug I may not have the best password thing, but I did my best.
21:36
> I just made it sign the build. I hope to do another release on Monday, but if you want, I can make you a custom build for you to check this out.
Hi, @PeterMTaylor.
Just discussing your issue.
Yep saw that, morning from me everyone. On my way to work
Got to the tests.
@PeterMTaylor hi!
Not nice when a train is already late leaving after the previous one is cancelled though.
21:42
[rubberduck-vba/Rubberduck] build for commit a06aac1d on unknown branch: AppVeyor build succeeded
Down to two pages of 2.0 issues.
> No they aren't.
> I don't think I can do anything about this for existing repos very cleanly, but if you go through RD, any components removed from the VBE should be deleted from the repo as well since #1750.
> Should be done with #1751, but we might as well leave it open until it is tested.
> Please check out the beta. We fixed a bunch of bugs since the alpha release, and this may well be one of them.
22:01
Hi, @jt2000.
> This is an interesting issue. Simply setting the active VB project causes this window to lose focus, event with the PE closed.
Whoops, just closed VS...
> So, make the CE get back the focus if the active VBProject was set by an action that occurred in the CE?
That's the tricky part.
I tried going calling SetFocus() already....
22:06
6:05PM, I need to get out of here and get home before I go permanently nuts
hi @jt2000! lurking? you write VBA? C#?
@Mat'sMug Still trying to recruit people?
lol, do we ever have too many contributors? :D
I honestly have no idea what's going on
Or too many cook spoil the broth so to speak
I'm just a new stackexchange user testing out chat rooms
22:10
Did we pass @jt2000?
Well, you found one of the friendliest ones on the network.
@jt2000 hehe... we're working on a C# add-in for the Visual Basic Editor (VBE), the VBA IDE. the project is called "Rubberduck"; we have our GitHub hooks sending everything (issues, releases, pull requests, etc) into this chat room, via @Duga the lovely chat bot. The official Code Review chat is The 2nd Monitor, if you want to come say hi to the site regulars =)
TTQW, BBL
I actually like the idea of the build automatically signing it @Mat'sMug now the question is (for me) will a public sign be including in my fork when I rebuild it?
@PeterMTaylor No.
We had to disable it because of AppVeyor.
but if it's just you running your build, it doesn't need to be signed anyway
22:15
Ok
To turn it on, you need to go into each project (except the tests), go to the Signed tab, and check the box.
it's if you're going to distribute it that it becomes an issue :)
We'll just do that for release builds.
</mug>
Ok then, so that's what our issue will be if the next release is ready for distribution
Ok
22:17
@Mat'sMug Did you figure out the password?
Sounds cryptic?
@Mat'sMug Would opening the Windows command line be good enough for #104?
Anyway will catch ya all either at lunch or later in my day as I have approached my workplace.
@Hosch250 for git command-line?
I'd prefer PowerShell
That's what I use.
Ugh, I hate the PS commandline.
22:25
PowerShell is sooooo much better for this
VS opens the main one...
VS opens PS for me
Not for me.
Does cmd.exe show the current branch?
cmd.exe?
Oh, no.
22:26
PS does
I always know which branch I'm in.
Anyway, driving now - later
See you.
> Well, RD already always feels more stable now than last night.
@ThunderFrame Not always.
Most definitely not always.
22:34
Does the Source Control feature export every module, delete the local ones and then re-import?
Yeah.
It is pretty inefficient, but works OK.
we buried a feature
Which?
I thought I created an issue for it, but can't find it now
export/delete/import is a way of cleansing the vbProject - Forces VBE to load the file from text and throw away in cached p-code/extra junk that can build up and corrupt a project over time
Well, just use source control.
Every time it switches branches, it'll do it.
22:42
Access has the feature when you add a decompile switch on startup.
> The VBA Code Cleaner DOES NOT support 64-bit versions of Excel. It runs in all 32-bit versions of Excel on any version of Windows
CodeCleaner is another Rob Bovey utility.
Professional Excel Development author?
how are they relevant?
@Hosch250 yeah, but that's kind of burying the feature. We should add a more explicit command (even if it uses the source-control method underneath). Although, IIRC, the CodeCleaner add-in offers and API. Do we expose Source Control via the API?
Yes, we do.
23:00
I (and many forum posts) always used to recommend users install
- MZ Tools 3
- SmartIndenter
- CodeCleaner

MZ Tools 3 isn't available anymore (8.0 is paid licence)
SmartIndenter is 32-bit only
CodeCleaner is 32-bit only
Rubberduck fills the void of CodeCleaner and SmartIndenter, and brings loads more features... And it's free.
@Vogel612 and Smart Indenter author too
> Export/delete/reimporting is already functionally available via Source Control, but we should expose the Decompile functionality as an explicit command (maybe with less UI than source Control)

See the popular Excel Add-In CodeCleaner
http://www.appspro.com/Utilities/CodeCleaner.htm
@Hosch250 you know what, come to think of it, I always launch git command-line from my start menu... it came with GitHub for Windows, ..that's the PowerShell tool I'm using actually. ...and I like it quite much.. I think the VS command-line also shows which branch you're in and how many commits ahead/behind it is vs the remote
@Mat'sMug Are you using the right-click menu?
Huh? Where?
23:10
You can set that to open powershell or the normal commandline.
@Mat'sMug Right-click the start button.
I always use Git Bash myself. Old habits.
No lol I mean I have a shortcut to it in my start menu, next to my GitHub for Windows shortcut
In a dream world we'd hijack the immediate pane and turn it into a git command-line tool lol
23:12
I always go Team Viewer--Actions--Command line.
That's Team Explorer ;-)
Oh yea.
Doesn't the Git provider accept raw commands and return raw output?
If it does, what's wrong with an RD git console?
> Rubberduck.Setup.2.0b.exe (5.27MB) - Downloaded 8 times.
Last updated on 2016-06-08
2
woot! a whopping 8 downloads!
@Comintern nothing at all :-)
It's just lazier to just fire up cmd.exe no?
I thought I was lazy...
23:20
lol
23:36
@Comintern nope it doesn't. It's a rather thin-ish wrapper over another thin wrapper over a reimplementation IIUC
That explains why I always use the command line instead of the VS tools I guess.
because VS makes doing useful stuff needlessly hard
The funny thing is that you can attach VS to another crashing VS instance to debug it.
...but you can't publish to a bare repo...
I'm not sure that the menus are tearing down fast enough. Found this thread pending when the main thread threw an access violation:
3956	0	Worker Thread	Win32 Thread	office.dll!Microsoft.Office.Core._CommandBarButtonEvents_EventProvider.Finalize	Highest
 	 	 	 	[External Code]
 	 	 	 	[Managed to Native Transition]
 	 	 	 	office.dll!Microsoft.Office.Core._CommandBarButtonEvents_EventProvider.Finalize()
 	 	 	 	[Native to Managed Transition]
 	 	 	 	[External Code]
Would it be unreasonable to put a hook into the main Excel process to delay the WM_DESTROY from getting through until RD is shut down to a point where it wouldn't matter if Excel is busy simultaneously shutting down?
23:58
@Comintern heck why not, if it works? ;-)

« first day (733 days earlier)      last day (2447 days later) »