@Izzy I've ported the whole gist mess to a full repository and imported everybodies gists as branches to make it easy to see differences between them and port anything useful between them. For example the diffs in your branch to main are here: github.com/alerque/SE-AutoReviewComments/compare/…
@Caleb Also, some of my comments in the script might be removed (e.g. line 4 from the end; shall I do that kind of cleanup in my Gist, and you pull again then?)
@Benjol That's why I setup branches, so we can pull in the script modifications but leave people's comments and custom stuff in their own branches (preferably that they then fork to continue editing).
That and I changed machine a while ago, and can't quite remember what I have to do so that github will recognise me and accept commits from here
If I must confess all, I've been using git for years, but only ever on my own. So I can handle branching and merging, and sort of grok remotes. But never done both
@Izzy How does this patch look. I rebased your commits on @Benjol's latest and selected only the parts of the diff that were not changes to the default data set.
@Benjol the part Caleb just pointed at: On the sites I'm active, the "Stack Exchange" string was always remaining in $SITENAME$ (e.g. "Welcome to Software Recommendations Stack Exchange"). I lacked the time to check for all possible sites, so this was my "quick hack" to get rid of it. Might need improvement, but my replacement did a better job for the sites I'm on.
@Benjol 2nd piece is lines 185+186 in this patch. Is there any place where you depend on GetStorage() returning undefined? If not, my patch could stay.
@Caleb Did you import my defaultMessages? If not, you don't have "site specific" data stored.
@Benjol 3rd and last part requiring a closer look: Lines 352+356. Should work fine (and substr should be slightly faster than a regex replace), but the regex replace (which you also used before) might be more "error-prone". Not sure.
@Caleb I don't think so, but let me check again. AFAIR that line just strips of the " Stack Exchange" part from the Welcome message.
@Caleb I could put that into a separate Gist meanwhile, and you could pull it into your corresponding branch?
@Caleb line 80 had placed it into localStorage. But Benjol's original script did that as well.
@Izzy I imported that bit anyway. (and clobbered the one I had already pushed so that is now what shows up at github). I did add tho ? modifier on the space just in case.
I have taken the liberty of doing some organization.
I have created a full blown Github repo here. The master branch is the latest from benjol's gist and all commit history is included. The master branch can be installed from this alternate location as a userscript using this url. This should m...
@Izzy, I'm not sure. I'm afraid I'm no good at just looking at diffs and seeing if it will work in all cases or not.
@Caleb, thanks for your help. I think that as a minimum I would take my last version and update it to point to github instead of gist.
But I'm not yet comfortable absorbing all of Izzy's modifications until I've had time to look at them properly
@Caleb however I guess I'd have to have that last version in both places (otherwise the people who are still pointing at gist will never discover that there's a new version)
Btw @Caleb and @Benjol I've just checked through the other forks. That one from Oliver is worth a closer look, and maybe should be integrated as well (not sure yet what it does, need to take a second look). The others don't seem to really add anything.
According to Olivers commit-messages, it includes some quick-insert buttons and hover-styling.
@Izzy Not a good way to start. This was a bit of a mess to start with and that's always the ugliest part. You have to fight messes by making a little more along the way.
@Benjol I just made the transfer request. As soon as you accept it and it's safe in your account I will clone and make some tweaks on my branch back in my own fork. Master in the one I transferred is exactly how you left it except the aut-update URL was fixed.
@Izzy Yes, that was before I realized other people had changes and it was likely that some of them could get merged and the whole thing needed more infrastructure. We're on the right track now.
@Benjol I imported all the history from the gist but if you had commits/comments outside of that, it's a little late :) (although not impossible to fix).
The easy way to comment
The AutoReviewComments user script provides a handy way to keep a collection of template comments on hand. I (Izzy) modified this script with some features to handle site-specific comment templates. My version is published in this gist (but be warned that it includes my c...
The real issue here is going to be mix and match between data formats. I tried to simplify by pushing for the new format for the new script or the old one for the other. The fact that the new script works with the old format if you use it exclusively is not mentioned.
@Caleb Done. Maybe you cross-check again what I broke now? ;)
@Caleb I had that in originally. It's a one-way ticket, though (as it doesn't work the other way without manual corrections), but I thought it might be convenient for one or the other. But yeah, better keep it simple :)
@Caleb good point, yes: Meat is raw :) Did another edit as well ("Tips for sharing").
@Caleb Was for quite a while already. If you wanna try that: Make sure to first export your customizations. I didn't try how it works with the modified script.
It would be nice if we could sanely do the import per-site too. Then we can just suck from whoever does the best work on that sight without manually merging all the time.
I have taken the liberty of doing some organization.
I have created a full blown Github repo here. The master branch is the latest from benjol's gist and all commit history is included. The master branch can be installed from this alternate location as a userscript using this url. This should m...
