Groom Lake

rlemon

14:49

@DannyBeckett did you figure out the invalid message business? because I have :P it is stupid

@PatoSáinz watch your step there Pato

Danny Beckett

@rlemon I believe it's because the max length is >500 including links?

rlemon

@DannyBeckett the bot ignores herself, so all messages from the bot are invalid in her eye. running the bot locally you have to stop ignoring yourself.

Danny Beckett

Do you have a solution?

I tried

args.directreply(output.length < 500 ? output : 'Sorry, the weather data retrieved was > 500 characters (the max allowed) - I\'ll fix this tomorrow - try another airport!');

but still got the error

rlemon

that is another issue

Danny Beckett

I'm speculating it's because bot.adapter.link doesn't factor into the .length calculation

var output = '**' + link + ':** ' + resp.our_airport.name + ' \u2022 ' + text[mode];

link = bot.adapter.link(code, 'http://aviationweather.gov/adds/metars/?station_ids=' + resp.our_airport.icao + '&std_trans=translated&chk_metars=on&hoursStr=most+recent+only&chk_tafs=on&submi‌tmet=Submit');

@rlemon

rlemon

14:53

there was an open issue about this stuff in the issue list

i'm looking for it now, not sure what Zirak did with it

Danny Beckett

thanks man

source code for the command available here: github.com/dannybeckett/SO-ChatBot/blob/master/source/plugins/…

@rlemon ah, you were asking about the parseMessage invalid issue, initially?

I've just been seeing Server error (status 500) occured (message probably too long) messages - thought you were referring to that

Yeah I sorted that out... you're right, you have to disable self-ignore

rlemon

15:20

or enter dev mode

Anonymous

@rlemon yes?

rlemon

19 hours ago, by Pato Sáinz

JS ROOM? EWWWWW

blasphemy!!

Anonymous

the only truth!

Danny Beckett

bullshit.

@rlemon don't suppose you found an issue?

lnafziger

22:28

hey

Danny Beckett

hey!

lnafziger

@DannyBeckett: Okay :)

Danny Beckett

so the server in both cases is dannybeckett.co.uk

standard ports

just changing the password for SSH from my own personal password so we can share it

username's aviationbot

lnafziger

okay, sounds good

Danny Beckett

ok, ready for the password?

gonna send it here, then delete straight away

lnafziger

22:30

shoot

got it

Danny Beckett

it's the same login for both SSH and FTP

if you login to FTP first, I can tell you how it's organised

you only need SSH to restart the bot

lnafziger

well, I just logged in via ssh.. it works. :)

Danny Beckett

which you need to do after each edit to any file

lnafziger

no reload command for the bot?

Danny Beckett

well while you're there

cd dev

lnafziger

22:32

there

Danny Beckett

just logging in myself, 1 sec

so if you run ls

you'll see the same as what's in FTP

the commands are stored in...

lnafziger

yeah, I'm quite familiar with the command line... :)

Danny Beckett

~/dev/SO-ChatBot/source/plugins

ok great

but you're gonna FTP them anyway

the command you want to restart with is actually re load

there are a few in ~/dev

lnafziger

Aww, I can't just edit on your server? ;-)

Danny Beckett

you can

by all means

lnafziger

22:35

Okay, that's easier for me.. I'll keep proper backups. :)

Danny Beckett

ok great!

you just hit the nail on the head btw

lnafziger

(I've used "vi" for WAY too long, but at least it makes it easy for me.)

Danny Beckett

you remember I said it bitches at every turn?

lnafziger

yup

Danny Beckett

if there's a syntax error in your code, it spits out a dump of all the code and dies

so yeah, keep backups :)

(when you try to reload the bot)

lnafziger

22:36

nice, so how do we test it before we try to reload the "real" bot?

Here?

Danny Beckett

no it's ok to reload

nobody notices :p

lnafziger

haha

Danny Beckett

on that note, vi ~/dev/reloadpjs.sh

vim, not run

you'll need reload, not restart

(it rebuilds the solution)

lnafziger

okay, good

Danny Beckett

so you need to comment out the SCREEN line

whilst logged into SSH

oh shit, that's in another file actually

SO-ChatBot/startpjs.sh

don't move the files either, they're in a specific place for certain things to work

made a mistake

so-chatbot-driver/startpjs.sh

so you're gonna want to comment out the if [ -z $1 ]; then export SCREENCMD="screen -mdS so-chatbot-driver"; fi; line with a #

let me know when you've done that

with it commented, you see the output of the bot to the console

including details of syntax errors etc

also, we can restart it and you'll see what it does

when you've commented that out, you can run ~/dev/reloadpjs.sh

lnafziger

22:42

okay, I'm back. They kicked me off of the free internet here at the airport.

Danny Beckett

lol!

lnafziger

Fortunately all of your messages are still here.

Danny Beckett

yeah thats good

lnafziger

Do you have it open now?

It's complaining and wants me to open read-only. :)

Danny Beckett

yeah you can try now

lnafziger

22:43

k

Danny Beckett

(had to update the password in the script)

lnafziger

Okay, that's commented out.

Danny Beckett

ok so :wq

then ../reloadpjs.sh

lnafziger

Okay, I just reloaded

Danny Beckett

you see the output?

lnafziger

22:45

yeah, it's logging in now

Danny Beckett

eventually you should see Running...

lnafziger

there

!!weather ewr

Danny Beckett

at that point you can start hitting the room with commands like this

Otto the Autopilot

@lnafziger EWR/KEWR: Newark Liberty International Airport • Observed: 55 mins ago • Wind: 270°/W @ 18kts • Visibility: 10.0mi/16.09km • Sky (AGL): Few clouds @ 5,000ft • Temperature: -12.8°C/9°F • Dewpoint: -24.4°C/-12°F • Pressure: 30.27" Hg/1,025mb • Conditions: VFR

Danny Beckett

!!info

Otto the Autopilot

22:45

@DannyBeckett I awoke on Tue, 07 Jan 2014 22:45:11 GMT (that's about 26 seconds ago), got invoked 1 times, learned 1 commands

Danny Beckett

ok great - it usually takes longer after saying it's running

so let's get you setup with a template for a command

1 sec

lnafziger

(I'm trying to fly out of EWR right now, lol)

Danny Beckett

you can go ahead and create a new file called something.js in ~/dev/SO-ChatBot/source/plugins

lnafziger

And that's all that we need to add a new command?

Danny Beckett

@lnafziger lol, visibility's good at least

lnafziger

22:47

-13!!

Danny Beckett

"at least"

:p

lnafziger

!!info

Otto the Autopilot

@lnafziger I awoke on Tue, 07 Jan 2014 22:45:11 GMT (that's about 2 minutes ago), got invoked 2 times, learned 1 commands, teleported 97 goats

Danny Beckett

@lnafziger not quite

just getting you a template made up quickly

lnafziger

okay

Danny Beckett

22:50

pastebin.com/MzjKVud3

lnafziger

okay, how about far.js

Danny Beckett

wait, 1 sec on that pastebin

yeah far.js sounds good

lnafziger

ok

Danny Beckett

use this one instead pastebin.com/r5zxpQmH

ah shit 1 more thing

just remove , mode from the function declaration

command: function(args, cb)

lnafziger

done

Danny Beckett

22:52

ok cool

edit every instance of weather to far

lnafziger

and I assume change var weather to var far, etc.

got it

Danny Beckett

exactly ;)

lnafziger

is it case sensitive?

Danny Beckett

it is

use lower

lnafziger

I did... I hate that though, lol.

Danny Beckett

22:53

not sure on the parsing side, lets try

lnafziger

Is there a way to setup an alias so that far or FAR works?

Danny Beckett

!!WEATHER JFK

Otto the Autopilot

@DannyBeckett JFK/KJFK: John F Kennedy International Airport • Observed: 3 mins ago • Wind: 280°/W @ 16kts • Visibility: 10.0mi/16.09km • Sky (AGL): Few clouds @ 5,000ft • Temperature: -12.2°C/10°F • Dewpoint: -23.9°C/-11°F • Pressure: 30.29" Hg/1,026mb • Conditions: VFR

Danny Beckett

ah ok so it works in the chat at least

lnafziger

guess we don't need to. :)

Danny Beckett

22:54

it's just the variable names that are case sensitive, to JavaScript

lnafziger

cool

Danny Beckett

so once you've edited those to far, reload the bot

when you run !!far xxx it should reply something

lnafziger

logging in

!!far FLL

Otto the Autopilot

@lnafziger something

Danny Beckett

cool :)

you're gonna want to remove the restriction on length at the top

lnafziger

22:56

yeah, I can work that out.

Danny Beckett

if(!query)

essentially, you need data in JSONP

not just JSON, but JSONP

the easiest way to do that is with PHP

lnafziger

So what's the issue with that? Why can't we use JSON (or any other format)?

Danny Beckett

!!wiki cross origin resource sharing

Otto the Autopilot

Cross-origin resource sharing

Cross-origin resource sharing (CORS) is a mechanism that allows JavaScript on a web page to make XMLHttpRequests to another domain, not the domain the JavaScript originated from. It is more useful than only allowing same-origin requests, but it is more secure than simply allowing all such cross-origin requests. How CORS works The CORS standard works by adding new HTTP headers that allow servers to serve resources to permitted origin domains. Browsers support these headers and enforce the restrictions they establish. Additionally, for HTTP request methods that can cause side-effects on user...

Danny Beckett

it's something specific to JS

basically, it's a "security concern"

however, all hope is not lost

JSONP is just JSON with callback( on one side, and ) on the other

also, I've written a script to convert XML -> JSONP

this is where your next login comes in, 1 moment

lnafziger

22:59

okay

Danny Beckett

username is aviationphp - password is the same

lnafziger

Same server?

Danny Beckett

yup

lnafziger

oh, one more thing before we get to that.

Danny Beckett

ah nice, you just got /

apparently I can't give you SSH to that dir

lnafziger

23:02

When I want to logoff and leave the bot running...?

Danny Beckett

maybe if I add you to that group

ok, that's where the comment comes in on startpjs.sh

obviously if you wanna quit it, currently, you do Ctrl+C

lnafziger

Okay, so I un-comment it and then run it? In the background or does it do that automatically?

Danny Beckett

to have it run in the background, uncomment

yeah

lnafziger

Okay, got it

Danny Beckett

personally I keep it commented, so I can see the output

you can always open 2 instances

lnafziger

23:04

yeah, that's what I have now

Danny Beckett

ok great

lnafziger

just wondering about when I'm done for the day.

Danny Beckett

you need to go?

lnafziger

not yet

Danny Beckett

ok

lnafziger

23:05

okay, so aviationphp

Danny Beckett

yeah but it aint working

just added the user to the other group, maybe that will work, trying myself now

lnafziger

yeah, that's better

Danny Beckett

still getting an error

lnafziger

well, then again...

I can't ls, (although the error at login went away)

Danny Beckett

I still see the error

trying to get you into another user's home dir (mine)

I added it to the secondary group - will try primary

ok that worked :)

ah shit still not write-access though

maybe FTP is... lets see

lnafziger

23:09

oh, probably because I just "su"'d to the user instead of creating a new ssh session

man, they have crappy internet here.

Danny Beckett

nope. sigh

actually, tell you what, I'll just give you my login

make this easier

there's nothing on my website anyway

just gonna change the pass

so forget aviationphp - 2nd login is dannybeckett

same password, same everything else

lnafziger

okay, got it

Danny Beckett

relevant files are in ~/public_html/AviationBot

you can create PHP helper files here

e.g.

in the simplest form, <?php echo $_GET['callback'] . '(' . $someJSONdata . ')'; ?>

Airport.php is an example of how to screenscrape

Weather.php is an example of XML -> JSONP

lnafziger

I'm looking at Weather now

cool

Danny Beckett

it probably looks more complex than it is

lnafziger

23:16

curl, huh? I used that in an iOS project awhile back... Fun fun.

Danny Beckett

because it also calls Airport.php

so the output looks odd

lnafziger

Actually, I was about to say that it looks pretty straight-forward.

Danny Beckett

oh great!

in terms of the final line though, the whole reason for the substring is just to append inside the JSON object

(with data from Airport.php - this is the IATA support)

so... yeah.. you can create anything, so long as it outputs JSONP

are you familiar with php?

if so, you can simply do json_encode($anObject)

lnafziger

Okay, anything else major to show me? I think I can figure most of it out now.

and I'm using internet through my cell phone now, so it isn't the speediest, lol.

Danny Beckett

then wrap $_GET['callback'] . '(' and ')' around it

nope that's all!

just remember to wrap any JSON in that

otherwise it won't work

:)

above all, keep backups and don't forget to uncomment startpjs and run when you're logging out

feel free to give me a shout if you get stuck!

you can play with JavaScript either in F12 -> Console in Chrome

or in jsfiddle.net

lnafziger

23:21

nice

Danny Beckett

e.g. jsfiddle.net/s9jp3

JS is a nice language

easy to learn

PHP less so (lol)

lnafziger

I've used a little PHP, and it isn't SO bad.

Danny Beckett

ok that's definitely a positive!

as I say, feel free to give me a shout

lnafziger

But I'm wanting to learn JS anyway, so I'll probably stick with that for now.

Sounds good, thanks for setting this up!

Danny Beckett

I seem to be in The Hangar every day now

no problem man!

thanks for the help :)

lnafziger

23:23

It will probably be a little while before I can do any real work on it... I'll play with it plenty in time though. :)

Danny Beckett

of course ;)

I'd rather be flying than coding

one last thing: there's a 500 char limit on messages

which I just discovered when trying to get the weather for MIA

!!weather mia

bot down?

!!info

guess so..

hmm, looks like it's running from ps aux | grep java @lnafziger

lnafziger

!!info

Otto the Autopilot

@lnafziger I awoke on Tue, 07 Jan 2014 23:27:07 GMT (that's about 1 minute ago), learned 1 commands

lnafziger

I just stopped it and ran it in the background

Danny Beckett

!!listcommands

Otto the Autopilot

23:28

@DannyBeckett help, listen, eval, coffee, refresh, forget, info, listcommands, tell, afk, ban, unban, convert, define, far, findcommand, google, inhistory, learn, no, live, die, meme, metar, nudge, parse, spec, stat, stats, summon, unsummon, timer, todo, undo, user, weather, welcome, wiki, youtube (page 0/0)

lnafziger

so what happens when you go over 500 characters?

Danny Beckett

ah ok, guess it was still logging in

that's what I'm trying to figure out now

lnafziger

!!weather MIA

Otto the Autopilot

@lnafziger MIA/KMIA: Miami International Airport • Observed: 36 mins ago • Wind: 350°/N @ 5kts • Visibility: 10.0mi/16.09km • Sky (AGL): Overcast @ 2,000ft • Temperature: 13.3°C/56°F • Dewpoint: 9.4°C/49°F • Pressure: 30.25" Hg/1,024mb • Conditions: MVFR

Danny Beckett

ok MIA got shorter suddenly

yesterday, by Otto the Autopilot

Server error (status 500) occured (message probably too long)

lnafziger

23:29

lol

Of course it did

Danny Beckett

working on a solution atm

lnafziger

!!weather EWR

Danny Beckett

I just wanna split the message

Otto the Autopilot

@lnafziger EWR/KEWR: Newark Liberty International Airport • Observed: 39 mins ago • Wind: 270°/W @ 18kts • Visibility: 10.0mi/16.09km • Sky (AGL): Few clouds @ 5,000ft • Temperature: -12.8°C/9°F • Dewpoint: -24.4°C/-12°F • Pressure: 30.29" Hg/1,026mb • Conditions: VFR

Danny Beckett

but having trouble detecting when it's > 500 chars with output.length because you insert a link, like so:

lnafziger

23:30

yeah, probably good

Danny Beckett

var link = bot.adapter.link(code, 'http://aviationweather.gov/adds/metars/?station_ids=......

then you add it to the output, e.g. var output = '**' + link + ':** ' + resp.our_airport.name + ' ' + text;

and I don't think bot.adapter.link adds to .length

because this doesn't fire:

args.directreply(output.length < 500 ? output : 'Sorry, the weather data retrieved was > 500 characters (the max allowed) - I\'ll fix this tomorrow - try another airport!');

anyways, I'll leave you to it for now!

will let you know on the 500 chars issue

lnafziger

Okay, thanks. Talk to you soon!

Danny Beckett

(I guess the 500 max includes formatting)

cheers buddy. talk soon!

lnafziger

(Yeah, I'm sure that it does... It might be a SE limit, like on comments)

Danny Beckett

it is

seeya :)

hope you're not waiting round too long

lnafziger

23:34

Oh, and what do you think about removing the @user from the beginning of the messages since it it showing in a public room anyway?

Danny Beckett

could do, you use args.send() for that

instead of args.directreply()

but I think it's useful, because you know what it's replying to then (e.g. if a couple of people are using it at the same time, or you're a 3rd-party wondering why it's saying that)

I think the standard is to use args.directreply()

github.com/Zirak/SO-ChatBot/wiki/…

that tells you the various args.functions

there's also some other useful info in the wiki section

lnafziger

Okay, just a thought to shorten it since people will see the request and then the response pretty quickly... Maybe we should leave it though.

Danny Beckett

I'll get it to split the messages, don't worry

in the case of FARs, since some are really long, you could truncate instead, and link to the full FAR

Transcript for