« first day (1075 days earlier)      last day (22 days later) » 

@DestructibleWatermelon get a list of method names, okay?
00:54
still confused about this thing...
@DestructibleWatermelon I'm the game. You're the IO guy. I'm asking you to make a list of products I can buy from you. Products are, for example, get the next order you want to put in the bot. I think you need to read the specification on the actual game we're implementing
@noɥʇʎPʎzɐɹC where is it exactly
01:22
Go, Watermelon!
but, but, what are the names of the things that have to be included
in the code
 
1 hour later…
02:25
@noɥʇʎPʎzɐɹC I can certainly believe that.
 
1 hour later…
03:47
I might have more time tomorrow to actually work on stuff, today I was travelling home.
 
4 hours later…
08:00
I think I'll work on the order tiles
How does inheritance work in Python?
 
2 hours later…
10:13
What is class OrderName extends Order in Python
 
1 hour later…
Please check my Python, I don't even know if I did it right
 
1 hour later…
12:48
@KritixiLithos how do we want to handle the variety of rotate/forward tiles?
For example, some tiles rotate twice/three times, or go forward twice/three times.
There is an extra parameter while calling those functions that specify the number of forward tiles/rotation degrees
def execute(bot,distance):
That is found in Forward
What is the point of having Order and SpecialOrder as separate classes?
TBH I don't know that much about Python OOP, but I think we need to have the distance as part of the class/as an instance variable and not as an argument to the execute() function. Otherwise, how will we keep track of which Forward tiles have which values?
All right, I will change that
BTW I also don't know much about Python OOP.
I can work on adding the extra classes.
Do we want to follow the "finite inventory" of the original game? As in, there's a limited number of tiles each person has.
@KritixiLithos which rotation do we want to be "positive"/"negative"?
left = positive
13:22
Clockwise = positive to start with
@PhiNotPi We can work on the finite inventory once we've finished the tiles
@KritixiLithos what's the best way for me to update the repo with the code I wrote?
Did you create a new branch?
no not yet
why would I even need to make a new branch?
13:40
So you can do a PR
14:05
I'll merge it
Who is webflow?
> This account is the Git committer for all web commits (merge/revert/edit/etc...) made on GitHub.com.
 
5 hours later…
18:55
Y'all did soem stuff. Good!
@PhiNotPi Some of the PRs are non-PEP 8 conforming. I'll review them and send another PR to fix the formatting.
[ASCII-Art-Club/ASCII-Twin-Tin-Bots] web-flow pushed commit cc7e48ce to revert-10-orders: Revert "Adds more order types"
[ASCII-Art-Club/ASCII-Twin-Tin-Bots] CrazyPython created pull request [#11: [WIP] Modifies @PhiNotPi's commits](github.com/ASCII-Art-Club/ASCII-Twin-Tin-Bots/pull/11) to merge revert-10-orders into orders
> Conform with PEP 8, better OOP. WIP.
[ASCII-Art-Club/ASCII-Twin-Tin-Bots] CrazyPython assigned CrazyPython to pull request [#11: [WIP] Modifies @PhiNotPi's commits](github.com/ASCII-Art-Club/ASCII-Twin-Tin-Bots/pull/11)
@PhiNotPi Be a little less hasty with the reviewing
19:13
@PhiNotPi I see you did it on orders, so it's not on master yet. We have a clean branch!
19:29
It looks a little bit like this:
class SpecialOrder(Order, metaclass=ABCMeta):
    """All special orders inherit from this order."""

    @classmethod
    def execute(cls, bot):
        raise NotImplementedError()


class Forward(Order):
    forward_constant = 1

    @classmethod
    def execute(cls, bot):
        bot.move_forward(cls.forward_constant)


class ForwardTwice(Forward):
    forward_constant = 2


class Rotate(Order):
    rotate_constant = 1

    @classmethod
    def execute(cls, bot):
        bot.rotate(cls.rotate_constant)
Are anti-zap & anti-theft a permanent thing, or does it expire
As per my understanding @noɥʇʎPʎzɐɹC, those Orders are valid as long as they are in the bot's program.
19:46
@KritixiLithos Oh... hm, I'll change me TODO comment then. Thanks.
nvm I'll implement them real quick, as properties
I'm staging specific lines, lol
> Also implements anti_theft and anti_zap; I apologize for the git uncleanliness.
@KritixiLithos Review my PR, pelase
@noɥʇʎPʎzɐɹC What is cls?
@KritixiLithos Oh, I changed them all to classmethods. cls is the current class, so it can access class attributes. Required for all classmethods.
20:03
I'm back.
@noɥʇʎPʎzɐɹC I just copied the style of the existing code.
@PhiNotPi I know, it's not your fault.
Existing code was PEP 8
What is PEPE 8?
Official Python style guide
@PhiNotPi I don't want to start an editor war, but specifically for Python, PyCharm is a really good editor - it's mostly the builtin truly comprehensive linter and type checker.
I'm just using a default text editor.
20:15
@PhiNotPi Use PyCharm, it really is better. Put it in distraction-free mode if you need to.
I use Python IDLE
That's what I started with too
PyCharm is IDLE + the best linter that they made
@PhiNotPi Try it, maybe?
BTW, should I merge the PR?
@KritixiLithos Yes.
[ASCII-Art-Club/ASCII-Twin-Tin-Bots] CrazyPython pushed commit de087b9f to orders: Heavy lifting, OOP reorganization, moved order of classes; linted
Merge pull request #12 from CrazyPython/orders

Reorganize OOP
 
1 hour later…
21:34
...in a galaxy far far away...

« first day (1075 days earlier)      last day (22 days later) »