Vyxal - 2023-03-05

« first day (1052 days earlier) ← previous day next day → last day (722 days later) »

lyxal

02:35

For some reason, the js version doesn't do 100% float accuracy like v2 does

0.1 0.2 + -> 0.30000001192092896

Don't know whether that's also a problem with jvm and native.

lyxal

03:20

only a js problem

user

03:56

Does the toStrimg method still do toFloat? Maybe it’s because of that

We should be parsing numbers directly to Reals so there shouldn’t be a problem there

lyxal

gahhh fricked by the fact Ḟ casts numbers to list of digits

1 hour later…

lyxal

05:14

@user but it's not an issue on jvm and native

else underlying.real.toFloat.toString

Maybe js messes that up when converting

Is there another way to format real as decimal?

2 hours later…

Unrelated String

06:59

if it comes to it, you could write one yourself

lyxal

I'm sure spire would have some method built in

Unrelated String

07:27

because even ignoring this issue, it should be prepared to stringify reals that are too big to be floats

lyxal

07:37

Ah frick that's right floats have a size limitation too

Spot the python programmer moment :p

emanresu A

07:50

!!/amilyxal

Vyxal Bot

@emanresuA You are not lyxal.

emanresu A

08:22

!!/status cryptic

Vyxal Bot

Obg fgnghf: Bayvar
Hcgvzr: 1 qnl, 14:02:26.734643
Ehaavat fvapr: 2023-03-03G18:19:35.820197
Reebef fvapr fgneghc: 0

3 hours later…

Vyxal Bot

11:43

Lyxal created branch wheat in Vyxal/VyxalBot2

Lyxal opened pull request #25 (Update statuses.txt) in Vyxal/VyxalBot2

lyxal

@Ginger you might appreciate the above PR

Vyxal Bot

12:10

GingerIndustries approved #25 (Update statuses.txt): "I've got _alllll_ the posts, and they're _allll_ Indonesian Gambling Spam! Never posted a challenge. Been meaning to learn."

GingerIndustries merged pull request #25 (Update statuses.txt) in Vyxal/VyxalBot2

GingerIndustries deleted branch wheat in Vyxal/VyxalBot2

Ginger

@lyxal done

I'll restart the bot at some point

Vyxal Bot

12:48

Lyxal created branch improve-float-to-string-for-vnum in Vyxal/Vyxal

Lyxal opened pull request #1647 (Make toString on non-integer VNum not just a stringified float) in Vyxal/Vyxal

lyxal

That, and the SSS PR are ready for proper reviews

that is, ready for final reviews

Ginger

!!/issue open in VyxalBot2 No labeling Bot isn't labeling PRs for some reason

Vyxal Bot

vyxal-bot[bot] opened issue #26 (No labeling) in Vyxal/VyxalBot2

Lyxal opened pull request #1648 (Updat Production (5/03/2023)) in Vyxal/Vyxal

Ginger

@lyxal ...you do know there's a command for that right?

I added !!/prod a while ago

Vyxal Bot

Lyxal closed issue #26 (No labeling) in Vyxal/VyxalBot2

lyxal

12:59

@Ginger I needed to manually make a PR

and production was the most productive one I could think of

Ginger

uh wtf

why'd it label that one

lyxal

check the edit history

Ginger

yeah I know

Vyxal Bot

Lyxal merged pull request #1648 (Updat Production (5/03/2023)) in Vyxal/Vyxal

Ginger

but it didn't label *digs through issue logs*

cmon where is it

this one!

lyxal

13:04

@Ginger because the bot was dead

Ginger

oh

shot myself in the foot eh

lyxal

Feb 21 at 21:53, by lyxal

The bot ded

Feb 22 at 12:11, by Ginger

user image

Ginger

:|

!!/why you gotta do me like that

Vyxal Bot

Sorry Ginger, I'm afraid I can't do that.

Ginger

and yet you did it anyway

don't gaslight gatekeep girlboss your own developer

lyxal

13:07

@VyxalBot keep up the good work

lyxal

13:17

@lyxal (spoiler: it does)

Ginger

!!/status tingly

Vyxal Bot

Bot (｡ᴜ‿‿ᴜ｡) s-s-s-status: Onwinye
Uptime: 1 day, ***huggles tightly*** 19:06:50.487318
Wunnying since: 2023-03-03T18:19:35.820197
Ewwows since stawtup: 0

Ginger

glorious

2 hours later…

user

15:25

@lyxal it does iirc I’ll try to find it later today and either tell you or try to do it myself

2 hours later…

user

17:40

github.com/typelevel/spire/blob/main/core/src/main/scala/spire/…

We can just use `.toString

2 hours later…

mathcat

19:35

back

aw man, did I miss some funky JS errors?

Ginger

19:56

!!/status

Vyxal Bot

@Ginger I am doing an essay on the importance of chatbots in society. 10,000 words please

Ginger

cool

user

20:25

@mathcat Don't worry, there's plenty left to go around :P

mathcat

excited

user

Do I use ":P" too much? I guess that ^^ message was clearly a joke so the ":P" wasn't necessary

!!/status

Vyxal Bot

@user I am doing a never-ending battle against some kinds of dirt and grime

user

!!/amilyxal

Vyxal Bot

@user You are not lyxal.

user

20:26

!!/status

Vyxal Bot

@user I am doing things like getting better at German

2 hours later…

lyxal

22:08

@user what type is that a member of?

2 hours later…

user

23:49

Real

x.underlying.real.toString should work, I think

lyxal

that gives fractions sometimes though

user

Oh

Oh, that's why we used toFloat

i dum

I guess we could still look at its source code, steal from that

I guess the problem is that it's stored as a fraction :|

lyxal

I implemented a .toString method

user

Nice

lyxal

github.com/Vyxal/Vyxal/pull/1647

11 hours ago, by Vyxal Bot

Lyxal opened pull request #1647 (Make toString on non-integer VNum not just a stringified float) in Vyxal/Vyxal

user

23:51

Oh

Vyxal Bot

ysthakur approved #1647 (Make toString on non-integer VNum not just a stringified float): "Still gonna run into changes when we exceed the range of a Double but this is good until then"

lyxal

I don't think we'll run into problems with Double size limits

(n - n.floor) always returns 0 < x < 1

so it's just decimal points

user

Ohhh

You right

Merge?

lyxal

if you're happy with it

Vyxal Bot

ysthakur enqueued pull request #1647 (Make toString on non-integer VNum not just a stringified float) in Vyxal/Vyxal

user

23:57

Oh wait, the if in the helper isn't necessary because you already check

The whole helper could be inlined

Vyxal Bot

ysthakur deleted branch gh-readonly-queue/version-3/pr-1647-a08585fbf00181d7734855b48634cf5c665c2c78 in Vyxal/Vyxal

lyxal

@user it's needed for the complex part

the if in the og toString isn't needed

user

Oh

ye i dum

lyxal

merge queue saves the day :p

user

lol yeah

i hated how slow it is but was helpful here

lyxal

23:59

I'm happy with that change

user

Great

lyxal

@user it's really meant for when you have multiple PRs you want merged at once

« first day (1052 days earlier) ← previous day next day → last day (722 days later) »