Conversation started Apr 26, 2021 at 15:00.
Vogel612
Vogel612
Apr 26, 2021 15:00
@Feeds yo, wtf people?
sure, it's a badly written question, but that's all the context you will ever get for that code
there's nothing interesting about it and nothing more to add
even code like that sometimes needs a review
but that doesn't mean it should be closed
Sᴀᴍ Onᴇᴌᴀ
Sᴀᴍ Onᴇᴌᴀ
Monking
Vogel612
Vogel612
Monking
Der Kommissar
Der Kommissar
@Vogel612 Yeah, agree
Mast
Mast
Apr 26, 2021 15:14
@Vogel612 How much of it can be reviewed? I've seen Fizzbuzz that was more complicated than this.
Vogel612
Vogel612
the "productive" code there is APILog.objects.create(...)
Mast
Mast
I didn't VTC it, but I can understand why it got VTCd.
@Vogel612 Which we don't have.
Feeds
Feeds
Accelerating Stack Overflow’s transformation
Prashanth Chandrasekar on April 26, 2021
This quarter’s post from our CEO focuses on two strategic priorities: Product-led Transformation and Predictable and Reliable Financial Performance, both of which add value to our community and our customers by allowing us to continue to support and resource them better.
Vogel612
Vogel612
everything else is the plumbing for a middleware
Peilonrayz
Peilonrayz
@Vogel612 "Too often I see LCC used as a close reason when the reviewer lacks the context, and not the question."
Mast
Mast
Apr 26, 2021 15:16
Is that APILog thing part of Django or not?
Vogel612
Vogel612
@Mast does it need to be?
Mast
Mast
This is why namespaces are important...
Vogel612
Vogel612
It's clearly a database interaction API, something like EF or mongoose
Mast
Mast
If they want their code to be good code, it helps to post code that actually does something.
Vogel612
Vogel612
it does exactly one thing
Peilonrayz
Peilonrayz
Apr 26, 2021 15:18
@Mast Probably. The entire question looks like Django code. Someone who knows Django can answer the question.
Mast
Mast
I'll leave it up to those who closed it to explain themselves, this is not my battle.
Vogel612
Vogel612
I'm reasonably certain that APILog looks exactly as follows:
Mast
Mast
I didn't VTC and wouldn't have VTCd. I understand why people did it, doesn't mean it's right.
pacmaninbw
pacmaninbw
@Mast I did explain myself. If it was Drupal I might have been able to answer the question since I programmed in it for 3 years. I understood Django was providing a lot, I didn't know how much.
@Vogel612 It might have helped if he included the registration string.
Mast
Mast
I do think a downvote on the meta answer by pacman without comment is not helping the discussion.
Whoever's that is.
Don't think it's by OP.
Vogel612
Vogel612
Apr 26, 2021 15:20
@pacmaninbw the registration string is the fully qualified classname
and darkchat swallowed my typed model-class :/
django allows you to create model classes by basing them off django.db.models.Model
so objects.create(...) comes from django
how much it does I have no clue, I never worked with django, I'm literally just googling this as we're discussing
Der Kommissar
Der Kommissar
@Mast Ehhh, I personally am about to downvote his as well. It talks abstractly about why it might be closed, but it doesn't understand how Django works and I disagree with that being a factor for CV.
If you don't understand how the pipeline works but it's a well-known pipeline (Django, ASP.NET, Spring, etc.) casting a CV is irresponsible.
Mast
Mast
There's a definitive truth in that.
pacmaninbw
pacmaninbw
Agreed.
Vogel612
Vogel612
@Vogel612 Another question that will never be answered. — pacmaninbw 9 mins ago
@pacmaninbw ^ I fail to see how that's relevant
Der Kommissar
Der Kommissar
So "is this a Django thing" being part of why it might be closed tells me that the CV's were misplaced. I'm not saying that anyone is a bad person or anything (so don't take my DV on the Meta post personally, @pacmaninbw), but I do think that is perhaps the worst factor to consider.
Vogel612
Vogel612
Apr 26, 2021 15:25
whether a question is going to elicit an answer has no bearing on whether it's on-topic
Der Kommissar
Der Kommissar
@Vogel612 That too ^^^
On-topic / off-topic should be "can this question be answered", not "is it likely this question will be answered."
Peilonrayz
Peilonrayz
@Vogel612 @pacmaninbw we don't have many/any Django programmers on Code Review
Vogel612
Vogel612
also unanswered downvoted questions are automatically deleted, just not as quickly as downvoted closed questions
pacmaninbw
pacmaninbw
@Vogel612 I'll remove all my comments from the original question.
Do I need to remove my answer from Meta?
Peilonrayz
Peilonrayz
No
Vogel612
Vogel612
Apr 26, 2021 15:27
"do you want to?" is the pertinent question
Der Kommissar
Der Kommissar
@pacmaninbw I don't see why your answer on Meta should be removed -- it is potentially accurate. I just disagree with it.
Which is what Meta votes are for.
pacmaninbw
pacmaninbw
@Vogel612 Left that one, it was pertinent.
@DerKommissar I understand and agree with your down vote on my answer, but a comment for others would help.
@Peilonrayz When I first started on SE, I was active on the Drupal site as well as CR and answered a few questions. I didn't stay active on Drupal because I don't like web programming. Drupal hides almost as much as Django does.
Peilonrayz
Peilonrayz
@pacmaninbw I've not really used Django so can't comment too much. But from the little I have done I just wrote a couple of typehints and I magically had a fully functioning DB. I wouldn't be surprised if someone writes a dataclasses to Django tool
pacmaninbw
pacmaninbw
Apr 26, 2021 15:44
@Mast Just FYI: when I was using Drupal it was about 2 million lines of PHP 5. I learned about an eighth of that while I was using it so that I could write good Drupal code.
 
Conversation ended Apr 26, 2021 at 15:44.