Conversation started Sep 3, 2015 at 19:36.
jacwah
jacwah
Sep 3, 2015 19:36
What kind of message should the server send if an invitation is already open? Things I can think of: ServerErrorMessage, ChatMessage, InviteResponse.
Simon Forsberg
Simon Forsberg
@jacwah is there a ClientErrorMessage ?
jacwah
jacwah
Nope
Simon Forsberg
Simon Forsberg
not ServerErrorMessage I think, as it's nothing wrong in the server.
or maybe rename class to ErrorMessage ?
maybe even use a boolean flag for if it's server or client that made the error?
jacwah
jacwah
Right now it sends ChatMessage if you try to invite yourself
Simon Forsberg
Simon Forsberg
what do you think would be best?
jacwah
jacwah
Sep 3, 2015 19:39
I think that ChatMessage is wrong: the client should decide how to display it
I think some kind of error message should be used
Maybe a generic ErrorMessage is best. Does the client know what request caused it?
Simon Forsberg
Simon Forsberg
@jacwah I don't think that's certain that the client knows that. It will likely be the latest request though. Does the client need to know it explicitly?
jacwah
jacwah
InviteResponse is best if the client has no other way to know what caused the message
@SimonForsberg Maybe not
Simon Forsberg
Simon Forsberg
but technically it isn't an invite response
the client that has already been invited may still answer
jacwah
jacwah
OK, I like the ErrorMessage idea
It's easy to handle by clients.
They probably want to handle all errors the same way
Simon Forsberg
Simon Forsberg
should we use a boolean (or something) to indicate whether the server did something wrong, or the client?
jacwah
jacwah
Sep 3, 2015 19:47
Yeah I think some kind of flag is useful. A solution to an error in the server and in the client are very different.
Simon Forsberg
Simon Forsberg
true that
then ErrorMessage it is
 
Conversation ended Sep 3, 2015 at 19:48.