ecs-module-support conversation

skiwi

Sep 17, 2014 10:36

I'm trying to picture things

And how to do the branching for the mod-modules

Simon André Forsberg

that won't be a problem I think

git checkout -b mod-hearthstone

skiwi

I want to create a plan for myself

Simon André Forsberg

sure

skiwi

and off which branch to bracch off

I'm thinking about branching off ecs

Simon André Forsberg

well right now, ecs would be the best branch to branch off, yes

skiwi

Sep 17, 2014 10:39

and then create my own test mod

It should be simpler as the game we are implementing, yet covering everything

Simon André Forsberg

'covering everything'? what 'everything'?

skiwi

Well, the ECS system is split up in a core and a mod-implementation, right?

Simon André Forsberg

Note that right now, the PhrancisGame.createGame method might be a bit hard to understand and seem complex. It is possible to extract a lot of things to functions, so that you could do AttackYGO.add(game);

Depends on what you mean by core and what you mean by mod.

skiwi

@SimonAndréForsberg Classes like ECSSystem, etc. are core, and implementations are mod

Could make a separate module for common systems, etc.?

Simon André Forsberg

The core is really the cardshifter.ecs.base package, but cardshifter.ecs.actions, cardshifter.ecs.phase, and cardshifter.ecs.resources can also be considered part of the 'core'

because pretty much every mod will use actions, phases (player turns), and resources (creature stats, mana costs, mana, etc...)

@skiwi yes, that's a bit what I was thinking. Refactoring out Mana feature to it's own package/class(es)

skiwi

Sep 17, 2014 10:44

@SimonAndréForsberg But mana by itself should be mod specific, turns should be in the core, I think

lol, this made me look twice

Simon André Forsberg

@skiwi Absolutely. A mod can choose which mana style to use, or no of the existing styles.

skiwi

So that is kind of settled then once done

Then the hard part is developing your own mods

Of what files does a Java mod consist?

Simon André Forsberg

hard*est*

Technically, to make a mod all you need is one method. A method to setup the entities and add components to them, and to add the systems that you want to use.

I imagine that there will be many default-implementations of various systems and features

skiwi

So we have a setup method

Simon André Forsberg

so if you want to gain mana like in Hearthstone, it's a simple method call to Mana.asHearthstone(game);

skiwi

Sep 17, 2014 10:52

I'm asking this also with Lua in mind, because Lua mods will not use the java build system at all

Simon André Forsberg

yes, it's a setup method

depends on what you mean by 'at all'

skiwi

So the mod may be nothing more than a file (be it a zip for Lua or a jar for Java)

I picture people modding in Lua to not know anything about Java

Simon André Forsberg

they can use Java-Lua method bindings we provided to make what they want

skiwi

Correct, but still unclear to me (probably also because I didn't have time to look into your code thoroughly yet)

There is only exactly one method in the mod that gets called which loads up the entire mod?

Simon André Forsberg

@skiwi pretty much, yes.

It's pretty much like a configuration

As all the features has been extracted to components + systems

skiwi

Sep 17, 2014 10:57

Yes, but the mod needs to also be able to specify its own components and systems

Simon André Forsberg

And it will be able to do that

skiwi

good

So we have a single point of entry

Simon André Forsberg

yes

skiwi

So currently for console and javafx version, we need to specify the directory of the mod, I assume?

Simon André Forsberg

@skiwi we need to make it call a method (that returns an instance of ECSGame). How we do that, that's up to us.

skiwi

Sep 17, 2014 11:00

@SimonAndréForsberg Well yes, I'm thinking about the most simple implementation we can do at the moment

Simon André Forsberg

Most simple implementation? Dependency injection. Provide it with a Supplier<ECSGame>

skiwi

We cannot require Java there

won't work for Lua

And it's then also hardcoded

I'm thinking we specify the mod (Lua uses a zip, Java uses a jar), and specify whether it is written in Lua and Java

Simon André Forsberg

sure we can require Java, the client is Java. We can provide a Lua-wrapper method. If we want to make a mod with Lua, we pass it a LuaGameLoader(InputStream)

and btw, the client is pretty much hard-coded for our specific mod as it is.

skiwi

Well yes for testing that would be nice

Then last point for now

You are developing a mod, say a Java one for simplicity's sake

Is there a way you can as modder test the mod via automated tests?

Like taking over the basic startup tests from the core module, and then add your own integration tests?

While being aware that mod repository only has the mod code and nothing else

Simon André Forsberg

@skiwi not at the moment, but there is a way to make that possible yes.

skiwi

Sep 17, 2014 11:07

What would be required to do so?

I would think publishing at least the core module on mvnrepo and creating tests that have the option to specify a mod

Simon André Forsberg

well, you need to make it possible to access the core..

it's solvable, but I'm not sure if it's meaningful to put it up on mvnrepo. At least not until there are some real players and there's a real client (that can support all kinds of mods)

skiwi

Well, how would you else get the jar?

Simon André Forsberg

the old-fashioned way. Download it.

skiwi

Do we want to do that inside a Maven build script?

Simon André Forsberg

of course not

skiwi

Sep 17, 2014 11:16

Then what would be your plan on that?

Simon André Forsberg

I just mean that the initial modders don't have to use Maven

I don't think we should put it on mvnrepo until it's really production-ready, or at least beta-ready

skiwi

They don't have to, but we would

Simon André Forsberg

which is still a loooooooooooong time from now.

bazola

@SimonAndréForsberg no I am not much of a graphical designer either

@skiwi what is what thing?

skiwi

We still need to get the jar into there somewhee

@bazola Would be more helpful if you used the reply-to feature ;)

Simon André Forsberg

Sep 17, 2014 11:18

you can install jars into your local maven repository manually

or you can use the old-style 'build-path' to set up a mod-project

skiwi

@SimonAndréForsberg Yes, but it executes on Travis

I do agree though that we may not want to put up things on mvnrepo now already

Simon André Forsberg

you never said that you wanted to use Travis for it!!!

skiwi

@SimonAndréForsberg Well.... That's technically correct

bazola

@skiwi okay I will start using reply-to :)

skiwi

@bazola But it's the picture I think yo meant?

bazola

Sep 17, 2014 11:23

yeah

er no

@skiwi what's what thing?

Simon André Forsberg

14 hours ago, by bazola

skiwi

@bazola Ah, the window in front there

Simon André Forsberg

^^ that thing

bazola

its the github desktop client

mac.github.com

the pc version looks the same though

skiwi

Can you do anything cool with it, or just see fancy stuff?

bazola

Sep 17, 2014 11:26

you can do everything that you can do with the console

sometimes in mac when I do something in the console, it seems to get stuck, so I have used the GUI to fix it

skiwi

okay

@SimonAndréForsberg I'll leave the discussion at where we are at right now

Will have plenty of things to do ;)

Coding Projects and Duga Heaven :)

Participants