Conversation started Feb 12, 2015 at 15:38.
Mat's Mug
Mat's Mug
Feb 12, 2015 15:38
@RubberDuck would it break the code inspections configs if I added a member to CodeInspectionType? I'd like to add LanguageOpportunities and have ObsoleteCallStatementUsageInspection, ObsoleteLetStatementUsageInspection and ObsoleteCommentSyntaxInspection in there, as well as OptionBaseInspection and TypeHintUsageInspection
RubberDuck
RubberDuck
@Mat'sMug It will not so long as it's not marked with an attribute to be exported.
If it needs to be configurable, then obviously some changes need to be made.
Mat's Mug
Mat's Mug
nope - it's just to put them in proper buckets ;)
RubberDuck
RubberDuck
Worst case, it frak's someone's config file.
Mat's Mug
Mat's Mug
and that would make it self-recover right?
RubberDuck
RubberDuck
Yes. It should.
But it wouldn't even do that.
This is the only relevant Code if you modify the actual CodeInspection class. 
private void EnableCodeInspections(Configuration config)
{
    foreach (var inspection in _inspections)
    {
        foreach (var setting in config.UserSettings.CodeInspectionSettings.CodeInspections)
        {
            if (inspection.Name == setting.Name)
            {
                inspection.Severity = setting.Severity;
            }
        }
    }
}
Mat's Mug
Mat's Mug
Feb 12, 2015 15:42
cool
RubberDuck
RubberDuck
I never got around to cleaning these up with an interface due to the reflection.
I still think they should share an interface of some sort though.
The actual inspection would use IInspection in addition to some other interface. Then the reflection could look for that other interface.
Mat's Mug
Mat's Mug
IConfigurableInspection?
RubberDuck
RubberDuck
Maybe.
Mat's Mug
Mat's Mug
IConfigurableInspection : IInspection
RubberDuck
RubberDuck
Well... no.
Mat's Mug
Mat's Mug
Feb 12, 2015 15:44
lol
RubberDuck
RubberDuck
Ignore the terrible name, but it would be more like.
`ICodeInspection : IInspection`
because the *real* inspection does things the configuration type doesn't need to know about.
Mat's Mug
Mat's Mug
ah, right
IInspection : IInspectionModel
RubberDuck
RubberDuck
That ^
 
Conversation ended Feb 12, 2015 at 15:46.