It feels a bit needlessly complicated and you aren't actually using private encapsulation. Unfortunately SO tends to frown at design and big picture issues. If you could re-post this at Codidact Software Development under the code review category, I'll take a closer look at it and post an answer. — Lundin16 secs ago
I wrote this two player tic-tac-toe program in bash. To make a move you enter a number between 0 and 8 which corresponds to the square:
0|1|2
3|4|5
6|7|8
This is my code:
#!/usr/bin/env bash
declare -r BOARD_SIZE=9
declare -r DEFAULT_SQUARE_VALUE=-
declare -ra PLAYERS=(O X)
draw_board() {
...
If you want someone to review your code and make suggestions, post to Code Review, not Stack Overflow. Stack Overflow is for code that doesn't work the way you expect. — Doug Stevenson15 secs ago
I have a function which does firebase set, update operations but it looks messy. I want to shrink it but also make sure that it works the same. Any ideas?
const handleUserSelect = async (user: Users) => {
if (!currentUser) return;
const combinedId =
currentUser.uid > user.uid
...
I have written my own basic implementation of the Observer pattern. Please code review it as you feel. This is a one file implementation, and any feedback no matter how small is appreciated.
One sticky point is I was unsure on the implementation of RemoveObserver, so this may not be optimal. Co...
The requirement is to define a macro which takes a single argument with the following contraints:
Is a character pointer
Must be non-null
Must be immutable
Must be 0-terminated
My first try at it was to surround it with empty string literals (I got this from Modern C):
#define SV(str) (sizeof("
Write an efficient function in the Python language called SmartSearch, this function will receive a sorted arr array of integers of size n containing at the beginning m "significant numbers" and the rest of the numbers are "fictitious numbers" whose value is 9999. The function also receives a num...
I came across this question which asks to create a function which will return true/false based on the passed array containing all the letters to make up the passed word. Each letter from array can only be used once.
Here's my attempt:
const checkArray = (word, arr) => {
let good = true
wo...
I wrote this two player tic-tac-toe program in bash. To make a move you enter a number between 0 and 8 which corresponds to the square:
0|1|2
3|4|5
6|7|8
This is my code:
#!/usr/bin/env bash
declare -r BOARD_SIZE=9
declare -r DEFAULT_SQUARE_VALUE=-
declare -ra PLAYERS=(O X)
draw_board() {
...
I have a function which does firebase set, update operations but it looks messy. I want to shrink it but also make sure that it works the same. Any ideas?
const handleUserSelect = async (user: Users) => {
if (!currentUser) return;
const combinedId =
currentUser.uid > user.uid
...
I have written my own basic implementation of the Observer pattern. Please code review it as you feel. This is a one file implementation, and any feedback no matter how small is appreciated.
One sticky point is I was unsure on the implementation of RemoveObserver, so this may not be optimal. Co...
The requirement is to define a macro which takes a single argument with the following contraints:
Is a character pointer
Must be non-null
Must be immutable
Must be 0-terminated
My first try at it was to surround it with empty string literals (I got this from Modern C):
#define SV(str) (sizeof("
I came across this question which asks to create a function which will return true/false based on the passed array containing all the letters to make up the passed word. Each letter from array can only be used once.
Here's my attempt:
const checkArray = (word, arr) => {
let good = true
wo...
