maybe the problem is #3 treats "code from a project" and "example code" as being mutually exclusive when they aren't necessarily (in the case of a project created as an example).
well, if we aren't, we have very different preconceived notions of what "example code" means, so the faq must be pretty ambiguous
to me, a project created to illustrate a design pattern for the sake of posting it here is example code, and it's a stretch for me to think of it as "just an example project but not example code."
I don't know why this is not in the .NET Library, but I need to be able to use an index against a list and not have it throw an exception if it is outside the bounds of the list.
This is what I came up with:
public static class LinqHelpers
{
public static TListType IndexOrDefault<TListType>...
This question looks like OP is worried about DRY and perhaps readability of a one-liner ternary.
I have a bias against one-liners and other narrowed-down questions, but there's a consensus about them being reviewable and on-topic, and besides there's no "too narrow" close reason.
Regardless of ...
I'm not sure if it defines topicality as such, but perhaps my view on the basic difference between here and SO will add something useful. At least as I see it, the basic intent on SO is to change the behavior of the code. The basic intent here is to refactor the code to be more readable, flexible, etc., but (at least normally) to maintain the same basic behavior.
As such, it seems to me that at least part of the basic intent of topicality is that 1) the present behavior of the code should be something that's worth maintaining (e.g., not obviously buggy) and 2) that the code is sufficiently complete and coherent that we can ascertain the intended behavior.
@DaggNabbit Right--the problem is that "worth maintaining" can be something of a judgement call. If it's obvious buggy, that makes it pretty obvious. If it works but is too limited to be useful...that's open to a lot more argument. If we aren't pretty liberal in that respect, nearly all student assignments fall outside the line as well.
I have the below mentioned function written in plpgsql which is working fine. I want someone to review it and let me know how can I improve its performance.
What this function does is that, it takes data from staging table and inserts into target tables. Before it inserts, it checks for the exis...
@DaggNabbit My own tendency is in rather the opposite direction--to err on the side of keeping things open unless they're clearly off-topic or of such low quality that they obviously detract from the site.
The simple fact is that rightly or wrongly, people generally often feel like they're being personally attacked when their questions get closed, so I'd rather avoid it just about any time it's at all reasonable.
@DaggNabbit Probably, but it really goes to my second point above: that it's so incomplete (and the names so generic) that we can't really ascertain what behavior is desired at any more than a microscopic level, so it's essentially impossible to suggest alternatives in a meaningful manner.
@JerryCoffin Yeah, after it was closed i tried to address it with a generic solution that could be generally useful, but apparently that's not enough to legitimize the question.
@DaggNabbit Yeah--and while it's a decent to good answer, it's horribly handicapped by the incompleteness of the question, to the point that I have to question whether I'd be at all likely to use the code from the answer in any real code (even assuming I did write JavaScript regularly).
Naming conventions
Classes start with an uppercase letter, methods start with lowercase letters.
HomeworkArrayWFunctionstest5 would be slightly better, but HomeworkArrayWithFunctionsTest5 would be even better, although describing what the class is used for is often best. That's hard to apply on...
@Mat'sMug good point, more like answering an SO question. But, if he had presented code to access deeply-nested properties of an object, I probably would have responded with the updated part of my answer, just the same.
@SimonAndréForsberg I probably wouldn't even mention it except that it's in bold-face, but you've misspelled "inconsistent" as "Inconcistent" in one of the headings.
@rolfl I remember we've been discussing Scanner before, what do you think of the use of it in this question? codereview.stackexchange.com/questions/54567/… . For me it feels wrong to create Scanners inside such a method call
I posted this code in an answer earlier today, but thought it was worth seeing if somebody could suggest further improvements:
#include <numeric>
#include <vector>
#include <iterator>
#include <iostream>
#include <algorithm>
template <class InIt, class OutIt>
OutIt adjacent_sum(InIt begin, InIt...
@Corbin I've had my online Minesweeper Flags game for six years now. I'm using ELO for Multiplayer games played there. You have no idea how many comments the players have had about that!! I did not make it easier either by allowing the AIs to have rating. Should then the AIs have static rating or dynamic rating? Should games vs. guests give rating? How to detect players who are just losing games on purpose? Oh decisions, decisions, decisions!!
@Mat'sMug I'm like that in Swedish so it's alright :)
I am trying to get a simple password from my technician's database but it seems that the $query line is not running. I am new to this PDO idea and I am not sure what to use for this either query or a prepare. From what I have read the query is a base query but the prepare is safer. Can anyone hel...
So, [this post](http://codereview.stackexchange.com/questions/54388/revised-version-of-a-complex-query-to-count-votes-with-a-redistribution-system#54388) is driving me crazy.. Mainly for this reason: `votes_above_the_threshold` is being called multiple times, yet nowhere in the script can I find where it is actually being declared/set. It's not a column name either... ugh.
@SimonAndréForsberg I wish I knew.... AOE II has existed for 15 years and they haven't been able to figure it out. I suppose you could have some kind of "upset" detection. For example, a 1500 should never beat a 1700. At least not 1v1 (as minesweeper always is). At the same time though, it can happen, and a 1700 could lose on purpose. :/
I've never actually played a game that had any decent form of automatic ELO governing. Making new accounts throws anything out the window. People on AOE II love to smurf and make a second account that's like 1550 when they're actually 1750+. It's very, very annoying for someone like me who usually plays in the 1550-1700 range :/ lol
As far as guest games go though, I would definitely have those unranked. It's way too easy to be untruthful if one of the people is anonymous.
Example Project vs Example Code
It's example code that we don't want to see. Example code is hard to review because it either:
lacks sufficient context (and/or)
has identifiers with names like foo and bar (and/or)
has methods with placeholder comments // ... instead of actual code
@200_Succe...
Yeah, me too. Not to be alarmist, but, we're driving through wicked rain, with hail, and wind, and then my cell phone starts chiming, and it comes up with 'tornado warning'.
Well, 3 seconds later it lightened up and we were through it, but, for a moment ....
@rolfl Tornado warnings can be a bit scary. Where I grew up, they were pretty common (sometimes two or three times a week during hottest part of the summer) and I still never quite got used to them.
Please evaluate this function. It takes a list [a] and an Int, i.e. the index, and returns a new list with the selected item at the top of the list. Note that it returns Maybe [a] to account for bad indexes.
pushToTop :: [a] -> Int -> Maybe [a]
pushToTop [] _ = Just []
pushToTop xs i
| i >=...
I'm working on a basic strategy game for iOS and I have a question about the overall layout of the code in the program. I added some features to the game today and I had to add code to several different places to get the features to function properly. In general I think I am doing things correc...
Hah. I'm pretty damn terrible at algorithms. I just got lucky and spotted a minor potential bug (unless "hey don't pass this an empty range" is a valid precondition -- then it's not a bug).
I noticed the spacing around the initialization list too, and I thought about including the headers and that. Seemed a bit minor given the context of throw-away code though :/ lol
But if someone else posts it, I shall certainly upvote it :p
This is the function I've implemented in an answer to this question. I've tried to make this as simple and idiomatic as possible, using C++11. Could this still be improved in any way?
Test run
#include <algorithm>
#include <cstdint>
#include <iostream>
#include <iterator>
#include <vector>
...
This is the function I've implemented in an answer to this question. I've tried to make this as simple and idiomatic as possible, using C++11. Could this still be improved in any way?
Test run
#include <algorithm>
#include <cstdint>
#include <iostream>
#include <iterator>
#include <vector>
...
Last semester in my Masters Program I developed this code for sieving.
Is this any decent? Or is my implementation really slow?
My professor wants me to write a report that he might use locally within the school, but I feel like I've done nothing that new, despite coming up with my algorithm wi...
I'm becoming acquainted with ruby by taking some of my legacy shell scripts and rewriting them as .rb
The pattern that is emerging is that I have a number of different dumb tasks, that do what they are told, and a coordinator that is responsible for ordering the tasks, and providing to the tasks...
@skiwi No. It's simply the old standard point of separating implementation from interface. The difference is that a Java interface requires you to explicitly specify all the operations the interface will support, then define a type as implementing that interface. A typedef is a but like a duck-typing version of the same basic concept. That is to say, we specify a type name and we use that type--but the requirements on the type are defined only by the operations we actually use.
Changing the typedef lets us substitute a different implementation of the interface (i.e., specify a different concrete type that will be used to support the specified operations). The big difference is that the interface is defined implicitly (by the operations we actually use) rather than explicitly by code that says what operations all implementations of that interface must support.
In this case, the operations used (that I recall immediately, anyway) were bit-shifting, bitwise-and, and most likely assignment. The typedef gives us a layer of indirection (over the type, not the address) that lets us substitute any other type, as long as it also supports bit-shift, bitwise-and and assignment.
Please take a look at this Fiddle
Is there a better way of building a table with titles in the first cell of each row, like this:
<div id="area">
<table>
<thead>
<tr>
<th></th>
<th>A</th>
<th>B</th>
<th>C</th>
</tr>
</thead>
<tbody>
<tr>
<td>Germany</td>
<td>...
Finding the nearest polygon out of a list of polygons seems to be quite a challenge on performance, due to lack of optimization. Consider the following image:
Rather than, code, I'll give the concept behind this. The "purple" pointer under the mouse is an entity and each blue blob is a polygon...
I am working with quite large files (pytables) and I am having problems with the Memory Error when I try to load the data for processing.
I would like some tips about how to avoid this in my python 32bits, since I am new working with pandas and pytables, and I do not know how to work splitting t...
I have a own made grid system and made a jQuery function for that to check if there are not to many columns in each row. If so, delete the HTML code of the row.
Normally in my grid system, there fits 12 columns in 1 row. But i can change that.
In HTML, i write them like this:
<div ...
Logic is to call a function with some input values and function returns multiple boolean variables.
In Future the boolean variables may be extended.
function(inp1,inp3,bool1,bool2... booln)
I decided to pack the boolean variables into structure
function(inp1,inp3,struct bool_flags)
Kindly ...
Welcome to Code Review! it seems you have misunderstood what this site is about. We do not help with implementing features or give abstract design advice. For stuff like this you might want to check out Programmers or Stack Overflow. Please read though their respective help center first to find out if your question is okay to be asked there. — Vogel6121 min ago
How to make the following code more efficient?
"""
Calculate the posterior distribution of p(pos|word) using Baye's rule:
p(pos|word) \propto p(word|pos)p(pos).
"""
word_pos_dict = defaultdict(float) # Example, word|pos -> 0.0012
pos_dict = defaultdict(float) # pos -> 0.005
pos_word_d...
An Arithmetic Progression is defined as one in which there is a constant difference between the consecutive terms of a given series of numbers. You are provided with consecutive elements of an Arithmetic Progression. There is however one hitch: Exactly one term from the original series is missing...
First, I'm in no way an experienced php coder. This is my 5th time working with php so if you see anything that can bee improve please point them out for me.
So I have the code checking for $_POST variable and use them to create the page title. Here is the code:
$pgeName = safeVal(basename($_SE...
i just started learning swift. I started with an example of rss feed parser. I've wrapper class written in ObjC which converted the xml response into NSDictonary. I'm using the NSDictionary returned from my wrapper class. Then in need to iterate though the NSDictionary and fetch all the title and...
How can I pass a property to a method to check if it's null? Something along the lines of public void IsRequired<T>(Expression<Func<T, bool>> property)
@Corbin My experience with ELO is that no matter how you do it, there's always someone who's not happy. (In my case though, that someone tended to be the same persons over and over again...)
I am doing a validation. I believe that, there is no.of stuff can reducible / removable. Still I an re-work on this. But I am looking for some experts look on my code and get the very best approach for both individual and form submit error handling.
here is my code : (see the fiddle for real val...
my Question is from Talent Buddy
Tweets per second Japan Castle in the Sky airing broke a Twitter
record on August 3, 2013. At one point during the classic anime movie
showing, people submitted 143,199 tweets per second. This particular
spike was about 25 times greater than Twitter’s st...
I'm new to Python, with some background in Java and C# from a while ago, and more recently in scripting worlds like Bash and AppleScript.
I wanted to be able to create classes that could a) report their instances, and b) limit their number of instances.
Synthesizing various answers from Stack O...
I don't know why this is not in the .NET Library, but I need to be able to use an index against a list and not have it throw an exception if it is outside the bounds of the list.
This is what I came up with:
public static class LinqHelpers
{
public static TListType IndexOrDefault<TListType>...
This question looks like OP is worried about DRY and perhaps readability of a one-liner ternary.
I have a bias against one-liners and other narrowed-down questions, but there's a consensus about them being reviewable and on-topic, and besides there's no "too narrow" close reason.
Regardless of ...
Naming conventions
Classes start with an uppercase letter, methods start with lowercase letters.
HomeworkArrayWFunctionstest5 would be slightly better, but HomeworkArrayWithFunctionsTest5 would be even better, although describing what the class is used for is often best. That's hard to apply on...
I posted this code in an answer earlier today, but thought it was worth seeing if somebody could suggest further improvements:
#include <numeric>
#include <vector>
#include <iterator>
#include <iostream>
#include <algorithm>
template <class InIt, class OutIt>
OutIt adjacent_sum(InIt begin, InIt...
Please evaluate this function. It takes a list [a] and an Int, i.e. the index, and returns a new list with the selected item at the top of the list. Note that it returns Maybe [a] to account for bad indexes.
pushToTop :: [a] -> Int -> Maybe [a]
pushToTop [] _ = Just []
pushToTop xs i
| i >=...
I'm working on a basic strategy game for iOS and I have a question about the overall layout of the code in the program. I added some features to the game today and I had to add code to several different places to get the features to function properly. In general I think I am doing things correc...
This is the function I've implemented in an answer to this question. I've tried to make this as simple and idiomatic as possible, using C++11. Could this still be improved in any way?
Test run
#include <algorithm>
#include <cstdint>
#include <iostream>
#include <iterator>
#include <vector>
...
Please take a look at this Fiddle
Is there a better way of building a table with titles in the first cell of each row, like this:
<div id="area">
<table>
<thead>
<tr>
<th></th>
<th>A</th>
<th>B</th>
<th>C</th>
</tr>
</thead>
<tbody>
<tr>
<td>Germany</td>
<td>...
Finding the nearest polygon out of a list of polygons seems to be quite a challenge on performance, due to lack of optimization. Consider the following image:
Rather than, code, I'll give the concept behind this. The "purple" pointer under the mouse is an entity and each blue blob is a polygon...
I have a own made grid system and made a jQuery function for that to check if there are not to many columns in each row. If so, delete the HTML code of the row.
Normally in my grid system, there fits 12 columns in 1 row. But i can change that.
In HTML, i write them like this:
<div ...
Logic is to call a function with some input values and function returns multiple boolean variables.
In Future the boolean variables may be extended.
function(inp1,inp3,bool1,bool2... booln)
I decided to pack the boolean variables into structure
function(inp1,inp3,struct bool_flags)
Kindly ...
You could try -
row.children('[class*="size-"],[class*="offset-"],[class*="push-"],[class*="pull-"]').each(function () {
columns += getCurrentSize(this);
});
function getCurrentSize(element){
return Number($(element).attr('class').match(/\d+$/)[0]);
}
How to make the following code more efficient?
"""
Calculate the posterior distribution of p(pos|word) using Baye's rule:
p(pos|word) \propto p(word|pos)p(pos).
"""
word_pos_dict = defaultdict(float) # Example, word|pos -> 0.0012
pos_dict = defaultdict(float) # pos -> 0.005
pos_word_d...
First, I'm in no way an experienced php coder. This is my 5th time working with php so if you see anything that can bee improve please point them out for me.
So I have the code checking for $_POST variable and use them to create the page title. Here is the code:
$pgeName = safeVal(basename($_SE...
Wrapper:
internal static class Cache
{
private static ObjectCache InternalCache
{
get
{
return MemoryCache.Default;
}
}
private static T CacheOrGetExisting<T>(string key, Func<T> valueFactory)
{
T value;
object uncastedValu...
I'm new to Python, with some background in Java and C# from a while ago, and more recently in scripting worlds like Bash and AppleScript.
I wanted to be able to create classes that could a) report their instances, and b) limit their number of instances.
Synthesizing various answers from Stack O...
