« first day (386 days earlier)      last day (3192 days later) » 

10:24 AM
Require clients to log in

See issue #363.

Handler code also is isolated from Server. The Server class is already
doing too much.
Merge pull request #370 from jacwah/auth

Require clients to log in
[Cardshifter/Cardshifter] build for commit 2749dd54 on develop: The Travis CI build passed
[Cardshifter/Cardshifter] Zomis pushed 2 commits to develop
[Cardshifter/Cardshifter] Zomis pushed commit 62aa86af to develop: Merge branch 'groovy' into develop
[Cardshifter/Cardshifter] Zomis pushed 3 commits to groovy
[Cardshifter/Cardshifter] Zomis pushed commit 1ac027cc to groovy: made 'query' (ServerQueryMessage) not require login
[Cardshifter/Cardshifter] build for commit 62aa86af on develop: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit 62aa86af on develop: The Travis CI build passed
[Cardshifter/Cardshifter] build for commit 1ac027cc on groovy: The Travis CI build passed
 
10:43 AM
hey
 
hey
 
The DNS servers still haven't flipped
 
@SimonAndréForsberg How exactly does this work?
Oh wait, I'm stupid, ignore me
list != result
Since when the the room name get updated here?
 
yesterday, by Simon André Forsberg
room topic changed to Cardshifter TCG: Site http://www.cardshifter.com/ - Snapshots http://www.cardshifter.com/releases - Q&A http://www2.zomis.net/tcg-creation/ - Github https://github.com/Cardshifter/Cardshifter - Network https://github.com/Cardshifter/Cardshifter/network - Waffle https://waffle.io/Cardshifter/Cardshifter [cardshifter] [duga] [groovy] [java] [libgdx]
 
10:49 AM
That's the room topic though? Or does that change also include room name
 
I don't know TBH, but it looks like it also includes the name ("Cardshifter TCG: ")
 
True ^^
Should I go somewhere else with Fragments? :P
 
naah, Fragments can stay
 
Yaay
 
room topic changed to <room name>: <description> [tags]
 
10:51 AM
I just realized that FragmentsServerService sounds weird, because I put it in the services directory, while it's just really a bean
services are transactional by default, which doesn't even make sense here
 
who cares about names? :)
 
This may lead to issues I believe
 
It's one of The Hard Things
 
Only Services (that interact with the domain model) should be in services/
 
[skiwi2/Fragments-Server] skiwi2 pushed commit 59c74e37 to develop: Moved FragmentsServerService out of services package and renamed it to FragmentsServer, it now is just a regular Spring bean instead of a Grails service.
 
10:57 AM
Any clue how to start a Grails app via Tomcat with arguments? (I'm trying to figure out how to set application arguments in my Grails app that are not hardcoded)
2
A: How do you manage the configuration of a grails application deployed as a "product"?

ScArcher2I found this documentation after some searching on the grails site. 3.4 Externalized Configuration The default configuration file Config.groovy in grails-app/conf is fine in the majority of cases, but there may be circumstances where you want to maintain the configuration in a file outside the ...

Seems pretty cool ^^
 
> I think this issue can be closed as of 75a6854fccfd15bbfc379a8060c4f186c59e1fed.
 
I know what I'll be supporting first on my server ;)
 
@Duga Didn't realize I can close my own issues!
 
[Cardshifter/HTML-Client] Zomis pushed commit 7e697651 to game-board: resetting selected properly
[Cardshifter/HTML-Client] Zomis pushed commit 335bacef to game-board: changed selectCard to selectEntity and made players targetable, removed isTargetable method for cards
 
@skiwi use a config file?
@Duga @jacwah whoops, I forgot to close it
 
11:05 AM
Ugh, bluescreened
@SimonAndréForsberg Yeah, was trying to figur eout how, but the answer I posted below my question seems to be okay
 
that's what you think
I foresee problems.
 
Ouch
Some IntelliJ stuff is corrupted
52
Q: Intellij IDEA crashed and now i have Error

bvvi work in Intellij IDEA, my computer freezes, I off computer (long click power button), when i turned on computer and start Intellij IDEA i had Error Cannot load settings from file 'C:\Users\user\.IdeaIC13\config\options\code.style.schemes.xml': java.lang.AssertionError: Unexpected content stor...

Got lucky there, just a cache issue
 
[Cardshifter/HTML-Client] Zomis pushed commit c34fa4bc to game-board: if action requires exactly one target, perform action directly (see #61)
 
@SimonAndréForsberg What problems do you see?
 
> I found this documentation after some searching on the grails site.
check the version
and see the time for when the answer was posted
 
11:20 AM
A little bit... old
 
exactly ^^
Now, do you think a five year old answer will work for you?
 
Oh wow, I mixed things up there, I thought it was from somewhere early '14
But that might've been some other answer then
 
12:06 PM
monking
 
Hello
 
how are you? <:
 
This is finally my day to relax after 7 days of work/school :)
 
Awesome :D
I overslept today so now I just feel stupid because I only have 9 hours before I need to sleep again
 
Sleep patterns are hard to get right
 
12:16 PM
No, it's not even a sleep pattern. I just overslept :(
 
But now you've got a problem if you have to go to sleep in 9 hours.
 
#firstworldproblems
 
[Cardshifter/HTML-Client] Zomis pushed commit 2501406f to game-board: keeping track of which card is in what zone and using that info to update properties
[Cardshifter/HTML-Client] Zomis pushed commit d260b013 to game-board: implemented removeEntity function
 
12:45 PM
@Phrancis @SimonAndréForsberg Info on directives
 
12:58 PM
[Cardshifter/Cardshifter] Zomis pushed commit 2910928a to groovy: sending PlayerEliminatedMessage when a player is no longer able to play in a game (whether win or lose)
[Cardshifter/Cardshifter] Zomis pushed commit b9b59444 to groovy: corrected player elimination resultPosition
[Cardshifter/Cardshifter] Zomis pushed commit 91f74ab2 to groovy: the players who are the last ones standing are marked as winners
 
> OK CodeReview, y'all gonna learn today about angular directives
love it already
 
[Cardshifter/Cardshifter] build for commit 91f74ab2 on groovy: The Travis CI build passed
 
that resembles a lot what the Angular docs said
 
I tried to make it more human language ha
But well, they are docs :P
 
1:24 PM
> A new PlayerEliminatedMessage was recently added to the server, would be perfect to react on that. When you receive that message with an id matching your player, you will no longer be able to perform any actions in the game. That message contains information about whether you won or lost also.
 
2:17 PM
[Cardshifter/Cardshifter] Zomis pushed commit e91fdfd2 to groovy: sending ZoneMessages in order, for consistency
[Cardshifter/Cardshifter] build for commit e91fdfd2 on groovy: The Travis CI build passed
 
@DanPantry / @SirPython when I use templateUrl it seems like it looks for the template in the www directory, is it possible to have it look in a directory such as src/cards ?
 
@SimonAndréForsberg templateUrl looks for a url in the web host
 
am I doing something wrong?
should I just use template ?
 
so if you're on localhost:8080 and you look for 1234.html it will look for localhost:8080/1234.html
you're on the wbepack thing right?
 
I think so... I'm not sure what this is using honestly
 
2:31 PM
Ok well, templateUrl causes angular to execute a XHR to that url
so it will look at stuff in the www directory because thats' what is set as localhost in the webpack dev server.
 
okay, that's not optimal
 
You should use template + require
 
I'll try template then
got it
 
var template = require('./template.html')
.....
template: template
 
oh holy crap this is awesome
 
2:33 PM
webpack i sgreat as well because later on you can extract all of the text required by a certain pattern
 
it's possible to have the template being returned by a function, right?
 
Yes.
 
so you can run postprocessing to extract all html into their own file and distribute that on its own
 
I'll let someone else take care of that part
 
2:34 PM
It was just an example of what you can do :p
 
I have no clue about how the build system works for the HTML Client
I'm just happy it works
 
;-)
I put it together of course it works o;
 
and yet you ask if I'm on the webpack thing
 
You might have been on a different branch
 
I think all branches use the webpack thing by now
 
2:36 PM
oh, alright
 
> With the implementation of #363 in 75a6854fccfd15bbfc379a8060c4f186c59e1fed, I don't think the connection has to be closed. The server already lets clients know if a login attempt fails or succeeds; it's up to the client to handle that in UI. Since 1ac027cc485baabfeaee88056eabbf8f39beb02c any client, logged in or not, is allowed to send ServerQueryMessage. I don't see why a failed login attempt should deny clients to send certain messages. To try to log in again, the client can reuse the same
 
Monking!
 
Monking @Phrancis
 
Aug 18 at 21:28, by SirPython
 
@Phrancis didn't you move the card_model files to src/ ?
 
2:44 PM
20 hours ago, by Simon André Forsberg
@Duga @Phrancis when you do that, you could make it apply for all cards at once, easily, if you'd like.
@SimonAndréForsberg Not yet, no
I can move them right now if you like though
 
don't worry
me fix
 
Aww cute
 
[Cardshifter/HTML-Client] Zomis pushed commit 77fb2237 to game-board: added card Angular-directive and loading card models from src/card_model/card_template.html
 
Wait, did you just inject that into the game board!?
 
2:49 PM
HOLY CARP
 
Honestly, it was incredibly easy to inject that.
Directives FTW
 
it's super easy
 
Wow ok, glad to hear it!
 
[Cardshifter/HTML-Client] Zomis pushed commit 31e0507b to sections-layout: Merge branch 'game-board' into sections-layout
[Cardshifter/HTML-Client] Zomis pushed 11 commits to develop
 
2:54 PM
@Phrancis TODO: Change card template to use divs and stuff instead of tables!
 
LOL
 
17 hours ago, by Simon André Forsberg
I WANT JQUERY
@SimonAndréForsberg I don't want jQuery at all!
3
 
I can do that before I do anything else, shouldn't take very long anyways
 
please do
note that I forwarded your branch
 
@SimonAndréForsberg LOL
 
2:56 PM
12 mins ago, by Phrancis
20 hours ago, by Simon André Forsberg
@Duga @Phrancis when you do that, you could make it apply for all cards at once, easily, if you'd like.
@SimonAndréForsberg what did you mean be that^?
 
[Cardshifter/HTML-Client] Zomis deleted branch server-listening
 
20 hours ago, by Duga
> I talked to @jay1148 and he will provide us generic logos for Cardshifter, Cyborg Chronicles and Mythos that can be used as placeholders until a card has an image of its own. Eventually, most if not all cards will have an image of their own. This will not require any coding, just adding this attribute to each card.
 
> Is the stack overflow solved by #352? If not, how can I reproduce it?
[Cardshifter/HTML-Client] Zomis deleted branch lobby
[Cardshifter/HTML-Client] Zomis deleted branch deck-builder
 
@Phrancis it sounds like you wanted to apply a place-holder image to all cards, if so, you don't need to copy-paste the imageURL '...' on every card, instead you can have it apply to all cards at once
 
O. Yeah that'd be great. Can we make it by mod though?
i.e., different images for CC and Mythos
I was going to hardcode something like imagePath 'cardimages/mythos/default.png' etc.
 
3:00 PM
@DanPantry Ready to review my React code for Fragments?
 
> Stack Overflow error has been fixed, yes. As for EOFException, I think that is not a global bug, only a local one (because of incompatible versions between the gdx project and main Cardshifter repo).
 
@Duga @bazola
@Phrancis sure thing
 
Hm, let's just drop cardimages/ from that, that'd be better fit client-side (type it once instead of 200 times, and less chance for typos)
 
hey @Phrancis
 
So, then, let's just assume I'll have a mythos/default.png and cyborg-chronicles/default.png image, how would we go about doing that?
 
3:03 PM
@Duga Does this mean that the issue is solved @SimonAndréForsberg?
 
@skiwi im in game ATM
 
@DanPantry Don't worry, the code isn't here yet
 
@jacwah probably, but I want to check with @bazola first.
@Phrancis we use Magic!
 
@DanPantry A friend of mine is about to start a project where he needs to display stats/graphs on a page based on information queried from databases. He has access to all .NET platform but he knows naught about web dev. What would be a good JavaScript or other technology for something like this, in your opinion?
He hasn't written a line of code for it yet, so now's the best time to decide which tech to use
 
The SPDX identifier for the Apache 2.0 license is AFL-2.0.
 
Hmm that's pretty gorgeous - and also jQuery, you think that would be the best for him?
 
@Phrancis graph data? highcharts, d3 or rickshaw.
 
Graphs and tables, yes essentially
 
@Duga True, but I think you missed something there.
 
3:12 PM
@Duga huh?
What did we ask @Duga there? :p
 
Ah :P
 
Correct license property in package.json

The SPDX identifier for the Apache 2.0 license is AFL-2.0.
Merge pull request #64 from jacwah/fix-license

Correct license property in package.json
 
jQuery is for DOM manipulation
Not for graphs/tables
 
3:14 PM
@jacwah Aren't you added as a contributor? If not, would you like to be?
 
@SimonAndréForsberg should we do a new snapshot with the fixes?
 
@Phrancis I'd be honoured :)
 
@Simon ^ could you add @jacwah please?
I need to update the website soon, but I keep postponing because I hate having to use Eclipse :|
Couldn't find anything that works with IDEA and Tomcat
 
@Duga oh bloody... I thought I fixed you this morning
 
> $ git status
error: bad signature
fatal: index file corrupt
 
3:20 PM
> > The SPDX identifier for the Apache 2.0 license is AFL-2.0.

[Duga just turned into a trivia bot.](http://chat.stackexchange.com/transcript/message/23616058#23616058)

This message was posted when I created [a PR](https://github.com/Cardshifter/HTML-Client/pull/64) from my fork to https://github.com/Cardshifter/HTML-Client.
 
@bazola I think that fix was included in the last snapshot already
@Phrancis @jacwah has been added
 
[skiwi2/Fragments-Server] skiwi2 pushed commit fc742e5f to develop: Made WebSocket server host and port configurable in application.yml.
> related to #95
 
@skiwi where's that react code then?
Bear in mind I'm not an established authority on React..
 
@DanPantry /dev/null
 
@SimonAndréForsberg lol
 
3:23 PM
@DanPantry I still have to write it ;)
 
@skiwi oh :P
well, I onl picked up React a week ago, so I'd only be able to offer an opinion rather than informed opinion
 
Any opinion is welcome :)
 
[Cardshifter/HTML-Client] Phrancis pushed commit 1700630e to sections-layout: Replaced table layout of card model with divs.
 
@SimonAndréForsberg Time to celebrate!
What is cardshifter-database for?
 
3:35 PM
@Phrancis This may be intentional, but I think you forgot to delete some things from the deck builder HTML after you changed things around: I still see the old deck list and deck saving form at the bottom of the page.
 
Oh. Must have forgotten to clean-up
 
@SimonAndréForsberg Do you know if, in general, you should use Java reflection or Groovy metaClass if doing reflective stuff?
Say if a client sends test | a, I want to call a method someClass.test("a") for example
Gonna give an interesting problem withs trings and ints already there
 
> I was playing a test game and I noticed that the three "Medusa Snake" cards I had on the field all said "-1/1" on their cards.

Is this a bug?
 
I could potentially play around with invokeMethod -- but it would be cooler if there was something like methodExists
 
Popovers look great IMO! ^
 
3:44 PM
That looks great!
 
Only problem now will be doing something with those \ns but I'll open an issue, since I don't know how to fix it
I can't do it within the HTML page because the \n are passed into a tag property, so it would have to be preprocessed I think. I'm not sure a <br/> would work either for same reason, so we may have to use a char10
 
@jacwah future database stuff. mainly something @Phrancis has been working on from time to time
@SirPython that might be my fault. I did the merge.
 
[Cardshifter/HTML-Client] SirPython pushed commit 412466d8 to game-board: added blank hrefs to deck and card links
 
@SimonAndréForsberg In the deck builder, do you think that the card models should be in place of the card name links, or you should only see the card model once the card name link is clicked?
 
3:49 PM
> If it says -1/1, that's -1 attack, not health.
 
@SimonAndréForsberg Oh wow...
That looks easy
I also just realized that using Java reflection on a Groovy class probably makes no sense
 
@SirPython don't know actually. That's a design decision. In the deck builder, I don't know if @Phrancis / everyone wants to have a table of the cards (like @Phrancis' screenshot) or showing the cards as real cards
@skiwi it is easy, and Groovy
 
[Cardshifter/HTML-Client] Phrancis pushed commit 723e7136 to sections-layout: Added popovers for effect and flavor buttons
 
If we were to put the card models in the table, the table would be very stretched out.
 
3:53 PM
@SimonAndréForsberg What I"m trying to do is probably a bit more difficult though
Oh right, this docs.groovy-lang.org/latest/html/api/groovy/lang/… actually is what I want
just trying to figure out from the docs what happens if the method doesn't exist
 
@skiwi groovy can call a methodMissing method for missing methods, or if no such method exists as well, throw an exception
 
@SimonAndréForsberg Ok, but the docs don't describe that exception, might be my gripe
I know a way to figure it out though :)
 
@skiwi I would not use that. I would use my solution instead (which in turn calls that method)
 
I could also make it as I think is okay and you can provide feedback on that :)
My arguments are also variable for example
 
3:58 PM
I know about methodMissing, but the called class does not have the responsibility to handle the case when a method is missing
The class that calls that class should handle the case if a method is missing
 
@SimonAndréForsberg My wife actually had a good suggestion on that particular aspect, after I showed her the builder
She said perhaps we should make it to where you can select one design or the other, at your preference
 
displays card model on click

Before, when a card name link was clicked, a list of all the card data would be displayed at the top. However, now that there is a card model directive, upon clicking the card name link, a card model directive is loaded which displays all the information about the card in card form.
 
Perhaps we could just make two big divs with the different layouts, and a button to switch between them
 
Configuration over convention?
 
Guess that's one way to put it :)
With the flexibility of AngularJS and Bootstrap together, I don't see that would be a big problem or add much overhead, if any
 
4:06 PM
> I see this deals with #60 as well, good good
 
@Duga Good good :)
 
@Duga This can be reduced to completely getting rid of the $scope.showDetails and instead using radio inputs and ng-model. Or, is it fine as it is?
 
> Ah, my bad. However, should the attack be -1?
 
Don't mind this: i.imgur.com/6XEFeap.png
Just dropping here so I can SMS it to Jay and GreyFox
 
[Cardshifter/HTML-Client] Phrancis pushed commit 276c8a16 to sections-layout: Cleanup deck builder
 
4:17 PM
I know so little about Groovy :(
There's an equivalent to Runnable, but I don't know what it is
 
@Phrancis Now that the card model is displayed in the deck builder, how much information still needs to be in the table? Is there any repeat data? Or is good to have all the information there because it makes for an easy comparison?
 
> Attack value can go negative, yes. There are some creatures that while in play have an effect on other creatures
> The main repo comes with a few pre-built decks, this client should also (somehow) come with a few, preferably.
 
@SirPython The latter, IMO
Wait, card model is shown in deck builder? Since when?
 
20 mins ago, by Duga
displays card model on click

Before, when a card name link was clicked, a list of all the card data would be displayed at the top. However, now that there is a card model directive, upon clicking the card name link, a card model directive is loaded which displays all the information about the card in card form.
You may not have pulled yet.
If we want to work on an issue, should we assign ourselves to it, or just do it?
 
[Cardshifter/Cardshifter] Zomis pushed 1 commit to groovy
[Cardshifter/Cardshifter] Zomis pushed commit 258bf066 to groovy: Merge branch 'mods' into groovy
[Cardshifter/Cardshifter] Zomis pushed commit acb3b448 to groovy: added default card images
 
4:28 PM
@SirPython preferably both. Just doing it is more important, but assigning yourself to it is a good thing to do
 
Wow. The client works for CC, too!
2
 
2 hours ago, by Dan Pantry
I put it together of course it works o;
s/I/we/
 
[Cardshifter/Cardshifter] build for commit acb3b448 on develop: The Travis CI build passed
 
4:33 PM
Well, I didn't expect it to work because I thought it was only tested for Mythos ;-)
 
[Cardshifter/Cardshifter] build for commit acb3b448 on develop: The Travis CI build passed
 
@SirPython well, I haven't tested it for CC, but I see no reason why it wouldn't work
 
Well, my main confusion originally was the difference in how messages are sent in the beginning.
 
Any thoughts so far?
 
4:36 PM
@Phrancis now we're talking
 
@Phrancis That looks great! It has a very sleek design.
 
@SirPython look at the similarities instead of the differences :)
 
I'm curious to put the type and atk/hlt above the picture
That would make it look very much like YGO
 
Do we want it to look like YGO?
 
YGO?
 
4:37 PM
Yu-Gi-Oh
 
Not necessarily. I'd prefer it looked like Pokemon or MTG really
 
some old TCG-style game
IMO, we want it to look like Mythos / Cyborg-Chronicles. i.e. we want it to look like our game.
 
@SimonAndréForsberg Just don't say that in front of Jay, he's a fan of YGO ;)
 
...whatever that means
(that = "our game", not "fan of YGO")
 
lol figured as much :)
 
4:40 PM
> see the github.com/Cardshifter/HTML-Client/tree/server-stats branch for some progress on this
> Seems like game board doesn't use currentUser at all anymore (which I am grateful for), I'd like however that it also be removed in github.com/Cardshifter/HTML-Client/blob/develop/src/… as well. Is it possible to pass it along to the controller constructor or something, rather than have the controller ask the currentUser object for this value? ("Tell, don't ask" principle)
 
@Duga currentUser is used twice in game board, @SimonAndréForsberg.
 
or 4 times, depending on how you look at it. currentUser.game.mod * 3 and currentUser.game.id
 
> I believe that the angular-ui-bootstrap-thingy can be used for this to create some sort of Modal that is shown when game is over
 
Right, forgot about the game over.
Isn't there a message for that?
 
3 hours ago, by Duga
> A new PlayerEliminatedMessage was recently added to the server, would be perfect to react on that. When you receive that message with an id matching your player, you will no longer be able to perform any actions in the game. That message contains information about whether you won or lost also.
there's also GameOverMessage, but I think PlayerEliminatedMessage is better
 
4:51 PM
Ah, I see. So GameOverMessage is obsolete?
 
more or less
it will be kept around though
 
I'm going to start working on handling the game over.
 
because just because one player is out of the game doesn't have to mean that the game is totally ended
good
 
I will either improve or make worse some stuff about the cards on battlefield
 
4:57 PM
> In line with what is written above, how about making `cardset 'spells'` search for `spells.cardset`? In other words, keep `include` as it is and force `cardset` to look for files with the `.cardset` extension.

An alternative solution could be to separate the file searching logic for the two keywords and have `cardset` look in the local mod directory (e.g. `mods/mythos/`) and `include` in the parent directory (`mods/`).

new File(modDirectory, fileName),
new File(modDirectory.getP
 

« first day (386 days earlier)      last day (3192 days later) »