> Seems I misunderstood the issue here. I thought this was about the actual file transfer. What you're actually saying is that you want the game server to detect if a file under `extra-resources` is changed and start using that file instead.
> allowing updates to game content without having to [...] restart the server.
I think the first thing to do here is to examine the current behaviour. What files are kept open, and what files are read each time a new game starts? AFAIK, no groovy file
Ah, that's interesting. This seems a little like the concept of, on big projects, only having to re-compile a single file rather than having to re-compile the entire project.
> Another solution would be to "hot-swap" servers instead of individual files. If you want to update something something on the server:
1. Start a new server process (without killing the old one). Don't listen for connections yet. 2. Tell the old server to stop listening for new connections, but keep it running so that running games are not interrupted. 3. Tell the new server to start listening for connections. 4. Notify clients in the lobby of the old server that they should reconnect or
> This should already work fairly well on OSs that aren't Windows. MS had the great idea to make any file currently open in another process uneditable. In Linux (and I think OS X too) if a file is edited by one process the other process still has it's own copy of the file, just like it looked like when it was opened by them.
> I tested what currently happens by starting a game, changing the deck size in Game.groovy and then starting another game. Everything seems to be fine.
> AFAIK, all the files in extra-resources are read each time a game starts. I don't think race conditions are a concern so much here, as once a game entity is created (along with all the additional entities that are related to it), it appears to be stand-alone, as in it won't have to read any of the Groovy game files again until the game is over and a new one is started.
➜ cardshifter-0.6.1-SNAPSHOT-20150905-2155 git:(mods) java -jar cardshifter-server-0.6.1-SNAPSHOT.jar
no main manifest attribute, in cardshifter-server-0.6.1-SNAPSHOT.jar
That's the regular one^
➜ cardshifter-0.6.1-SNAPSHOT-20150905-2155 git:(mods) java -jar cardshifter-server-0.6.1-SNAPSHOT-all.jar
Cannot read properties: java.io.FileNotFoundException: server.properties (No such file or directory), using defaults.
No security manager has been installed, you need to install one to be protected against malicious mods, please refer to the documentation to install a correct security manager.
CONTINUE AT YOUR OWN RISK
Do you want to continue without a security manager? (y/n)
y
[2015-09-05 22:20:15,869] INFO ModCollection [ main] ( ModCollection.java: 59) - Loading mods in /Us…
That^ is the -all one - which fired up (apparently) correctly, but then raised that other error when I tried to connect from localhost
> Right now, every time the "refresh" button is clicked in the server stats section, a new "user" is created that exists as long as the user keeps the client open.
This "user" has no name, but can be seen in the lobby:
CardshifterServerAPI.init is now called by passing anonymous functions with the local variables passed into it.
Before, when this loop inside $scope.refreshServers was running, since API.init is async, the loop would finish instantly and the local `thisServer` would be the very last server in the list. Now, an anonymous function is passed to the init method that is given the current server when it is passed in so it does not change in that function's scope.
It is quite easy to attempt and crash a server just by smashing the "refresh" button. Right now, there is an interval setup to disable this button for a certain amount of time, but it still needs some work (aka: it doesn't work)
@Phrancis the -all file should get renamed during the build process. What gradle command did you run? Also, that ArrayIndexOutOfBoundsException indicates that you might be running a quite old server. What git branch are you on? Did you pull latest changes?
1. When pressing the "Refresh" button, the connection is not closed after getting response from the server. (which should be fixed in the HTML Client) 2. The server sends out user information messages even for users that are not logged in (which is a server issue)
> Even if no files are read after game initialization, a race condition still exists: if one game is in the process of initialization and has read 50% of the files, and they're then replaced, it's going to have 50% old files and 50% new files loaded. This will lead to very unpredictable behaviour.
> I am not a fan of hot-swapping servers, for several reasons: Users becoming separated between different servers, not being able to observe games on other servers (see #110), requiring clients to reconnect...
I think the best way is to toggle a flag on the server, which temporarily prevents - or pauses - new game creation while the files are being updated
As for how to actually update the files, the issue is that there are many different servers (bazola's, mine, several localhosts being u
> I think server admins should have control over their own server. I don't see why a person who is not trusted with ssh or ftp login should be trusted to modify resource files.
> I think the best way is to toggle a flag on the server, which temporarily prevents - or pauses - new game creation while the files are being updated
A system-wide locking mechanism will be required. * There can be multiple servers using the same set of resources. * The server needs to keep track of if games are
@Duga @jacwah I don't quite understand what you're saying here. "multiple servers using the same set of resources", do you mean on the same machine or on different machines?
as I see it, and as you rightfully have noted, there is a potential problem that can happen with the implementation of issue 381. When fixing issue 381, we should try to fix it so that multiple processes of servers are supported.
How about writing an empty update.lock file and have the servers check if that file exists when starting a new game?
from my experience with Minesweeper Flags Extreme, having a /nogames command is very useful feature on a server.
when writing /update (assuming we will go by that approach), how about having the server that you are writing it on check the statuses of games. I believe server games are marked as NOT_STARTED in the beginning of the initialization.
if a server admin is running multiple servers, then he can use /nogames on one to disable new games, write /update on the other, which makes sure that no games are currently initializing and then downloads new files, and then write /nogames on the first again to re-enable new games
I disagree there. In fact, running multiple processes that have the same resources is done very often, if you run a server at the same time as you're doing gradlew test for example. However, the likelihood that you want to update both servers with the latest mod data is very low, not to mention the probability of something going wrong because you're updating at the same time as someone is starting a new game.
The easiest, and most reasonable, way for us IMO is to use a /nogames command that switches a flag on the server so that the server doesn't allow new games to be started. And in addition have a /update command that (safely, but only taking into the consideration the current process) updates the mod files resources.
> Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any
In my university, graduate students under scholarship have to perform certain tasks like tutoring and grading. I have no problem with that since it is part of the contract.
There are also some miscellaneous tasks like offering to help out for a departmental party (takes 10 hours over a few days)...
> Take a look at https://github.com/TomasMikula/RichTextFX/blob/master/richtextfx-demos/src/main/java/org/fxmisc/richtext/demo/JavaKeywords.java and see what can be accomplished with syntax highlighting in Brainfuck.
- [ ] Match `[` and `]` - [ ] Different color for comments - [ ] Highlight `[` and `]` and possibly `.` and `,` - [ ] Use [dynamic tooltips](https://github.com/TomasMikula/RichTextFX/blob/master/richtextfx-demos/src/main/java/org/fxmisc/richtext/demo/TooltipDemo.java) for insp
➜ cardshifter-0.6.1-SNAPSHOT-20150906-1312 git:(mods) java -jar cardshifter-server-0.6.1-SNAPSHOT.jar
Cannot read properties: java.io.FileNotFoundException: server.properties (No such file or directory), using defaults.
No security manager has been installed, you need to install one to be protected against malicious mods, please refer to the documentation to install a correct security manager.
CONTINUE AT YOUR OWN RISK
Do you want to continue without a security manager? (y/n)
y
> We had [a discussion](http://chat.stackexchange.com/rooms/16134/conversation/discussion-about-381) in chat and decided to use a process-scoped flag switched by a `/nogames` or `/update` command. The flag will prevent new games from being started.
> * The easiest, and most reasonable, way for us IMO is to use a /nogames command that switches a flag on the server so that the server doesn't allow new games to be started. And in addition have a /update command that (safely, but only taking int
@Phrancis Trust me, I find weird things too. The only difference is that I can find out what is causing them easier and know how to either fix it or work around it.
> Please post here any game balance issues/concerns you find so they can be addressed/fixed. Please make sure to identify the Mod, the Card(s) in question, and what you think is unbalanced.
@SimonForsberg Not sure, I was just going to keep one of those for each month to keep all balance related things in one place...
Guess that'd be fine
I talked to Jay about manaUpkeep for Mythos. He would like for it to always be even numbers (not sure why). We're thinking upkeep should be about half of manaCost across the board, and make adjustments to specific cards if/when needed
So I can round down or up, depending on which one is going to be even
Hm, I should really write a script to do this, doing it by hand would take a long time
but if there's a "default" rule for what the value should be, then you can do it in the Game.groovy, then only change the value for the cards that should have a different value than the default
/**
*
* @return This could be used for randomly pairing up clients
*/
public AtomicReference<ClientIO> getPlayAny() {
return playAny;
}
This javadoc is not very informative
/**
* This could be used for randomly pairing up clients
* @return Atomic reference that will reference a ClientIO that is looking to play if one exists
*/
public AtomicReference<ClientIO> getPlayAny() {
return playAny;
}
