12:01 AM
[rubberduck-vba/Rubberduck] 10 commits. 3 closed issues. 2 issue comments. 3215 additions. 185 deletions.
[Vannevelj/VSDiagnostics] 2 commits. 1 opened issue. 1 closed issue. 3 issue comments. 488 additions.
3 hours later…
3:10 AM
Merge pull request #779 from INOPIAE/#778
Replaced "Menu Bar" by index number of the control bar so it should w…
Replaced "Menu Bar" by index number of the control bar so it should w…
[retailcoder/Rubberduck] Vogel612 pushed commit 06ab8c0e to next: Replaced String-Based access with named integer constants, as per #778
[retailcoder/Rubberduck] Vogel612 pushed commit 21e5db1f to next: Corrected spelling error in German locale, removed duplicate entry in English locale
[retailcoder/Rubberduck] Vogel612 pushed commit 4ca8758f to next: Moved RemoveParameters from the RefactorMenu into a Command class, see #762
[retailcoder/Rubberduck] retailcoder pushed commit 342721bc to next: removed source control junk in .csproj file
3:18 AM
[retailcoder/Rubberduck] retailcoder pushed commit 7c8130c4 to next: moved files where .csproj expected them
[retailcoder/Rubberduck] retailcoder pushed commit 7d5857af to next: removed unused usings in RefactorMenu; marked class as obsolete
4:04 AM
[retailcoder/Rubberduck] retailcoder pushed commit c55aa6c5 to next: fixed baseCommandTypes bindings
4:19 AM
[retailcoder/Rubberduck] retailcoder pushed commit bcd4997c to next: disabled unimplemented RegexSearchReplaceView; RefactorExtractMethodCommand.Execute runs twice for some reason.
1 hour later…
6:12 AM
[rubberduck-vba/Rubberduck] INOPIAE commented on issue #755: Implement a more permissive AssertClass
> When I try to compile the next branch (sha-1: 49ae39383d7cbb0f30b65155fe3578192147eda) I run into these two errors:
"'Rubberduck.Unit.Testing.PermissiveAssertClass.AreEqual()': cannot override inherited member 'Rubberduck.Unit.Testing.AssertClass.AreEqual()' because it is not marked virtual, abstract, or override"
"Rubberduck.Unit.Testing.PermissiveAssertClass.AreNotEqual()': cannot override inherited member 'Rubberduck.Unit.Testing.AssertClass.AreNotEqual()' because it is not marked virtu
"'Rubberduck.Unit.Testing.PermissiveAssertClass.AreEqual()': cannot override inherited member 'Rubberduck.Unit.Testing.AssertClass.AreEqual()' because it is not marked virtual, abstract, or override"
"Rubberduck.Unit.Testing.PermissiveAssertClass.AreNotEqual()': cannot override inherited member 'Rubberduck.Unit.Testing.AssertClass.AreNotEqual()' because it is not marked virtu
4 hours later…
9:55 AM
2 hours later…
12:11 PM
[Vogel612/TranslationHelper] Vogel612 pushed commit 272bf06d to develop: Inlined TranslationPresenter, removed .impl package
[Vogel612/TranslationHelper] Vogel612 pushed commit 4bef29d7 to develop: Inlined OverviewModelImpl
12:31 PM
[Vogel612/TranslationHelper] Vogel612 pushed commit 3ce5f9e8 to develop: Inlined OverviewPresenterImpl
3 hours later…
3:33 PM
[rubberduck-vba/Rubberduck] mwolfe02 opened issue #784: Test Explorer test runner is adding reference to Rubberduck type library
> I'm trying to run tests with late-binding. I switched from `New Rubberduck.AssertClass` to `CreateObject("Rubberduck.AssertClass")`. I can remove the reference to the Rubberduck type library and the project compiles. Everything's good so far.
When I run the tests from the Test Explorer, though, the reference to the Rubberduck type library is being re-added to my project without warning. It's just an annoyance, but I don't want to ship out a production version of my Access app with a lib
When I run the tests from the Test Explorer, though, the reference to the Rubberduck type library is being re-added to my project without warning. It's just an annoyance, but I don't want to ship out a production version of my Access app with a lib
4:16 PM
[rubberduck-vba/Rubberduck] mwolfe02 commented on issue #784: Test Explorer test runner is adding reference to Rubberduck type library
> It looks like this may have already been fixed on August 22 in revision ff60ef93f231b50c8956853819df620b0c781d05.
The following lines were removed from \RetailCoder.VBE\UI\UnitTesting\TestExplorerDockablePresenter.cs:
public void RunTests(IEnumerable<TestMethod> tests)
{
try
{
_view.ClearResults();
var testMethods = tests as IList<TestMethod> ?? tests.ToList(); //bypasses multiple enumeration
The following lines were removed from \RetailCoder.VBE\UI\UnitTesting\TestExplorerDockablePresenter.cs:
public void RunTests(IEnumerable<TestMethod> tests)
{
try
{
_view.ClearResults();
var testMethods = tests as IList<TestMethod> ?? tests.ToList(); //bypasses multiple enumeration
2 hours later…
6:37 PM
[rubberduck-vba/Rubberduck] retailcoder commented on issue #784: Test Explorer test runner is adding reference to Rubberduck type library
6:49 PM
[rubberduck-vba/Rubberduck] retailcoder added label settings-config to issue #785: Add a "Unit Testing" page to the Rubberduck Settings dialog
[rubberduck-vba/Rubberduck] retailcoder opened issue #785: Add a "Unit Testing" page to the Rubberduck Settings dialog
> Let's add a "Unit Testing" page to the settings dialog, and make the following configurables:
- [ ] **Early-bind the Rubberduck type library** - when this option is checked (checked by default), running Rubberduck tests will ensure the VBA project has a reference to the Rubberduck type library. Unchecking this box can cause runtime errors if unit tests require early binding (e.g. if `AssertClass` is being instantiated directly).
...what else?
- [ ] **Early-bind the Rubberduck type library** - when this option is checked (checked by default), running Rubberduck tests will ensure the VBA project has a reference to the Rubberduck type library. Unchecking this box can cause runtime errors if unit tests require early binding (e.g. if `AssertClass` is being instantiated directly).
...what else?
[rubberduck-vba/Rubberduck] retailcoder commented on issue #785: Add a "Unit Testing" page to the Rubberduck Settings dialog
> If #291 is implemented, then this setting should also determine whether a new test module gets created with a late or early bound `AssertClass`.
Also:
- [ ] **Use permissive equality asserts** - when this option is checked (unchecked by default), creating a new test module will declare a `Private Assert As New Rubberduck.PermissiveAssertClass` instead of a `New Rubberduck.AssertClass`. Also consider sync'ing test modules with the status of this option - i.e. if it's checked, *change exi
Also:
- [ ] **Use permissive equality asserts** - when this option is checked (unchecked by default), creating a new test module will declare a `Private Assert As New Rubberduck.PermissiveAssertClass` instead of a `New Rubberduck.AssertClass`. Also consider sync'ing test modules with the status of this option - i.e. if it's checked, *change exi
[rubberduck-vba/Rubberduck] retailcoder commented on issue #291: Toggle Early/Late Binding for Rubberduck.AssertClass
[rubberduck-vba/Rubberduck] retailcoder closed issue #291: Toggle Early/Late Binding for Rubberduck.AssertClass
[rubberduck-vba/Rubberduck] retailcoder added label status-declined to issue #291: Toggle Early/Late Binding for Rubberduck.AssertClass
[rubberduck-vba/Rubberduck] retailcoder removed label status-deferred from issue #291: Toggle Early/Late Binding for Rubberduck.AssertClass
7:05 PM
[rubberduck-vba/Rubberduck] retailcoder commented on issue #755: Implement a more permissive AssertClass
> I'm closing this issue, @Vogel612 implemented the thing - now we need unit tests for it :stuck_out_tongue_winking_eye:
[rubberduck-vba/Rubberduck] retailcoder added label status-declined to issue #17: Split declaration and assignment
[rubberduck-vba/Rubberduck] retailcoder added label status-declined to issue #23: Unreacheable code detected
[rubberduck-vba/Rubberduck] retailcoder removed label status-deferred from issue #23: Unreacheable code detected
> Detecting unreacheable code implies simulating the compiler... which is a little bit beyond the scope of this project.
[rubberduck-vba/Rubberduck] retailcoder added label status-declined to issue #29: Join declaration and assignment
> This has non-obvious side effects:
Private Sub Foo()
Dim c As New Collection
Set c = Nothing
c.Add "123" ' error? nope!
End Sub
Rejecting this quickfix.
Private Sub Foo()
Dim c As New Collection
Set c = Nothing
c.Add "123" ' error? nope!
End Sub
Rejecting this quickfix.
[rubberduck-vba/Rubberduck] retailcoder commented on issue #25: If block body can be on separate line
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #14: Property with public mutator (Let/Set) should expose a public accessor (Get)
[rubberduck-vba/Rubberduck] retailcoder commented on issue #16: Multiple conditionals operating on the same variable can be converted to Select Case block
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #13: GoSub can be extracted to procedure
[rubberduck-vba/Rubberduck] retailcoder commented on issue #28: Condition can be a single instruction
> Let's make a first iteration of this inspection as a mere little "Runtime errors suppressed" warning that triggers when
On Error Resume Next
is used without being followed by an On Error GoTo 0
statement.
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #32: Handle runtime errors
[rubberduck-vba/Rubberduck] retailcoder added label status-declined to issue #45: Explicit type conversion is redundant
[rubberduck-vba/Rubberduck] retailcoder commented on issue #45: Explicit type conversion is redundant
[rubberduck-vba/Rubberduck] retailcoder commented on issue #51: Use CodeBlockNode to determine indentation level?
> We're not using homebrewn
Node
classes since v1.22, and indentation will be handled by SmartIndenter. This issue is moot.
[rubberduck-vba/Rubberduck] retailcoder closed issue #51: Use CodeBlockNode to determine indentation level?
[rubberduck-vba/Rubberduck] retailcoder added label status-declined to issue #51: Use CodeBlockNode to determine indentation level?
> @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?
> Same here; @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?
> Again (sorry for all the notifications!), @ckuhn203 is the SCI code responsible for exporting/importing modules decoupled enough to be reused for this?
[rubberduck-vba/Rubberduck] retailcoder commented on issue #112: Unit Testing - Support All Major Office Applications
7:50 PM
To learn how a given API works, yes. To learn how to write clean, flexible and reusable code, no. #Excel #VBA https://twitter.com/ExcelEasy/status/646385372491030528
Tweeted by rubberduckvba on September 22, 2015 at 7:46 PM
8:07 PM
[rubberduck-vba/Rubberduck] retailcoder removed label help-wanted from issue #112: Unit Testing - Support All Major Office Applications
8:46 PM
> There are a number of opened issues that have been around since 0.x:
- [ ] #52 toggle default instance attribute
- [ ] #53 toggle default member attribute
- [ ] #54 edit procedure description attribute
- [ ] #55 toggle iterator getter attribute
2.0 is going to have to make them happen. I'm tagging with [code-parsing], but really this isn't about the parser - it's *purely* about *parsing*: the VBE doesn't support member attributes, but honors them.
This feature will work off the cur
- [ ] #52 toggle default instance attribute
- [ ] #53 toggle default member attribute
- [ ] #54 edit procedure description attribute
- [ ] #55 toggle iterator getter attribute
2.0 is going to have to make them happen. I'm tagging with [code-parsing], but really this isn't about the parser - it's *purely* about *parsing*: the VBE doesn't support member attributes, but honors them.
This feature will work off the cur
[rubberduck-vba/Rubberduck] retailcoder added label module-and-procedure-attributes to issue #786: Handle Procedure Attributes
[rubberduck-vba/Rubberduck] retailcoder added label code-parsing to issue #786: Handle Procedure Attributes
9:04 PM
9:39 PM
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #786: Handle Procedure Attributes
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #52: Toggle DefaultInstanceId attribute
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #53: Toggle Default Member Attribute
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #54: Procedure description attribute
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #55: Iterator getter attribute
« first day (473 days earlier) ← previous day next day → last day (2707 days later) »
Transcript for
Sep21
Sep '1522
Sep23
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ