Worst. Username. Ever. stackoverflow.com/users/7729108/analanalyst

(unless you're a proctologist, that is)

@Comintern Just be glad he/she/it has only ever reached ~3 people?

'Apparently, this user prefers to keep an air of mystery about them.' Who wouldn't with a username like that?

OK, @Mat'sMug, this didn't work out either.

@Comintern that one is going to end up in the annals!

lol

Now I'm getting exceptions that the insertion is in a range that was previously deleted :/

@Mat'sMug Aren't you missing an "n"?

Probably lol

@Hosch250 I don't know what you tried... You still do InsertAfter? Does InsertBefore do the same thing?

Yeah.

I tried both.

Like, InsertBefore(1)

Hmm

Oh, hmm.

Work against another token then

Insert before the first member?

my brain hurts, TTGH!

1 failing test.

Did you tackle the ignored one that gets stuck?

Forgot to rewrite the reference updates.

Don't see it anywhere.

There's only a handful of ignored tests...

[Hosch250/Rubberduck] Hosch250 pushed commit 9fc4fcd0 to Issue2884: Fix encapsulate field tests

[Hosch250/Rubberduck] Hosch250 pushed commit 87796188 to Issue2884: Merge branch 'Issue2884' of github.com/Hosch250/Rubberduck.git

Did I seriously just get asked what ThisWorkbook was? I thought that was a typo.

lol

[Hosch250/Rubberduck] Hosch250 pushed commit f39ff6bc to Issue2884: Force refactorings to rewrite changes to the code pane

Yeah, Move Closer needs to be re-written too

As do Reorder/Remove parameters.

I'll do that later.

[rubberduck-vba/Rubberduck] Hosch250 created pull request #2896: Rewrite Encapsulate Field to merge Hosch250/Rubberduck/Issue2884 into rubberduck-vba/Rubberduck/next

@FreeMan IvenBach has me covered, thank you!

[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #2896: Rewrite Encapsulate Field

[Hosch250/Rubberduck] web-flow pushed commit 11b3caf8 to Issue2884

A Move Closer test and an inspections test is failing still.

The majority of them are OK now.

@IvenBach Which things are those? :P

[rubberduck-vba/Rubberduck] build for commit f39ff6bc on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] build for commit d0285ef2 on unknown branch: AppVeyor build failed

BUILD FAILURE!

> stringly-typed parameters

^ LOL

@Mat'sMug You'll need to merge that one.

Hang on--found an off-by-one for the failing inspection test.

[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #2896: Rewrite Encapsulate Field

[Hosch250/Rubberduck] Hosch250 pushed commit 084c4d7e to Issue2884: Fix off-by-one

[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #2896: Rewrite Encapsulate Field

[Hosch250/Rubberduck] web-flow pushed commit c9472351 to Issue2884: Merge branch 'next' into Issue2884

[rubberduck-vba/Rubberduck] build for commit 6e957fdd on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit c9472351 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Hosch250 merged pull request #2896: Rewrite Encapsulate Field from Hosch250/Rubberduck/Issue2884 into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] Hosch250 pushed commit 9fc4fcd0 to next: Fix encapsulate field tests

[rubberduck-vba/Rubberduck] Hosch250 pushed commit 87796188 to next: Merge branch 'Issue2884' of github.com/Hosch250/Rubberduck.git

@Hosch250 you're a hero!

Now I need to go rewrite the other refactorings as well.

[rubberduck-vba/Rubberduck] build for commit def1ce6b on next: AppVeyor build succeeded

Did you add the tests that cover indented stuff?

Nope.

I don't know what you want there.

I just rewrote the refactorings to properly cover this stuff.

And fixed a couple broken tests comparing the wrong rewriter/module content to the wrong expectation.

try this:

Busy today.

Sub DoSomething()
    Dim foo As Integer
End Sub

Probably won't be working on it again until later.

ok

FYI removing foo leaves this:

Sub DoSomething()
    End Sub

LOL.

The VBE will fix that.

Don't worry about it. If the VBE changes, we are going to be obsolete.

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #2888: Parser Error when method has 0 or >1 parameters in parentheses on continued line

Sure thing... Except I'd love the rewriter to do exactly what we need it to do

@Duga this should be a trivial missing optional token in the parser rule

TTQW

@Mat'sMug IIR, I specifically took that out as a work-around for #2206. Of the two, I'd say #2206 is more likely to appear in in the wild, but this needs a more comprehensive fix.

@FreeMan support.office.com/en-us/article/…

[rubberduck-vba/Rubberduck] comintern commented on issue #2888: Parser Error when method has 0 or >1 parameters in parentheses on continued line

> Linking #2205, #2206

@PeterMTaylor Fixed.

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #2891: Rubberduck needs to FAKE ALL THE THINGS!

Found a Project that parses, but throws in resolve/inspections phase:

Rubberduck.Root.InterceptedException occurred
  HResult=-2146233088
  Message=Unable to cast object of type 'Rubberduck.Parsing.QualifiedContext`1[Rubberduck.Parsing.Grammar.VBAParser+LiteralExpressionContext]' to type 'Rubberduck.Parsing.QualifiedContext`1[Rubberduck.Parsing.Grammar.VBAParser+AnnotationContext]'.
  Source=Rubberduck
  StackTrace:
       at Rubberduck.Root.InterceptorBase.OnError(IInvocation invocation, Exception exception) in C:\Users\Andrew\Documents\GitHub\Rubberduck\RetailCoder.VBE\Root\InterceptorBase.cs:line 33

@ThunderFrame What was the annotation?

I don't know that there are any - downloaded the project, found about 50 of the syntax errors involving paretheses on the next line. Fixed all of those, and the Parse completed. AFAIK, there aren't any annotations, unless there just happens to be a comment followed by an @.

registration required :-/ thecodecage.com/forumz/view.php?pg=vbacleanup_downloads

The irony being that the CodeCleanUp addin needs every single line to be discarded and rewritten as OOP cleaned up

> The cargo cult has found thier messiah in this wrapper.

Ouch!

I was trying not to be too harsh, but it was a fine line...

The benchmark is the killer though

IKR?

hmm, tried again, and it gets to ready, but declarations window is still spinning. I'm expecting 100K results

That's not the UK "VBA sounds dull but lets you play Candy Crush at work" guy's stuff, is it?

Lisa Green

@ThunderFrame s/declarations/inspections/?

It's hard not to find something wrong with every line

1700 line procedures! yeah

1700 lines? Ouch.

@Mat'sMug yep, sorry, inspections window still spinning

@Comintern @Mat'sMug you have to download it as a test project. it's worth the registration hassles.

it's like somebody discovered the arithmetic operators in Excel, and ran with it, never realizing the higher order constructs like functions, nested functions and array formulas existed. So much effort, such flaky outcome.

WTH? Hungarian prefixes on Sub and Function names?

@ThunderFrame written with pride in notepad

LOL - Visual Brainfuck for Applications?

@ThunderFrame @Mat'sMug will be relieved to hear that even I don't do that

lol

@ThunderFrame open up the log file

(keep it running!)

What do the inspections log?

no entries on log file for last 24 mins

Huh

last error in file is

2017-03-18 09:25:47.1918;WARN-2.0.13.36418;Rubberduck.Parsing.VBA.VBAModuleParser;SLL mode failed in module zmSorts. Retrying using LL.;Rubberduck.Parsing.Symbols.SyntaxErrorException: extraneous input 'String' expecting {':', WS, LINE_CONTINUATION}
   at Rubberduck.Parsing.Symbols.ExceptionErrorListener.SyntaxError(IRecognizer recognizer, IToken offendingSymbol, Int32 line, Int32 charPositionInLine, String msg, RecognitionException e) in C:\Users\Andrew\Documents\GitHub\Rubberduck\Rubberduck.Parsing\Symbols\ExceptionErrorListener.cs:line 10

Must be an inspection is stuck

Inspections aren't even running then....

ran a reparse

A ghost

^

I had one of those earlier today at work.

/zombie

OK, restarted

error in current log:

2017-03-18 10:02:46.5675;DEBUG-2.0.13.36418;Rubberduck.Parsing.Symbols.SyntaxErrorException;;
2017-03-18 10:02:46.5675;DEBUG-2.0.13.36418;Rubberduck.Parsing.Symbols.SyntaxErrorException;Token: String (L356C24);
2017-03-18 10:02:46.5675;WARN-2.0.13.36418;Rubberduck.Parsing.VBA.VBAModuleParser;SLL mode failed in module zmSorts. Retrying using LL.;Rubberduck.Parsing.Symbols.SyntaxErrorException: extraneous input 'String' expecting {':', WS, LINE_CONTINUATION}
   at Rubberduck.Parsing.Symbols.ExceptionErrorListener.SyntaxError(IRecognizer recognizer, IToken offendingSymbol, Int32 line, Int32 ch…

but no message in VBE or RD toolbar.

Log entries stopped about 4 mins ago.

Hmm... The inspections page isn't listing all issues

rubberduckvba.com/Inspections/List

^^ "member not on interface" should be firing

Did the favicon not get updated or do I need to clear my cache?

@ThunderFrame I've tried that. Actually, I go to File|Info|Links and copy the full file name that shows up there & search for that. Then I search for smaller and smaller pieces of it and usually can't find it. This time, I happened to come across it in the data validation for a column of cells that was pointing at a range in another workbook.

OK, so this is the line of code is that is throwing the error (albeit only in the logs, it never shows in the UI or as an exception msgbox) - Note the spaces between array parentheses and the Type...

Dim slTempArray() As String

WTH?

That can't be the only problem, otherwise the Indenter would be failing a bunch of tests.

Doesn't the parser report the position where it failed in evaluating the token stream as opposed to where the token stream started?

What's above that?

I did MCVE in a Word project:

Option Explicit

Sub Test()

Dim slTempArray()   As String


End Sub

2017-03-18 10:10:53.9834;TRACE-2.0.13.36418;Rubberduck.Parsing.VBA.ComponentParseTask;Starting ParseTaskID b60072be-f207-4203-8f00-e4a8bd297d11 on thread 23.;
2017-03-18 10:10:54.0265;DEBUG-2.0.13.36418;Rubberduck.Parsing.Symbols.SyntaxErrorException;;
2017-03-18 10:10:54.0265;DEBUG-2.0.13.36418;Rubberduck.Parsing.Symbols.SyntaxErrorException;Token: String (L6C24);
2017-03-18 10:10:54.0395;WARN-2.0.13.36418;Rubberduck.Parsing.VBA.VBAModuleParser;SLL mode failed in module Module1. Retrying using LL.;Rubberduck.Parsing.Symbols.SyntaxErrorException: extraneous input 'String' expecting {':', WS…

Huh. Parses fine in my build in Excel.

@Comintern not on the website... or did you PR it in RD-Web?

@Comintern It only shows up in the logs, not in the UI

UI says it parsed fine

No, I didn't PR it to Web - I didn't have 2015 installed when I make the change.

@ThunderFrame Huh. You're right. Does that log mean that SLL mode failed and LL mode succeeded, or that they both failed?

this is a full trace, from refresh to done

2017-03-18 10:24:18.4993;DEBUG-2.0.13.36418;Rubberduck.UI.Command.MenuItems.CommandBars.AppCommandBarBase;(26295076) Executing click handler for commandbar item 'Ready', hash code 50787128;
2017-03-18 10:24:18.5069;DEBUG-2.0.13.36418;Rubberduck.Parsing.VBA.ParseCoordinator;Parsing run started. (thread 19).;
2017-03-18 10:24:18.6137;DEBUG-2.0.13.36418;Rubberduck.Parsing.VBA.RubberduckParserState;Module 'Module1' state is changing to 'Pending' (thread 19);
2017-03-18 10:24:18.6137;DEBUG-2.0.13.36418;Rubberduck.Parsing.VBA.RubberduckParserState;RubberduckParserState raised StateChanged (Pending);

> 2017-03-18 10:24:19.8631;DEBUG-2.0.13.36418;Rubberduck.Parsing.VBA.RubberduckParserState;Mo‌​dule 'Module1' state is changing to 'Parsed' (thread 19);

looks like RD considers it parsed

log suggests that SLL failed, suppressed errors, tried LL, LL failed, and RD ignored the LL result?

Oh Wow, Inspections finally completed on the Excel project

Badge opportunity: Constant is not used: 1058 results

1058 unused constants? Makes me wonder how many there are total.