VBA Rubberducking

RubberDuck

5:00 PM

@FreeMan Look into TempVar

FreeMan

ah... that's about as big a stretch as I usually have to make.

RubberDuck

It's a handy way to store things in Access.

Faster than a table, but if you're relying on a config..... idk. Might not be the best solution.

FreeMan

TempVar - interesting, I wasn't aware of that. Will look into it.

Lyle's Mug

someone want to tell me if I am using String Builder inappropriately?

FreeMan

At the moment, I'm relying on one constant for the path, and need to split off dev & prod, so everything's an option on the table at the moment.

Mat's Mug

5:02 PM

@Lyle'sMug sure

Lyle's Mug

I am changing someone else's code to create a new site

so don't yell at me for naming here...one step at a time

    mailMessage2.Append(txtAddr1.Text)
    mailMessage2.Append(" ")
    mailMessage2.Append(txtAddr2.Text)
    mailMessage2.Append(" ")
    mailMessage2.Append(ddlState.SelectedValue.ToString())

Mat's Mug

@Hosch250 github.com/retailcoder/Rubberduck/blob/next/RetailCoder.VBE/UI/…

@Lyle'sMug StringBuilder works best in a loop.. this looks more like a job for String.Concat

@Hosch250 replacing the 1 with _view.Target.Selection.EndLine might fix it (or it might introduce more issues)

I'd start with that ;)

Hosch250

I tried replacing it with 10,000.

Didn't work :)

Lyle's Mug

@Mat'sMug or leave it like this?

> emailMessage = emailMessage + txtAddr1.Text + " " + txtAddr2.Text + " " + TxtCity.Text + " " + ddlState.SelectedValue + " " + TxtZip.Text + "<br />"

I am adding to it based on some if/then statements.

Mat's Mug

in most cases _view.Target.Selection.StartLine will match _view.Target.Selection.EndLine, hence the 1 here. Oh wait, should be Selection.LineCount, not EndLine

Hosch250

5:08 PM

No luck - same problem.

Lyle's Mug

whoa, wait a minute

Hosch250

Still same problem.

Mat's Mug

then break on line 233 and step through. the bug is in that area for sure

Lyle's Mug

nevermind....

Hosch250

I did that so I would know what to do.

FreeMan

5:13 PM

I think @Lyle'sMug just had a conversation with himself and managed to fix his own issue.

I don't know whether to feel useful or used

Hosch250

So, doing it again.

Lyle's Mug

I haven't fixed my issue yet.

FreeMan

:(

me neither...

Hosch250

@FreeMan I feel using, because @Mat'sMug is always having to walk me through fixing the bug.

Lyle's Mug

I am trying to figure out the best way to use String.Concat, but I don't think it is going to work for me in this circumstance

FreeMan

5:14 PM

@Hosch250 meh, you'll catch on, then start teaching him stuff!

Mat's Mug

so, execution enters the if block and gets to line 236 right?

Hosch250

Umm, hold on.

Lyle's Mug

I think I am going to leave the concatenation alone and work on the bigger issues first, maybe it will circle back

Hosch250

Yeah.

Mat's Mug

line 236 performs the replacement in the token stream - the token stream is likely correct (you'll need to confirm that).

Hosch250

5:16 PM

Then, it runs through to this if:

if (subStmtContext != null)
{
    lastTokenIndex = subStmtContext.argList().RPAREN().Symbol.TokenIndex;
}

Then this return:

Mat's Mug

the rest of the logic is trying to determine which part of the rewritten token stream to stick into the VBE

Hosch250

return targetModule.Rewriter.GetText(new Interval(firstTokenIndex, lastTokenIndex));

OK.

Mat's Mug

is that return value correct?

Hosch250

I don't know what it should be.

Mat's Mug

that should be the new signature

Hosch250

5:17 PM

OK.

Yes, the signature is fine - except it is on one line.

Mat's Mug

that's good.

it can't be on multiple lines, the parser doesn't even know what a line continuation token is

so.

Hosch250

Huh.

Maybe we should update the parser and kill the problem at the root?

Mat's Mug

the correct behavior for the refactoring, is to take a multiline signature, rename the target, and rewrite the signature on one line

@Hosch250 easier said than done.

Hosch250

Yeah, it does that, it just doesn't remove the second line.

So, what am I trying to do here, anyway?

Remove the other lines, or make it insert over multiple lines?

Mat's Mug

oh, here right?

Hosch250

5:20 PM

Yeah, something like that.

Is there a way we can just replace the variable name and leave everything as is?

Mat's Mug

no

Hosch250

Bother.

Mat's Mug

lol

notice everything except parameters is renamed with a regex

Lyle's Mug

are there any good reasons to have an empty Catch?

Hosch250

@Lyle'sMug So it doesn't keep throwing?

That will eat the exception and just continue executing.

Lyle's Mug

5:22 PM

Okay I will leave this one here.

Mat's Mug

@Lyle'sMug this is COM interop, accessing the buttons on a form designer - if anything goes boom, I don't want to crash my whole app

Lyle's Mug

oh gosh I forgot this is VB for apps and not a .NET room

2

Mat's Mug

yeah well we're debugging Rubberduck lol

Lyle's Mug

I just Followed your VB tools. I figured I might have a look at some of that stuff later

Mat's Mug

so @Hosch250 after line #123, you need to add logic that determines if the signature has multiple lines.

and to remove the excess ones

notice:

var argContext = (VBAParser.ArgContext)_view.Target.Context;

Hosch250

5:26 PM

newContent "Public Sub Foo(ByVal Var12 As Integer, ByVal Var2 As Integer)" string

Mat's Mug

looks good

Hosch250

Huh, it had a bunch of extra spaces in there.

Lyle's Mug

Rubberduck Master is your Repo @Mat'sMug?

Mat's Mug

so _view.Target.Context is an ArgContext - you just need to get the parent to get the ArgsListContext, and from there you can tell on how many lines the signature is written

@Lyle'sMug yeah

Lyle's Mug

can I butt in for a minute here

:)

Mat's Mug

5:28 PM

but you should only do that when _view.Target.DeclarationType is a DeclarationType.Parameter

if you wonder how the heck I know that you need to get the parent context and that that parent is an ArgsListContext, ..it's all in the grammar file, VBA.g4

Hosch250

Hmm, kind of hard to work with this without docs.

Yeah, I'm making a bit of progress.

Mat's Mug

github.com/retailcoder/Rubberduck/blob/next/Rubberduck.Parsing/…

^^ ArgListContext actually

Lyle's Mug

if I want a copy, do I fork it or branch it? (RubberDuck)

Hosch250

Fork it.

So, I have this:

if (_view.Target.DeclarationType == DeclarationType.Parameter)
{
    var something = _view.Target.Context.Parent;
}

Mat's Mug

@Lyle'sMug for contributing, fork it. for using, download the latest release :)

fork the next branch

Hosch250

5:33 PM

Is that right so far?

(Beyond the atrocious name, that is.)

Duga

[retailcoder/Rubberduck] malachi26 forked us into malachi26/Rubberduck

3

Lyle's Mug

Forking!

Mat's Mug

something would be a ParserRuleContext or some other ANTLR base class for an IParseTree - you need to explicitly cast it to a VBAParser.ArgListContext

Hosch250

OK.

Mat's Mug

and argList would make a much better name ;)

Hosch250

5:35 PM

Yeah, will definitely rename before I submit it.

Lyle's Mug

what issue are you guys working on?

Hosch250

I'm doing 446.

Mat's Mug

so, argList.Start has the line for the first token, and argList.Stop has the line for the last token

Hosch250

Thanks.

Now, I have a question.

Mat's Mug

but just call the .GetSelection() extension method on it instead. A Selection is easier to work with

Lyle's Mug

5:37 PM

443 looks like fun, maybe I should check out the code when I get home tonight and see if I can't figure that part out.

Hosch250

Why in the world do you have both Start and start method?

Mat's Mug

that's the ANTLR API - I suspect they're exposing public fields. Avoid using those (the lowercase ones), they might properly encapsulate them in future versions.

@Lyle'sMug yeah, take down all the easy-fix issues!

Lyle's Mug

I still have to figure out GITHUB and getting it to work with my freebie version of VS2013 at home..... and then I have to figure out the code you guys have so far. and then I have to find where all that stuff is going on in the code....lol

I don't know Versioning control. I am a Novice.

Mat's Mug

@Hosch250 so, argList.GetSelection().LineCount will tell you on how many lines the original signature was written on, assuming the opening brace is on the same line as the method's name.

Hosch250

Thanks.

Mat's Mug

5:43 PM

if that's greater than 1, you need to delete argList.GetSelection().LineCount - 1 lines in the code module starting at the line immediately below the one you just replaced. An off-by-one error here will wipe out the entire signature and beautifully wreck the user's code ;)

RubberDuck

@Lyle'sMug start with creating a new branch from the next branch. ;)

^^^

@RubberDuck ???

@RubberDuck TMLI5 ;)

@Mat'sMug If it is beautiful, surely they won't mind it?

Lyle's Mug

5:45 PM

wait I think I am getting there, going to do it at work too....lol

Hosch250

YES!!!

The only problem: It inserts empty lines instead.

Mat's Mug

sounds like "it works!"

huh?

Lyle's Mug

is there a naming scheme for branching and such?

Mat's Mug

you should be deleting lines, right?

Hosch250

I just replaced the hanging lines with empty lines for now.

RubberDuck

5:46 PM

@Lyle'sMug we try to follow this model. nvie.com/posts/a-successful-git-branching-model

Not very successfully, but we try.

Hosch250

And, it only works when the variable renamed is on the top line :(

RubberDuck

Branch name should say what it is you're trying to add or fix.

Hosch250

This is trickier than it looks.

Mat's Mug

@Hosch250 it always is

Hosch250

OK, it now deletes the lines, but still only works when the line we replace is the top line.

Lyle's Mug

5:51 PM

@RubberDuck so "443" should be the Branch name.....lol jk

RubberDuck

@Lyle'sMug eh.. it's your fork. If you really want to confuse yourself.... =;)-

Mat's Mug

try acquiring a target on the 2nd line; the ArgListContext should still be the same..

Lyle's Mug

I called it "noReferences"

RubberDuck

> Drink life as it comes. Straight. No chasers.

Lyle's Mug

now I just need to hook it into VS2013 and then again at home, and then find the place to write the code.

Mat's Mug

5:52 PM

@Lyle'sMug I would have gone with TellMeWhenImUseless

Lyle's Mug

@Mat'sMug you all have plenty to teach me, so I don't think that will be for a long time

Mat's Mug

the branch name I mean!

lol

Hosch250

Almost working!

Mat's Mug

but hey, I'm responsible for GrammarIsFun

Hosch250

Now, we are chasing a rare bird, so I have to leave.

Lyle's Mug

5:53 PM

lol

Hosch250

See you later, hope to submit this tomorrow.

Mat's Mug

@Hosch250 commiiiiiiiiiit! :)

great!

Lyle's Mug

think I figured it out!

later @Hosch250

Microsoft.Office.Core is giving me some issues

is this supposed to be 32-bit? my machine is 64-bit

Mat's Mug

You have Office installed right?

Lyle's Mug

yeah

Mat's Mug

6:01 PM

Mine too, running office 64-bit

Lyle's Mug

give me a second....

Mat's Mug

32-bit office has been a breeze though

Lyle's Mug

I thought there was a location to set the target 32 or 64 bit in the project properties.

Mat's Mug

You'll need to manually add a registry key to get RD to run in debug. Let us know when you get there ;)

Lyle's Mug

but it looks like it is set for any CPU

Hosch250

6:03 PM

Not working quite.

Mat's Mug

Yeah. Don't change that!

Lyle's Mug

@Mat'sMug oh, that is what I am trying to do....

Mat's Mug

@Lyle'sMug running in debug config right?

Does it build?

Lyle's Mug

yes it builds

wait

> 1>------ Build started: Project: Rubberduck.Parsing, Configuration: Debug Any CPU ------
1>C:\Program Files (x86)\MSBuild\12.0\bin\Microsoft.Common.CurrentVersion.targets(2151,5): warning MSB3283: Cannot find wrapper assembly for type library "Microsoft.Office.Core". Verify that (1) the COM component is registered correctly and (2) your target platform is the same as the bitness of the COM component. For example, if the COM component is 32-bit, your target platform must not be 64-bit.
2>------ Build started: Project: Rubberduck, Configuration: Debug Any CPU ------

Hosch250

Run VS as Admin.

RubberDuck

6:05 PM

@Lyle'sMug are you running 32 bit office, or 64 bit office? Your OS bitness doesn't matter.

Lyle's Mug

@Hosch250 automatically always

Mat's Mug

verify references

(in all projects)

Lyle's Mug

@RubberDuck Rubberduck doesn't like Microsoft.Office.Core

32-bit

Hosch250

IT WORKS!!!

2

It works on both the first and second variables.

Mat's Mug

awesome!

RubberDuck

6:07 PM

@Lyle'sMug Then you need to target 32 or Any.

Hosch250

Now, I'm going to test it with 10 variables, and if it still works, I'll commit.

Lyle's Mug

@RubberDuck where are we talking? everywhere I have seen so far says Any CPU

Mat's Mug

yes, leave Any CPU

RubberDuck

Hmm. Okay then. Not it.

Mat's Mug

did you check the project references?

RubberDuck

6:10 PM

What year do you have?

Hosch250

One bug.

Will submit and create issue.

Mat's Mug

@Hosch250 also test that it doesn't break other use cases

Lyle's Mug

Office 2010, VS 2013

Mat's Mug

@Lyle'sMug same as mine

Lyle's Mug

brb

Hosch250

6:12 PM

@Mat'sMug It shouldn't.

Mat's Mug

I know

Hosch250

if (_view.Target.DeclarationType != DeclarationType.Parameter)
{
    module.ReplaceLine(_view.Target.Selection.StartLine, newContent);
}
else
{
    module.ReplaceLine(argList.Start.Line, newContent);
    module.DeleteLines(argList.Start.Line + 1, lineNum - 1);
}

See, I just replace the first line and delete the rest.

The bug is something to do with caching, I am positive.

Mat's Mug

what's the bug?

(I'd revert that condition; prefer positiveness :)

there's no caching involved at that point...

Hosch250

I'm creating an issue.

Duga

[retailcoder/Rubberduck] Hosch250 pushed commit 2314eb08 to next: Fix issue 446

Hosch250

6:15 PM

I just pushed the commit to next.

Mat's Mug

did you try renaming a control on a multiline instruction to see if the change on line 243 was warranted?

there might be other repercussions here

Hosch250

Oh, no, I forgot about that.

I'll undo that.

Lyle's Mug

figured it out

Duga

[retailcoder/Rubberduck] retailcoder commented on RetailCoder.VBE/UI/Refactorings/Rename/RenamePresenter.cs of commit 2314eb08

> that should have been on a separate commit. you might have uncovered another unreported bug right here :+1:

Lyle's Mug

it wants 14.0 and not 12.0

Mat's Mug

6:19 PM

ok

Duga

[retailcoder/Rubberduck] Hosch250 opened issue #462: Renaming variables

> Say you have this code:

Public Sub Foo(ByVal Var1 As Integer, _
ByVal Var2 As Integer)

Debug.Print Var1
Debug.Print Var2

End Sub

If you rename Var1 to Var15, (example), then CTRL-Z twice to undo both renames, then rename Var2 to Var25, then the code becomes this:

Public Sub Foo(ByVal Var15 As Integer, ByVal Var25 As Integer)

Debug.Print Var1
Debug.Print Var25

End Sub

[retailcoder/Rubberduck] retailcoder commented on RetailCoder.VBE/UI/Refactorings/Rename/RenamePresenter.cs of commit 2314eb08

> this cast fails if _view.Target.DeclarationType isn't a Parameter

Hosch250

Whoops, will fix that too.

Mat's Mug

that's why I said you needed to test a few other known-to-work cases ;)

Hosch250

I don't know what to test :(

Mat's Mug

if you rename another declaration type, like a variable, I expect an InvalidCastException there

Hosch250

6:22 PM

Anyway, I just changed the scope of the variables, and put the 0 back in.

Testing now.

Huh, now it crashes.

Anyway, leaving now.

Will finish this later.

Duga

[retailcoder/Rubberduck] retailcoder commented on issue #462: Renaming variables

FreeMan

@Mat'sMug - maybe write up a little doc on what to do to get the project working with VS2013. Seems like both @Hosch250 and @Lyle'sMug went through similar issues. It should save you some chat time working it out each time...

Duga

> You need to Ctrl+Z more than twice to fully undo all changes to the code module. "Undo rename" isn't something that's currently a supported use case. This is native/normal behavior.

Mat's Mug

@FreeMan yeah yeah

;)

Lyle's Mug

I am having issues with other references now

Mat's Mug

6:25 PM

did you download the required nuget packages?

Duga

[retailcoder/Rubberduck] retailcoder added label status-by-design to issue #462: Renaming variables

[retailcoder/Rubberduck] retailcoder added label refactorings to issue #462: Renaming variables

Lyle's Mug

@Mat'sMug you telling me that I should read the readme file....????

Duga

[retailcoder/Rubberduck] retailcoder closed issue #462: Renaming variables

Mat's Mug

@Lyle'sMug what references are missing?

Lyle's Mug

there are mismatched references.

Mat's Mug

6:28 PM

what does that mean?

Lyle's Mug

Error 11 Assembly 'Microsoft.Office.Interop.Access, Version=15.0.0.0, Culture=neutral, PublicKeyToken=71e9bce111e9429c' uses 'office, Version=15.0.0.0, Culture=neutral, PublicKeyToken=71e9bce111e9429c' which has a higher version than referenced assembly 'office, Version=14.0.0.0, Culture=neutral, PublicKeyToken=71e9bce111e9429c' c:\Program Files (x86)\Microsoft Visual Studio 12.0\Visual Studio Tools for Office\PIA\Office15\Microsoft.Office.Interop.Access.dll Rubberduck

RubberDuck

@Lyle'sMug download the 2007 PIAs.

Mat's Mug

look in the solution tree, under each project there's a "references" folder - open it. then don't even try to build until all references have no yellow triangle

those are called PIA's for a reason..

Lyle's Mug

the test project is the only one with failing references and they are the other 2 projects

but the one project built this time around, I switched from 15 to 14 on that specific reference

Mat's Mug

15.0 would fail on my machine as well...

Lyle's Mug

6:31 PM

they built

Duga

[retailcoder/Rubberduck] ckuhn203 edited wiki page Building & Installation

RubberDuck

There's a link to the 2007 PIA right there ^.

If we want it to run on older versions, that's the version we need to use.

Mat's Mug

@RubberDuck well then how the heck does it run on Office 97 then?

oh. it runs. doesn't mean it'll build in VS

RubberDuck

I still have no idea how it works at all on 97 or 2003.

@Mat'sMug I think that might be it.

Not sure to be honest.

Mat's Mug

if the interfaces are compatible, COM might just happily go with it

.net is pickier

Lyle's Mug

6:37 PM

@RubberDuck not sure I should do that on my work machine, I already have a special place in the hearts of the Network Services guys....lol

RubberDuck

Oh. Well. Fair enough.

Mat's Mug

you're building RD on your work machine??

2

RubberDuck

cough

Mat's Mug

lol

I wouldn't get anything done if I did that

@Lyle'sMug but seriously, the Office PIA's are just interop DLL's - they wouldn't interfere with anything.

if anything interferes with your work.... it's working on Rubberduck!

Lyle's Mug

lol

RubberDuck

6:42 PM

Yeah. Don't do that ^^

Lyle's Mug

there is one guy I talk to in Network Services here in the office and we have a running joke about me getting work done.....lol

or lack thereof

I will try to take a look at it later at home.

Mat's Mug

@Lyle'sMug that doesn't make you look very good

Lyle's Mug

I get work done, that's what makes it funny....

Mat's Mug

I just don't want RD to get you in trouble ;)

Duga

[retailcoder/Rubberduck] retailcoder edited wiki page Building & Installation

2

Lyle's Mug

6:55 PM

I will keep it to break time and other downtime moments....lol

RubberDuck

@Duga Do we need to add a blurb about NuGet packages?

Mat's Mug

nah, VS warns you about 'em

RubberDuck

cool

Duga

[retailcoder/Rubberduck] retailcoder commented on commit 2314eb08

> Next time please create a new branch instead of committing directly to "next" - that way you can make all necessary commits and tests and fixes, and then you can make a PR to get your dev branch merged into "next".

Mat's Mug

@Duga that way we can review the changes before they hit the next release

FreeMan

7:23 PM

@Mat'sMug Truth!

hasn't accomplished much since discovering RD...

Mat's Mug

@Hosch250 I think I misread #462. I'll take another look tonight, after I pull your changes

Duga

[retailcoder/Rubberduck] retailcoder removed label status-by-design from issue #462: Renaming variables

[retailcoder/Rubberduck] retailcoder commented on issue #462: Renaming variables

> Just to clarify. You have this:

Public Sub Foo(ByVal Var1 As Integer, _
ByVal Var2 As Integer)

Debug.Print Var1
Debug.Print Var2

End Sub

Rename `Var1` to `Var15`, then you get this:

Public Sub Foo(ByVal Var15 As Integer, ByVal Var2 As Integer)

Debug.Print Var15
Debug.Print Var2

End Sub

So far so good. Then you Ctrl+Z / undo the rename and get this:

Public Sub Foo(ByVal Var1 As Integer, ByVal Va

[retailcoder/Rubberduck] retailcoder reopened issue #462: Renaming variables

[retailcoder/Rubberduck] retailcoder added label bug to issue #462: Renaming variables

[retailcoder/Rubberduck] retailcoder commented on issue #462: Renaming variables

> Behavior confirmed in 1.3.0.1 release. Houston, we have a bug!

Mat's Mug

7:41 PM

@Duga that's a whiskey-tango-foxtrot case

Lyle's Mug

8:17 PM

never try to copy a site to another project and then rename it.... my master page has identity issues. and I can't fix it!!!!!!!!!!!

Stack Exchange

8:36 PM

0

Q: SQL + VBA Populating Data in Cell Range

I currently have a code that is connecting to SQL database in VBA. The data is populating correctly as I would like however, I was wondering if there is a way to condense the code below. I have 4 different columns and 26 rows and I feel like if I go this route, I will be wasting a lot of time. I ...

Hosch250

8:55 PM

@Mat'sMug You still here?

@Lyle'sMug I may have an idea.

Open the RubberDuck Properties from the bottom of the Debug dropdown.

Remove the pre-build and post-build events, and see what happens.

Duga

9:07 PM

[retailcoder/Rubberduck] Hosch250 pushed commit 7ca9a000 to next: Update so it really should work now

Hosch250

@Duga LOL - status-by-design

NVM, worked it out, Mat'sMug.

Put this back:

var content = module.get_Lines(_view.Target.Selection.StartLine, 1);

And re-did this better:

            if (_view.Target.DeclarationType == DeclarationType.Parameter)
            {
                var argList = (VBAParser.ArgListContext)_view.Target.Context.Parent;
                var lineNum = argList.GetSelection().LineCount;

                module.ReplaceLine(argList.Start.Line, newContent);
                module.DeleteLines(argList.Start.Line + 1, lineNum - 1);
            }
            else
            {
                module.ReplaceLine(_view.Target.Selection.StartLine, newContent);

Duga

[retailcoder/Rubberduck] Hosch250 commented on RetailCoder.VBE/UI/Refactorings/Rename/RenamePresenter.cs of commit 2314eb08

> Fixed now, I believe, @retailcoder

[retailcoder/Rubberduck] Hosch250 commented on RetailCoder.VBE/UI/Refactorings/Rename/RenamePresenter.cs of commit 2314eb08

> Rolled back, @retailcoder

[retailcoder/Rubberduck] Hosch250 commented on commit 2314eb08

> Whoops, didn't see this until now, but will definitely do next time.

Phrancis

@RubberDuck @Mat'sMug in case you're interested:

in TCG Creation, 57 secs ago, by Duga

[Cardshifter/Cardshifter] Phrancis opened issue #223: New mod: "Mythos"

Hosch250

Ow, I got stung by a nettle or something on my leg an hour ago :(

Lyle's Mug

@Hosch250 I will never know now.....I scrapped it and went back to my last changeset. but I branched this time, maybe I can do this whole VCS thing right this time

@Hosch250 what?!

Hosch250

9:15 PM

Yeah, tried to see a rare bird, which involved a walk through the woods.

Didn't see the bird, but got bit on my leg by a plant because I was wearing shorts.

Still hurting.

Duga

[retailcoder/Rubberduck] Hosch250 commented on issue #446: Renaming variables breaks functions/subs with variable declarations on multiple lines

> This is now fixed in my latest commit, with a single-line declaration.

Mat's Mug

9:33 PM

good! feel free to close the issue, I'll pull your changes tonight, I have some changes to merge into next too.

Duga

10:05 PM

[retailcoder/Rubberduck] Hosch250 closed issue #446: Renaming variables breaks functions/subs with variable declarations on multiple lines

Hosch250

10:19 PM

I just merged the main Rubberduck into my fork. I believe the main Rubberduck is alright, but if I did something, just blame me.

Duga

10:29 PM

[retailcoder/Rubberduck] Hosch250 assigned Hosch250 to issue #358: Renaming "ThisWorkbook" isn't done right.

Mat's Mug

@Duga good luck with that one... you're not picking the easiest issues! ;-)

Hosch250

Really?

OK.

Hosch250

10:51 PM

This is making me mad.

I tried to switch to my repo instead of yours, and now Rubberduck can't load!

RubberDuck

@Phrancis think this will scare him enough to stop the insanity?

0

A: SQL + VBA Populating Data in Cell Range

What you need is an ADODB.Command. It's the same query with different parameters, so you should use a parameterized query. Honestly, you should be using a parameterized query anyway. You have no idea what the user has put into those cells. This is a SQL Injection disaster waiting to happen. Let's...

Phrancis

@RubberDuck You need to find a way to include that xkcd comic in there somewhere!

I think right after Boom. There goes your entire database. Gone. Poof. Up in smoke. would be perfect

Mat's Mug

@Hosch250 the regasm.exe command registered the codebase at a specific location. You need to unregister the old location and register the new one... or locate the key in your registry and update it

Hosch250

I just completely cleaned my registry of everything Rubberduck, and it is still busted.

OK.

What is the command again?

Duga

[retailcoder/Rubberduck] retailcoder commented on issue #358: Renaming "ThisWorkbook" isn't done right.

> I'm not sure how much of this applies to Word or Access/PowerPoint documents.

RubberDuck

11:02 PM

@Phrancis better?

Phrancis

Much ;D

Good answer BTW (unsurprisingly)

RubberDuck

Thanks! There was some other stuff that I'm tired of repeating, so I didn't...

Phrancis

Nice catch on complimenting the way of handling transferring from recordset to worksheet

Mat's Mug

^^ yeah. It ...counter-balances ;)

Hosch250

NVM, found it.

Phrancis

11:06 PM

"I need to take things from a table, and put them into another table... I know, I'm going to loop over the tables!"

facepalm

I have to give an accolade to @Mat'sMug for helping me think in set-based mentality. Remember that mug? That was my first question!

Hosch250

@Mat'sMug Thanks, it is loading fine again.

Which is a good thing because I might have quit if it didn't.

Can't be reinstalling Windows every night.

RubberDuck

regedit >> Ctrl + F

Repeat as necessary.

Hosch250

@RubberDuck Yeah, but what a job.

RubberDuck

Oh. I know...

New blog post up btw.

Iterate over a date range in VBA http://wp.me/p42nM1-6E

Tweeted by Rubberduck203 on May 13, 2015 at 9:32 PM

Mat's Mug

11:27 PM

Next is already at 1,075 commits

I blame ducky and megamerge

I really like the way you split the projects in the solution btw @RubberDuck

RubberDuck

Oh. Thanks. Been meaning to do it for a while.

Partly did it to motivate me to finish Git Integration. It was a 2.0 kind of change.

Hosch250

I just deleted an empty Refactoring folder in Rubberduck

Also, I adjusted an if {} else { if {} else {} } into an if {} else if {} else {}

@Mat'sMug Quick question about some of your catches:

catch (Exception exception)
{
    Debug.Assert(false);
}

RubberDuck

Wtf Mug? ^ lol

Hosch250

Do you really need to do catch (...)?

Can't you just do catch, and be done with it?

I am getting a zillion warnings, and I don't like warnings :(

RubberDuck

11:43 PM

As a wild guess. It should probably be swallowing just COMException.

But it's just a wild guess.

Got a link?

Hosch250

CodeInspectionsToolbar.cs.

> warning CS0168: The variable 'exception' is declared but never used

> // I got ya! I got you all! You'll think twice before messing with Percival C. McLeach!

RubberDuck

github.com/retailcoder/Rubberduck/blob/next/RetailCoder.VBE/UI/…

That ^?

I'm definitely thinking it should be catching COMException instead. Lots of interaction with the VBE there.

But I'm not certain why it is the way it is. There aren't any comments. cough

Hmm... Why is this forcing focus manually? github.com/retailcoder/Rubberduck/blob/next/RetailCoder.VBE/UI/…

I thought the extension method took care of that...

Hosch250

I don't think it should catch any particular exception because the exception value isn't used.

RubberDuck

Normally, I'd agree. But COMExceptions are a bit out of our control sometimes and it's better to not let them crash the program.

Transcript for