Charcoal HQ

quartata

7:03 PM

yay!

@Undo By the way, I think even with nochat on I still have to put in chat credentials

Maybe that should be changed?

Andy

@quartata Add a feature request to github. It's easier to track

quartata

Well I'm not certain which is why I'm asking if that's the case

Thomas Ward

put it on GH

that way if i'ts a bug we'll fix it, otherwise blah

Andy

@quartata Probably on SmokeDetector if that's where the nochat you're talking about is

ArtOfCode

what is this nochat?

quartata

7:09 PM

github.com/Charcoal-SE/SmokeDetector/commit/…

Undo

@quartata Yeah, it's very much WIP

Thomas Ward

@Undo I think i've refactored apigetpost to return a Post object, but i have to check...

this'll be interesting heh

@Undo github.com/Charcoal-SE/SmokeDetector/tree/postdata_refactor may like your attention. Basically, replaces PostData objects with a Post object, since they have mostly the same fields. Also gets rid of a heck of a lot of your assignment statements by creating a dict to struct the post object for the return xD.

this needs testing though 'cause it goes and pokes things elsewhere. Including in the metasmoke handlers.

which i think blew up previously.

SmokeDetector

API quota rolled over with 11861 requests remaining. Current quota: 19999.

stackoverflow: 17
askubuntu: 8
unix: 7
mathoverflow.net: 6
superuser: 5
mathematica: 4
english: 4
salesforce: 4
academia: 4
softwarerecs: 3
ru.stackoverflow: 3
physics: 3
sharepoint: 3
electronics: 3
es.stackoverflow: 3
workplace: 3
codegolf: 3
worldbuilding: 3
engineering: 2
math: 2
rpg: 2
drupal: 2
rus: 2
stats: 2
japanese: 2
wordpress: 2
softwareengineering: 2
dba: 2
sqa: 2
gis: 2
pt.stackoverflow: 2
scifi: 2
travel: 2
apple: 2
ux: 1
parenting: 1
photo: 1
bicycles: 1
puzzling: 1
arduino: 1
law: 1

Thomas Ward

@Undo that removes the PostData class and having to recreate a dict for an api_response from post_data objects. Up to you for review and consideration since it needs checked either way

and tested :)

Undo

7:26 PM

I'm busy with some other things, probably will be for the next day or so. You're free to do whatever you think is best ;)

Thomas Ward

OK. I don't want to mess with it just now, but I'm making a Refactor: Objects project on the repository, and then adding issue items to it. We can track refactoring efforts there :P

At least this way we can start tracking what we do or don't want to refactor

SmokeDetector

[ SmokeDetector | MS ] Manually reported answer: Olx-like database design by hemogenes cusihuaman on stackoverflow.com

quartata

7:41 PM

@SmokeDetector why

SmokeDetector

@quartata Post manually reported by user FelixSFD in room SO Close Vote Reviewers.

quartata

Oh it's gone

@SmokeDetector k

SmokeDetector

@quartata: It seems this is your first time sending feedback to SmokeDetector. Make sure you've read the guidance on your privileges, the available commands, and what feedback to use in different situations.

quartata

No it's not

silence

Thomas Ward

it's the first time you've used the chat to send feedback since you got privs, you shush :)

M.A.R.

7:42 PM

@quartata: It seems this is your first time sending feedback to SmokeDetector. Make sure you've read the guidance on your privileges, the available commands, and what feedback to use in different situations. NOOB

Thomas Ward

throws sticks at random users

quartata

@ThomasWard How does it even keep track of that if not via Metasmoke

via metasmoke

Ouch!

but it's weird

7:43 PM

Then why would Metasmoke think I've never submitted anything there

because I have

Thomas Ward

@JanDvorak at least it wasn't a punt into space, because we don't need more satellites.

Glorfindel

@M.A.R. it seems this is your first time sending feedback to users about sending feedback to SmokeDetector.

Thomas Ward

@quartata it's not determining general submissions it's determining 'first chat room feedback via SmokeDetector'

ArtOfCode

42 secs ago, by ArtOfCode

but it's weird

Thomas Ward

if you've been doing reviews and FDSC it handles it differently

M.A.R.

7:44 PM

@Glorfindel You forgot the 'NOOB'

SmokeDetector

[ SmokeDetector | MS ] URL in title: Is www.languagetrainers.co.uk Legit by Amadeus on languagelearning.SE

Thomas Ward

you didn't have SmokeDetector privs in the room yet :P

quartata

I mean to be fair it's saying "seems" so at least it's admitting it might be wrong

@SmokeDetector ehhh?

Jan Dvorak

@ThomasWard orbital mechanics say what goes up < must go down > unless it has a propulsion system with at least 3 km/s dV on board

M.A.R.

@SmokeDetector F

Thomas Ward

7:44 PM

@JanDvorak Well, unless you're punted so hard you break orbit.

M.A.R.

That was a hard decision, but F.

Thomas Ward

@ArtOfCode yay for refactors lol

ArtOfCode

@quartata it uses chat user ID, which isn't applied to feedback from review or the API.

Jan Dvorak

... or that, yeah. In that case you'll burn up in the atmosphere.

quartata

@ArtOfCode Oh that is weird

Thomas Ward

7:50 PM

@ArtOfCode you have access to MS logs right?

like links that get sent to it and such

ArtOfCode

@ThomasWard sanitized, yes

Thomas Ward

(from Smokey)

yeah i'm not after PII, but I want to test the PostData refactor that I just started poking.

so i was gonna launch later :P

so we can start messing, and if the MS exploding happens then I'll need to know what links Smokey sent to MS

so i can start fussing with it :)

ArtOfCode

go for it

although it'd be good if some people who aren't using it could close any metasmoke tabs they have open, otherwise the log is just gonna be full of websocket logs

Glorfindel

!!/report english.stackexchange.com/a/378918/116151

SmokeDetector

[ SmokeDetector | MS ] Manually reported answer: Could you list all stops & continuants? by domino on english.SE

tpu- by MAR

[ SmokeDetector | MS ] Manually reported answer: LINQ: From a list of type T, retrieve only objects of a certain subclass S by Logan Harrison on stackoverflow.com

tpu- by Glorfindel

SmokeDetector

9:07 PM

[ SmokeDetector | MS ] Bad keyword in link text in body, bad keyword in title: North Carolina vs Texas Southern live by faizulhaque sojib on webmasters.SE

tpu- by Undo

NobodyNada

heh, the spammer couldn't be bothered to read the formatting help

quartata

10:06 PM

@Undo Since currently only parts of the post are passed in to the rule I was going to add a 'whole_post' key that just gives the post object to the rule, is that OK?

Undo

@quartata Sounds good to me

quartata

Uh this is kind of weird:

                matched_title, why_title = rule['method'](post.title, post.post_site, post.user_name)
                if matched_title and rule['title']:

That is, it runs the rule on the title regardless of whether it actually wants it, then checks after

Undo

Huh, that is weird

quartata

I'll leave it be for now but a lot of this could use some refactor

It's a little odd

Undo

Most of that code probably hasn't been touched for 2+ years

quartata

10:17 PM

Is the post ID included with Post or do I need something else to uniquely identify a post

I suspect id(...) would work as long as nothing was copied

Undo

How unique?

Getting the link to the post would work, or the post ID if you don't care about cross-site conflicts.

quartata

Just so that when I'm iterating through the question's answers I don't accidentally compare the post to itself

Cross-site wouldn't be an issue

Undo

post_id should work

quartata

10:31 PM

All righty, let's see if this explodes.

What is your test framework? Nose?

Oh, PyTest. All right

Wow, those errors are extremely red

With exclamation points

> E AttributeError: Post instance has no attribute 'parent'

While running the tests?

@Undo I'm guessing the test data you're feeding in wasn't changed during the refactor

ArtOfCode

gonna want to ask @ThomasWard that

Undo

no, that'd be because a parent attribute never got added to the model

quartata

But it's there on line 286?

github.com/Charcoal-SE/SmokeDetector/blob/master/…

Undo

There's no accessor on the model

You want something much like github.com/Charcoal-SE/SmokeDetector/blob/master/classes/…

quartata

Oh, that's an easy fix

Undo

10:42 PM

yep

quartata

The test data still doesn't have the parent though (it's None). So I'll just skip those

Undo

Yep, that'd work

quartata

Huh, the URL_REGEX doesn't match the protocol

Is that intentional?

ArtOfCode

11:01 PM

someone remind me how to actually run our tests locally?

quartata

python2 -m pytest

But I had to delete ChatExchange's tests since they were messing everything up

ArtOfCode

ta

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in title, phone number detected in title: .s.k.y.p.e. .s.u.p.p.o.r.t. .n.u.m.b.e.r. .1.8.4.4. .7.8.2. .8.0.9.6. .s.k.y.p.e. .t.e.c.h. .s.u.p.p.o.r.t. .n.u.m.b.e.r by movu on civicrm.SE

tpu- by ArtOfCode

quartata

@SmokeDetector k

ArtOfCode

github.com/Charcoal-SE/SmokeDetector/pull/598 for someone to code- and sanity-review

quartata

11:16 PM

Does anyone have an example of a stolen answer with spam links added for me to try?

I had an example in mind that I can't seem to find

SmokeDetector

11:43 PM

Conflicting feedback on Is languagetrainers.co.uk Legit.

tpu- by Yvette on Is languagetrainers.co.uk Legit [MS]

NobodyNada

@Yvette you sure? I don't see a reason to assume it's spam

Morning everyone

@angussidney o/

\o

@ArtOfCode I left another comment on the redunda issue, I'd like to hear your thoughts

ArtOfCode

11:46 PM

I'm not proposing removing functionality from MS, @angus. I'm proposing pinging Redunda in addition to metasmoke; we need to keep pinging metasmoke anyway for a couple other reasons.

NobodyNada

39 mins ago, by SmokeDetector

[ SmokeDetector | MS ] Bad keyword in title, phone number detected in title: .s.k.y.p.e. .s.u.p.p.o.r.t. .n.u.m.b.e.r. .1.8.4.4. .7.8.2. .8.0.9.6. .s.k.y.p.e. .t.e.c.h. .s.u.p.p.o.r.t. .n.u.m.b.e.r by movu on civicrm.SE

still needs flags

angussidney

@ArtOfCode so in other words, if we go ahead with this, MS will still show the status, you can still initiate a failover via MS, MS will still initiate failovers automatically, etc? Just Redunda will also do those things

ArtOfCode

@angussidney aye

angussidney

@NobodyNada heh, all 6 flags from Charcoal

Yvette Colomb

@NobodyNada new site, I didn't know discussing products was on topic

angussidney

11:49 PM

@ArtOfCode OK then, I'm fine for you to go ahead with that

NobodyNada

@YvetteColomb I don't know if it's on-topic either, but I'm pretty sure it's not spam. The title looks sort of spammy, but the body does not, and neither do the OP's edits to the tags.

@Art I've submitted a Redunda PR for data storage.

ArtOfCode

@NobodyNada already looking at it :P

Transcript for