Stack Exchange
log in

holroy

 The 2nd Monitor

General discussion about codereview.stackexchange.com - Welcom...
2
holroy
May 15, 2017 04:17
@CaptainObvious Seems to be only auto-generated code. With loads of "TODO" where the user could actually write some code to get values and do something with those values.
holroy
May 14, 2017 20:06
@SimonForsberg I like your leading by example, and that you removed the comments, despite minor disagreement on the line. :-)
holroy
May 14, 2017 20:00
And that is kind of my point, that the OP sees it as working, and wants to improve it. It does a little extra, and he has mentioned it. Therefore it's getting closed. If he hadn't mentioned it, it would have been OK? I guess my line (in the sand :-) ) is drawn a little more to the advantage of the OP when intentions seem to be good.
holroy
May 14, 2017 19:57
@EBrown To me it kind of reads "I'm not sure why these extra links occurs". However, I do see the reasoning related to not "fixing and changing"...
holroy
May 14, 2017 19:56
@SimonForsberg And I think that should have been the reviewer, but that is possibly asking too much.
holroy
May 14, 2017 19:55
I guess its the "fixing and changing" I'm not entirely sure how to react towards. I'm kind of lenient towards reviewing it, and if it happens to fix an issue it would be good. But your comment is way better compared to simply stating broken code.
holroy
May 14, 2017 19:53
So not entirely according to intention, but as good as he gets it. Where is the line between unknown bugs or known shortcomings, and broken code?
holroy
May 14, 2017 19:52
Should it? It seems to do the job, but gets some extra links.
holroy
May 14, 2017 19:49
I'm not sure if we should (or can) do something, but I don't really like the tone of userXXXX.
holroy
May 14, 2017 19:48
0
Q: Web-crawler for yellowpages

SMth80I have been trying to code in Python for the last few months and I don't have much knowledge in this arena so if I make any mistake, I apologize in advance. I've written a script which is parsing yellowpages US. If I give any link of that site, this script scrapes almost everything irrespective o...

python web-scraping
holroy
May 14, 2017 19:48
@SimonForsberg, Could you please take a look at the comments related to this question:
holroy
May 14, 2017 19:44
Semi-automatic... :-D Nice...
holroy
May 14, 2017 19:44
Is comments automatically removed when reopened?
holroy
May 14, 2017 19:44
Wrenched?
holroy
May 14, 2017 19:42
0
Q: Perlin Noise terrain in Unity3D

Simeon LaplevI've recently had time to devise another program so this time I decided to write the Perlin Noise algorithm in code. I have succeeded and the code works but I can't help but feel that my practices while writing are still not as good as they should be (especially since I'm still pretty new to the ...

c# algorithm object-oriented unity3d
holroy
May 14, 2017 19:42
OP has now provided code, so I think it can be reopened:
holroy
May 14, 2017 12:43
Using 8000 would break the output format of his example file, since 3428.12 + 8000 = 11428.12 which OP doesn't have room for in his print format, but that is a purely visual issue.
holroy
May 14, 2017 12:41
The code change is just a change of the number he adds to the first line, and is trivial.
holroy
May 14, 2017 12:18
The "wrong format" note seems to only be related to the actual output format of his code, and not the code itself. He has removed the line, and changed the value to add into the new file.
holroy
May 14, 2017 11:57
Looking at featured questions is always interesting, both related to the rep involved, but also as people tend to really try to get the good answers then. Reading this answer, wow. I'm impressed.
holroy
May 14, 2017 11:05
@Mast It kind of felt appropriate for that particular question, and I remembered reading about it just recently, so there it was the reference to MCVE. Usually I would just ask for a good example, but due to vague recollection of chatting about MCVE I tried being a little more formal (and failed miserably :-) )
holroy
May 13, 2017 22:53
But then Portugal would be leading during the entire vote (given this years voting)
holroy
May 13, 2017 22:52
What would be really fun/good, would be to get all of those votes distributed on recent question and answers here on Code Review! :-D
3
holroy
May 13, 2017 22:51
Yeah...
holroy
May 13, 2017 22:50
True, but having 84 vote annoucements would be rather heavy (42 countries times 2)
holroy
May 13, 2017 22:49
Like having the jury votes in horizontal stacks and then have a sliding bar revealing the addition of the televotes... I think that could look better, and be more exciting than listing like they did just now. To easy to see that Portugal would win when it had the lead they had.
holroy
May 13, 2017 22:47
I saw the last part of the voting, and if having separate round of voting, it could possibly be fun to have a sliding graph of the televotes being added....
holroy
May 13, 2017 22:46
They added the televotes in a separate round...
holroy
May 13, 2017 21:48
Oh well, I'm not going to use any more time on it, as I see it as a waste of time and resources.
holroy
May 13, 2017 21:47
So the fact that he constructed the code for the question, and changed it to better match Code Review, are still not good enough reasons to close it?
holroy
May 13, 2017 21:40
It also has potential bugs related to the NULL exceptions...
holroy
May 13, 2017 21:40
@SimonForsberg Unclear code. Isn't actual code, it is constructed for the purpose of the question. Not possible to test, as we don't have any indication on what the State class is. Just to mention a few reasons...
holroy
May 13, 2017 21:24
@CaptainObvious I think it's hammer time...
holroy
May 13, 2017 20:00
@CaptainObvious Ouch... Very broken...
holroy
May 13, 2017 17:32
After being off-line, I tend to go back in the chat log and click on most of the questions, but a lot of them has already been dealt with before I get around to click on them. So it would have been nice to have them cleaned out of the way.
holroy
May 13, 2017 17:31
It would allow us to focus on stuff which are still open, and not waste time and energy on stuff already dealt with.
holroy
May 13, 2017 17:18
So for something like this to work, we would have to ditch the Captain Obvious feed, make Duga (or another bot) do the feed (so that it owns the message), and then it could delete it a little later if closed/deleted... I like the idea, but not the amount of work...
holroy
May 13, 2017 17:16
Reply wouldn't be enough, I think. My thought was that if we had such a system, we wouldn't need to click on questions already dealt with. But I do believe you are correct, that most likely it is more work than the positive effect it would have.
holroy
May 13, 2017 17:14
But is it theoretically possibly to delete them, or is there some general limitations within SE network?
holroy
May 13, 2017 17:12
@SimonForsberg Regarding my confusing question related to CaptainObvious's feed vs Duga... Would it be possible for Duga to remove/delete/tag deleted/closed question from Captain Obvious's feed within this chat?
holroy
May 13, 2017 17:08
A realm is an actual Pocket Edition game. There doesn't really exist multiplayer servers for the Pocket Edition. All of those are re-implemented version of Pocket Edition, and all of those are lacking one way or another!
holroy
May 13, 2017 17:07
Thanks... And I really like the typo: "we couldn't do it with you guys"! :-D
holroy
May 13, 2017 17:06
The realms are really great as they are the real gameplaying experience. Sadly, due to that it isn't easy to do anti-griefing.
holroy
May 13, 2017 17:05
Computer Edition or Pocket Edition? I only play Pocket Edition...
holroy
May 13, 2017 17:04
@SimonForsberg With that being said: A great thank you to you, 200_success, janos, and other moderators in here! You're doing a great job, and you've been doing it for quite some time! I'm in awe for the effort and dedication you've put into Code Review!
5
holroy
May 13, 2017 17:03
HeHe... I hear you, and I feel the pain...
holroy
May 13, 2017 17:03
A few months I had a great time on a MCPE Realm, until this kid (possibly the younger son of one of the member), and he griefed a lot, so that the realm was shut down. Quite a lot of work/energy/... down-the-drain.
holroy
May 13, 2017 16:50
Sigh... I know, I know... Still frustrates me at times, when I feel that I can't focus on the real purpose of the society or community!
holroy
May 13, 2017 16:46
Just had to rant a little... Sorry...
holroy
May 13, 2017 16:46
Wouldn't it be nice, if we didn't have to VTC, rollback edits, and could just focus on giving good code reviews, and up-voting other good and interesting answers? (Or the same related to Minecraft: To focus on the game itself, and how to advance/prosper within the game)