codebreaker

@murgatroid99 couldn't they pass fake symbols into either a ManaCostEntry or just a factory method for ManaCost?

how's that?

I might prefer the special-case mana cost implementation for that

and then they can't have any other elements with them

I did think about that, that only generic symbols can be allowed to be 0

okay, yeah, that's what I was thinking

for devotion, can't you just do symbol.colors().contains(color)?

okay, cool, thanks

Yeah, that sounds reasonable

A SymbolParser class might be useful, and mana cost parsing would basically just be doing that in a loop, so it probably wouldn't be too much more complex

yeah, you're right. I thought I would use it more later. I figured maybe you could return that type from parse

no it's cool, different views are always good to have

actually yeah, that's a good point about matching

I really like multisets

ugh yeah I guess

which I suppose really isn't a big deal

other than it's now O(n) for contains

how is that different from a multiset?

what should they get back?

what if they pass "{3}"

okay, yeah, I sort of did that in Solution 1

okay, well I have a partially finished interface-based Symbol implementation, maybe I'll finish that up

lol true

if they break the contract, yeah, I guess

maybe I'm worrying too much

make a purple symbol or something

like someone else could just implement Symbol if it was an interface

and people could pass bogus symbols to a ManaCost builder

my only issue with symbol interfaces is the creation of symbols could be public

I did actually consider making Symbol an interface

but I'd certainly be interested in hearing your suggestions

besides, the actual type of mana symbols seldom matters

I just didn't want to bloat the class with a bunch of 10-line files

okay, that's what I thought

do you have permission to do it?

okay, sure

@murgatroid99 It's true, I could do that, and that's sort of how I did it in my initial version, I just like the idea of having TwoPart symbols that are actually made up of two different Symbols.

@murgatroid99 yeah, I think I prefer that way too, I just wish there was a better way to make monocolor hybrid symbols

Hey @Rainbolt @murgatroid99, I have two new versions of the ManaCost/ Symbol implementation, let me know what you think! I also included a list of the benefits of each system (and links to the two branches) here: github.com/c0d3br34k3r/magic/issues/4#issuecomment-100300996

I do probably use it too much

I dont think switch is evil

@Rainbolt well my IDE produces a warning if you don't account for all types or don't have a default

@Rainbolt yeah, that's what I'm used to

also, length isn't the only thing that's important, though it's a good indicator

@Rainbolt @murgatroid99 okay, I'll make a branch or two on my repo and see what it looks like

I'm trying not to be biased

it seems simpler to me

Okay, well I'll think about this. I'm not trying to be frustrating, but I'm still trying to figure out why using the Symbol idea, with ColorlessSymbols, is a bad idea

yeah

that makes sense