RELOAD!

[rubberduck-vba/Rubberduck] 3 commits. 1 opened issue. 1 closed issue. 14 issue comments. 36 additions. 18 deletions.

[Minesweeper] Games Played: 98, Bombs Used: 59, Moves Performed: 13099, New Users: 15

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.4.1.5086

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.4.1.5086

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.4.1.5086

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.4.1.5086

[rubberduck-vba/Rubberduck] build for commit 175de28c on next: AppVeyor build succeeded

@this I suppose... they're probably what, 2K commits behind?

I think I will open PRs for better explanation what Columns, Rows and Cells do to the documentation repository.

[rubberduck-vba/Battleship] oiooio starred us

[rubberduck-vba/Rubberduck] oiooio starred us

[rubberduck-vba/Rubberduck] MDoerner assigned MDoerner to issue #5222: '@DefaultMember Annotation - Running Any Quick-Fix applies CurrentValue.VB_UserMemId = 0 to both Get and Let

Wow! !(Busy night)

@M.Doerner Do we also have to consider the Range and Item properties, too? There's also Value for when no parameters are provided (is Value2 even used?) That's at least 4 different properties, which is a bit more than typically expected for a xmldoc on an inspection.

@MathieuGuindon More like 4K+ behind. :)

The examples in the documentation for Range.Range are useless; they all use Worksheet.Range, which is another method, which just does the same for a worksheet.

Oh wow, the last example is actually a bug.

@this The Range member does not correspond to the default member.

No parameters is another inspection.

But in the case of Item, the behavior of _Default is changed, no?

I was not sure if that was true for the Range but from a superficial reading of the docs, it seems to have no bearing on how _Default will behave.

Whenever parameters are provided, [_Default] behaves exactly as Item.

Then I may have misunderstood. I understood that if it's via Columns or Rows, the behavior of _Default changes.

I guess I should also make a PR to the doc for Range.Item.

and without the parameters, _Default becomes just Value (Value2?)

So does the behaviour of Item.

It becomes Value.

My concern is more about understanding how _Default maps to different properties under what circumstances.

From what you've told so far, it seems to be just either Item and Value

(and that Item has more nuanced behavior, depending on the prior member access, if any)

^

Still, not exactly intuitive nor unsurprising.

I think I will really do a PR to the docs for the stupidity around Item.

I guess somebody just wanted to be clever when Columns and Rows was introduced.

^

[rubberduck-vba/Rubberduck] mika76 created comment on issue #4888: Support for semicolon on object.print

> Hey @retailcoder this is great stuff! Any idea when your next stable release will be? Last one was in march...

@Duga lol tell me about it...

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #4888: Support for semicolon on object.print

> The current plan is early to mid November.

[rubberduck-vba/Rubberduck] mika76 created comment on issue #4888: Support for semicolon on object.print

> @MDoerner fantastic thanks!

@MathieuGuindon We have a pinned chat message for it.

:)

Nuttin' like random Joe swinging the motivation hammer, eh?

[rubberduck-vba/Rubberduck] ricardoba13 opened issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

[rubberduck-vba/Rubberduck] ricardoba13 added label enhancement to issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

@Duga huh, but todo labels don't care what the comment marker is, do they?

work-around: use "fix all" on one of the many "use of obsolete Rem keyword" inspection results?

@Duga The Rem is not part of the comment.

no repro

Huh?

What did you test?

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

^ @M.Doerner this. Or am I missing something?

I think you are missing what OP is asking for.

entirely possible

He wants to see Rem whatever in the ToDo explorer if Rem exists as todo marker.

that's... wtf

if Rem is also the comment marker, then it can't happen without making todo comments include the comment marker

which is totally wrong, I think.

[rubberduck-vba/Rubberduck] retailcoder edited issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

Based on the description, OP uses Rem to mark that he has to remeber it and ' otherwise.

That is what todo markers are for in the first place.

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

@Duga I'm kind of confused. If it's 'Rem, isn't the ' the comment marker and the Rem a TODO marker? The OP sounds like he's using 'Rem, so the Rem has no syntactical meaning.

No, 'Rem is reported in the todo explorer, but nor Rem alone.

oh right, he said "and also"

Ok now I'm clear. Yeah, the latter, we can't do anything.

Too bad we can't suggest him to use regex search to replace all occurrences of Rem into 'Rem

The current implementation of that feature is not something we should release.

I almost was going to suggest using the built-in F & R but the problem is that it wouldn't exclude cases that shouldn't be replace

BTW, I have to rebuild meta to activate the analyzer for inspection xml-docs, right?

With a regex, you can specify $(w+)Rem.

(I think)

RD.Deployment doesn't build RD.Meta?

@M.Doerner It should not be necessary to rebuild the meta. This would be done automatically as part of normal build.

right, otherwise AV wouldn't be running them

@MathieuGuindon Not really. More like that all projects imported from the base project has a dependency on the build task, which guarantees that meta is built as soon as any one of the project depending on such base project is built

because the meta must be built before any one of the 17 project get built.

makes sense

I really need to update that wiki about build process.

Erm, why do we have an inconclusive test in next?

not sure what you mean by that - I guess you aren't referring to the ~30 tests that are ignored.

No, one case of EmptyModuleInspectionTests uses invalid code.

[rubberduck-vba/Rubberduck] ricardoba13 created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

@Duga no, the logic was built without thinking someone would turn a keyword into a TODO marker

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

[rubberduck-vba/Rubberduck] bclothier created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

[rubberduck-vba/Rubberduck] ricardoba13 created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

> @MDoerner hmm, so the Rem keyword is intended to "Remark" something and not to "Remember" something, if that is the actual case, that's a game changer then. And I have to admit I was wrong!

well it is short for "remark"

@Duga you're not the first or last soul to be saved by the duck then :)

[rubberduck-vba/Rubberduck] MDoerner created pull request #5224: Fix member attributes recovery for properties to merge MDoerner/Rubberduck/FixAttributesRecovery into rubberduck-vba/Rubberduck/next

@Duga Easy fix

[rubberduck-vba/Rubberduck] ricardoba13 edited comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

> @MDoerner @bclothier hmm, so the Rem keyword is intended to "Remark" something and not to "Remember" something, if that is the actual case, that's a game changer then. And I have to admit I was wrong!

Why are the examples in the Excel VBA documentation so bad?

They look like random ramblings.

I think that's universal for most of Office

I hear several old timers complaining about it.

There are some who hold onto 97 help documentation just for that reason.

[rubberduck-vba/Rubberduck] Vogel612 added label status-bydesign to issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

[rubberduck-vba/Rubberduck] Vogel612 added label feature-todo-explorer to issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

[rubberduck-vba/Rubberduck] Vogel612 created comment on issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

> I consider this behaviour by design (and it seems the other dev team members share my opinion there). As such I'm closing this issue. Thanks for your feedback :)

[rubberduck-vba/Rubberduck] Vogel612 closed issue #5223: Rem without apostrophe should also be shown in the TODO Explorer

[rubberduck-vba/Rubberduck] build for commit 63abcea8 on unknown branch: AppVeyor build succeeded

I think I will do something about a few of the examples.

At least the last one for Worksheet.Range is an error just waiting to happen.

@M.Doerner I've seen several examples that are VB which don't even compile for VBA. Makes learning very difficult without experience.

I've fixed one or two of those

@IvenBach That's because they were written by lizard people who wants everyone to stop using any BASIC dialects. </shifty eyes>

(no, not really)

I've fixed a couple too.

Update: Scheduling a BBQ for my mom right now.</terrible-joke>

Did her grandchildren forget a comma?

LOL. Touche. Well played.

I'm sure she'll appreciate the BBQ-wake (at least I'm assuming that's what it's)

Getting pricing for cremation is like pulling teeth.

$1400 is cheapest option I've found so far. And that's still too expensive IMO.

Unfortunately. There are several laws in regards to how they can sell the packages so the funeral homes are.... difficult.

Because they are afraid of getting sued by the bereaved for extortion but their business is based on people dying so....

I'm well aware of that. Was over $7,000 (correct comma) for my grandmothers "services" on a plot and plan she'd already paid in full for decades earlier.

First letter opened is pre-approved life insurance. #Irony.

Enjoy the day pond. I'd be making too many off-topic and off-colored remarks if I stayed.</iven>

@IvenBach this is your home pond as well.

Hmm, turns out the Microsoft would really rather you didn't try to deploy Core 3 WPF apps over ClickOnce. Think I've nearly got things working though.

i thought ClickOnce was long ago deprecated?

nope, still in wide use for net fx in corporates

but for core, MS want you to use their new store installer thingy

wsix?

but its not great for corps, "sideloading" is not a great look, and ain't nobody wanna put their internal apps on the MS store (locked down or not...)

and now azure devops won't load the release definitions page

fml

hmm, looks like this is the blog I need to read

blogs.msdn.microsoft.com/appconsult/2018/03/22/…

interesting. I was under the impression it all went out around the time VS 2010 came out

but for now I just want to get things working with our existing release pipeline...

I kinda got tacit approval from our PM to migrate to Core 3, but if it turns into a whole thing it's gonna get awkward...

[rubberduck-vba/Rubberduck] SteveLaycock added label support to issue #5225: ToDo list Not reporting '@Ignore annotations

[rubberduck-vba/Rubberduck] SteveLaycock opened issue #5225: ToDo list Not reporting '@Ignore annotations

@Duga I wonder why the annoations come up at all. They are not part of the comment.

or shouldn't be

I might be misunderstanding but from what I see, ToDo is just a specialized CommentNode?

e.g. it's not its own parse context, so there's nothing preventing it from being both a ToDo and an annotation

My guess is that they are followed by a comment without the colon so that they are not recognized as annotation.

AFAIU, we search comments for the todo markers.

The annotations are not part of the comment node.

Either way, he has a point RE: finding ignored annotation. They're not very discoverable.

@M.Doerner so given a line '@Foo blah, the @Foo is an annotation, while blah is a comment node?

No, but that is because you missed to use the colon.

'@Foo : blah

That is what your example should look like.

and in the earlier example, blah would be considered an argument to the annotation @Foo (which may be invalid), right?

'@Foo blah is just one comment

Or that

hmm. Feels too fragile.

It might have been a good idea to require parentheses.

@this I'd have thought the @ was distinctive enough to make Ctrl+F a no-brainer, but eh

[rubberduck-vba/Rubberduck] bclothier created comment on issue #5225: ToDo list Not reporting '@Ignore annotations

> Linking #3364 for the part regarding finding annotations.

However, that is a breaking change now.

@MathieuGuindon using the built-in find dialog?

Find them one by agonizing one?

That's why I much prefer using MZ-Tools' find dialog over the built-in find dialog.

but for those without....

We could just make an annotation explorer.

do we need a separate one? this feels like a specialized case of todo

that would be on-brand :)

Or simply add an alternative view to the todo explorer

Apparently, I cannot tipe fast enough on mobile.

[rubberduck-vba/Rubberduck] bclothier closed issue #4617: Expand the Todo Explorer to pick up annotations

[rubberduck-vba/Rubberduck] bclothier created comment on issue #4617: Expand the Todo Explorer to pick up annotations

> Closing this in favor of #3364

[rubberduck-vba/Rubberduck] bclothier created comment on issue #3364: Locate Ignored Annotations

> As #4617 suggests, ToDo explorer may be enhanced to handle this instead of inventing a new window.

I thought there was a similar issue a while back but I can't find it where the user was similarly confused with the mixed annotation/comment

Maybe I was thinking of #5091

@MathieuGuindon / @M.Doerner I apologize for asking directly but do either of you have non-English VBA?

You mean a non-English host, right?

I don't have one.

yes

Non-English Excel is seriously confusing.

Yes, I've heard same thing to that effect - most developers say they won't do anything on it since it causes much unnecessary pains for development.

The localization behavior in Office is not that well thought out, so it's not easy to write an effective localized test.

The problem is not the VBA part, which is identical.

However, all Excel function names have been translated.

hmm. I thought I remembered someone saying that non-English host may cause the date formatting to be treated differently?

Date formatting depends on the regional settings of the operating system.

hm.

However, as long as you use the members referring to values in the language of the macro, there is no problem.

It is the equivalent to InvariantCulture.

I could try changing my date formats

and running the tests to see if it breaks.

Just don't look at Excel online; that depends on the browser settings.

BTW, it always annoys me that VBA dates are prettified to en-us dates in VBA.

Yes, that's a part of reason why I originally used en-US rather than invariant culture to make that explicit, but I want to verify that is correct reasoning.

The invariant culture in .Net is en-us.

the documentation does not say so?

Hm, it is only specified to be en.

That's why I did not feel confident that it's an equivalent representation, given VBA's propensity to use en-US date formats

@this I think I have a French Office install of my wife's laptop

If you do, can you test the test cases via VBA immediate window just to see how it handles the stringified dates?

I'll have to get back to you, but yeah

Does Quebec French uses DD-MM-YYYY?

that would be fr-CA.. not sure what the date format is, could be that, but inner me wants it to be yyyy-MM-dd

ok, good enough - it's not US format so that'll prove positively whether non-English install impacts teh formatting of VBA (beyond the windows regional setting as Max suggested)

wait does a French OS thwart this experience?

nah, I can control thta by setting my OS to french temporarily (!)

and see how it behaves with an English Office host

:+1:

TBH, it's not all that clear how it all aligns. It feels like playing a some kind of globalization roulette.

[rubberduck-vba/Rubberduck] BZngr created pull request #5226: Complete InspectionTestsBase incorporation to merge BZngr/Rubberduck/5191_I_thru_Z into rubberduck-vba/Rubberduck/next

> Closes #5191. This PR incorporates InspectionTestsBase into the remaining inspection tests (except one - see below). The good news is that there is net reduction of nearly 4000 lines of inspection test code thanks to the InspectionTestsBase class. Other notes of interest: UnreachableCaseInspectionTests: 1. Is the only test class remaining that does not derive from **InspectionTestsBase**: 2. The UnreachableCaseInspectionTests as-written make use of the InspectionResults.resx to...

identify which result(s) occur for the various test scenarios. The resource string comparisons/manipulations were used by the tests because this inspection flags more than one type of issue. So, there are a number of places in the test code that look like InspectionResults.UnreachableCaseInspection_Unreachable. These references to the resource file become name conflicts with the InspectionTestsBase.InspectionResults method. So, this particular test class could not inherit from the base...

class. I can look at reworking the test class, but I'm thinking this would be outside the scope of this PR. InspectionTestsBase: Added some overloads within this class, particularly regarding the InspectionResultsForModules method. The overloads all have to do with making it easier to introduce reference libraries when building up theVBE. The overloaded methods take either a single library identifier string or an enumerable list in addition to the module-defining tuple(s). The...

MockVBEBuilder uses raw strings to organize and manage the libraries - so the added overloads are consistent with that approach. MockVBEBuilder: 1. Added some overloads to the BuildFromModules method to support the overloads added to InspectionTestsBase. 2. Modified public const string TestProjectName and TestModuleName to be public static string properties. This allows tests an option to modify the default names without breaking pre-existing references to the constants. This...

was needed/used for the UseMeaningfulNameInspectionTests (issue described below). UseMeaningfulNamesTests: The UseMeaningfulName inspection requires different identifiers than the MockVBEBuilder's default Project and Module names. "TestProject1" and "TestModule1" both end with a number - and therefore are flagged by the inspection. There seemed to be a couple options: a) Simply change the default values to ones that are not flagged. or, b) Provide some mechanism for the test...

subclasses to set the default name. I chose the latter approach. This was partly motivated by the fact that at several tests use the default Project and Module names as part of there expected value for comparison. The other reason is that there may be other test classes (now or in the future) that wish to use identifiers different than the defaults if for no other reason than to remove the possibility that changes to the default name would break its tests. So, the following changes were made:...

a. Modified MockVBEBuilder Project and Module default name constants (described above). b. Added OneTimeSetup and OneTimeTeardown attributed methods to UseMeaningfulNameInspectionTests. Since the MockVBEBuilder properties are static, the setup/teardown methods are needed to ensure that tests running subsequent to the UseMeaningfulNameInspectionTests would receive the expected default values.

Holy Wall of Text, Batman!!!

....was thinking @Duga might truncate that a bit.

or a lot.

LOL, no, not for PR comments, she doesn't.

(don't misunderstand me - verbose information is better than none!)

probably should reserve judgement until you've had to wade thru it. ;)

Regarding the non-standard project name, you can just build the mock vbe using a MockVbeBuilder instance.

At least that is what I do when I need a different project name.

True...but the InspectionTestsBase removes that option if you use its methods.

InspectionResults takes an IVBE.

Yes - but InspectionResultsFromModules does not.

I used that method (and variants) for the most part.

All other methods are just convenient ways to define what kind of IVBE you want to pass to InspectionResults.

yes - but I preferred that to building an IVBE locally in the test(s) to make things as consistent as possible across all the tests.

@Vogel612 I limit my venting frustration as conversation should revolve around RD dev and coding.

[rubberduck-vba/Rubberduck] build for commit 6a2ea75c on unknown branch: AppVeyor build succeeded

@BZngr Also, one difference is that on the GH PR it's formatted but on here, not so much. :)

And thanks for taking on this monster!

lol, running 2.4.0.4511 on wife's laptop

> Rubberduck 2.4.1.0 is now available!

@this so, ?Date outputs 2019-10-15 and I'm proud of fr-CA date format!

Anything else you want me to check?

Quick before my eyes melt, this is a French VBE!

but what about the 4 test cases?

[TestCase("04/12/2000", typeof(DateTime), ExpectedResult = "2000-04-12 00:00:00")]
        [TestCase("12/04/2000", typeof(DateTime), ExpectedResult = "2000-12-04 00:00:00")]
        [TestCase("13/04/2000", typeof(DateTime), ExpectedResult = "2000-04-13 00:00:00")]

so i guess the VBA equivalent would be:

?CDate("04/12/2000")

the missing 4th test case is `04/13/2000'

ducky updated

@this 2000-04-12

hmm.what about the implicit conversion.... Dim dte As Date : dte = "04/12/2000"

@this 2000-04-13

so it does take US formats. Fascinating.

@this still 2000-04-12

and what about "13/04/2000"?

that's the one that should be most hilarious (right?)

@this 2000-04-13

I guess that settles it. It's US-centric, then.

yeah

Thanks, MSFT!

(and thank you, @MathieuGuindon for being a guinea pig! )

storm here. Better shut down before I get fried. Later!