« first day (1947 days earlier)      last day (1233 days later) » 

Duga
Duga
12:00 AM
RELOAD!
[rubberduck-vba/Rubberduck] 3 commits. 3 opened issues. 3 closed issues. 20 issue comments. 2 additions. 14 deletions.
[Minesweeper] Games Played: 59, Bombs Used: 31, Moves Performed: 7303, New Users: 22
 
IvenBach
IvenBach
Darn looks like I missed an interesting chat. Wish I had time to read it.
 
mansellan
mansellan
12:17 AM
@IvenBach study
 
 
1 hour later…
Duga
Duga
1:45 AM
 
this
this
One more annoying thing about the build / test cycle --- I've just built everything successfully, so I click on Run All. What does VS do? Why, like any sane IDE would do, it goes to rebuild the project because.... we gonna be sure!
 
Duga
Duga
2:13 AM
> Based on the proposal outlined here, and in light of recent PRs (mostly mine :( ) adding several new trace flags and conditional compilation code, I thought that Rubberduck would benefit from having more of its code verified at compile-time regardless of which flags are in effect. This is first of 2 commits I intend to make on this PR. The 2nd commit will be mainly within the TypeLib...
API where a certain fool has added a bunch of conditional compilation flags and needs ot clean up the mess. ~.~ However, before I get into this effort, I wanted to get others' feedback if this is a change for the better.
[rubberduck-vba/Rubberduck] build for commit f7881a5e on unknown branch: AppVeyor build failed
BUILD FAILURE!
 
this
this
wtf?
That's because you didn't build release locally, this.
 
Duga
Duga
2:47 AM
 
Duga
Duga
2:59 AM
[rubberduck-vba/Rubberduck] build for commit 4b524403 on unknown branch: AppVeyor build succeeded
 
Duga
Duga
3:12 AM
> All fixed.
Thank you for your help.
> I just had a look at this issue and I'm unfortunately unable to reproduce this issue.

This is what I did:

Using battleship spreadsheet, I exported the contents of the project to a folder.
I open a Windows explorer to the same path.
I then export. No error.
I then create a new folder within it.
I then export, targeting the new folder but do not select it just yet.
I delete the folder via windows explorer.
I then select the folder and it still exports, re-creating the folder in the
 
IvenBach
IvenBach
3:56 AM
@mansellan Just did. Got the take home portion of my exam finished. Think it's correct, and double checking it after a break I came to the same result.
 
Duga
Duga
4:40 AM
 
IvenBach
IvenBach
@Duga I mean a free t-shirt is a free t-shirt. #NoShame
@IvenBach github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Core/… comes up as never being used. I call :dibs: <hint>PR for tomorrow.</hint>.
Night pond.</iven>
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 08c5c116 on unknown branch: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 88b4153c on unknown branch: AppVeyor build failed
BUILD FAILURE!
 
IvenBach
IvenBach
5:06 AM
Reminder to Mug to not carve your pumpkins until, at most, the day before Halloween. Looking forward to your pumpkin art btw.
@Duga will revert that const tomorrow.
 
 
6 hours later…
Duga
Duga
10:46 AM
 
 
2 hours later…
Duga
Duga
12:23 PM
> There is an undue amount of issues open here, where the `@Ignore` and `@IgnoreModule` annotations do not work correctly. While they are comparatively easy to fix, it would be much better if we didn't get these issues in the first place because such checking is automatically done for every inspection.

This necessitates centralizing the ignore handling into the InspectionBase class.
Notably the Inspections dealing with references that can be ignored at their declarations need custom support
 
Duga
Duga
12:53 PM
> Fixes #4965
 
Duga
Duga
1:05 PM
[rubberduck-vba/Rubberduck] build for commit 60e2dac9 on unknown branch: AppVeyor build succeeded
 
Duga
Duga
1:30 PM
> Closing this due to age. Feel free to reopen if this still occurs.
Fix Ignore and IgnoreModule for UnderscoreInPublicMemberName Inspection

Fixes #4965
Merge pull request #5185 from Vogel612/fix/ignore-underscore-inspection

Fix Ignore and IgnoreModule for UnderscoreInPublicMemberName Inspection
 
Duga
Duga
1:56 PM
[rubberduck-vba/Rubberduck] build for commit 17019167 on next: AppVeyor build succeeded
 
Vogel612
Vogel612
2:46 PM
bleh... 
public static bool IsIgnoringInspectionResult(this IInspectionResult result, DeclarationFinder declarationFinder)
{
    switch (result)
    {
        case DeclarationInspectionResult dr:
            return dr.Target.IsIgnoringInspectionResultFor(dr.Inspection.AnnotationName);
        case IdentifierReferenceInspectionResult irr:
            return irr.QualifiedName.IsIgnoringInspectionResultFor(irr.Context.Start.Line, declarationFinder, irr.Inspection.AnnotationName);
        case QualifiedContextInspectionResult qcr:
 
Duga
Duga
3:08 PM
> IIRC the main reason this wasn't centralized is because not all inspections can be ignored. ...and since that was established, AFAICT out of all inspections we made, there is only one that cannot be annotated (default project name)... which in hindsight wasn't a good reason at all. Let's fix this!
 
 
1 hour later…
this
this
4:20 PM
@Vogel612 why not adapt a similar pattern that Max used for commands, so that each type can contribute their logic?
 
Vogel612
Vogel612
the predicates aren't really different enough to merit that
like ... I've reduced the ignore checks to about two handful of checks from ~200
 
this
this
That's great. But what about that lone exception? How does it get to say "I can't be ignored!"?
 
Vogel612
Vogel612
it just filters in the "GetInspectionResults"
the helper methods are available either way
 
this
this
oh, ok
 
Vogel612
Vogel612
I'm just verifying the ignoring still works as before after I removed all of that stuff...
 
Vogel612
Vogel612
4:35 PM
damn, I broke some tests.
now I gotta find out what went wrong. But that's for tomorrow
 
Duga
Duga
 
Duga
Duga
4:50 PM
[rubberduck-vba/Rubberduck] build for commit 1bd58ca4 on unknown branch: AppVeyor build succeeded
 
 
1 hour later…
Duga
Duga
6:08 PM
 
Duga
Duga
6:21 PM
> PR created for this request
[rubberduck-vba/Rubberduck] build for commit 8dcfb02d on unknown branch: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit f7869517 on unknown branch: AppVeyor build succeeded
 
 
2 hours later…
Duga
Duga
8:31 PM
> Hi, I'm new to Rubberduck but I'd like to work on this issue for Hacktoberfest. Just to clarify, you want it so that you can press the Esc key instead of clicking Cancel on all dialogs?
 
 
1 hour later…
Duga
Duga
9:35 PM
> Not quite (although that would be cool as well). This is about the SearchBox control we built to unify the searching behavior in CodeExplorer, ToDoExplorer and the Inspections window. It may only be necessary to update this file
 
Duga
Duga
10:12 PM
> To clarify, the desired behavior seems to be

Given there is text in the SearchBox
When the Esc key is pressed
Then the textbox is cleared
 
Duga
Duga
10:41 PM
[rubberduck-vba/Rubberduck] Unrecognized author pushed commit 8dcfb02d to next: Change in Ok button text to better represent actual functionality
[rubberduck-vba/Rubberduck] Unrecognized author pushed commit f7869517 to next: Proper change for Ok button, settings dialog change of key used for the previous Ok button. Kept Ok button resource since it's used by other components
Merge pull request #5187 from GusAV/next

Change in Ok button text to better represent actual functionality
 
Duga
Duga
10:52 PM
[rubberduck-vba/Rubberduck] build for commit d4c3f2bf on next: AppVeyor build succeeded
 
Duga
Duga
11:04 PM
> **Justification**
Consider the following code (using the Excel object model):
```
Dim col As Sheets
Set col = Application.Worksheets.Item(1)
```
This code will fail, because `col` is a `Sheets` collection, while the object returned from `Worksheets.Item(1)` is a `Worksheet`.

The VBA compiler cannot currently catch this sort of thing, because `Application.Worksheets` returns a reference to the `Sheets` collection, and `Sheets.Item` can return either of two types:

* if you pass in an
 
Duga
Duga
11:42 PM
> Oh I see. Thanks :) I'll start work on this tomorrow then.
> This PR consolidates name/identifier validation code along with a couple improvements for DeclarationTypes other than DeclarationType.Variable 1. Replaces VariableNameValidator class 2. Adds support for different identifier name length validations: variables (255) modules (31) 3. Add detection of "VBA" as invalid when renaming a Project identifier (MS-VBAL 4.1) 4. Consolidates identifier validation code and result messages for Inspections, QuickFixes, and Refactoring. As part of...
researching renaming/identifier issues (e.g., #4819) and while working on a MoveMember refactoring, there appeared to be value in first moving the various versions of validation code from the Inspections, Quick-fixes, and Refactorings to a single location - making the logic and messages common/re-useable.
> `Sheets` is the return type of the `Worksheets` property; `Sheets` is also another property that also yields a `Sheets` reference, only that collection might include sheets that `Worksheets` wouldn't (e.g. `Chart` sheets).

I like this idea... basically document the "overloads" in various type libraries.. I think we could make that work with an xml format; this one would have an overload definition taking a string, another taking a long, and another taking an array (any array I guess).
[rubberduck-vba/Rubberduck] build for commit c7c916c3 on unknown branch: AppVeyor build succeeded
 
IvenBach
IvenBach
11:57 PM
@Duga So that's what it feels like when someone else tackles an issue you opened. Cool stuff.
 
Vogel612
Vogel612
@IvenBach yea, the SearchBox issue caused some confusion, though.
 
IvenBach
IvenBach
SearchBox?
 

« first day (1947 days earlier)      last day (1233 days later) »