VBA Rubberducking

5:01 PM

@Comintern lol, "how can I crash Excel and get an APPCRASH event log entry?" - gets awesome, valid answer - "ok thanks but that's not helping me find out anything about the unhandled exception in my C# code" - facepalm

Comintern

IKR?

Mathieu Guindon

FWIW my VTC is still in there

missing nerd-snipe tag. totally X-Y too.

Comintern

LOL

nerd-snipe should be an answer tag.

this

^ need a hat for that

Mathieu Guindon

a hat that's actually a rack supporting an oncoming bus? could be a good one...

this

5:06 PM

was thinking of either sniper's scope or Elmer Fudd's hat

Comintern

Target superimposed with cross-hairs?

Duga

[rubberduck-vba/Rubberduck] Inarion created comment on issue #4478: Code Explorer search bar is invisible

> @comintern I just saw in that demo for the new CE that you implemented a watermark there. Which probably means, nothing more needs to be done here?
I'll remove my assignment in any case, as it's unlikely I'll get anything done in the foreseeable future.

this

that's not a hat, is it?

Duga

[rubberduck-vba/Rubberduck] Inarion unassigned Inarion from issue #4478: Code Explorer search bar is invisible

this

but then again, I suppose sunglasses aren't, either.

Mathieu Guindon

5:09 PM

> Nerd-Sniped! Provided an elaborate answer to a short question, scoring 5+

Duga

[rubberduck-vba/Rubberduck] comintern created comment on issue #4478: Code Explorer search bar is invisible

> @Inarion Gah! Sorry about that, I completely missed this issue when I was trolling for CE related tags.

[rubberduck-vba/Rubberduck] comintern assigned comintern to issue #4478: Code Explorer search bar is invisible

Comintern

@this Anything is a hat if you put it on top of your head.

Mathieu Guindon

^

this

by that logic if I stand head down, I'm wearing Earth as my hat.

Comintern

Yep.

Inarion

5:11 PM

@Duga @Comintern No worries! Besides researching the issue some weeks ago I had not made any real progress. (Due to lack of time investment, primarily.)

Comintern

Just don't try to wear it standing up.

this

not sure that makes any difference given that gravity works in all direction.

it's the ~~falling~~ accelerating toward it that makes the sudden stop at the end..... painful.

Comintern

It would if you were standing on something else though, I.e. the moon. But then we'd all be screwed.

this

here's a thought - is it possible to land moon on earth gently?

Comintern

I'd think so.

The problem would be supporting it.

(one problem)

this

5:17 PM

I doubt it. two bodies with masses significant enough to generate gravity wells would have to accelerate toward each other if they are on an collision course.

Inarion

if you have some huge structural extensions to the moon to which you could then strap some enormous boosters... I guess it could work.

Comintern

It would screw with the Earth's rotation though because the center of mass would move. That would probably throw everyone on the opposite side of the planet off.

Inarion

(The extensions are needed to not completely scorch/erode the Earth's surface when trying to land the moon.)

Comintern

@this I was thinking something like in between, like a girder system to keep the gravity wells from merging completely. It would need to be hard core to say the least.

Inarion

@Comintern Agreed. That would make for a massive landslide, if not supported. Some volcanism on top, maybe?

FreeMan

5:20 PM

If when attempting to land the moon on the earth, one were to use retro-rockets, would the thrust of the rockets, designed to slow the moon's descent, eject enough mass to push the earth away?

this

The problem is having enough energy to do that

it's the same reason we don't use retro-rockets on the re-entry.

Comintern

@FreeMan Or more importantly for the people attempting this, would the reaction mass hitting the Earth do as much damage as a collision.

this

simply slamming into the atmosphere is much cheaper than firing some retro rocket for which you need to bring along the fuel

FreeMan

SpaceX uses them to land their launchers. But, then, those parts don't exit the atmosphere.

Comintern

For some values of "slamming".

FreeMan

5:22 PM

@Comintern Or more importantly for the people attempting this be far enough out of the way that they don't get hit by the blast?

Comintern

Yeah, I'd want to be somewhere off system.

this

Using a girder is problematic because of bodies moving. See What-If on Earth-Moon firepole.

Duga

[rubberduck-vba/Rubberduck] mansellan created comment on issue #4634: Rubberduck windows not correctly sized

> Windows has a threshold at 125% between two different scaling strategies. Would be interesting to know if this happens at 120%, or 130% (in Custom). Also, you mentioned multiple monitors - is the effect apparent on all of them, or only some?

FreeMan

@this Yes, but the rockets are necessary to counter the gravitationally induced collision to make it a somewhat softer touchdown

@this this does all seem very XKCD...

this

Yes, you do need to slow the collision somehow but my concern is that we might not have even enough energy to do that.

Heck I'm not sure if launching our entire nuclear armanent would do the job.

Maybe we should ask Randall. :D

FreeMan

5:24 PM

lets!

Comintern

I'm thinking this might end in disaster. We should tag the "Could you set the Moon on the Earth" issue as [status-declined] for now.

this

I think that's given.

Comintern

Probably blocked by other issues anyway.

Duga

[rubberduck-vba/Rubberduck] cswartzvi created comment on issue #4640: Rubberduck Add-In could not be loaded: System.IO.FileLoadException

> I talked to our IT department and they told me that my workstation (which is only 6 months old) has never had Excel 2010 on it. I did some searching myself and while I didn't find a 2010 version of `office.dll` I did find some interoperability dlls, specifically `policy.12.0.office.dll`. Any chance these could be the problem? Note, however, that these dll's are not new and appear to have existed for as long as I have had the workstation.

I appreciate your help so far on this issue, please l

FreeMan

If we waves hands nudge the moon out of its orbit and toward Earth, how much rocket energy would be required for the moon to make a soft landing on the Earth's surface? Where "soft" is a relative term meaning "short of cataclysmic disaster".

this

5:27 PM

without anything else? Impossible

Hosch250

You can't do it.

FreeMan

spoil sports!

this

Remember, gravity accelerates the body toward it.

Hosch250

They were just discussing this on WB, only landing an asteroid on the moon.

IvenBach

@FreeMan commitstrip.com/en/2018/12/17/…

Your problem is solved!

Hosch250

5:28 PM

Essentially, you either end up with a direct collision (not soft) or an almost-in-orbit body that comes along and they aren't gravitationally locked to each other.

this

That's why we measure our gravity in units of meters per second squared. (or if you're an imperialist pig like me, feet per second squared.)

Hosch250

Also, my markdown-to-WPF works awesome, almost.

It doesn't support embedded HTML (and never will).

FreeMan

@IvenBach yeah, this is essentially what he was doing. We're allowed to buy new equipment for new employees, but not upgrade equipment for existing employees. So, now we have an unofficial hand-me-down program exactly like that!

Hosch250

The only issue right now is with code blocks.

They don't let me scroll sideways :'(

I've got images, tables, etc.

IvenBach

@FreeMan That gives me the sads hearing that.

Mathieu Guindon

5:31 PM

@this I can't picture g with any other value than 9.8...

FreeMan

you're sad? I'm living it!

Hosch250

It even renders the readme.md on Rubberduck reasonably nice, except it gives the images full width to the view pane.

FreeMan

@Hosch250 did you earn a... rubberduck hat?????

IvenBach

@FreeMan You can fight with Vogel over my last condolence I gave him a while back. Or did he give that to Comintern? I forget...

Hosch250

Yes.

IvenBach

5:32 PM

#Jealous

Mathieu Guindon

@Duga I guess we're all out of ideas here... question is, did we break their Office install??

Hosch250

Go start a question/answer. Let it auto-save, then use the Discard button.

this

@MathieuGuindon neither can I. They had me doing metrics for all of my physics studies, thankfully. But for all I know, there's probably some slide rulers out there who still calculate their orbital speed in feets per second squared.

Hosch250

You get the Rubberduck hat :)

5

this

@MathieuGuindon the fact that it's looking for 12 (which is actually 2007, not 2010) makes me think it might be another build artifact.

Duga

5:33 PM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.CodeAnalysis/Inspections/Concrete/AttributeValueOutOfSyncInspection.‌cs of pull request #4642: Attribute value out of sync inspection

this

But I did not get a chance to check if that's the case.

Mathieu Guindon

@this look, there's SI units, and then there's heretic units. pick your side. :p

Hosch250

<- Proud unit heretic.

IvenBach

@Hosch250 Didn't get my rubberduck hat after discarding.

this

@MathieuGuindon media0.giphy.com/media/3o85xIO33l7RlmLR4I/…

Hosch250

5:35 PM

It'll take a couple minutes.

this

(sorry no one-boxing this)

FreeMan

@IvenBach I've managed to get my upgraded machine, so I'm surviving, Vogel can keep the condolence.

Hosch250

@this Did that kid being carried change hair color half-way through?

mansellan

@MathieuGuindon It really irks me that the Discovery channel insists on using km - we're heavily miles-based in the UK

Hosch250

@mansellan EU mandate, probably.

FreeMan

5:36 PM

@mansellan It's funny listening to F1 coverage on Sky as they bounce between metrics and imperials...

Hosch250

They can't sell apples by the pound anymore, you know. They even arrested people who tried.

mansellan

@Hosch250 lol then roll on Brexit!

2

FreeMan

@Hosch250 somehow that doesn't shock me

Duga

[rubberduck-vba/Rubberduck] cswartzvi edited comment on issue #4640: Rubberduck Add-In could not be loaded: System.IO.FileLoadException

> I talked to our IT department and they told me that my workstation (which is only 6 months old) has never had Excel 2010 on it. I did some searching myself and while I didn't find a 2010 version of `office.dll` I did find some interoperability dlls, specifically `policy.12.0.office.dll`. Any chance these could be the problem? Note, however, that these dll's are not new and appear to have existed for as long as I have had the workstation.

I appreciate your help so far on this issue, please l

mansellan

@Hosch250 heh, milk here comes in 568ml containers (or multiples thereof)

Mathieu Guindon

5:40 PM

here it's 500ml, 1L, or 2L. embrace metric, see how simpler life becomes!

Hosch250

LOL.

@MathieuGuindon That translates to 1 pint.

Except EU mandate they can't sell by imperial in the stores.

this

one thing I really have wondered about though - does imperial units actually work better when you don't have any equipment and must estimate by eyeballing?

Hosch250

@this Not for me.

this

that question is hard to answer because I can't just ask a kid who knows only imperial all the life .

Ditto for a kid who knows only metrics.

That wouldn't be a basis for fair comparison.

Hosch250

My first thumb joint is 1in, and my handspan is 6in (or .5ft).

this

5:42 PM

yeah, same here

Hosch250

So, I have a built-in ruler in sensible increments.

this

my hope is to find a bunch of kids who grew and are equally fluent in both systems in order to pose the question. Unlikely.

Mathieu Guindon

the funny thing is, I know my weight in pounds, and don't ask me about kilos

Hosch250

Haha.

mansellan

@Hosch250 they're allowed to put imperial on, but metric has to be there and be more prominent

Mathieu Guindon

5:43 PM

also swimming pool temp is in Farenheight

Hosch250

@mansellan OK.

this

Why? Don't you quote air temp in C?

Mathieu Guindon

but body temp is in C

FreeMan

Still no duck hat. sad

Mathieu Guindon

@this yes, outside temp is C

this

5:44 PM

You get C for effort, I guess.

:-p

mansellan

@MathieuGuindon pfft, Kelvin ftw.

this

@mansellan do you still quote body weights in stones?

mansellan

@this yeah, almost everyone does

except the doctors usually

this

even though I use pounds, stones just is too weird

12 stones => OMG that's fat!!!!

Mathieu Guindon

are leagues still a thing?

I mean, if you still have stones...

Duga

5:54 PM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Annotations/ModuleAttributeAnnotation.cs of pull request #4642: Attribute value out of sync inspection

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Annotations/ModuleDescriptionAnnotation.cs of pull request #4642: Attribute value out of sync inspection

mansellan

@MathieuGuindon no, they're gone

We use acres for area though

Comintern

What's the retro-fan hat for? Is that for answering questions about ancient programming languages like VBA?

Oh, that's kind of lame. Taking it off.

FreeMan

@Comintern wearing mine like a bra... :)

Comintern

lol

Mathieu Guindon

6:10 PM

@FreeMan burn it! FREE man!

FreeMan

LOL!

FreeMan

7:01 PM

I got my duck sombrero!!!

Took a couple of hours. Sadly, I don't seem to be able to wear it at a jaunty angle. The rotate tool seems to be missing.

IvenBach

@Vogel612 Duck check: With Big O notation is log(foo) taken to be a base of 2?

Hosch250

7:21 PM

OK, I totally feel like Calvin right now.

My mom's approval rating is about -100 ATM.

If I could tempt her into domestic violence, I'd call the police on her, I'm so ticked.

Duga

8:05 PM

[rubberduck-vba/Rubberduck] daFreeMan opened issue #4645: False positive 'Parameter can be passed by value'

> Version 2.3.1.4327
OS: Microsoft Windows NT 10.0.15063.0, x64
Host Product: Microsoft Office 2016 x64
Host Version: 16.0.4711.1000
Host Executable: MSACCESS.EXE

This code is generating a `Parameter '{x}' can be passed by value' inspection.
```VBA
Public Property Get Url() As String
End Property
Public Property Let Url(ByVal Value As String)
End Property
```
![image](https://user-images.githubusercontent.com/11889733/50111992-1fed0180-020c-11e9-89ec-910438481c87.png)

[Rubberduc

IvenBach

@Hosch250 Keep calm and code on. Then get a separate bank account.

Hosch250

LOL.

Talking about coding on...

Isn't that pretty?

FreeMan

@Duga I'm getting a similar Parameter can be passed by value on a ByRef parameter in the interface. In the implementation, it does need to by ByRef, but I'd imagine that it will take full on code analysis to determine that...

@Hosch250 noice!

IvenBach

@Hosch250 What is that? I'm out of the loop...

Hosch250

It's a markdown render window :)

I've been working on a framework for an app to teach C# from, with a fiddle and all built right in.

So now I can write any tutorials in markdown, and it'll just work :)

It supports quote blocks, tables, italic, bold, strikethrough, superscript, subscript, inline code, code blocks, images, hyperlinks, lists (number and bullet), headers, horizontal rules, etc.

I'm thinking about putting my editor control up on NuGet.

M.Doerner

8:21 PM

@IvenBach Regarding your big O notation question, the base does not matter.

IvenBach

mkay.

@M.Doerner Why doesn't it matter? Wouldn't log(n) in base 2 have a better efficiency than if it's in base 10?

M.Doerner

log_a(x) = log_a(b^log_b(x)) = log_b(x)*log_a(b)

It's just a factor.

IvenBach

I need to write this out again. Logs were my slowerest subject. I still struggle with them.

M.Doerner

a^log_a(x) = x = b^log_b(x) = (a^log_a(b))^log_b(x) = a^(log_a(b)*log_b(x))

IvenBach

8:41 PM

Mostly see the scaling factor. Derived both ways but I can't ever retain that 'Got it.' feeling WRT logarithms.

Thanks for the refresher on log properties.

Mathieu Guindon

@Hosch250 you're not rendering comments correctly

FreeMan

Am I getting this inspection because this should be a Private Sub instead of Public sub?

It's the click event handler of a button in Access.

this

no i think that's a false positive

Mathieu Guindon

RD doesn't know there's a button

this

^

Mathieu Guindon

8:47 PM

therefore doesn't know there's a handler for the button

FreeMan

It's not firing on any of the other button handlers, all of which have an _ in them, but are Private

Mathieu Guindon

therefore the procedure looks like just any other plain old public procedure with an underscore

this

(please don't open issue for that! We have a number of them! ;-) )

FreeMan

really wants to add just one more

Mathieu Guindon

@FreeMan yes, the underscore thing is only a problem with public members

BTW handlers should be Private

this

8:49 PM

hmm that's a different problem, isn't it?

If it's really Private, it shouldn't even be firing that inspection?

Mathieu Guindon

the inspection looks for public class module members with an underscore

FreeMan

Yeah, I'd think that should be an inspection for Public event handler should be declared private, but since the duck doesn't know it's an event handler, it can't know that.

this

Yeah and the one in the screenshot is fine (for some value of "fine")

~~but this wouldn't be OK:~~ #FML #ReadFail

FreeMan

I think this is probably something our hardware guy put together wehn he tried to write some code...

:/

this

Yes, frankly, event handlers of any kind anywhere shouldn't be public.

Mathieu Guindon

8:51 PM

when you double-click a button, VBE makes a handler procedure automatically, and it's Private. no handler will ever be Public unless someone went and made them so

for no reason at all

FreeMan

I'd imagine he made it so... #1

this

Many people don't realize they can create their own procedure and call that and just change Private to Public and call it "problem solved"

Mathieu Guindon

unless they're invoking the handler from somewhere else, which is all kinds of wrong

FreeMan

lord only knows.

this

^ that's where you should make a new procedure.

FreeMan

8:52 PM

set it back to private and "problem solved"!

Mathieu Guindon

@FreeMan actually, if it's invoked by something somewhere, RD knows

this

Nothing wrong with calling it from an event handler; just don't call it directly from the outside.

Mathieu Guindon

@FreeMan yes

assuming 0 references

FreeMan

@MathieuGuindon lol...

this

@MathieuGuindon Freeman, note that if that's not true and you delete it anyway, it makes an ass out of you and Merciless Ming.

FreeMan

8:53 PM

Yeah, he just copy/pasta'd a whole form hid 99% of the buttons and went to town.

not sure who the Merciless Ming are, but that seems like an offense I'd like to avoid making...

this

old villain of some superhero

Mathieu Guindon

well, if making it Private makes the project uncompilable, you know it's invoked somewhere. but an easier way is to look at what the RD toolbar says

:)

this

I want to say Flash but I'm not entirely sure.

FreeMan

@MathieuGuindon not so sure about that... none of the button click handlers show a reference count > 0. Even ones I know are used.

Hosch250

@MathieuGuindon Sure I am.

FreeMan

8:58 PM

I know its used because Access takes me to the procedure when I click on the [...] icon

Hosch250

Also, I didn't set the colors--that's the default theme.

Mathieu Guindon

@Hosch250 nope. well, not in that .gif anyway :)

Hosch250

I could change change it.

But I don't want to bother.

And it is green...

Mathieu Guindon

<!-- campaign is no longer accepting donations <~ shouldn't be showing up

<!-- campaign is no longer accepting donations
### Donate!

If you like this project and would like to thank its contributors, you are welcome to support our GoFundMe campaign to finance Rubberduck swag and international shipping - contributors will be getting t-shirts, mugs, and other cool things.

[![GoFundMe campaign](user-images.githubusercontent.com/5751684/…
-->

should probably be removed....

Hosch250

@MathieuGuindon That's an HTML comment.

It means nothing in markdown.

It'll (not) render in an HTML document because that's how HTML works.

Mathieu Guindon

9:01 PM

...then I would't expect to see actual images

Hosch250

I thought you meant the comment in Avalon edit.

@MathieuGuindon An image is an image.

I just have to provide the URI.

.NET can figure out if it's a relative or absolute URI and take care of downloading it and everything.

Vogel612

I see max got to it. Generally speaking the log is most likely to be base 2, but for certain problems it could be something else. It's not relevant under big O anyways 😊

Mathieu Guindon

a .md render would translate the ![image](url) into an <img> tag AFAIK

Hosch250

And I did change one of the images from HTML to markdown.

That top one.

@MathieuGuindon I'm doing my own render.

I'm using MS's parser to parse it and I convert each element recursively into the proper block or inline WPF element in a richtextbox.

I'm going to post it on CR in a day or two.

Mathieu Guindon

.md to .rtf huh

Hosch250

9:04 PM

Yeah.

Mathieu Guindon

should still strip html comments imo

Hosch250

I probably could, TBH, but I'm not sure I want to go there.

Mathieu Guindon

or any non-handled html content actually

Hosch250

Because if I go there, then I have to convert other HTML elements too.

Mathieu Guindon

only those you care to handle - <img> for example

Hosch250

9:05 PM

And this parser just gives me those as raw text, and I'm not building an HTML parser to find (malformed) HTML.

M.Doerner

@Vogel612 Am I correct that rebasing my current PR now on next would be a good idea?

Hosch250

I figured anyone that ends up using this has access to the content anyway.

Mathieu Guindon

.
.
R̢̯̝̯̦͈͈͋̐̉͛̀̄͑͜͜ͅẻ̲͉̗̗̰̼͂̾̀̓͐̽͞g̳̘̟̙̲͇̬̼̿̒̑̐̒̍͜E̢͕̪̘͕͚̽͛̏̋̒̑͘͘͘͝ẍ̡̡̛̰͇̙̅̀͑͌̕
.
.

Hosch250

So they can check it and do what they like before they pass it to my tool.

M.Doerner

The branch it was based on has just been merged into next.

Hosch250

9:06 PM

Also, did you know hyperlinks can have tooltips?

Mathieu Guindon

yeah...

Hosch250

[MSDN](http://msdn.com MSDN)

My tool renders that tooltip correctly when you hover on the link :)

(MS's parser parses the tooltip for me.)

Mathieu Guindon

SO doesn't

GH doesn't either

this

how many flavors of MDs are there actually?

Mathieu Guindon

yay, another Markdown standard!

@this one. GitHub flavor. all others are wrong.

this

9:09 PM

This shall be named MD Code Red

lol

only that I understood there to be mainly 2

GH and SO

Mathieu Guindon

^

Hosch250

GitHub's is the standard.

Mathieu Guindon

then "mini-markdown", in SE chat

but yeah, if everyone just started using GitHub's ... looking at you JIRA ...

Hosch250

Actually, GitHub does support the tooltip. Except you put "'s around it.

[Attributions](https://github.com/rubberduck-vba/Rubberduck/blob/next/docs/Attr‌ibutions.md "Attributions")

Working from memory...

FYI, Manning has 50% off all ebooks.

Duga

[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #4642: Attribute value out of sync inspection

Vogel612

9:12 PM

@M.Doerner which of the two?

M.Doerner

Just did it and it looked plausible.

The first branch got merged.

Vogel612

Generally speaking: yes. Has the chance of making the diff significantly cleaner

Mathieu Guindon

@M.Doerner is #4642 good to go? I'd rather merge it sooner than later, since the "part one" is already in

M.Doerner

The branch I branched from that is the open PR.

Cleaning up the diff was my goal.

this

now that makes much sense. I was wondering why it didn't change when the first PR got merged

M.Doerner

9:14 PM

Let's wait for the bulid and see whether I messed something up with my first rebase ever.

Mathieu Guindon

sure :)

and with that, we're no longer losing member attributes on rewrite, correct?

M.Doerner

No

We still lose them.

Mathieu Guindon

aw

Vogel612

@M.Doerner if you didn't need to resolve conflicts it should be just fine :)

M.Doerner

As I said before, wiring that up in the rewriting manager is a bit more involved.

The log actually looked exactly the way I wanted it to look.

Mathieu Guindon

9:16 PM

in any case, just getting what you've got there in the state it's currently in, is a massive accomplishment

this

^

M.Doerner

I still think that the actual trick got merged already a few months ago.

Vogel612

And with that I'm off to bed. Gotta sleep away that lurking cold before it really hits me hard

M.Doerner

Gute Besserung!

Mathieu Guindon

@Vogel612 'night! (haven't seen ya get to bed that early in ages!!)

Vogel612

9:18 PM

Yesterday was even earlier

I slept for 10 hours and another two or so earlier this evening

Mathieu Guindon

woot, got my rubber ducky hat! #represent

M.Doerner

If anybody wants to have another look at the smaller diff, feel free. Otherwise, my PR should be good to merge, pending the build.

Mathieu Guindon

I'll likely merge it tonight, barring anyone finding any showstoppers

M.Doerner

And I will start to rewrite the annotation scoping system yet again.

Mathieu Guindon

looks pretty damn neat from the client side (e.g. inspections) though

M.Doerner

9:30 PM

The problem with the current system is that removing the annotations from a member annotation line and leaving the comment breaks all member annotations above.

The idea is to simply take all member annotations below the last logical line of the previous member.

Module annotations are treated differently now anyway.

Mathieu Guindon

that, and we might eventually need a consolidate annotations "refactoring"

I mean, to turn a 3-line, 3-annotations comment block into a 1-liner, 3-annotations comment.

M.Doerner

Identifier references will get a consistent behaviour in thet they can be in any contiguous whitespace right above the identifier.

Mathieu Guindon

(and then maybe an expand annotations operation that does the reverse)

Dim foo '@Description("is this scoped to foo?")

M.Doerner

The first one would have to be deactivated for annotations with comments.

No

Whitespace above the member.

Duga

[rubberduck-vba/Rubberduck] build for commit 59c2a334 on unknown branch: AppVeyor build succeeded

this

9:35 PM

IMO, the procedure separator you see in VBE is the bar to meet. If annotations is above the line, then it's with that previous procedure, not in the current procedure.

Otherwise, it only will confuse the users.

Mathieu Guindon

having a comment above a procedure makes that comment part of the procedure as far as VBE is concerned

this

yes but not always per our grammar

Public Sub Bar()
...
End Sub
-------------------

'@Description("foo")

'@Exposed

Public Sub Foo()

End

AIUI, under the present system the @Description (and possibly also the @Exposed would be incorrectly scoped to Bar, because of whitespace.

Mathieu Guindon

really?

M.Doerner

No

Currently, none of them gets scoped to anything.

@Expose is a module annotation, which has to be above the first member to be valid.

Mathieu Guindon

and @Description misses its scope because of the whitespace under it

..which is fine IMO

M.Doerner

9:43 PM

@Description is not in a contiguous block of member or identifier annotations above a member.

The unintuitive one is the following.

'@Description "Desc"
'The caller has to make sure the input is of a value type.
Public Sub Foo(arg As Variant)
End Sub

Duga

[rubberduck-vba/Rubberduck] retailcoder created comment on pull request #4642: Attribute value out of sync inspection

> I'm kind of torn about handling member attributes synchronization, given we lose them on rewrite... module attributes can work, but member attributes... OTOH, if there's an annotation and the attribute gets wiped accidentally, it's nice to have an inspection result to tell us "hey that module's members don't have the attributes they're supposed to have anymore".

this

@M.Doerner argh, bad example

@MathieuGuindon IMO, that's not fine. User sees the procedure separator and are told that it's not in scope?

M.Doerner

Really, I think emulating the procedure separator is not that hard.

My idea is based on the endOfStatement the annotation is contained in.

this

yeah that should work, I think.

M.Doerner

It will have to end on the first line of the member or variable.

There is just one condition: the annotation must not be part of the first endOfLine.

With one exception: the start of the file.

this

9:51 PM

which is only the case if the module does not contain any Option or any other declaration element, right?

M.Doerner

The condition makes sure that it is at least one logical line below the previous member or variable.

Oh

Hm, do you want to allow variable and member annotations above Option statements?

Anyway, that is only a concern for the first member or variable.

this

Also, did I understand that there may be some legal member annotations for elements within the (Declarations) section?

M.Doerner

I think you can put member annotations on Declare statements.

Moreover, you can put variable annotations on module variables.

this

@M.Doerner that implies for the elements within the (Declarations) section, the rule will have to be different

M.Doerner

Why?

this

9:55 PM

the endOfStatement idea would only work for those outside that section.

M.Doerner

Why?

this

I was thinking that in that section, it becomes more ambiguous but I'm doubting myself.

M.Doerner

It contains all contiguous whitespace between the enclosing statements.

this

I initially thought because there's no procedure separator line in that section, it would not be as clear but I think with what you're proposing, it'll just work the same way, even without a visual line present.

'@Description("this is not scoped to anything")

Option Explicit


'@Description("this is scoped to foo")

Private Declare Function Foo....

'@Description("this is scoped to bar")

Private Declare Function Bar....

Mathieu Guindon

@this the first would actually be illegal IIUC

M.Doerner

9:59 PM

Not scoped to anything => illegal

Transcript for