VBA Rubberducking

Cache deserialized ComProjects in the tests instead of declarations

Previously, we statucally cached serialized declarations we loadedfrom file in tests to avoid loading several MB of text files multiple times in different tests. This is no longer sensible because we derserialize ComProjects now and generate the declarations based on them.

this

@Comintern there, you now have your fall guy.

Duga

[rubberduck-vba/Rubberduck] MDoerner pushed commit c80cc17a to next

Merge branch 'next' into FixDeserializedObjectCachingInTests

# Conflicts:
# Rubberduck.Parsing/Rubberduck.Parsing.csproj
# RubberduckTests/RubberduckTests.csproj

[rubberduck-vba/Rubberduck] web-flow pushed commit 126d05d0 to next

Merge pull request #4441 from MDoerner/FixDeserializedObjectCachingInTests

Cache deserialized ComProjects in the tests instead of declarations

Comintern

LOL. Taking that as a no then.

this

there are few other PRs that should be merged, too, I think...

Comintern

11:11 PM

Yeah, that one was holding up work on inspections that need functioning tests.

Oh, crap. #4452 has a nice little twist - the indenter can change the line count. Not just as easy as caching the selection from the active pane.

this

BTW, any objections to merging the serialize enhancement PR I opened? I would like that in for my next PR

Comintern

I'm all good.

this

The trouble is I ~~can't~~ shouldn't merge my own PRs....

Comintern

Did M.Doerner have anything outstanding on review?

this

i'm not sure he had a chance to review.

Comintern

11:19 PM

Yeah, there was a comment re the possibility for hash collisions.

I don't think that's in the current PR though.

this

uh, i think that's different PR

Comintern

#4426?

this

no #4443 which was merged already.

Comintern

github.com/rubberduck-vba/Rubberduck/pull/4426/files/…

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Rubberduck-v2.2.0.4029

Comintern

11:23 PM

That commit?

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Rubberduck-v2.2.0.4029

Comintern

I think it's obsolete.

Duga

[rubberduck-vba/Rubberduck] build for commit 126d05d0 on next: AppVeyor build succeeded

this

yes, should be.

invalidated by this commit: github.com/rubberduck-vba/Rubberduck/pull/4426/commits/…

Comintern

Yep. I'm good.

Duga

11:27 PM

[rubberduck-vba/Rubberduck] comintern merged pull request #4426: Introduce Serialize method for COM Safe from bclothier/Rubberduck/ComSafeSerialize into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] comintern pushed 12 commits to next (only showing some of them below)

[rubberduck-vba/Rubberduck] bclothier pushed commit 20d8a4e2 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into ComSafeCleanup

[rubberduck-vba/Rubberduck] bclothier pushed commit 71f43ce1 to next: Add stack tracing and make a big mess of WeakComSafe - need to be refactored

[rubberduck-vba/Rubberduck] bclothier pushed commit 9d288f04 to next

Extract all the mess and try to hide it away in an abstract base class.
Modify StrongComSafe to be more consistent with hashing.

[rubberduck-vba/Rubberduck] bclothier pushed commit d3c80c99 to next: Restore the original dictionary design to StrongComSafe and adapt the GetWrappers method instead

[rubberduck-vba/Rubberduck] bclothier pushed commit df89aaf1 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into ComSafeCleanup

[rubberduck-vba/Rubberduck] bclothier pushed commit 1d47b077 to next

Clean up the flawed trace implementation
Convert trace into a stream to avoid caching all trace in memory
Overload the Serialize button to serialize both the project declaration and the COM safe's contents/trace logs
Provide some safety around the tracing and fix various one-off errors

[rubberduck-vba/Rubberduck] bclothier pushed commit 2872a051 to next

Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck into ComSafeCleanup

# Conflicts:
# Rubberduck.VBEEditor/Rubberduck.VBEditor.csproj

[rubberduck-vba/Rubberduck] bclothier pushed commit 54358bfa to next: Address PR review comments, add XML docs about DEBUG

[rubberduck-vba/Rubberduck] bclothier pushed commit e62dcefa to next: Reverse the condition on string.IsNullOrWhitespace (doh!)

[rubberduck-vba/Rubberduck] web-flow pushed commit 2a47a4d4 to next

Merge pull request #4426 from bclothier/ComSafeSerialize

Introduce Serialize method for COM Safe

Duga

11:41 PM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Rubberduck-v2.2.0.4030

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Rubberduck-v2.2.0.4030

[rubberduck-vba/Rubberduck] build for commit 2a47a4d4 on next: AppVeyor build succeeded

this

11:52 PM

Yikes! Apparently CE is leaking most of the stuff

596 incidents for Rubberduck.Navigation.CodeExplorer.CodeExplorerComponentViewModel::ContainsBuil‌tinDocumentPropertiesProperty

and this looks so innocent....

    private bool ContainsBuiltinDocumentPropertiesProperty()
    {
        var component = _projectsProvider.Component(Declaration.QualifiedName.QualifiedModuleName);
        using (var properties = component.Properties)
        {
            return properties.Any(item => item.Name == "BuiltinDocumentProperties");
        }

Comintern

Yeah, that's not good.

Hosch250

Hmmm.

Comintern

HTH do you find out if the currently active window is a designer?

Hosch250

That .Any, right?

this

yeah

Hosch250

11:56 PM

And maybe a using around the component, or is that good?

this

no it's OK because it comes from the provider

it's the property that needs to be used

changed to....

        private bool ContainsBuiltinDocumentPropertiesProperty()
        {
            var component = _projectsProvider.Component(Declaration.QualifiedName.QualifiedModuleName);
            using (var properties = component.Properties)
            {
                foreach (var property in properties)
                using(property)
                {
                    if (property.Name == "BuiltinDocumentProperties")
                    {
                        return true;
                    }

@Comintern isn't there supposed to be a property for that?

Comintern

@this One would think...

Found it.

this

i'm probably thinking from the wrong end - i might be thinking of the component, rather than window.

Transcript for