> not using vbWatchDog. I do use MZ-Tools but even if I unload it Rubberduck still gives me a parsing error.
I've just created a macro with one module, containing [function addTwoNumbers(a,b) as double] => obvious code
Rubberduck did not give me a parse error. I then added a test module through the Rubberduck dropdown, reparsed and got a parse error. if I remove the test module, the parse error persists. if I close and re-open, the error persists.
> not using vbWatchDog. I do use MZ-Tools but even if I unload it Rubberduck still gives me a parsing error.
I've just created a macro with one module, containing [function addTwoNumbers(a,b) as double] => obvious code
Rubberduck did not give me a parse error. I then added a test module through the Rubberduck dropdown, reparsed and got a parse error. if I remove the test module, the parse error persists. if I close and re-open, the error persists.
> I suspect an IOException (or something derived from it) in the preprocessing stage - logs can get very verbose at TRACE level, but they also tell us the most about the sequence of events. We use NLog for logging, it handles all the archiving automatically, and we set it up to clear the current log everytime RD starts, which works well for diagnosing issues.
So I got an error object from rtcErrObj() and called .Raise from managed code. Which resulted in an unhandled managed throw with the same error code that I raised. Are you kidding me?
> The wording is unfortunate. The requirement is the CLR (the .net runtime), not the .net framework. There is no "CLR 4.5", both .net 4 and .net 4.5 run off CLR version 4.0.30319.
OK, this is messed up. I might need to throw an unhandled managed exception and set the hresult manually so that it marshals to an unmanaged exception.
FML. This is a complete catch-22. If I call Err.Raise in a try-catch block, it gets flagged as "handled" before it reaches the VBA runtime. If I don't use a try-catch block, it's unhandled in managed code and reaches VBA as a generic COM server error.
@IvenBach Not at all - The guy doesn't even need to know what HTTPS or SQL-injection are. His biggest fail was telling the internet that his site was unbreakable.
> FWIW - in a project, our developers ran into a weird issue where the temp directory wouldn't be consistent, especially in a RDP environment. That is, calling %TEMP% may return one path ending with ...\Temp\01 then next time it's now ...\Temp\02. Thus it can be a mistake to assume that the %TEMP% won't change within a session. Just throwing this out in case this is relevant given that the parsers are using temporary directories.
> seems the error might not be related to the file system at all - This is from VBE6 and Access 2000, but it suggests that the error relates to a compile error:
> Without getting into the mundane details, the basis of the problem is a conflict between Access 2000 and version 6.3.91.8 of the Vbe6.dll. This conflict prevents certain code modules from compiling and runn
I wonder if this error is only occurring on files that have been saved *after* Rubberduck processing, and that are later re-opened? Could it be that the export/import process is occurring too fast for the VBE to keep up, or possibly before the project is ready to export, and Rubberduck inadvertently corrupts the project?
> Or maybe the file is corrupt, and we're assuming the message is because of something RD is doing? Maybe the message is appearing because the file is corrupt, and would have appeared whether RD was loaded or not?
This SO answer suggests that the file can be recovered.
http://stackoverflow.com/a/41689709/5757159
> I just came across this error, using the option to "Open and Repair" from the drop-down on the button on Excel's "Open" dialog fixed it for me.
> Thunderframe, It's certainly possible a file can be corrupt, although usually I see a blank Error 400 when that happens rather than a network error. That's why I repeated the test after removing the RD addin, to verify that there was no error. There are a number of MS forum reports about network errors (Document not saved) so there might be some bug in Excel that nobody has pinned down yet. I don't know the RD code, but those discussions about race conditions between RD and the VBE sound like
> @SystemsModelling you can just drag & drop a file to attach it to the current comment. It doesn't work for all filetypes, but txts should work just fine. Usually I go around and extract the stacktraces from logs for simplicity anyways ...
Note that you can press the little stylus on the top right of your comments to edit them. This allows seeing the actual markdown itself. for the codeblocks I used to use the four-space-indent as it was common on StackExchange, but github uses "fences" lik
> Start with RD NOT loaded in Addin Manager Start Excel, new Book1. Alt+F11 to see VBE Alt-Tab back to Excel UI. Open a .xlsm, see it in UI, as expected.
Now load RD 2.0.13, restart Excel. Repeat test AltF+F11 shows RD splash Alt-Tab back to Excel UI. Open a .xlsm, VBE window is brought to front.
> Just looked into the log. An interesting entry: `2017-03-21 09:44:56.3238;DEBUG-2.0.13.32288;Rubberduck.Parsing.VBA.RubberduckParserState;Project '㼿㼿' was added.;
Later in that log, an error was logged. Duh, I've just seen the prompt below "Attach files by dragging & dropping, ..." [Error extract.txt](https://github.com/rubberduck-vba/Rubberduck/files/857680/Error.extract.txt)
> Hello, I'm relatively new to VBA and I recently installed Rubberduck for my CorelDRAW VBA environment. I'm using CorelDRAW X7 on Windows 7 64bit.
I tried to run Rubberduck for the first time, after doing some registry workarounds to make it load in my 64 bit IDE. It works, but I stumped by Parse Error hence leave most of Rubberduck features unusable.
Here's pastebin to the log file >> http://pastebin.com/wFwMbW6v
Thank you, looking forward to be able to use this powerful add-in..!
2017-03-21 17:15:25.1471;ERROR-2.0.13.32288;Rubberduck.Parsing.VBA.ComponentParseTask;Exception thrown in thread 24, ParseTaskID 6ed1af23-86ba-4b8f-bac8-a021c2075efd.;System.ArgumentOutOfRangeException: Length cannot be less than zero. Parameter name: length at System.String.Substring(Int32 startIndex, Int32 length) at Rubberduck.Parsing.Preprocessing.LivelinessExpression.MarkAsDead(String code) in C:\Users\Mathieu\Documents\GitHub\Rubberduck (main)\Rubberduck\Rubberduck.Parsin
> There are some additional parse-errors, namely in the modules: frmTiling, frmProgress, frmCTP and CSVReader. Are you 100% sure that the code does compile and work, especially on all precompiler-directive combinations?
> I've successfully installed that tool that seems to be pretty awesome, but **I can't manage to get it to parse anything**... I've tried letting VBE opened for hours with a basic project (one sub with Debug.Print), and still pending...
It is **stuck on "Pending"** ("Pending. Click to refresh."), and **nothing happen when I click it**.
The only thing that I seem able to do (sometimes, then I can't again) is to add a modules or userform.
> Just now, I was looking at an xlsx tab on a phone call not touching the keyboard and suddenly the VBE window came in front again. Just as well I wasn't sharing the screen :-) The RD button then changed to Ready, so it must be RD bringing the VBE to the front.
> Just now, I was looking at an xlsx tab on a phone call not touching the keyboard and suddenly the VBE window came in front again. Just as well I wasn't sharing the screen :-) The RD button then changed to Ready, so it must be RD bringing the VBE to the front.
> I open a wb, into VBE, click Pending, status goes to Parsing and stops, stays greyed out.
Add a dummy code line, it suddenly wakes up and goes to Ready. Click Refresh, parses and goes to Ready as expected.
No errors, but some Warnings. Too many to paste, but here's a few. Do they matter?
`2017-03-21 11:53:06.3114;WARN-2.0.13.32288;Rubberduck.Parsing.Symbols.TypeAnnotationPass;Failed to resolve type ProcCall; 2017-03-21 11:53:06.6424;WARN-2.0.13.32288;Rubberduck.Parsing.Symbols.Ident
> Although the double headed (N-S) arrow cursor appears when I hover over the bottom frame, I can't increase the height of the Navigation window by dragging the bottom frame, only the bottom right hand corner where the cursor is NW-SE. The horizontal drag (W-E) works to widen it.
Feature request: Can I have it opened at the last size I set it to?
> I have a UserForm with a CommandButton `CommandButton1`, that is shown in Object Browser as being declared in my UserForm as `WithEvents CommandButton1 As CommandButton` but VBA has extended **all** of the `Control` members to the instance, so usages of `CommandButton1` or `Me.CommandButton1` give you access to all of the `CommandButton` members and all of the `Control` Members. Eg. `Control`'s `Height` and `_GetHeight` members are both available.
> The way the VBE handles its toolwindows is... Let's just say if it were intuitive we wouldn't be having half the teardown issues we're having ;-)
I believe a single clean exit is all it takes for it to remember what was where; my work laptop install seems to leave everything where I left it. Not sure what we can do about these resizing quirks - at least not without a shot of the VBE toolwindow layout.
> When I use Rubberduck in CorelDRAW X6, I have to unload all of the GlobalMacros as at least one of the GlobalMacros has something that is causing a ParserError, and I haven't been able to work out what it is yet.
no problem at all - I put CC-by-SA because I had originally published pretty much all of it on Stack Overflow & Code Review where it's CC-by-SA per SE's ToS... for all I care it could be public domain :)
So my two main questions: - Could you have a look and tell if you are fine with me releasing that stuff (which was originally based on yours) under a different license? I do intend to give credit. - The one big chunk that's left that I did not change is Strings.format. Should I remove that or are you ok with relicensing?
I couldn't find one anywhere, so I made my own:
Public PADDING_CHAR As String
Public Function StringFormat(format_string As String, ParamArray values()) As String
'VB6 implementation of .net String.Format(), slightly customized.
'Tested with Office 2010 VBA (x64)
Dim return_value As St...
Also: There is currently a discussion about changing the license in SO code snippets. The state of that discussion is: Using SO codereview does NOT force the questioner to loose any rights of his code. They do discuss adding a second code license (MIT I think)
Context
I'm working on a little project that consists in a series of Microsoft Excel add-ins (.xlam). The code being submitted for review here, is located in the Reflection project:
Feel free to comment on the project architecture, but I'm mostly interested in the Reflection.LinqEnumerable cl...
Dim accumulator As Delegate
Set accumulator = Delegate.Create("(work,value) => value & "" "" & work")
Debug.Print LinqEnumerable.FromList(List.Create("the", "quick", "brown", "fox")) _
.Aggregate(accumulator)
> fox brown quick the
basically it takes the lambda string and literally creates an "anonymous function" at runtime, runs it, and then destroys it
performance probably sucks big time, but I didn't write that for performance... I wrote it because I could :)
@patszim BTW, have you tried Rubberduck?
@patszim huh, I don't even remember what that one is... that's probably some exploratory project I put up on GH in the couple of weeks that led to Rubberduck kicking off.
@jkpieterse - Keep in mind that you're the one that felt compelled to comment on my definition of "best practise", not the other way around. I also never used the term "best practise" - I'm saying that it creates a "readability issue", particularly with the code in question. If I'm reviewing code and find that it's hard to read, I'm going to call it out as hard to read. If I'm going to "pick a method and stick to it", it's going to be "write code that is easy to read". Of course you're perfectly entitled to your opinion - I'll look forward to reading more about it in your review. — Comintern20 secs ago
> Outstanding technical community members are nominated by their peers, Microsoft employees, and MVPs. Each year a panel of Microsoft employees reviews the contributions of each nominee for quality, quantity, and level of impact on the technical community.
It actually looks like a hassle from some of the descriptions: "With the introduction of a site dedicated to MVPs, it is now easier to locate an MVP from a specific country and from a specific area of expertise."
I would imagine they'd expect you to answer one or two of those...
sooner or later I'll be tweeting to Microsoft to ask them WTF is up with their VBE, why RD keeps crashing it for stupid reasons and what we can do to work around the VBE's clumsiness.
Disclaimer: I'm heavily involved with the development of the Rubberduck add-in.
You did nothing wrong =)
In earlier alpha 2.x releases we discovered that launching the initial parse on startup was causing problems (violent crashes), because the add-in was, essentially, ready before the VBE ...
@patszim latest release 2.0.13 means to launch the initial parse automatically (doesn't consistently work though for some reason), which should enable all the menu commands. pre-.13 you need to trigger the initial parse manually by clicking the "Pending" parser state button in the Rubberduck commandbar =)
(^ not your day-to-day SQL Injection hack, it happened because an employee of the company filed a bug with Firefox telling them to stop warning about http login/credit card pages on the company's site, saying the company had their own "security system" and hadn't been hacked in 15 years. Needless to say Bobby was all over that and the users table was dropped in short order.)
> I have a thought about cleaning up the mess with injecting quick fix dependencies into the inspections. This is a total mess; we need to make the quick fixes call the inspection result, not vice-versa (the current way). So, suppose we told each quick fix what inspection result types it could fix and gave it a `Fix` method that took a result, like so: ``` public interface IInspectionQuickFix { List<IInspectionResult> CanFix { get; } void Fix(IInspectionResult target); } ``` Now
> ok! Here's a log output from when I click the refresh button in the ribbon. [RubberduckLog.txt](https://github.com/rubberduck-vba/Rubberduck/files/858866/RubberduckLog.txt)
> ok! Here's a log output from when I click the refresh button in the ribbon. [RubberduckLog.txt](https://github.com/rubberduck-vba/Rubberduck/files/858866/RubberduckLog.txt)
> The first log is relevant to the parse error and point to line 746, column 23 of module "AppVariables". It looks like it's failing on some sort of declaration. Are there a couple lines around there that can be shared? If not, how about the same syntax with only the variable names \ literal values changed?
The second log is a bit more puzzling - from that one it looks like we tried to load a library from a referenced project or library, but couldn't load it because the typelib wasn't regi
> Here is the whole thing with the lines in tact, redacted where necessary. this entire module is global variables. my ego insists that I notify you that this is legacy code I maintain. :) [AppVariables.txt](https://github.com/rubberduck-vba/Rubberduck/files/858966/AppVariables.txt)
if is RD looking at the first line as "Attribute VB_Name = "AppVariables"" then line 746 is "Public arySV(300, 7) As Variant" column 23 is where there is a double space before "As Variant" I'm surprised tha
> Here is the whole thing with the lines in tact, redacted where necessary. this entire module is global variables. my ego insists that I notify you that this is legacy code I maintain. :) [AppVariables.txt](https://github.com/rubberduck-vba/Rubberduck/files/858966/AppVariables.txt)
if is RD looking at the first line as "Attribute VB_Name = "AppVariables"" then line 746 is "Public arySV(300, 7) As Variant" column 23 is where there is a double space before "As Variant" I'm surprised tha
> I like what @Hosch250 proposes above. However, I would take it one step further and inject an IQuickFixHandler into the view model and inject all the quickfixes into its implementation. I think the view model itself should not know the details of how applying the quickfixes works. It should just translate the input and pass it on to somebody else who knows.
> @connerk - We've had issues with the potential ambiguity in the VBA grammar between array subscripts and procedure argument lists. I'm pretty sure it's some combination of multi-dimensional fixed array, `Public` declaration, and "strong" (or in this case explicit) typing.
Thanks for providing the file - that helps tremendously.
Referring to the actual project: _Do you reference anything that isn't a library? For example, an .xlam file?_ => NO _Do you reference anything that isn't on the local machine - i.e. a registered library from a network share?_ => NO _Do you have any of the Rubberduck COM APIs referenced?_ => late bound RubberDuck.AssertClass
if I open a brand new book (no modules): refresh => success add test method through RD menu, early binding => parse err
Referring to the actual project: _Do you reference anything that isn't a library? For example, an .xlam file?_ => NO _Do you reference anything that isn't on the local machine - i.e. a registered library from a network share?_ => NO _Do you have any of the Rubberduck COM APIs referenced?_ => late bound RubberDuck.AssertClass
if I open a brand new book (no modules): refresh => success add test method through RD menu, early binding => parse err
```` 2017-03-21 10:26:34.8598;ERROR-2.0.13.32288;Rubberduck.Parsing.VBA.ParseCoordinator;Unexpected exception thrown in parsing run. (thread 13).;System.Runtime.InteropServices.COMException (0x8002801D): Library not registered. (Exception from HRESULT: 0x8002801D (TYPE_E_LIBNOTREGISTERED)) at Microsoft.Vbe.Interop.Reference.get_FullPath() at Rubberduck.VBEditor.SafeComWrappers.VBA.Reference.get_FullPath() in C:\Users\Mathieu\Documents\GitHub\Rubberduck (main)\Rubberduck\Rub
> Nah, I don't think it would fix anything - looks like Rubberduck doesn't like loading its own type library at runtime; we have a plan to use actual .net reflection to pull the COM-visible declarations from Rubberduck.dll instead of loading the Rubberduck.tlb referenced type library: this is a known (but intermittent and not really explained) issue with parsing a project that has an early-bound reference to Rubberduck's API.
> A reinstall probably won't help, although we've also run into a couple instances where RD has difficulty loading its own typelib with a LoadLibrary call. Linking #2789
> ah. seems like if it has Ever been early bound it will error ever after. I dont' see any RD in the references 
and have ensured all assertClass's are late bound. still getting the parse error ``` 2017-03-21 10:38:05.6380;DEBUG-2.0.13.32288;Rubberduck.Parsing.VBA.RubberduckParserState;RubberduckParserState raised StateChanged (ResolvingReferences); 2017-03-21 10:38:05.8944;ERROR-
> ah. seems like if it has Ever been early bound it will error ever after. I dont' see any RD in the references 
and have ensured all assertClass's are late bound. still getting the parse error ``` 2017-03-21 10:38:05.6380;DEBUG-2.0.13.32288;Rubberduck.Parsing.VBA.RubberduckParserState;RubberduckParserState raised StateChanged (ResolvingReferences); 2017-03-21 10:38:05.8944;ERROR-
> @connerk hmm this looks like a bug in the declaration finder - could the project happen to be named exactly as one of the class modules under it?
---
FWIW I pasted `AppVariables.txt` in a new module and it parsed without any issues here. `arySV` is recognized as a `Variant`, but it seems to fail to recognize it as an array:
> @connerk hmm this looks like a bug in the declaration finder - could the project happen to be named exactly as one of the class modules under it?
---
FWIW I pasted `AppVariables.txt` in a new module and it parsed without any issues here. `arySV` is recognized as a `Variant`, but it seems to fail to recognize it as an array:
> @connerk hmm this looks like a bug in the declaration finder (well in the `TypeHierarchyPass` anyway) - could the project happen to be named exactly as one of the class modules under it?
---
FWIW I pasted `AppVariables.txt` in a new module and it parsed without any issues here. `arySV` is recognized as a `Variant`, but it seems to fail to recognize it as an array:
> if I put AppVariables into a fresh workbook I also don't get a parse error. be advised though, I did fix the "[double space] As Variant" script though if I add the extra space back it still doesn't error
> The double space shouldn't matter, our grammar is (mostly) written against the VBA language specifications, not against what the VBE turns processed code into (although we *do* have a few hacks that rely on it).
I'm positively confused now.
````csharp private void AddImplementedInterface(Declaration potentialClassModule) { if (potentialClassModule.DeclarationType != DeclarationType.ClassModule) { return; // this guard clause SHOULD prevent the InvalidCastException yo
how the F does Unable to cast object of type 'Rubberduck.Parsing.Symbols.ProjectDeclaration' to type 'Rubberduck.Parsing.Symbols.ClassModuleDeclaration'. happen here? a ProjectDeclaration can't even possibly make it this far into the method!!
Those also the only 2 usages, so the only way that can happen is if we're creating a ProjectDeclaration, but setting the DeclarationType == DeclarationType.ClassModule
I'm not disputing any of that. I just have no clue what you're referring to when you say "because it cannot obfuscate object model calls". — Comintern1 min ago
So wait, you have nuke launch codes in a macro-enabled worksheet? At the end of the day if a computer can run it, a decompiler can decompile it. Your question is unclear, it's more of a statement than anything else. Or are you looking for "real opinions" on these tools? The server solution seems like the only solution - run the code on your servers if you don't want your clients to access it in any way shape or form. Not sure where VBA/Excel fits in though, and that seems way overkill. And if it's meant to be called from Excel, you're killing performance to profit security. Life is a balance! — Mat's Mug6 secs ago
I have a super secure awesome gizmo. So secure, nobody can use it.
Either that or "I protect my IP by ham-stringing the application you paid me to spend a year and a half writing. Should have thought of that earlier. Oops."
If 1 person can crack the Unviewable security, then security is broken. If the 1% can crack the security, then security is easily broken. Hint: Unviewable plus uses a decoy VBAProject.bin, and a number of other techniques, but the code can be easily extracted using freely available open-source tools. The VBA file format spec is published by Microsoft. Anybody with a spare afternoon could read the file. — ThunderFrame2 mins ago
^ given @ThunderFrame-grade naming, it has to be that way
@Zerk a hex editor is overkill. this solution "simply" hijacks the password prompt through a clever Win32 hack, to make the VBE think the correct password was entered - it's not even trying to brute-force or hash-collide the actual password. I regularly use it to unlock "protected" VBA projects we own but for which we lost the passwords. VBA project protection is an annoyance for the dev, and a joke for everyone else. — Mat's Mug21 secs ago
The SimpleNameTypeBinding trys to bind in the following order: udf in enclosind module -> enum in enclosing module -> enclosing project -> referenced project -> standard module in project -> class in project -> ...
@Hosch250 oh, I don't have the slightest idea - that's essentially making an "extension API" that other .net projects can reference.. we need to discuss what extension points need to be exposed
and before that, the menus need to GTFO of RubberduckModule
@M.Doerner that seems correct. but does a TypeBinding returning a ProjectDeclaration make sense?
Comintern I am required to standardised it in a particular format. Particuarly in a row and when the new user wishes to add more content, they can. I want the button or function to be easily clicked or run so it takes that content and produces the result I need. Then I can use it for automation purposes. — user756804210 mins ago
FYI when you want someone to be notified of a reply, use @TheirName to do so. Anyway declare i as a Long, not an Integer, and if you know which row you need to stop at then as people have been telling you, you need a For i = start to finish loop, where finish is, I guess, your LastRow. I'm voting to close this question as unclear what you're asking until you edit it to clarify exactly what "doesn't work" means. When you have half the VBA expertise of Stack Overflow scratching their heads, it's a sign your question isn't clear. — Mat's Mug10 secs ago
@Mat'sMug - Declaring i as long only means he/she will have to wait longer for it to crash. :) — Jeeped14 secs ago
> @connerk Can you tell us the names of the interfaces/classes your classes and forms implement? That might help a lot to understand what is going wrong here.
YowE3K Thank you very much. I tested it and it worked perfectly. In my for loop, I did "For Each text In ActiveSheet.Range("A1:A11") ...End If Next text End Sub. But it didn't work. Luckily your use of "If and Else" and "For i = 1 To LastRow" solved my problem. Thank you very much again YowE3K — user75680427 mins ago
OK, so I was going to get my invoice ready. What should I put on there for your time?
I just came across this error, using the option to "Open and Repair" from the drop-down on the button on Excel's "Open" dialog fixed it for me.
I couldn't find one anywhere, so I made my own:
Public PADDING_CHAR As String
Public Function StringFormat(format_string As String, ParamArray values()) As String
'VB6 implementation of .net String.Format(), slightly customized.
'Tested with Office 2010 VBA (x64)
Dim return_value As St...
VBA Rubberducking
VBA Rubberducking