VBA Rubberducking

12:02 AM

RELOAD!

[Cardshifter/Cardshifter] 9 commits. 1 opened issue. 1 closed issue. 5 issue comments. 324 additions. 143 deletions.

[Cardshifter/HTML-Client] 4 opened issues. 2 closed issues. 5 issue comments.

[retailcoder/Rubberduck] 1 commit. 683 additions. 614 deletions.

[rubberduck-vba/Rubberduck] 1 opened issue. 14 issue comments.

[ShearOfDoom/CactusReborn] 4 commits. 2 opened issues. 1 closed issue. 5 issue comments. 60 additions. 12 deletions.

[skiwi2/ROVControlSoftware] 2 commits. 14 additions. 3 deletions.

[Zomis/CodeReview-Shield] 1 commit. 1 opened issue. 1 closed issue. 8 additions.

[retailcoder/Rubberduck] retailcoder pushed commit 2fdcc5cd to next: removed "Pass parameter ByVal" quickfix for ImplicitByRefParameterInspectionResult, and made ParameterCanBeByValInspection no longer skip Variant and object types

[rubberduck-vba/Rubberduck] retailcoder removed label critical from issue #747: Not recieving AppVeyor build notifications

[rubberduck-vba/Rubberduck] retailcoder commented on issue #747: Not recieving AppVeyor build notifications

> no idea how to fix this

[rubberduck-vba/Rubberduck] retailcoder added label help-wanted to issue #747: Not recieving AppVeyor build notifications

Duga

3:10 AM

[rubberduck-vba/Rubberduck] retailcoder added label vba-grammar to issue #753: Grammar of INTEGERLITERAL and DOUBLELITERAL is too permissive

[rubberduck-vba/Rubberduck] retailcoder added label enhancement to issue #753: Grammar of INTEGERLITERAL and DOUBLELITERAL is too permissive

Duga

4:00 AM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #749: Grammar doesn't understand function's array return value being accessed in the same instruction

> Looks like this issue is now fixed on my fork and will be closed when I merge my changes in :smiley:

Duga

4:10 AM

[retailcoder/Rubberduck] retailcoder pushed commit cc751a79 to next: grammar changes. fixes #749

[retailcoder/Rubberduck] retailcoder pushed commit 4eb2fd85 to next: added macroConstStmt rule to grammar. fixes #718.

Duga

4:34 AM

[retailcoder/Rubberduck] retailcoder pushed commit dd4cb4df to next: grammar fix: instructions separator. fixes #550.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #550: Module disappears with colon

> Fixed on my fork.

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #550: Module disappears with colon

[retailcoder/Rubberduck] retailcoder pushed commit a95e68fe to next: grammar fix: fileNumber rule. fixes #714.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #714: 'fileNumber' grammar rule needs to accept 'valueStmt', not just an identifier or a literal

> Fixed in my fork. Looking good!

Duga

5:00 AM

[retailcoder/Rubberduck] retailcoder pushed commit 1b0dcc43 to next: grammar fix: select case. fixes #750

[rubberduck-vba/Rubberduck] retailcoder commented on issue #750: Parser error: Select Case, multi Case

> @EBrown8534 @wqweto @ckuhn203 this seems to fix the problem:

selectCaseStmt :
SELECT WS CASE WS valueStmt NEWLINE+
sC_Case*
WS? END_SELECT
;

sC_Selection :
IS WS? comparisonOperator WS? valueStmt # caseCondIs
| valueStmt WS TO WS valueStmt # caseCondTo
| valueStmt # caseCondValue
;

sC_Case :
CASE WS sC_Cond WS? (':'? NEWLINE*)
(block NEWLINE+)*

[rubberduck-vba/Rubberduck] retailcoder removed label up-for-grabs from issue #750: Parser error: Select Case, multi Case

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #750: Parser error: Select Case, multi Case

[rubberduck-vba/Rubberduck] retailcoder commented on issue #753: Grammar of INTEGERLITERAL and DOUBLELITERAL is too permissive

> I'm going to [status-deferred] this issue for now; the parser needs to assume the parsed code compiles - if VBA can't handle it, then Rubberduck has no reason to handle it. A side-effect of this, is that an integer literal that, in theory, is too permissive, is in practice not a problem.

[rubberduck-vba/Rubberduck] retailcoder added label status-deferred to issue #753: Grammar of INTEGERLITERAL and DOUBLELITERAL is too permissive

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #753: Grammar of INTEGERLITERAL and DOUBLELITERAL is too permissive

Mat's Mug

well, every identified grammar issue deemed fixable are now fixed

Duga

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to pull request #788: Grammar fixes, inspection fixes, code inspections UI update.

[rubberduck-vba/Rubberduck] retailcoder created pull request #788: Grammar fixes, inspection fixes, code inspections UI update. to merge retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder merged pull request #788: Grammar fixes, inspection fixes, code inspections UI update. from retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder closed issue #739: "Variable can be passed ByVal" inspection incorrectly raised.

[rubberduck-vba/Rubberduck] retailcoder closed issue #749: Grammar doesn't understand function's array return value being accessed in the same instruction

[rubberduck-vba/Rubberduck] retailcoder closed issue #718: Parser doesn't seem to like #const

[rubberduck-vba/Rubberduck] retailcoder closed issue #714: 'fileNumber' grammar rule needs to accept 'valueStmt', not just an identifier or a literal

[rubberduck-vba/Rubberduck] retailcoder closed issue #750: Parser error: Select Case, multi Case

[rubberduck-vba/Rubberduck] retailcoder closed issue #550: Module disappears with colon

[rubberduck-vba/Rubberduck] retailcoder pushed 1 commit to next

[rubberduck-vba/Rubberduck] retailcoder pushed 28 commits to next (only showing some of them below)

[rubberduck-vba/Rubberduck] retailcoder pushed commit dd9bf7f5 to next: progress: caching the menu items partly solves the problem of commands running twice ....except the first time. Also, locals and parameters in Extract Method refactoring nee

[rubberduck-vba/Rubberduck] retailcoder pushed commit 9abdee80 to next: added ToList to enumerate menu items... doesn't fix the double-run bug, but feels more correct.

[rubberduck-vba/Rubberduck] retailcoder pushed commit 580fcca2 to next: fixes #739

[rubberduck-vba/Rubberduck] retailcoder pushed commit 2fdcc5cd to next: removed "Pass parameter ByVal" quickfix for ImplicitByRefParameterInspectionResult, and made ParameterCanBeByValInspection no longer skip Variant and object types

[rubberduck-vba/Rubberduck] retailcoder pushed commit cc751a79 to next: grammar changes. fixes #749

[rubberduck-vba/Rubberduck] retailcoder pushed commit 4eb2fd85 to next: added macroConstStmt rule to grammar. fixes #718.

[rubberduck-vba/Rubberduck] retailcoder pushed commit dd4cb4df to next: grammar fix: instructions separator. fixes #550.

[rubberduck-vba/Rubberduck] retailcoder pushed commit a95e68fe to next: grammar fix: fileNumber rule. fixes #714.

[rubberduck-vba/Rubberduck] retailcoder pushed commit 1b0dcc43 to next: grammar fix: select case. fixes #750

[rubberduck-vba/Rubberduck] retailcoder pushed commit e5179960 to next

Merge pull request #788 from retailcoder/next

Grammar fixes, inspection fixes, code inspections UI update.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #270: ByValParameterAssignmentInspection

> This issue should already be closed:

![image](https://cloud.githubusercontent.com/assets/5751684/10115976/29192e1c-63ec-11e5-97d6-4fdff09284da.png)

[rubberduck-vba/Rubberduck] retailcoder closed issue #270: ByValParameterAssignmentInspection

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #270: ByValParameterAssignmentInspection

[rubberduck-vba/Rubberduck] retailcoder closed issue #768: Redesign Code Inspections using a XAML TreeView

[rubberduck-vba/Rubberduck] retailcoder commented on issue #768: Redesign Code Inspections using a XAML TreeView

> treeview is implemented. few adjustments might be needed, missing a few commands, but design is completed.

[rubberduck-vba/Rubberduck] retailcoder closed issue #439: CodeInspectionResultBase instances need to be injected with an interface, not the VBE

[rubberduck-vba/Rubberduck] retailcoder commented on issue #439: CodeInspectionResultBase instances need to be injected with an interface, not the VBE

> seems mock builder solves this problem and this issue was somehow left opened.

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #439: CodeInspectionResultBase instances need to be injected with an interface, not the VBE

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #407: Warn for Variant returning functions when a strongly typed function exists.

Duga

5:56 AM

[retailcoder/Rubberduck] retailcoder pushed commit edea056e to next: implented UntypedFunctionUsageInspection (#407)

[rubberduck-vba/Rubberduck] retailcoder commented on issue #407: Warn for Variant returning functions when a strongly typed function exists.

> Oooh this is cool!!!

![image](https://cloud.githubusercontent.com/assets/5751684/10116083/ca37b650-63f2-11e5-860b-42f8103533ff.png)

Tweeting Duck

Now, this is getting pretty cool! #VBA #SmartDucky http://t.co/3uIWyKxdLm

Tweeted by rubberduckvba on September 26, 2015 at 6:07 AM

Duga

[retailcoder/Rubberduck] retailcoder pushed commit f28c7fc2 to next: fixed resolver bug with global built-in variable usages.

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to pull request #789: UntypedFunctionUsageInspection

fixes #407

[rubberduck-vba/Rubberduck] retailcoder merged pull request #789: UntypedFunctionUsageInspection from retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder closed issue #407: Warn for Variant returning functions when a strongly typed function exists.

[rubberduck-vba/Rubberduck] retailcoder pushed commit edea056e to next: implented UntypedFunctionUsageInspection (#407)

[rubberduck-vba/Rubberduck] retailcoder pushed commit f28c7fc2 to next: fixed resolver bug with global built-in variable usages.

[rubberduck-vba/Rubberduck] retailcoder pushed commit 5b9574b1 to next

Merge pull request #789 from retailcoder/next

UntypedFunctionUsageInspection

[rubberduck-vba/Rubberduck] retailcoder commented on issue #765: Implement RunCodeInspectionsCommand

> that's completed.

[rubberduck-vba/Rubberduck] retailcoder closed issue #765: Implement RunCodeInspectionsCommand

Duga

6:33 AM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #14: Property with public mutator (Let/Set) should expose a public accessor (Get)

> !image

Tweeting Duck

@rubberduckvba Set-only properties smell don't they? v2.0 will have an inspection for that! #VBA #SmartDucky http://t.co/lvq1idejsg

Tweeted by rubberduckvba on September 26, 2015 at 6:36 AM in reply to rubberduckvba

Duga

[retailcoder/Rubberduck] retailcoder pushed commit 8dc515a7 to next: Added WriteOnlyPropertyInspection. fixes #14.

Mat's Mug

that's right. #14.

Duga

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to pull request #790: Added WriteOnlyPropertyInspection. fixes #14.

[rubberduck-vba/Rubberduck] retailcoder created pull request #790: Added WriteOnlyPropertyInspection. fixes #14. to merge retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder merged pull request #790: Added WriteOnlyPropertyInspection. fixes #14. from retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder closed issue #14: Property with public mutator (Let/Set) should expose a public accessor (Get)

[rubberduck-vba/Rubberduck] retailcoder pushed commit 8dc515a7 to next: Added WriteOnlyPropertyInspection. fixes #14.

[rubberduck-vba/Rubberduck] retailcoder pushed commit 305e6ae8 to next

Merge pull request #790 from retailcoder/next

Added WriteOnlyPropertyInspection. fixes #14.

[rubberduck-vba/Rubberduck] retailcoder removed label up-for-grabs from issue #14: Property with public mutator (Let/Set) should expose a public accessor (Get)

Duga

1:11 PM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

> A `NullReferenceException` in the resolver (processing a `For` loop) is likely to be the reason for so many false positives, since identifiers didn't get all their references resolved.

This is annoying though:

![image](https://cloud.githubusercontent.com/assets/5751684/10117727/8c935764-642e-11e5-860f-c1675dc11195.png)

Working on it.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

> Found the issue with `VariableNotUsedInspection`:

var declarations = parseResult.Declarations.Items.Where(declaration =>
!declaration.IsBuiltIn
&& declaration.DeclarationType == DeclarationType.Variable
&& declaration.References.All(reference => reference.IsAssignment));

The problem isn't so much with the inspection itself - if all references of a variable are assignment targets, then none of the references are actual usages

Duga

1:47 PM

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

[rubberduck-vba/Rubberduck] retailcoder added label code-parsing to issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

[rubberduck-vba/Rubberduck] retailcoder added label critical to issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

Duga

3:09 PM

[Vogel612/TranslationHelper]‌ Vogel612 pushed commit 4bf00741 to develop: Asks for feedback when closing with unsaved changes now, fixes #11

Duga

3:39 PM

[Vogel612/TranslationHelper]‌ Vogel612 pushed commit 4fcf3d0f to develop: Added simplistic unit-test for saved-status

[Vogel612/TranslationHelper]‌ Vogel612 pushed commit 8b506191 to develop: Added command line capabilities to chose locale, fixes #13

Inlined interfaces with a single implementation, save the View
Implemented "Unsaved Changes" and "CLI locale choosing"

[Vogel612/TranslationHelper] build for commit 4bf00741 on develop: The Travis CI build passed

Duga

4:01 PM

[Vogel612/TranslationHelper] build for commit 8b506191 on develop: The Travis CI build passed

[Vogel612/TranslationHelper] build for commit 8b506191 on develop: Coverage increased (+0.6%) to 45.767%

[Vogel612/TranslationHelper] build for commit 8b506191 on develop: The Travis CI build passed

[Vogel612/TranslationHelper]‌ Vogel612 closed issue #11: Do that "unsaved changes" thing

[Vogel612/TranslationHelper]‌ Vogel612 closed issue #13: Allow specifying locales as Arguments to main

[Vogel612/TranslationHelper]‌ Vogel612 merged pull request #14: Develop from develop into master

[Vogel612/TranslationHelper]‌ Vogel612 pushed 6 commits to master

[Vogel612/TranslationHelper]‌ Vogel612 pushed commit 30df5802 to master: Merge pull request #14 from Vogel612/develop

[Vogel612/TranslationHelper]‌ Vogel612 pushed 1 commit to develop

Duga

4:13 PM

[Vogel612/TranslationHelper] build for commit 30df5802 on master: The Travis CI build passed

Duga

5:32 PM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

> Narrowed down to LetStmt - Set assignments don't have this problem. This bug is on its way out :smiley:

Duga

9:56 PM

[retailcoder/Rubberduck] retailcoder pushed commit cbcc5837 to next: fixed resolver bug. fixes #727

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to pull request #791: fixed resolver bug. fixes #727

such a simple fix, for such an annoying bug!

[rubberduck-vba/Rubberduck] retailcoder added label code-parsing to pull request #791: fixed resolver bug. fixes #727

[rubberduck-vba/Rubberduck] retailcoder merged pull request #791: fixed resolver bug. fixes #727 from retailcoder/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder closed issue #727: Code Inspection, VariableNeverUsed, flagging incorrect code

[rubberduck-vba/Rubberduck] retailcoder pushed commit cbcc5837 to next: fixed resolver bug. fixes #727

[rubberduck-vba/Rubberduck] retailcoder pushed commit 80d5794a to next

Merge pull request #791 from retailcoder/next

fixed resolver bug. fixes #727

[rubberduck-vba/Rubberduck] retailcoder commented on issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

> #727 is fixed. Having a hard time reproducing the NullReferenceException in the For loop though.

Duga

11:23 PM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

> Good news, the code parses and resolves without error:

![image](https://cloud.githubusercontent.com/assets/5751684/10120303/aa40accc-6482-11e5-887b-a095b48efaf7.png)

The `NullReferenceException` in this [stack trace](https://gist.github.com/byronwall/cf826b6144efc81094d1) was thrown here:

public void Resolve(VBAParser.ForNextStmtContext context)
{
var identifiers = context.ambiguousIdentifier();
var identifier = ResolveInternal(identifiers[0]

Duga

11:55 PM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

> @byronwall works! Here are your inspection results:

![image](https://cloud.githubusercontent.com/assets/5751684/10120360/135e69e0-6485-11e5-9aae-39abf90b26e3.png)

I'd suggest you start by specifying `Option Explicit` in all modules, and fix the compile errors this causes (i.e. declare the undeclared variables).

Here are the full results. A few notes:

- `ParameterNotUsedInspection` seems to be only firing on handler procedures, so these can be ignored.
- `ParameterCanBeByValInsp

[rubberduck-vba/Rubberduck] retailcoder closed issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

[rubberduck-vba/Rubberduck] retailcoder added label code-parsing to issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

[rubberduck-vba/Rubberduck] retailcoder added label critical to issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #725: Parse error (?) leads to Code Explorer not updating, Code Inspection issues, and runtime error

Transcript for