« first day (45 days earlier)      last day (363 days later) » 

Hosch250
Hosch250
1:37 AM
Wow. These changes busted almost every single test in VSDiagnostics.
Mostly missing using directives.
Some are missing references.
Wow, you missed some semi-colons in one of the tests.
Sometimes I had a bool method that should have been void.
 
Duga
Duga
2:24 AM
[Hosch250/VSDiagnostics] Hosch250 pushed commit 56c86025 to Feature251: Fix a bunch of tests, remove a couple that could not be fixed (cannot create static enums, structs delegates, or nested class/struct/enum/delegate/anything).
 
Hosch250
Hosch250
My fork isn't ready for merging, but I'll do it in a bit.
I mean, it won't be ready until I get my Roslyn bug fixed.
 
 
6 hours later…
Duga
Duga
8:36 AM
> I was finally able to work on this again ;) Luckily, I wasn't able to reproduce the problem, so it's working as expected :+1:
 
 
6 hours later…
Hosch250
Hosch250
2:10 PM
@JeroenVannevel He got back to you.
I recognize him from Roslyn itself.
He has a WpfDiagnostics project.
 
 
5 hours later…
Duga
Duga
6:49 PM
 
 
1 hour later…
Duga
Duga
8:08 PM
I ended up adding a new diagnostic category for "structs", given that there are a few more open issues regarding structs, but I'm not sure what your policy is regarding category assignment.
 
Duga
Duga
8:26 PM
 
Hosch250
Hosch250
I'm not sure if that should be in General? I think General needs to be split up some.
@JeroenVannevel You have a PR from a new contributor!
 
Duga
Duga
[Vannevelj/VSDiagnostics] build for commit 6ec184e7 on unknown branch: AppVeyor build succeeded
> Looks nice. Generally we would use the "General" category for this, but I've been thinking lately that we should add a few more categories. If you wish to chat about this project, we have a chatroom setup at Code Review.SE: chat.stackexchange.com/rooms/26639/vsdiagnostics
> Perfect! You'll notice that the v1.5.0 release is hidden from NuGet because we had concerns about this issue and another one that caused VB.NET stuff to be handled incorrectly. Since these two issues are now resolved, we'll release v1.6.0 with some added new functionality as soon as I'm home -- which is in a week.

I'm not sure if you can still use the NuGet v1.5.0 release so you might want to hold on to that dll for the time being otherwise.
 
Hosch250
Hosch250
@JeroenVannevel You can still use the 1.5.0. I was using it after you pulled it before I used my version.
You just can't re-download it.
 
Jeroen Vannevel
Jeroen Vannevel
Let me catch up with everything here and elsewhere
My first moment of free time here in Boston
 
Hosch250
Hosch250
OK.
How are you liking it?
 
Jeroen Vannevel
Jeroen Vannevel
8:41 PM
I love it. The city is sparkling with life, the weather is amazing, everything is really clean, the people are friendly, lots of very talented street performers, etc
 
Hosch250
Hosch250
Great.
 
Duga
Duga
> Looks good! The added category is fine -- maybe we should look into creating more categories anyway.

Would you mind adding a few more tests to account for different execution paths? I'm thinking like for example assiging `new X(5)` to a variable instead of `this`. This will prevent us from creating problems in the future should that diagnostic ever need refactoring.
 

« first day (45 days earlier)      last day (363 days later) »