« first day (413 days earlier)      last day (2767 days later) » 

12:01 AM
RELOAD!
[Cardshifter/Cardshifter] 16 commits. 2 opened issues. 9 closed issues. 28 issue comments. 1353 additions. 795 deletions.
[CodeReviewCommunity/CodeReviewCommunity.github.io] 4 opened issues. 5 closed issues. 6 issue comments.
[rubberduck-vba/Rubberduck] 3 opened issues. 1 closed issue. 7 issue comments.
[Vogel612/TranslationHelper\‌​] 3 commits. 33 additions. 18 deletions.
 
@Duga \o/
 
 
1 hour later…
1:42 AM
[rubberduck-vba/Rubberduck] build for commit 67b9549c on next: AppVeyor build succeeded
 
 
3 hours later…
4:29 AM
good news, the VBE dependency injection issue was cause by the EmbedInteropTypes being switched on in some of the projects. setting it to false solves the issue and Ninject happily resolves it.
 
@Mat'sMug You are back at your laptop?
 
yes!
 
Can you check out my new branch sometime so I can do the same for the rest of the navigations in Refactor menu?
You said to wait until you checked it.
 
[rubberduck-vba/Rubberduck] retailcoder pushed commit f61e9ed2 to next: set EmbedInteropTypes to false; Ninject can now correctly resolve the VBE dependency across assemblies :)
 
@Hosch250 sure, what should I be looking at?
(or just pull that commit)
 
[rubberduck-vba/Rubberduck] build for commit f61e9ed2 on next: AppVeyor build succeeded
 
Also, I'm downloading VS 2013 update 5, in case you are interested.
 
@Hosch250 what am I looking for?
 
> Showing 20 changed files with 234 additions and 180 deletions.
any concerns?
 
4:35 AM
No.
Three of them were added.
One was changed for Ninject to see our custom message box.
One is the refactor menu file, and one is App.cs because of the DI'ing.
At least one is a config file because of the added files.
 
ok. I'm going to push [next] into a new [RefactorMenus] branch on the main tree.
 
And, the rest are changes caused by the rename because of Ninject.
 
> 1,999 commits
 
[rubberduck-vba/Rubberduck] build for commit f61e9ed2 on next: AppVeyor build succeeded
 
4:39 AM
all right. I'm PR'ing your branch into the main tree's [RefactorMenus] branch.
 
and merged
 
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 954260ad to RefactorMenus: Move cursor set out of finally to keep wait cursor from not turning off. Re: stackoverflow.com/questions/31118912/…
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 9f143ff7 to RefactorMenus: Remove utterly unnecessary catch
Merge pull request #7 from rubberduck-vba/next

Pull from Next
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 0ceceed4 to RefactorMenus: Create FindAllImplementations class and interface. Rename IMessageBox to IRubberduckMessageBox to fool Ninject.
[rubberduck-vba/Rubberduck] Hosch250 pushed commit 101783e1 to RefactorMenus: Rename namespace
Merge pull request #721 from Hosch250/RefactorMenus

Refactor menus
[rubberduck-vba/Rubberduck] build for commit 101783e1 on RefactorMenus: AppVeyor build cancelled
BUILD FAILURE!
 
@Duga yeah yeah, shut up
pulling the changes
 
Build Failure?
It worked on my system.
Did @RubberDuck get the tests running again?
 
4:42 AM
[rubberduck-vba/Rubberduck] build for commit 713d968d on RefactorMenus: AppVeyor build succeeded
 
I didn't let it finish
 
Oh.
 
wasn't hitting [next] anyway
ok, we're in sync
well, I got your changes (don't know if you got mine)
 
[rubberduck-vba/Rubberduck] build for commit 713d968d on RefactorMenus: AppVeyor build succeeded
 
^^ there
 
4:45 AM
[Hosch250/Rubberduck] retailcoder pushed commit f61e9ed2 to next: set EmbedInteropTypes to false; Ninject can now correctly resolve the VBE dependency across assemblies :)
Merge pull request #8 from rubberduck-vba/next

set EmbedInteropTypes to false; Ninject can now correctly resolve theā€¦
 
I'm off to bed.
See you later.
(BTW, I'm ready to do the regex search/search-replace when you are.)
(BTW2, does R# have this? I'm regularly wishing I didn't need to search for exact matches in VS.)
 
ReSharper > Find > Search with pattern...
or
Ctrl+F, Alt+E for native VS regex search ;-)
 
 
4 hours later…
9:12 AM
 
 
2 hours later…
11:37 AM
Ohh. Look at that @Duga! Another stargazer!
 
11:51 AM
> > Hi there, I've downloaded this today and was attempting to try the source control. When pressing the "Init New Report from this project" button i get the following message.
>
> Can you please help? Thanks, Taareq

************** Exception Text **************
LibGit2Sharp.LibGit2SharpException: Configuration value 'user.name' is missing or invalid.
at LibGit2Sharp.Configuration.NormalizeUserSetting(Boolean shouldThrowIfNotFound, String entryName, String currentValue, Func`1 defau
 
 
2 hours later…
2:04 PM
> I was attempting to try
...
> Do or do not. There is no try.
2
 
 
2 hours later…
4:09 PM
15
Q: Excuse me, how many of you are new here? Mind if I JOIN you?

RubberDuckI had perceived an uptick in new reviewers around here, and I wanted to see if the data backed that observation up. It's been a while since I've written any SQL, so this was a nice little exercise in using the Stack Exchange Data Explorer. The query finds the first question and first answer from...

I saw that title in the hot questions list an knew it had to be @RubberDuck or @Mat'sMug...
 
4:30 PM
Lol. I have my moments.
Oh! Popular question badge!
 
5:18 PM
Nifty! A Strunk & White over at Aviation.SE :D
 
6:09 PM
Monking!
@Mat'sMug Have time for a SSRS question?
 
maybe
 
Is it possible, AFAYK, to make a report where you can feed it an Excel/CSV document, instead of inputting values in fields?
 
if you can set up a data source for the CSV file, maybe... never done that
 
Ah ok
 
 
2 hours later…
7:46 PM
in TCG Creation, 4 mins ago, by Simon André Forsberg
> 1,567 commits
 
 
2 hours later…
9:40 PM
[rubberduck-vba/Rubberduck] retailcoder pushed commit 4781a657 to RefactorMenus: renamed INavigateImplementations and implementation
[rubberduck-vba/Rubberduck] retailcoder pushed commit 191fa7d7 to RefactorMenus: included RubberduckUI.de.resx in solution
[rubberduck-vba/Rubberduck] build for commit 191fa7d7 on RefactorMenus: AppVeyor build succeeded
 
9:59 PM
something is terribly wrong
@Hosch250 I'm deleting that branch, keep yours or I'll lose the merged changes.
 
10:34 PM
@Mat'sMug What's up with that branch?
 
@Hosch250 I broke it
 
:(
Do I have permission to do more of this stuff?
 
@Hosch250 sure
 
OK.
I will in a bit.
@Mat'sMug Didn't you fix this?
> // todo: figure out why Ninject can't seem to resolve the VBE dependency to ActiveCodePaneEditor if it's in the VBEDitor assembly.
 
Yes
 
10:44 PM
Want to remove it?
It's in App.cs.
 
I have gone locally but I'm not pushing my branch
 
OK.
 
11:00 PM
[Hosch250/Rubberduck] Hosch250 pushed commit d93c02de to RefactorMenus: Move FindAllReferences out of RefactorMenu
 
ok we have a problem
I switched to [next], added the RubberduckUI.DE.resx to the solution, added a Language_DE key and launched
@Hosch250 if you launch RD and then go to options and switch languages, and then bring up the Code Explorer, what do you get?
 
Can you hold on a sec?
 
sure
 
I get an exception.
 
an InvalidOperationException in the _parser_ParseStarted handler, right?
 
11:08 PM
No, an exception because the window was already closed.
 
...
interesting
 
Also, I'm getting Excel crashing on close again :(
Probably need to make all these Finds I'm working on implement IDisposable.
 
1 hour ago, by Mat's Mug
something is terribly wrong
the good news is, it turns out I didn't break anything
the bad news is, [next] is broken
 
[Hosch250/Rubberduck] Hosch250 pushed commit e4282e53 to RefactorMenus: Get Find Symbol out of RefactorMenu
 
This is looking more like it.
 
11:21 PM
[Hosch250/Rubberduck] Hosch250 pushed commit 459b0f54 to RefactorMenus: Unsubscribe from event before destroying window
 
Good. It isn't my new changes.
It happens in Next too.
 
12 mins ago, by Mat's Mug
the bad news is, [next] is broken
 
Did you guys forget to unsubscribe from an event?
Wait, I bet it is Ninject.
I had a similar problem with Unity in my Resx editor, where the app wouldn't close.
 
the InvalidOperationException I'm getting is because the object (the base docked window) is already disposed
 
I solved it by not using an IoC container after trying a zillion things unsuccessfully.
 
11:25 PM
for a small application, poor man's DI can work, but in our case using an IoC container properly would be a preferrable solution ;-)
 
I know.
But, we've got to somehow get everything disposed of properly.
This is just a conjecture, nothing for sure.
 
the problem I'm seeing in [next] is that things get disposed, but not re-created properly
 
I'm not talking about that. I'm talking about closing Excel and having it crash again.
 
if anything that's becoming a total non-issue with full-blown IoC. Disposables get cleaned up when the kernel gets disposed.
 
Nope, it is happening right now.
 
11:30 PM
and we have a fraction of the types in the kernel, and there are two kernels involved.
our shit is badly broken atm
 
It wasn't happening just the other day.
It wasn't happening when I was writing tests.
Ninject is the only thing I can think of that happened in Next since then.
 
looks good
 
I don't like how they are all together in the directory. Should I add another level?
 
nah
 
11:35 PM
gosh
good job!
 
Now it basically builds the menu, handles clicks, and destroys the menu.
It still looks a bit messy, but there isn't a whole lot to be moved out.
I'm thinking maybe we should have a class for this?
public void Rename()
{
    var progress = new ParsingProgressPresenter();
    var result = progress.Parse(_parser, IDE.ActiveVBProject);

    using (var view = new RenameDialog())
    {
        var factory = new RenamePresenterFactory(IDE, view, result, new RubberduckMessageBox(), _factory);
        var refactoring = new RenameRefactoring(factory, _editor, new RubberduckMessageBox());
        refactoring.Refactor();
    }
}

public void Rename(Declaration target)
{
    var progress = new ParsingProgressPresenter();
What do you think?
 
it's probably good enough
I'd like to end up with commands eventually
 
We could then call that class from the inspections and other menus too.
 
yup
 
Instead of this:
private void codePresenter_Rename(object sender, TreeNodeNavigateCodeEventArgs e)
{
    var declaration = e.Node.Tag as Declaration;
    if (declaration == null)
    {
        return;
    }
    _refactorMenu.Rename(declaration);
}
 
11:41 PM
damn right
 
So, I should create a class, or no?
 
that's definitely spaghettified
 
Or a command, or whatever.
 
if you think it's time for this, go ahead
 
I don't know. I was asking you :\
It is definitely bad the way it is.
 
11:42 PM
well, we're in a refactoring phase..
 
I'm not sure if a separate class to call the refactorings are the way to go, or if I'm missing a design pattern or something.
 
the command pattern, specifically
 
OK, I'll research that.
 
WPF uses it extensively ;-)
 
Oh, that!
We already have a Show() class in the refactorings, but we have to pass the view in.
 
11:54 PM
@Hosch250 @RubberDuck I'm looking at commits on next, I'm thinking about a rollback up to merge #716. thoughts?
 
You mean Ninject?
 
yes. I'll create a separate branch for it
 
Sounds good.
 

« first day (413 days earlier)      last day (2767 days later) »