I've never used AVERTY, but I could see if be good for French where W is not used near as often as V. Although, interestingly, Q is used a lot more in French than in English
You see, I had to have the data right away for the Remove and Reorder, or I would be duplicating all the setup in both the presenter and the refactoring, and I didn't want to do that.
I figured they could share the code.
I haven't done rename yet, and I'm not sure how to do that - just a copy/paste like Reorder?
public void Refactor(QualifiedSelection selection)
{
var member = AcquireTarget(selection);
if (member == null)
{
OnInvalidSelection();
return;
}
using (var view = new ExtractMethodDialog())
{
var presenter = new ExtractMethodPresenter(_editor, view, member, selection, _declarations);
presenter.Show();
}
}
if you're passing a QualifiedSelection into the constructor (and/or perhaps a Declaration in a constructor overload), then you shouldn't need any public members outside AcquireTarget(QualifiedSelection) and Refactor()
I don't see public members in the parameter refactorings outside the interface members
the extract method has other public members because I hadn't designed it as a fire-and-forget thing.. but I like the way you have it
I mean, the target should be passed into the constructor, and the parameters are a result of acquiring the target, and the client code doesn't care what the parameters are
basically what we want to accomplish here, is we new-up the refactoring, inject its dependencies (perhaps a factory will be in order), and call Refactor() and be done with it
the refactoring needs to be injected with an abstraction that represents the view, so we can inject it with a mock and run tests without being bothered with the view... no?
> `RubberduckParser` is already logging parse errors in debug builds (logging is disabled in release builds). What would be nice, is if we would report parse exception details in a docked window that we could bring up and populate as the parser blows up, a bit like Visual Studio compile errors/warnings.
Let's implement a docked toolwindow that lets user navigate exactly where the parse errors are, and that can be exported to a text file, or into the clipboard.
> Exporting to clipboard deferred to 2.0 - this is just a quick-and-dirty window, so that user gets minimum feedback when something is wrong with parsing the source code. errors are double-click navigatable.
Since the project started, we’ve been releasing pretty much every 100 commits or so – actually more than that, given 13 releases in 1,003 commits. Our “next” branch stands at 1,375 commits at the time of this writing, and the next release will likely be well beyond the 1,400th commit. What’s up, duck? Quite a lot […]
I would say no. They could be, but they're part of the code and most code is in English. If someone wants to use their native language, they can set up their own.
I actually did have a problem with NuGet packages a few days ago. For some reason, some program was holding on to a lock of one of the packages folder which stopped NuGet from functioning
Showing 1 changed file with 0 additions and 2 deletions. Showing 25 changed files with 23 additions and 1,308 deletions. Showing 12 changed files with 0 additions and 1,552 deletions. Showing 2 changed files with 0 additions and 48 deletions. Showing 9 changed files with 0 additions and 1,290 deletions. Showing 18 changed files with 0 additions and 851 deletions. Showing 2 changed files with 8 additions and 15 deletions. Showing 17 changed files with 12 additions and 1,225 deletions.
@Mat'sMug When you are around again, I've localized the code explorer window and code inspections window, just so you know. The strings are in RubberduckUI.resx, so you will have to somehow compare the two .resx's and add the French strings, but they aren't hard coded anymore.
Also, I IRefactorized Reorder Params and Remove Params.
I might not be around too much later - my mom volunteered for my family to help a friend stuff envelopes, and I'm not sure if they are going to impose "mandatory volunteerism" on me.
VBA Rubberducking
VBA Rubberducking