« first day (307 days earlier)      last day (2873 days later) » 

Duga
Duga
12:01 AM
RELOAD!
[retailcoder/Rubberduck] 4 commits. 4 opened issues. 2 closed issues. 15 issue comments.
2
[Vogel612/BloggingPlatform] 1 issue comment.
[Zomis/Duga] 3 commits.
 
 
1 hour later…
Stack Exchange
Stack Exchange
1:05 AM
10000 rep Stack Overflow users earn 35% more than average http://stackoverflow.com/research/developer-survey-2015 http://t.co/Rl46ij3qiG
Tweeted by spolsky on April 7, 2015 at 3:01 PM
 
Duga
Duga
1:18 AM
> Merge branch 'next'
 
Duga
Duga
2:05 AM
> re-added Rubberduck.Parsing project into solution (lost in merge)
> closes #368 and another issue with Declaration.IsTypeSpecified when type hints are involved.
> Fixed!
 
 
1 hour later…
Duga
Duga
3:19 AM
> changed wording of inspection results to include DeclarationType.
> implemented quickfix for ObsoleteTypeHintInspection; fixed related bugs involving HasTypeHint() in both Declaration and IdentifierReference classes.
> removed DeclaredIdentifierNode dead code
 
Duga
Duga
4:16 AM
> closes #353 - also fixes a bug where a ModuleOption could be acquired as a rename target
 
Mat's Mug
Mat's Mug
@Duga not kidding - Please specify new name for identifier 'Option Explicit':
 
Duga
Duga
> Merge branch 'next'
[retailcoder/Rubberduck] retailcoder pushed 20 commits to next
3
> fixed broken test (IdentifierReference constructor signature was modified)
 
Mat's Mug
Mat's Mug
> 49 tests passed
 
Duga
Duga
4:33 AM
 
Mat's Mug
Mat's Mug
I don't know how many commits that makes, but I'm calling it a day.
 
Duga
Duga
 
Duga
Duga
5:06 AM
> With the `Declarations` API this is now getting more and more realistic - if a constant, variable, function or member is referenced in the right-hand side of an assignment, then the type to use on the left-hand side is known, even if it's an `Object`, and the scoping issue is already solved.

Literals can be picked up pretty easily.

If we say anything else remains `Variant` (or `Object` if the left-hand side is `Set`), then we're already in a pretty good position to infer the return type.
 
Mat's Mug
Mat's Mug
^^ let's not even think of implementing it before 1.4 though...
 
Duga
Duga
> That's really just a funky edge case, flagging it as "by design" and moving on.
> 1.3 is too early for this. Let's try for 1.4.
> @christophocles you'll be happy to hear that the rename refactoring is now in the [Next] branch - that one's going to be a :bomb:!!
> Renaming a module/class from the Code Explorer works, but the toolwindow needs to be manually refreshed for the changes to be reflected in the tree view; the Code Explorer should automatically refresh after performing a rename refactoring.
> Code Explorer nodes' `Tag` should be the corresponding `Declaration` object instead of just a `QualifiedSelection` - that way there would be enough information in the tree nodes to just grab the selected node's tag, cast it into a `Declaration` object, and pass it to the rename presenter without any further processing.

Right now the rename right-click menu prompts to rename the containing class/module when a method is selected.
 
Mat's Mug
Mat's Mug
5:31 AM
alright now, tired. enough. bedtime. for real.
really.
 
Duga
Duga
> updated change log in grammar file, added implementation stubs and comments (referencing GitHub issues) for picking up literals in IdentifierReferenceListener
> fixed InvalidOperationException in RenamePresenter
 
Mat's Mug
Mat's Mug
that doesn't count
 
 
4 hours later…
skiwi
skiwi
9:21 AM
People working hard here
 
RubberDuck
RubberDuck
9:55 AM
Sure it doesn't count...
 
 
2 hours later…
Mat's Mug
Mat's Mug
11:50 AM
> 901 commits
16+29 downloads
 
Duga
Duga
12:22 PM
> The `Error` statement is obsolete and should be replaced with a call to `Err.Raise` per [the MSDN documentation](https://msdn.microsoft.com/EN-US/library/office/gg264544.aspx).

Error 11 ' simulate division by zero error

- Severity: Hint
- Quick Fix: Replace Error statement with proper call to `Err.Raise`

Err.Raise 11
 
RubberDuck
RubberDuck
@ticker... "Procedure too large error"??
I've gotta see this.
 
Simon André Forsberg
Simon André Forsberg
@RubberDuck You are getting friends? Or competition perhaps...
 
RubberDuck
RubberDuck
> There can be only one.
0
Q: "Procedure too large" error with Private Subs

Laurentiu ManolacheI have in a Excel 2007 with multiple worksheets a working VBA code without errors that verify Hyperlinks from a range name and execute 2 different formatting. I have a subroutine for erasing formatting and another for reformatting in Module 1, which are called by their name: Erase_format and Doub...

vba compiler-errors excel-2007 private subroutine
 
skiwi
skiwi
12:44 PM
You guys here using SCRUM?
As I see you often talking about sprints or 4-week cycles
 
Mat's Mug
Mat's Mug
@Duga Wow I'll have to verify that one is actually in the grammar!
 
Duga
Duga
@Mat'sMug Yes, you should!
 
RubberDuck
RubberDuck
@skiwi Not formally, but we have been trying to hit 4 week sprints.
17 hours ago, by RubberDuck
@skiwi release early, release often
 
skiwi
skiwi
@RubberDuck Ah okay, how do you balance the features you want to build yourselves and user suggestions?
 
RubberDuck
RubberDuck
Depends.. suggestion or bug?
Suggestions get prioritized into some future release. Bugs we try to handle for the next release.
 
skiwi
skiwi
12:53 PM
Well, assuming you don't want to build bugs, I think suggestions would be a thing ;)
Do you actually plan out future features for different versions or do you prioritize them? And then use that to clear the backlog
 
RubberDuck
RubberDuck
We usually only go one (maybe 2) releases out.
When one version gets close to release, we take some time to plan the next version.
So, we've typically had a week between one version releasing and work starting on the next.
Which makes for a nice little break.
Gotta keep the sanity
 
skiwi
skiwi
^^
Time for a quick poll here, mainly for @RubberDuck and @Mat'sMug ;)
Would you want @Duga notifications to be available elsewhere?
 
RubberDuck
RubberDuck
@skiwi What do you mean?
 
Mat's Mug
Mat's Mug
TBH v1.3 was way too ambitious
 
Duga
Duga
@skiwi Everywhere! I shall rule everything!
2
 
skiwi
skiwi
12:59 PM
@RubberDuck Currently the only output of @Duga is towards SE chat, though there could be more endpoints
I'm personally wanting to support Pushbullet, such that I get notifications on my PC
 
Mat's Mug
Mat's Mug
A lot of issues marked 1.3 will end up in 1.4
 
skiwi
skiwi
(It's a little popup in the corner, which you have to manually dismiss)
 
RubberDuck
RubberDuck
@Mat'sMug Yeah... and honestly, it really could be 2.0 if I ever get SCI done.
@skiwi You can do that?
 
skiwi
skiwi
@RubberDuck Yeah, I've thought it all out, and it's a possibility!
 
Mat's Mug
Mat's Mug
@RubberDuck We're programmers, we can do anything
6
 
RubberDuck
RubberDuck
1:02 PM
@skiwi I would use that. Then I could focus on code and stay out of chat when I'm working on RD.
 
skiwi
skiwi
@RubberDuck I can't support you staying out of chat :(
 
RubberDuck
RubberDuck
LOL
Then I guess it's a no start.
 
skiwi
skiwi
No, but for real, I'm really thinking
I'm planning an overhaul of @Duga soon (tm) to give it a web interface
 
RubberDuck
RubberDuck
Seriously though, sometimes chat gets to be a distraction. It would be nice to still get Duga notifications if I don't want to log into chat.
 
skiwi
skiwi
It will ugly as hell, not my job :D
 
RubberDuck
RubberDuck
1:04 PM
Okay..... I don't get it.
I thought this was bit shifted at first, but.... 
vbCritical
16
Critical message
vbQuestion
32
Warning query
vbExclamation
48
Warning message
vbInformation
64
Information message
48 wtf?
LOL.... @Mat'sMug put this in the immediate window... 
msgbox "Hello", vbExclamation + vbCritical
You'll be surprised
 
skiwi
skiwi
So @RubberDuck if you would like that feature, then you'll need to motivate me some ;) If attention level drops low
It's at least good to know that someone besides myself wants it
I've got two exams tomorrow... After that 9 days of free time!
 
RubberDuck
RubberDuck
Nice!
 
skiwi
skiwi
Need to be careful I don't end up gaming 9/24/7 though
 
RubberDuck
RubberDuck
Bad @skiwi. Write code.
2
 
skiwi
skiwi
@RubberDuck Looks like +16 to me xd
 
RubberDuck
RubberDuck
1:08 PM
It's doing something like this internally 
If value < 16 Then
    NoIcon
ElseIf value >=16 && value <32 Then
   vbCritical
ElseIf....
 
skiwi
skiwi
I need to be really really careful to release early, release often
It's difficult
 
RubberDuck
RubberDuck
It is. I'm a few weeks passed where I wanted to have my current work done.
 
skiwi
skiwi
Take @Duga web interface for example, I want users to be able to enable/disable events per endpoint, I better don't do that in initial release though
Has anyone seen RD design documents/diagrams around here? ;)
 
FreeMan
FreeMan
design documents? what are those?
3
 
RubberDuck
RubberDuck
@skiwi I have..... but they're on pieces of graph paper here in my office.
 
skiwi
skiwi
1:25 PM
@RubberDuck Hehe, I'm seriously considering them for @Duga, but trying to figure out where to start
Is there something wrong with Release Early, Release Often, Refactor A Lot?
Should you be building systems of which you know that they can be programmed in a better way?
 
RubberDuck
RubberDuck
1:41 PM
@skiwi absolutely not. Nothing wrong there.
The latter, idk.
 
skiwi
skiwi
I'm thinking together with @SimonAndréForsberg and seems like we need to design more on the @Duga web interface to prevent code duplication, tc.
 
Simon André Forsberg
Simon André Forsberg
We need to design the code, not the web interface (i.e. GUI stuff)
 
skiwi
skiwi
Correct ^^^^ Important point
 
FreeMan
FreeMan
@RubberDuck Take a cell phone picture of them. They'll end up on the web eventually...
 
Mat's Mug
Mat's Mug
2:03 PM
I should start documenting the Rubberduck code base... but there's so much to implement, and so little time...
2
 
RubberDuck
RubberDuck
Word
 
Mat's Mug
Mat's Mug
I saw the SO survey results yesterday
I think I spend 20-30 hours a week writing code on-the-side for an open-source project... and 45 hours a week actually working
2
 
skiwi
skiwi
@Mat'sMug When do you do other stuff?
 
Mat's Mug
Mat's Mug
I'll burn out that way huh
 
skiwi
skiwi
Depends on how resistant you are
 
FreeMan
FreeMan
2:12 PM
@Mat'sMug Only if you're made of wax
 
Mat's Mug
Mat's Mug
I get home around 7PM, put the kids in bed around 8 - by 9 I'm coding, up to anywhere between 1 or 2AM, sometimes a bit later. then 7AM another day starts
God bless coffee
2
 
skiwi
skiwi
I have no schedule
 
Mat's Mug
Mat's Mug
I have no life - I mean... I want 48-hour days!!
 
RubberDuck
RubberDuck
@Mat'sMug why have we never thought about looking at the VisualBasic Namespace sourcecode
It's a re-implementation of VB6 in .Net...
@Mat'sMug You will. I've cut my out side of work coding back to about 8-10 hours a week. 
'Only allow legal button combinations to be set, one choice from each group
'These bit constants are defined in System.Windows.Forms.MessageBox
'Low-order 4 bits (0x000f), legal values: 0, 1, 2, 3, 4, 5
'     next 4 bits (0x00f0), legal values: 0, &H10, &H20, &H30, &H40
'     next 4 bits (0x0f00), legal values: 0, &H100, &H200
If ((Buttons And &HFI) > MsgBoxStyle.RetryCancel) OrElse ((Buttons And &HF0I) > MsgBoxStyle.Information) _
    OrElse ((Buttons And &HF00I) > MsgBoxStyle.DefaultButton3) Then
 
skiwi
skiwi
I don't know if I should be happy or not, tomorrow 9-12am first exam about Artificial Intelligence (which is difficult as hell, I'm not prepared and I absolutely need to deliver something in order to be allowed to take the resit), and then from 6-9pm I have an easy exam (resit) on Software Engineering
 
RubberDuck
RubberDuck
2:17 PM
whiskey tango foxtrot man...
 
skiwi
skiwi
Pretty much my free time starts after the first exam, though I do need to be there and pass the 2nd exam
 
Mat's Mug
Mat's Mug
@RubberDuck it's an abomination. whenever I see using Microsoft.VisualBasic; in .net source code, I die inside.
 
RubberDuck
RubberDuck
@Mat'sMug Yeah. Me too, but we basically have the VB6 source code at our fingertips.
 
Mat's Mug
Mat's Mug
..mkay, but to do what?
 
RubberDuck
RubberDuck
Why this hasn't dawned on me before..... I just don't know.
@Mat'sMug this 
Private Function ConvertMsgBoxStyleToErrorSeverity(ByVal style As VbMsgBoxStyle)
which enables this 
Public Sub LogError(moduleName As String, procName As String, Optional severity As ErrorSeverity = Critical, Optional OptionalText As String = vbNullString)
which is going to insert errors into a log table on SQL Server.
 
Mat's Mug
Mat's Mug
2:21 PM
...in .net? why bother? there's NLog...
not sure I'm following
 
RubberDuck
RubberDuck
No. In VBA.
I'm building a logger.
 
Mat's Mug
Mat's Mug
oh
 
RubberDuck
RubberDuck
So, what I'm saying is that if there's ever a question about how something works.. the source code is available.
 
Mat's Mug
Mat's Mug
14
Q: Extensible logging

Mat's MugWhenever I need logging functionality in .net, I use a logging framework, such as NLog. Obviously there's no logging framework for vba, at least none that I know of. As much as I love using NLog, the way it works, with targets, rules and loggers, was going to be way too heavy and complex for my ...

oop vba library logging
 
RubberDuck
RubberDuck
Well, not the source, but a source.
Yeah.. I know, but I already have all the error handling code wired up to display errors to users.
I'm modifying it to log too.
I want to see how many bugs are going unreported.
 
Mat's Mug
Mat's Mug
2:24 PM
you'll wish you could "inject" that into SNAP...
2
 
FreeMan
FreeMan
@RubberDuck I'm doing my best...
 
Mat's Mug
Mat's Mug
@FreeMan did you break the "extract method" refactoring yet? ;)
 
RubberDuck
RubberDuck
@Mat'sMug I did!
lol
 
FreeMan
FreeMan
@Mat'sMug haven't gotten there yet. I have actual work to do, in addition to ---beta --- alpha testing your product...
:D
_/though --- initiated <strike>. stoopid chat...
 
Mat's Mug
Mat's Mug
it does, but you can't have a trailing space there ---beta ---
---beta--- => beta
 
skiwi
skiwi
2:30 PM
----=>---
Heh, that causes weird behavior with the chat
 
Mat's Mug
Mat's Mug
you can't BF the chat, the chat has no brain!
2
 
FreeMan
FreeMan
@Mat'sMug but, but, I wanted the strike through that trailing space!!!
 
Mat's Mug
Mat's Mug
> 50 downloads
I think we're averaging over 5 downloads per day
 
Simon André Forsberg
Simon André Forsberg
@FreeMan is this what you want?
you can't get a strike through a trailing space though
 
Duga
Duga
2:47 PM
> Say you have interface IClass1: Option Explicit Public Sub DoSomething() End Sub And then Class1 implementing IClass1: Option Explicit Implements IClass1 Private Sub IClass1_DoSomething() End Sub You can decide to rename method IClass1_DoSomething to something else if you want, and Rubberduck will let you do it. It shouldn't. Rubberduck knows that this method is an implementation of member DoSomething from interface IClass1 - it shouldn't let you rename IClass1_DoSomething...
and make the code non-compilable. There should be an informative message displayed to the user instead. > Method IClass1_DoSomething cannot be renamed without breaking the code. Or something along these lines.
 
Mat's Mug
Mat's Mug
^^ not a bug, just a nice-to-have. #IdiotProofing
 
RubberDuck
RubberDuck
Sounds like preventing a bug report to me. =;)-
 
FreeMan
FreeMan
@SimonAndréForsberg Just claiming that my ineptitude was a feature, not a bug
 
Duga
Duga
> Or, if `IClass1_DoSomething` is selected, prompt the user with:

> *Rename interface member?*

And if confirmed, rename the `DoSomething` member of the `IClass1` interface instead of the selected `IClass1_DoSomething`
 
RubberDuck
RubberDuck
Is it a bad sign if I want to name a constant MagicBitShiftingNumber?
3
 
Mat's Mug
Mat's Mug
2:58 PM
You seem to want array semantics. Why not just stick to an array then? — Mat's Mug 37 secs ago
 
FreeMan
FreeMan
@RubberDuck only if that's not what the constant is for
 
RubberDuck
RubberDuck
.... I'd say it means I don't understand the problem well enough yet.
 
skiwi
skiwi
How does this look?
 
RubberDuck
RubberDuck
I don't like programming via superstition.
 
skiwi
skiwi
 
RubberDuck
RubberDuck
3:04 PM
Looks like that start of a good design. ;)
Mock it up and run it past the UX folks.
Okay, It's starting to make sense. 
011110000 == 240 ==  f0 == constant for pulling out icon
000010000 ==  16 ==  10 == vbCritical
000100000 ==  32 ==  20 == vbQuestion
000110000 ==  48 ==  30 == vbExclamation
001000000 ==  64 ==  40 == vbInformation

000000001 ==   1 ==   1 == vbOkCancel
100000000 == 256 == 100 == vbDefaultButton2
000010000 ==  16 ==  10 == vbCritical

100010001 == 273 == 111 == vbOKCancel + vbCritical + vbDefaultButton2
011110000 == 240 ==  f0 == constant for pulling out icon
------------------------Bit-Wise AND
BINGO! 
000010000 ==  16 ==  10 == vbCritical
000100000 ==  32 ==  20 == vbQuestion
000110000 ==  48 ==  30 == vbExclamation
001000000 ==  64 ==  40 == vbInformation
------------------------Bit-Wise OR
011110000 == 240 ==  f0 == constant for pulling out icon
Soooo what do I name the magic constant?
......
 
Mat's Mug
Mat's Mug
vbNonsense
3
 
RubberDuck
RubberDuck
18 mins ago, by RubberDuck
Is it a bad sign if I want to name a constant MagicBitShiftingNumber?
 
skiwi
skiwi
@RubberDuck Not trying to design that much yet though :P
Now if this design could also just as easily be made on the web, then I'd be happy
but for some reason they always turn out to be crappy
 
RubberDuck
RubberDuck
Ya know, when you were talking about design earlier, I thought you meant UML diagrams.
 
skiwi
skiwi
3:20 PM
I did
But I decided I needed an interface mockup as well, to clarify the UML diagrams
 
RubberDuck
RubberDuck
good man
 
skiwi
skiwi
Now if I could only draw such UML diagrams by hand without mistakes ;)
It feels good to have a designed GUI, it's something tangible!
A problem we're having is that this mockup is to support Github events... In reality @Duga also has Travis events and perodical tasks
If we can manage to fit those into the design of the initial release (not the implementation) then that would be great, but I'm quite lost there
 
RubberDuck
RubberDuck
Private Function GetVbIconType(ByVal style As VbMsgBoxStyle) As Integer
    ' There's a lot of bit shifting magic here.
    ' The Icon Type is retrieved by OR-ing the valid values together.

    'Binary       Dec    Hex    Description
    '
    '000010000 ==  16 ==  10 == vbCritical
    '000100000 ==  32 ==  20 == vbQuestion
    '000110000 ==  48 ==  30 == vbExclamation
    '001000000 ==  64 ==  40 == vbInformation
    '------------------------Bit-Wise OR
    '011110000 == 240 ==  f0 == constant for pulling out icon
21 Lines of Comment; 2 Lines of Code
2
in The 2nd Monitor, 12 mins ago, by skiwi
It explains the intents, which are absolutely magic and hackery
 
skiwi
skiwi
What ar eyou attempting to even do @RubberDuck?
 
RubberDuck
RubberDuck
I have a bunch of code through out my code base that displays a semi-standardized message box on error.
The dev can over-ride the default styling a bit though.
 
skiwi
skiwi
3:34 PM
This is work-related and not RD, right?
 
RubberDuck
RubberDuck
Now, I need to translate that styling into an error severity level for database logging of the errors.
Yeah. Work.
 
skiwi
skiwi
Whatever you are doing... It sounds complicated!
 
RubberDuck
RubberDuck
@skiwi Only because M$ made it complicated....
I'm supposed to be done with this by now.
 
skiwi
skiwi
Most things really do make a lot of sense, but it takes a while to understand them
Like UML diagrams
 
Mat's Mug
Mat's Mug
> errorStmt : ERROR WS valueStmt;
it's there
 
RubberDuck
RubberDuck
3:55 PM
Ahh good.
 
Mat's Mug
Mat's Mug
you know what? I'll leave that one for you to implement! :)
 
RubberDuck
RubberDuck
Sure. Should be simple enough. If it exists, it's a hit.
 
Duga
Duga
 
Mat's Mug
Mat's Mug
4:12 PM
just override EnterErrorStmt
then you can do something like this: github.com/retailcoder/Rubberduck/blob/…
that's the "too easy" part. the "fun" part is implementing the quickfix :)
 
Mat's Mug
Mat's Mug
5:00 PM
of all naming conventions.... alllowercase is the worst IMO
> Sub pullfrommsaccess()
Unrelated, but I'd suggest you drop alllowercase and adopt a camelCase naming convention for your locals, and PascalCase for procedure names. Readability++ — Mat's Mug 55 secs ago
 
skiwi
skiwi
 
Mat's Mug
Mat's Mug
(hides)
 
cheezsteak
cheezsteak
5:25 PM
I think the coffee at my work is extra caffeinated. After a week of my Gevalia this feels like I'm having a jittery heart attack.
 
RubberDuck
RubberDuck
@Mat'sMug wHAT ABOUT sQL cASE?
I have another reason not to ever use With in VB6. 
With New ADODB.Command
    Set .ActiveConnection = bimic.Connection
    .CommandType = adCmdText
    .CommandText = sql

    .Parameters.Refresh

    .Parameters(0).value = moduleName
    .Parameters(1).value = procName
    .Parameters(2).value = severity
    .Parameters(3).value = Err.Number
    .Parameters(4).value = Err.Source
    .Parameters(5).value = Err.Description
    .Parameters(6).value = IIf((OptionalText = vbNullString), Null, OptionalText)
    .Parameters(7).value = Environ("UserName")
Can't inspect the command object in the locals window.
And this is how you're supposed to use With.
Anyway... <lunch.
 
skiwi
skiwi
Naming issue detected!
I'm looking for a general name of an object in Duga Web Interface having multiple Endpoints and Users that can modify those
Currently it's called a Repository, but we also want to support tasks (like the daily @Duga RELOAD!)
 
FreeMan
FreeMan
@RubberDuck Nice, but not useful if your SP happens to have a return parm or you're returning data.
 
Mat's Mug
Mat's Mug
5:46 PM
@FreeMan this is:
10
Q: Creating ADODB Parameters on the fly

Mat's MugI have put together a small wrapper class to simplify creating parameterized ADODB queries with VB6/VBA. At this point I'm keeping things simple, so it's only supporting input parameters and from what I've tested it seems to work exactly as intended. The main reason for writing this, is because ...

sql-server vba sql-injection vb6 adodb
 
RubberDuck
RubberDuck
5:56 PM
@FreeMan it's actually a parameterized text query.
I was just pointing out how stupid With can be. Even when you do it right.
Annndddd a new answer on a year old post.
 
FreeMan
FreeMan
6:50 PM
@RubberDuck nice kick in the shins
 
Mat's Mug
Mat's Mug
7:29 PM
@RubberDuck Huh? Comments? Documentation? But why?
 
RubberDuck
RubberDuck
@Mat'sMug Because you kept repeating that "The client is responsible for this", but someone looking at the code would have to figure that out for themselves.
 
Stack Exchange
Stack Exchange
7:56 PM
0
Q: Excel VBA - Get Folder Names

Anurag SinghI need to get folder names with the path for which I need to search the directory in a server with about 6000 folders. I have the following snippet of code to run through the folder and get the folder names with path. It works fine in a local directory but when I run the same code on a server dir...

vba excel
 
Simon André Forsberg
Simon André Forsberg
pimping have you seen this answer?
2
A: Should I use static method (C#)

Simon André ForsbergWhat you have here seems to be a version of the Static Factory Pattern. This is a well-known pattern and is perfectly fine to use. You might also be interested in the non-static version of the Factory Pattern. I assume HttpClient is not "your class", in which case you of course can't add a meth...

 
Mat's Mug
Mat's Mug
8:14 PM
> I assume HttpClient is not "your class", in which case you of course can't add a method inside the class itself.
@SimonAndréForsberg but this is C# - you can write an extension method for anything!
(not saying it's a good idea to extend a concrete type though)
 
FreeMan
FreeMan
@StackExchange interesting... cross-posted to Code Review. Someone want to flag the CR version for removal, since it really should be on SO?
 
Simon André Forsberg
Simon André Forsberg
@Mat'sMug good point! totally forgot about that actually. But indeed, probably not a very good idea to do so
 
RubberDuck
RubberDuck
@StackExchange Off topic.
@FreeMan LOL. I just voted to close.
This gets my downvote here too. There's not enough information to solve the problem. You need to tell us where the code fails and how. What's the error? — RubberDuck 14 secs ago
 
Mat's Mug
Mat's Mug
I'm on the fence here. The code works... but fails because I presume the folder names get too long. Do they? It's impossible to tell just by looking at the code, but I suggest you also print the length of the subfolder names you're getting. If it's too deep and folder names get longer than [what I think I remember as being] 240 characters, that's where it blows up. You need to handle runtime errors here. Basically if handling long folder names is part of your spec, this code doesn't work as intended and thus, isn't ready to be peer reviewed on this site. Good luck! — Mat's Mug 9 secs ago
 
FreeMan
FreeMan
@Mat'sMug oddly enough, I offered code review on the SO post, you offered fix it advice on the CR post.
Cross-post chaos ensues!
 
Mat's Mug
Mat's Mug
8:22 PM
lol
@RubberDuck we're not alone!!
If you're getting errors on update to 9.1 from within VS, please download full or web installer from https://www.jetbrains.com/resharper/download/ Apologies...
Tweeted by resharper on April 9, 2015 at 8:17 PM
#ShitHappens
@FreeMan @RubberDuck I've retracted my close vote
The code works absolutely fine.. but it hangs when the script is run on a server location where I have around 6000 folders. I am not sure why it takes so much time hence I posted here for optimization — Anurag Singh 9 mins ago
 
FreeMan
FreeMan
8:40 PM
Yes, the confusion between "hangs" and "takes so much time". Hard to know which it is at the moment
 
RubberDuck
RubberDuck
I'm still on the fence @AnuragSingh, but I'll give it the benefit of the doubt and retract my vote if you edit that (vital) information into your question. — RubberDuck 10 secs ago
@Mat'sMug That seriously makes me feel so much better.
#InstallersAreHard
 
Mat's Mug
Mat's Mug
RT'd ;)
 
Stack Exchange
Stack Exchange
If you're getting errors on update to 9.1 from within VS, please download full or web installer from https://www.jetbrains.com/resharper/download/ Apologies...
Tweeted by resharper on April 9, 2015 at 8:17 PM
 
RubberDuck
RubberDuck
@resharper #InstallersAreHard
Tweeted by Rubberduck203 on April 9, 2015 at 8:49 PM in reply to resharper
 
FreeMan
FreeMan
ruh-roh, George!
>See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.Runtime.InteropServices.COMException (0x80004005): Error HRESULT E_FAIL has been returned from a call to a COM component.
at Microsoft.Vbe.Interop._VBComponent.get_CodeModule()
at Rubberduck.Inspections.OptionBaseInspection.<GetInspectionResults>d__2.MoveNext() in c:\Users\Christopher\Source\Repos\Rubberduck\RetailCoder.VBE\Inspections\OptionBaseInspection.cs:line 23
>Unhandled exception has occurred in a component in your application. If you click Continue, the application will ignore this error and attempt to continue.
>Error HRESULT E_FAIL has been returned from a call to a COM component.
 
RubberDuck
RubberDuck
8:50 PM
> Error HRESULT E_FAIL has been returned from a call to a COM component.
 
FreeMan
FreeMan
that's what I said...
 
RubberDuck
RubberDuck
Why is it pointed at my code base anyway???
Heh...
 
FreeMan
FreeMan
It was fixing an implicit ByRef & refreshing the Inspections window then that popped up.
 
RubberDuck
RubberDuck
Latest version?
Yeah. 1.22.
 
FreeMan
FreeMan
I was going to ignore it, then I realized, "Hey, I know the devs!"
 
RubberDuck
RubberDuck
8:52 PM
Damn.
Can you repro on demand?
 
FreeMan
FreeMan
lemme see.
I get a blank Code Inspections window and refreshing doesn't do anything.
Blank as in, there's no grid. I've got the buttons, and the column headers, but solid grey below that.
It says 0 issues
 
RubberDuck
RubberDuck
@FreeMan I'm gonna go drink a beer or twelve, but if you figure out how to repro it, please leave repro steps and stack trace here github.com/retailcoder/Rubberduck/issues/new
 
FreeMan
FreeMan
enjoy yourself. After restarting Access, no repeat of the error. It had not yet actually fixed the missing ByRef
 
sᴉɔuɐɹɥԀ
sᴉɔuɐɹɥԀ
9:26 PM
mONKING!
 
Duga
Duga
10:21 PM
 
PetLahev
PetLahev
@Duga @RubberDuck @Mat'sMug this one is about the mysterious Cast problem, just one test to show you what I had to do to solve it. I'm sure, Moq can do that, I just don't know how. Thanks!
 
RubberDuck
RubberDuck
10:47 PM
Okay @PetLahev. I'll try to look later. I haven't had a chance to play with the Moq yet. Unfortunately, all of the code is so VBE reliant, it's hard to say what needs mocked until you dive into the internals of the code under test.
 
Mat's Mug
Mat's Mug
11:35 PM
@FreeMan FWIW I saw something like that the other day, where a COMException was thrown in the OptionBaseInspection. It's fixed in next release, the inspection is working against the Declarations API (because ModuleOption is now a DeclarationType)
 

« first day (307 days earlier)      last day (2873 days later) »