@RubberDuck In an ideal world we'd have an adapter interface to wrap the VBE & ANTLR stuff. Then we could isolate them... but it would be so much work, only for the benefit of... adding more work in writing unit tests. '~'
The problem is we don't just rely on the VBE itself. It's all of the thing's it exposes. Then you don't just have to mock the VBE, But the projects collection and a project and a component, ad naseum.
We can do better about just injecting what we actually need I think.
But then we have to be disciplined about not walking up and down the object chain.
Tests aren't the end all be all, but they make me feel better when I change something.
@RubberDuck Yes, but then the purpose of an adapter is to shape objects into something else that's more practical for our needs; IVBEAdapter, IVBProjectAdapter, and IVBComponentAdapter should be all we need, assuming we consider a component and its codepane as being the same thing.
IDK, maybe it's just an abstraction layer we don't really need.
There's just so much functionality built and on the roadmap. I want to make sure it's maintainable. I plan on working on RD for the foreseeable future.
With the VBE object model tucked behind an interface, we can get rid of a bunch of extension methods and build lots of functionality in these adapters. And then we can write a test that validates that SetSelection is called with the expexted parameters when a tree node is doubleclicked, for example.
> We're adding the Ru&bberduck menu before the &Window menu: public void Initialize() { var menuBarControls = IDE.CommandBars[1].Controls; var beforeIndex = FindMenuInsertionIndex(menuBarControls, "&Window"); var menu = menuBarControls.Add(MsoControlType.msoControlPopup, Before: beforeIndex, Temporary: true) as CommandBarPopup; Debug.Assert(menu != null, "menu != null"); menu.Caption = "Ru&bberduck"; This means we're not inserting our menu where we think we are, in non-English...
environments, where the &Window menu can be called something else. Let's refer to commandbar controls by their ID instead of by their caption.
> Looks like I just had the same idea again. IConfigurationService already exists, so I just need to create the event and inject the service into all of the presenters that will need it.
LOL! A HashSetener is what you get when you have a listener and then want to replace all List<T> with a HashSet<T> with find/replace-all ;) — Mat's Mug19 secs ago
@Duga For now, yes - only to determine the insertion point for our Rubberduck menu!
Other than that we may eventually need to use ID's for the "break" and "reset" (pause/stop) buttons when we manage to make unit tests run asynchronously and make them abortable.
You'll usually want to skip an iteration when a given condition is met - you have 2 options in VBA:
Wrap the loop body in an If block:
For i = 1 to 100
If SomeCondition Then
' interesting iterations
End If
Next
Use GoTo to skip an iteration (and reduce nest...
@Mat'sMug Not quite the kind of duck typing I'm talking about. I'm thinking of the way Ruby (and apparently Go) will consider a class to implement an interface so long as it fullfills the contract.
You do realize that plain replacing Chr(34) with a " will result in non-compilable code, right? You'll have to escape it, and enclose it between double quotes, so you actually want to replace Chr(34) with """"... but only where it's being concatenated into a string. Doesn't look like a job for an automated script. — Mat's Mug2 mins ago
@George I've seen nesting that doesn't break code, but wrecks one's brain ;) — Mat's Mug7 secs ago
Doing this will not make the code more readable. Abort abort. If you plan on doing anything, I would replace Chr(34) with a quote "constant" . (It has to be a variable though because Chr() is a function, not a constant.) — RubberDuck15 secs ago
One good tool to find out how to automate stuff with VBA, is the macro recorder - click "record", then format your table margins, click "stop" and look at the generated code - grab the interesting part, parameterize it and plug it into your code. — Mat's Mug6 secs ago
So here's what I'm trying to do:
Open file: Pc_Profile
Create new sheet: Sheet1
Copy desired cells from Pc_Profile to Sheet1 (see script below)
Copy entire Sheet1 to new excel file: db.xls
Rename sheet to content of cell A5
Create new sheet for next script run
Basically I'm trying to automate...
I want to make a local version of IsEmpty() in a class like this:
Public Dict As Dictionary
Public Function isEmpty(columnName As Variant) As Boolean
isEmpty = IsEmpty(Dict(columnName))
End Function
This is for information hiding, so that I can call
classInstance.isEmpty("someField")
inste...
You'll usually want to skip an iteration when a given condition is met - you have 2 options in VBA:
Wrap the loop body in an If block:
For i = 1 to 100
If SomeCondition Then
' interesting iterations
End If
Next
Use GoTo to skip an iteration (and reduce nest...
So here's what I'm trying to do:
Open file: Pc_Profile
Create new sheet: Sheet1
Copy desired cells from Pc_Profile to Sheet1 (see script below)
Copy entire Sheet1 to new excel file: db.xls
Rename sheet to content of cell A5
Create new sheet for next script run
Basically I'm trying to automate...
I want to make a local version of IsEmpty() in a class like this:
Public Dict As Dictionary
Public Function isEmpty(columnName As Variant) As Boolean
isEmpty = IsEmpty(Dict(columnName))
End Function
This is for information hiding, so that I can call
classInstance.isEmpty("someField")
inste...
VBA Rubberducking
VBA Rubberducking