@RubberDuck there's something I'm not getting... my Team Explorer is saying I'm working in my CodeInspections branch... but I make a commit & push, and it goes to Master...
In HasComment,
I find it odd that you have to iterate over the characters.
Isn't there something like indexOf that returns the index or -1 otherwise?
So that the loop could be replaced with this:
index = instruction.IndexOf(CommentMarker);
return index > -1;
A test for StripTrailingComment w...
public static bool HasComment(this string line, out int index)
{
var instruction = line.StripStringLiterals();
index = instruction.IndexOf(CommentMarker);
if (index >= 0)
{
return true;
}
index = instruction.IndexOf(ReservedKeywords.Rem, StringComparison.InvariantCulture);
return index >= 0;
}
Our Rubberduck open-source VBE add-in project is coming along nicely. One of the main features we're going to be implementing in the next release, is code inspections.
I started by defining an abstraction:
namespace Rubberduck.Inspections
{
/// <summary>
/// An interface that abstracts ...
> Our Rubberduck open-source VBE add-in project is coming along nicely. One of the main features we're going to be implementing in the next release, is code inspections.
@RubberDuck most code inspections are going to be corner cases that pick up all the weird shitz VBA programmers can do! ;)
I think we can parallelize the inspections; we could analyze code on one or more background threads... ...we could actually poll the code and almost-continuously parse it on a background thread, ... ...@RubberDuck can we programmatically add/remove "bookmarks" in code? We could have a bookmark pop up whenever background inspections find something...
Ohhh that's a really good idea @Mat'sMug. I'm not sure. Let me see what I can find.
Is there a keyboard shortcut for bookmark? We could set the cursor and simulate a key press. It's hacky, but otherwise there's no programmatic access to them.
@Mat'sMug this works. Just need a robust way of finding the commandbarbutton
Sub setbookmark()
Dim editMenu As CommandBarPopup
Set editMenu = Application.vbe.CommandBars("Menu Bar").Controls(2)
Dim bookmarkMenu As CommandBarPopup
Set bookmarkMenu = editMenu.Controls(editMenu.Controls.Count)
bookmarkMenu.Controls(1).Execute
End Sub
One of my favorite R# features, Ctrl+T / "goto anything", is going to be possible to implement... just not with the keyboard shortcut. Basically it's an autocomplete dropdown/combobox that searches for all identifiers in the tree, and tells you where it's at, and lets you navigate to it.
Another one is Go to implementation - navigate to all types that implement such or such method from a base class or interface. That should be feasible too :)
I'd have waited till we packed a little bit more features before a first release, but it's fine. The worst that could happen is a lawsuit from JetBrains :)
I think there's a bug with the test explorer / TestEngine, it doesn't run tests unless you re-discover them with "run all tests" - in other words, only "run all tests" seems to work properly, the other ones seem to work when they feel like.
@Yoh create an account on Code Review, post some working VBA code, get some upvotes, and then you can come chat here any time - this place is the cradle of a little revolution in the VBA world :)
In HasComment,
I find it odd that you have to iterate over the characters.
Isn't there something like indexOf that returns the index or -1 otherwise?
So that the loop could be replaced with this:
index = instruction.IndexOf(CommentMarker);
return index > -1;
A test for StripTrailingComment w...
Our Rubberduck open-source VBE add-in project is coming along nicely. One of the main features we're going to be implementing in the next release, is code inspections.
I started by defining an abstraction:
namespace Rubberduck.Inspections
{
/// <summary>
/// An interface that abstracts ...
VBA Rubberducking
VBA Rubberducking