Code Review - 2019-05-15

« first day next day → last day (604 days later) »

SpringLearner

7:34 AM

@Jens good morning for you

Jens

7:55 AM

@SpringLearner Good evening for you :)

SpringLearner

@Jens are you free or busy

Jens

@SpringLearner 30 minitues i hav e time

SpringLearner

@Jens I am having a silly doubt

I just got the project codes from my colleague

my colleague(non java guy) says that the project is built in spring

but when I checked in pom I could not find spring dependency

<dependency>
  <groupId>org.springframework</groupId>
  <artifactId>spring-webmvc</artifactId>
  <version>${spring.version}</version>
</dependency>

Even there is not word like spring in pom file

Jens

@SpringLearner can you Show the complete pom?

SpringLearner

@Jens pastiebin.com/5cdbc8d518820

Jens

8:13 AM

@SpringLearner Looks like a J2EE project

@SpringLearner definitivly not spring, maybe there are other modules which uses this which are spring modules

SpringLearner

@Jens only jsp/servlet?

Jens

@SpringLearner there are also Jackson libs included.Thats why i think there arealso rest serices involved

SpringLearner

I can see @GET
@Produces(MediaType.APPLICATION_JSON)

Jens

@SpringLearner @Produces is from which package?

SpringLearner

8:30 AM

@Jens javax.ws.rs.Produces;

Jens

8:42 AM

@SpringLearner This is J2EE

SpringLearner

@Jens there are several jsp pages also in this application

Jens

8:56 AM

@SpringLearner This is normal

SpringLearner

9:50 AM

when I right click on the project root level and run on server then project runs and opens a page but css,jquery contents are not loaded
when I run on server then in the browser opens and tried to open http://localhost:8080/PaymentWeb/ but the page is not loading properly
for example the I am getting the error in browser console GET http://localhost:8080/css/style.css net::ERR_ABORTED 404
when I checked the jsp page, I found that <link rel="stylesheet" type="text/css" href="<fmt:message key="app.root.context" />/css/style.css" />

Jens

10:45 AM

@SpringLearner loos like the context root is not set correctly. Can you look into the Project if the file exists end where?

SpringLearner

@Jens sorry did not understand you

Jens

11:26 AM

@SpringLearner What excectly?

2 hours later…

SpringLearner

1:14 PM

@Jens this line Can you look into the Project if the file exists end where?