The 2nd Monitor

Duga

00:20

REFRESH! There are 5572 unanswered questions (92.8198 answered)

Captain Obvious

06:31

0

Q: How to write efficient pattern search algorithm for infinite integer string in R

Let X = "1234567891011..." the infinite string contains all positive intergers. str is a sequence of digits. We are asked to find the first location in X that str appears. I have tried the KMP algorithm. It runs fine on small input, make did poor on input such as str = "667788999". It takes forev...

algorithm r

Duga

07:00

possible answer invalidation by greybeard, Joseph Shao on question by Joseph Shao: codereview.stackexchange.com/posts/294125/revisions

@deceze, the part of the question that asks, "to print the histogram vertically" would be off-topic on Code Review, as that's a request to change the functionality. See the guidance. — Toby Speight 51 secs ago

Captain Obvious

07:16

1

Q: Is this Python decorator a good idea to solve circular recursion?

I have several model classes, let's say A_0, A_1, ..., A_N I have a method A_0.to_A_1() that calls A_1.to_A_2(), ... that calls ..., that calls A_(N-1).to_A_N() So far so good, but A_N may then call again to_A_M() with M < N if A_N is an instance of A_K with K < M. That's bad! So I came up with t...

python recursion

Duga

may be codereview.stackexchange.com would be a better place? — Oersted 8 secs ago

Duga

09:29

IMO SustainedAction knows too much about Character. In particular it shouldn't add/remove instances of itself to/from ActionsInParticiption. As an idea to consider: SustainedAction has only a Target and no Player property. A Character has multiple SustainedActions and is responsible for adding to and removing from that list. Also if you ask your question at codereview.stackexchange.com and add some more details you will likely get much better answers than here. — Good Night Nerd Pride 9 secs ago

Duga

10:09

@oliver code review the use a raw pointers pointing to memory managed by owning pointers - this should be a red flag. — Richard Critten 43 secs ago

Duga

10:22

@RichardCritten The bug came up in my code because an object method was called on the weak_ptr, but then that object method passed its this pointer to a lambda that was executed in a deferred manner on another thread. I will try to catch such cases by code review, but my impression is that there were no "obvious" red flags; only the combination of these actions caused the bug. — oliver 48 secs ago

Duga

10:45

possible answer invalidation by Alexander Ivanchenko on question by Sergey: codereview.stackexchange.com/posts/294099/revisions

Before you post at Code Review, be sure to read A guide to Code Review for Stack Overflow users, as some things are done differently over there - e.g. question titles should simply say what the code is for, as the question is always, "How can I improve this?". Be sure that the code works correctly; include your unit tests if possible. You'll likely get some suggestions on making it more efficient, easier to read, and better tested. — Toby Speight 38 secs ago

Toby Speight

11:12

@Duga Looks like the code is unchanged - just presented in a different order.

Duga

11:36

Happy to try to post to codereview if that's a better place to get answers. Note that the purpose was not really a code review, but rather a more generic question on what the right way to use a custom std::formatter is when many sources including text books seem incorrect (breaking a combination of 1-3). I updated the code sample to be more illustrative. — digitalvision 21 secs ago

Duga

13:04

To the second close vote: I do not need a code review, I have specific debugging needs, as explained. I do not ask exactly where is the problem, just some idea how to find it. — virolino 5 secs ago

Duga

15:00

possible answer invalidation by PUBSGUSO on question by PUBSGUSO: codereview.stackexchange.com/posts/294125/revisions

toolic

@Duga: Rolled back edit and left comment

Duga

possible answer invalidation by PUBSGUSO on question by PUBSGUSO: codereview.stackexchange.com/posts/294125/revisions

Sᴀᴍ Onᴇᴌᴀ

16:16

Monking

skiwi

18:30

Monking

Duga

22:05

Opinions aren't something that Stack Overflow works well with. How are we to rate one person's opinion over another? If you're looking for a code review, we have Code Review, but you should be sure to read their help center to make sure you can make your question on topic over there (they have very specific rules, just like we do). Performance optimization is generally about trade offs; you can make it faster, but it uses more memory; or it uses less memory, but it's slower. Decide what's most important to you and optimize for that. — Heretic Monkey 48 secs ago

Transcript for