The 2nd Monitor

12:00 AM

There are 1361 unanswered questions

@larsks: Code Review is explicitly not for questions about "higher-level architecture and design of software systems", which I believe this question is about. — Qantas 94 Heavy 2 mins ago

Mat's Mug

@Duga there's hope for humanity after all

Simon André Forsberg

@Mat'sMug give him an upvote!

Mat's Mug

Done :)

Simon André Forsberg

Case closed. Good mug :)

Mat's Mug

Hosch is hyperactive on RD, seen the summary?

Hosch250

12:07 AM

@Mat'sMug I saw that.

Simon André Forsberg

@Mat'sMug I saw that summary yes. Were all of that @Hosch250?

in TCG Creation, 9 mins ago, by Duga

[retailcoder/Rubberduck] 19 commits. 3 issue comments.

RubberDuck

Most I believe. He's certainly outpacing me. =)

Simon André Forsberg

me too (especially on RubberDuck activity :P)

I hope to make some Groovy commits tomorrow

Hosch250

Well, you see, I commit a lot so I have backups.

I get it working on sample data, and commit.

Then, I get it working on the real data, and commit.

Then, I start fixing bugs, and commit every few bugs.

So, lots of commits.

Simon André Forsberg

I also tend to do lots of commits

I also tend to sleep a lot, which I plan to do now.

Hosch250

12:17 AM

Lol, I guess we are alike.

Simon André Forsberg

The sooner I go to bed, the sooner I wake up and the sooner I can start coding!

7

TTGTB :)

Hosch250

Yeah, only I go to bed late, and get up late.

Good night!

Simon André Forsberg

2 a.m. here so it is already late ;)

night

Hosch250

Whoa, night!

Captain Obvious

12:42 AM

0

Q: Adding SecureString support to Lib2GitSharp

A library that I use doesn't support SecureString in its credentials for connecting to GitHub, so I'm submitting a pull request to add it. I know it's not idea to pull the actual string out, but the idea here is to minimize the amount of time the string is in memory. Also, allowing client code to...

RubberDuck

@CaptainObvious, if there are any c# gurus around, I'd appreciate the sanity check.

user1950349

1:11 AM

hey guys, has anyone worked with git before? If yes, is anyone willing to help me out by importing the project to see if it can be build properly?

I am having weird issue after I imported the project as a maven after cloning the git repositories. All the package structure is messed up. All other maven projects I am able to build fine only this open source project is having issues in terms of structure

github.com/yahoo/Pistachio

Hosch250

1:24 AM

I've done Git, but I'm a bit busy right now, and I don't know Maven at all.

Hope you figure it out!

user1950349

yeah scratching my head since morning, trying all the stuffs what I read over the internet

RubberDuck

Did you clone the project?

user1950349

yes I did cloned it through SmartGit

and then imported as a maven project in eclipse

RubberDuck

I've worked with Git, but not eclipse or maven.

user1950349

I cannot paste the image here otherwise you would have get the idea what I am talking about in terms of project structure

RubberDuck

1:27 AM

But, when in doubt, I've found that deleting the local copy and getting a fresh clone helps sometimes.

user1950349

yeah I did that too as well.

I also have opened a SO post as well but nothing got so far on that. stackoverflow.com/questions/30268689/…

Now you will be getting idea what I am talking about in terms of package structure messed up.

RubberDuck

Does eclipse have any Git integration? Like, can you clone the project directly from eclipse?

user1950349

yeah there is, I have not tried that option yet. I always use SmartGit to clonee it and then import it as maven project and it worked fine always.

I can try out directly importing from eclipse to see whether that helps or not.

RubberDuck

It might? Idk.

Don't know much about Java.

user1950349

let me try that out

I still see same error

Ethan Bierlein

1:44 AM

I just love today's xkcd.

RubberDuck

How'd you break it?

Oh. Love. Damn. Must be tired.

SirPython

@EthanBierlein According to that 8 ball, I'm going to die by cake and roses.

Captain Obvious

0

Q: jQuery selector function in JavaScript

I've reproduced the jQuery selector function in JavaScript: Here are the two rules that come with this function: I.You may not use any JavaScript libraries II. document.querySelector/document.querySelectorAll may not be used var $ = function (selector) { var elements = []; // get starting i...

javascript jquery

Ethan Bierlein

@SirPython According to the 8 ball, I'm going to die at the hands of the spawn of satan, er, santa.

Duga

And I can't flag as off-topic.... There's no option to go to code review... Anyways, Stack Overflow is the place to diagnose and solve real issues for your code. If you want feedback from fellow programmers on your code that is functional, you are better off at codereview.stackexchange.com. — Zizouz212 36 secs ago

Jamal

2:33 AM

Well, I've just learned that I made a B in operating systems, one of the hardest classes taught at this school.

Hosch250

@Jamal Is that good?

Congratulations, if so, condolences otherwise.

Jamal

Oh no, that's excellent. :-) I was expecting a C or a D.

Hosch250

Congrats!

Jamal

Thanks!

Hosch250

So, you are graduated now?

Jamal

2:44 AM

Officially, I won't know until the 27th. Commencement does not at all indicate graduation.

Hosch250

OK.

Jamal

Though, at this point, I absolutely do not see any reason to think that it won't be happening. Still, the dean will be making that decision.

Hosch250

Good luck!

Jamal

Now I just have to wait. :-)

Hosch250

Just don't make the dean mad :)

So, I suppose you'll be interviewing now?

Jamal

2:48 AM

I won't. I don't plan on dancing across the stage tomorrow. That's high school crap. :P

2

Hosch250

I didn't do that when I graduated.

Jamal

I'll be sending out resumes first. As for interviewing, I'll really need to see how that goes. I have no practice with that at all.

Hosch250

I finished my Calc book just days before I graduated, and that is about when I started programming - two years ago +- a few weeks.

And, I've never interviewed either, so no I can't help there.

I need to get an email off to the MS recruiter for a potential internship next summer.

Mat's Mug

@Veedrac Thanks Captain Obvious! — blanco cayo 2 days ago

@mjolka you here?

congrats @Jamal :)

Jamal

Thanks!

Captain Obvious

3:17 AM

0

Q: Lemonade Game Java

I am writing the lemonade stand game in java but I am having a bit of trouble trying to figure out the perfect recipe I have most of the code done. except the math logic seems a little off. Please let me know if I can improve the code I would really appreciate it. I've been stuck in this part for...

java programming-challenge

mjolka

@Mat'sMug hello :)

Mat's Mug

XKCD what-if is a dangerous time-waster

21 hours ago, by mjolka

@Mat'sMug re that question, i think we need to talk about async some time. i'm not 100% on things so i won't post an answer, but hit me up when you want to chat

mjolka

yup yup

so let's look at OnRefreshCodeInspections

only invoked on the UI thread, right?

Mat's Mug

right

mjolka

ok, so why not make it async void? then you can write await RefreshAsync(); Control.SetIssuesStatus(_results.Count, true);

Mat's Mug

3:22 AM

hmm

instead of Task.Run(() => ...)

mjolka

right

private async void OnRefreshCodeInspections(object sender, EventArgs e)
{
    await RefreshAsync();
    Control.SetIssuesStatus(_results.Count, true);
}

Mat's Mug

and async void is only good because that's an event handler right?

mjolka

yep

Mat's Mug

now, first thing it does:

        Control.Invoke((MethodInvoker) delegate
        {
            Control.EnableRefresh(false);
            Control.Cursor = Cursors.WaitCursor;
        });

Nobel prize

moved to handler

mjolka

yeah it would be really nice to be able to remove all calls to Control.Invoke

Mat's Mug

3:27 AM

and removed the finally block

        private async void OnRefreshCodeInspections(object sender, EventArgs e)
        {
            Control.EnableRefresh(false);
            Control.Cursor = Cursors.WaitCursor;

            await RefreshAsync();

            Control.Cursor = Cursors.Default;
            Control.SetIssuesStatus(_issues, true);
            Control.EnableRefresh();
        }

mjolka

i'm not sure how to go about that, though

i would probably keep the finally block

Mat's Mug

actually..

        private async void OnRefreshCodeInspections(object sender, EventArgs e)
        {
            Control.EnableRefresh(false);
            Control.Cursor = Cursors.WaitCursor;

            await RefreshAsync();

            Control.SetContent(_results.Select(item => new CodeInspectionResultGridViewItem(item))
                                        .OrderBy(item => item.Component)
                                        .ThenBy(item => item.Line));

            Control.Cursor = Cursors.Default;

and voilà

I'm just adding a null-check and setting _results to null in the catch block

actually, no

            try
            {
                if (VBE != null)
                {
                    if (_parseResults == null || _needsResync)
                    {
                        _inspector.Parse(VBE, this);
                        return;
                    }

                    var parseResults = _parseResults.SingleOrDefault(p => p.Project == VBE.ActiveVBProject);
                    if (parseResults == null || _needsResync)
                    {
                        _inspector.Parse(VBE, this);

now, one problem I have, is that this method gets called more often than I thought it would

and actually, I'm seriously questioning if there's any gain in sharing parse results between features.

it's causing serious issues

e.g. code inspections are running - bring up the Code Explorer; code inspections restart... and "freeze"

mjolka

yeah i'm still not sure how to deal with that

Mat's Mug

well they don't actually freeze, they just remain in "reporting 'inspecting...' status" without doing any real work

easiest is to remove the parser handlers and get the results from the parser instead of from its events

having parseresults-per-feature means unsync'd results between toolwindows

and it's pretty much the best UX I can get I think

mjolka

i feel like the code is more complicated than it could be, because you can't guarantee that the event handlers are being invoked on the UI thread

which i think ties in to the problem of trying to share parse results

Mat's Mug

3:39 AM

should the parser synchronize them?

mjolka

synchronize what?

Mat's Mug

isn't there a way to have the parser only ever raise its events on the UI thread?

nah, I didn't ask that

scratch that

mjolka

i'll keep having a think about it, off to have lunch

Mat's Mug

parser should just be concerned about being thread-safe

later!

Ethan Bierlein

Man, I wish I knew more about language design. I have so many ideas...

Mat's Mug

3:49 AM

you know BNF notation?

Ethan Bierlein

Nope.

Mat's Mug

Rubberduck's grammar for VBA

Ethan Bierlein

Is this it?

Backus–Naur Form

In computer science, BNF (Backus Normal Form or Backus–Naur Form) is one of the two main notation techniques for context-free grammars, often used to describe the syntax of languages used in computing, such as computer programming languages, document formats, instruction sets and communication protocols; the other main technique for writing context-free grammars is the van Wijngaarden form. They are applied wherever exact descriptions of languages are needed: for instance, in official language specifications, in manuals, and in textbooks on programming language theory. Many extensions and variants...

Mat's Mug

yes

if you can define your language's grammar in that notation, you have a nice start :)

Is this answer wrong or just underexposed? (it's Friday night afterall)

0

A: Adding SecureString support to Lib2GitSharp

I don't see a problem with how the SecureString objects are handled - seems pretty solid to me, but I've never used those so I'm possibly missing something that someone else could point out here. Sealed Class I haven't looked at the actual project's source code, but general design guidelines ...

Ethan Bierlein

I could probably learn a lot of things if I didn't spend so much time playing Kerbal Space Program...

Captain Obvious

3:56 AM

0

Q: JMH Benchmark Metrics Evaluation

I'm currently attempting to learn some basic JVM optimization techniques using JMH. As the documentation states Your benchmarks should be peer-reviewed and, I'm not quite sure how to validate the results, I'm asking for a review of the following implementation to determine whether my workflow is...

java performance

Mat's Mug

lol

Hosch250

Looks underexposed to me.

Mat's Mug

:)

Phrancis

4:12 AM

Monking!

Mat's Mug

Monking!

Ethan Bierlein

I'm afraid to ask, but what does "monking" mean?

Phrancis

On phone otherwise i'd link. Mug?

Mat's Mug

19

A: What's a Zombie? And what are the many other memes of Code Review?

Meme: Monking Originator: Morwenn Cultural Height: The 2nd Monitor Background: A morning greeting to the Monkey doing his monkey-business, in other words: monking Examples: A small chat search Variations: Monkernoon, Monkevening, Monknight, ... Important is only that it begins with Monk... ;...

Phrancis

That one i think has stuck the best

Along with starring "lol"

4

Mat's Mug

4:21 AM

and Jamalized

Phrancis

Anyone interested to check out a good rock band, just saw Phosphene tonight out of Chicago. Got to help them set up gear, and chat with them after the show. Really cool and talented group

Hosch250

Any VBE devs here?

I need a VBA event to test my code against.

Also, a Property Get/Let/Set.

Phrancis

Was really impressed that a band who opened for Lacuna Coil in a 10K people venue stopped on their tour to play a very small local venue in Indiana

Mat's Mug

@Hosch250 vba <~ click here

Hosch250

Lol.

OK, thanks.

Mat's Mug

4:28 AM

actually...

Hosch250

I found a Get/Set on SO.

I feel like upvoting just because it was there.

Mat's Mug

Public Event Foobar(ByVal arg1 As Integer, ByVal arg2 As String)

Hosch250

Thanks.

Phrancis

@Hosch250 I upvote questions and answers on SO all the time crom Google, if thy helped me

Thy?

Hosch250

@Mat'sMug Now, how would I call that event?

Phrancis

4:31 AM

Thou shalt vote on SO posts where the post hath helpeth thy problem.

Hosch250

Like, this doesn't work:

Goodbye.

11th commandment

Bye.

@Hosch250 RaiseEvent Foobar(42, "Monking!")

Hosch250

4:32 AM

OK, thanks.

Mat's Mug

the handlers need to be addressed, too

Hosch250

Success reported.

Mat's Mug

say the event is declared in Class1

Hosch250

OK, then I need a handler.

Mat's Mug

and Class2 needs to handle Class1's event

so Class2 will have a Private WithEvents abc As Class1 field

Hosch250

4:34 AM

And?

Mat's Mug

and given abc is the name of the field, and Foobar is the name of the event

Hosch250

Public Event Foo(ByVal arg2 As String, ByVal arg1 As Integer)

Public Sub Goo()
    Dim test1 As Integer
    test1 = 3

    Dim test2 As String
    test2 = "rest"

    RaiseEvent Foo("Hi!", 42)
    RaiseEvent Foo(test2, test1)
End Sub

So, it did that for me.

Mat's Mug

the handler will be Private Sub abc_Foobar(ByVal arg1 As Integer, ByVal arg2 As String)

see?

Hosch250

In a different file?

Sort of.

Mat's Mug

yes

Hosch250

4:35 AM

I know C# handlers.

Mat's Mug

the thing is, the handlers aren't picked up as references of the event declaration

only the RaiseEvent call is

Hosch250

So, how do I specify the classes?

Mat's Mug

what do you mean, specify?

Hosch250

Create then.

Like, do I have to create the class to put stuff in?

Phrancis

@Hosch250 With caution.

Mat's Mug

4:38 AM

yes, I'm pretty sure only a class can handle events.

Hosch250

I have a Class object/file/whatever.

Is there any code I need to do other than that?

Mat's Mug

notice the two dropdowns in the code pane window?

Hosch250

Yeah.

It picked the class up.

Mat's Mug

if you've declared a WithEvents instance field, you should see that field name in the left-hand dropdown

Hosch250

Mat's Mug

4:41 AM

exactly

Hosch250

Only thing is, Class1 doesn't compile.

It crashes on the first line.

It says it doesn't source automation events.

Mat's Mug

wait no

declare the event in Class1, and subscribe to it in Sheet1

Hosch250

So now it says event not found at the first Raise

Mat's Mug

only the class that declares the event is allowed raising it

Hosch250

I'm saving all this in a file for future use.

Mat's Mug

4:44 AM

basically you had it all reversed

or, well you had it ok, except WithEvents abc As Class1 should be As Sheet1 but I'm not sure that's legal

Hosch250

This works:

Mat's Mug

ok now in Sheet1 select abc from the dropdown

Hosch250

And changing that to Sheet1 gives the automation error now.

What dropdown?

Mat's Mug

the left one

Hosch250

Oh, got it.

Mat's Mug

4:46 AM

that is your event handler

Phrancis

You guys are VBEing at the speed of light

Excel crashed.

It does that.

lol

I'm using a beta version too.

Mat's Mug

4:47 AM

better play it safe and not involve worksheets here

Phrancis

Crashing Excel is astoundingly easy even through the GUI

Hosch250

I have no worksheets.

Mat's Mug

Sheet1 is a worksheet...

I'd say create 2 class modules, Class1 and Class2. Class1 defines the event (and optionally raises it), and Class2 declares a WithEvents instance of Class2 (and handles the event)

Phrancis

So. I could (1) finish a song, (2) write documentation, (3) watch the final episode of Top Gear, or (4) go to bed. Any suggestions?

Mat's Mug

crash-course-in-oop-vba

(5) kill a zombie

Phrancis

4:52 AM

On any other given day, sure. But ears are ringing really bad and.. it's Friday night

Mat's Mug

just a suggestion ;)

Hosch250

OK, back to where we had it.

Private WithEvents abc As Class1


Private Sub abc_Foo(ByVal arg1 As Integer, ByVal arg2 As String)

End Sub

That is Class2.

Public Event Foo(ByVal arg1 As Integer, ByVal arg2 As String)


Private Sub abc_Foo(ByVal arg1 As Integer, ByVal arg2 As String)

    Dim test1 As Integer
    test1 = 3

    Dim test2 As String
    test2 = "test"

    RaiseEvent Foo("Hi!", 4)
    RaiseEvent Foo(test1, test2)

End Sub

Mat's Mug

looks good

Hosch250

And Class1.

So, that's it?

Mat's Mug

although abc_Foo in class1 is confusing, it looks like a handler but it's not

just make it a parameterless Sub DoSomething() that makes the RaiseEvent calls

Hosch250

4:55 AM

Whoops.

Public Event Foo(ByVal arg1 As Integer, ByVal arg2 As String)

Private Sub Bar()

    Dim test1 As Integer
    test1 = 3

    Dim test2 As String
    test2 = "test"

    RaiseEvent Foo("Hi!", 4)
    RaiseEvent Foo(test1, test2)

End Sub

Mat's Mug

ok

now save that workbook and keep it handy ;)

the RaiseEvent Foo("Hi!", 4) line should be RaiseEvent Foo(4, "Hi!")

Hosch250

Yeah, caught that already.

Now, you were right.

Mat's Mug

about what?

the handler not being picked up?

Hosch250

It works on the Raises and the event itself, but not the handlers.

Mat's Mug

I know! lol

status-bydesign

Hosch250

4:59 AM

So, more fun stuff ahead.

Midnight here, don't want to mess anything up...

Mat's Mug

still got R# running?

Hosch250

But, can't get ready for bed either.

I have it installed, but disabled.

Mat's Mug

Ctrl+T, "declarations" ...nevermind

find the Declarations class

Hosch250

Which one?

The _declarations one?

Mat's Mug

there's only one Declarations class

Declarations

the type

Hosch250

5:00 AM

Oh, OK.

Declarations.cs?

Mat's Mug

yes

public IEnumerable<Declaration> FindEventProcedures(Declaration withEventsDeclaration)

^^ this is what you want to call

Hosch250

OK.

Mat's Mug

that will give you all the event handler procedures, given a WithEvents declaration

Hosch250

OK.

Mat's Mug

and you already know how to handle reordering parameters for a Sub declaration ;)

Hosch250

5:03 AM

Is there a way to sort of stick a "bookmark" on a line of code?

Yup.

This is getting close to being done, I think.

Mat's Mug

Ctrl+K,Ctrl+K

Hosch250

Cool, thanks.

Mat's Mug

yeah, well.. there's interface implementations then

Hosch250

Like?

Oh, Ctrl+K, Ctrl+W opens a Bookmarks Pane.

Mat's Mug

Class1 has a DoSomething method right?

Hosch250

5:06 AM

It has a Bar() method.

Mat's Mug

or Bar()

whatever

Hosch250

There are properties too.

The get/set/let.

Mat's Mug

add a Class3 and stick a DoSomething(foo, bar) in there

just the signature, no need for a body

Hosch250

Just like that?

Mat's Mug

then put Implements Class3 in Class2

Hosch250

5:07 AM

Can this wait until the events are done?

Mat's Mug

sure

Hosch250

My brain is slowing down.

Mat's Mug

just saying, it's the next challenging thing

lol

Hosch250

OK.

Mat's Mug

mine too

good news is, the Declarations class has all the methods you need to find interface methods and their implementations

Hosch250

5:09 AM

Great.

So, after reading all this test VBA code, I might pick up enough to put it on my resume :)

Phrancis

@Mat'sMug Can I go now? ;)

Hosch250

After I get it working for everything, I need to let the user click in any child context and choose reorder, and figure out what to reorder, instead of just the name of the thing to be reordered (like in the signature on a variable).

Mat's Mug

@Phrancis nice!

Hosch250

And, drag/drop would be nice.

Quill

Afternoon

Mat's Mug

5:13 AM

hi @Quill!

Hosch250

@Quill In the wee-est of the wee hours of the morning :)

Just 13 minutes into the day.

Mat's Mug

1:13AM here

Quill

3:13pm here

Hosch250

I don't know how you guys stay up so late.

I'm exhausted, and I get up hours later than you too.

Mat's Mug

it's not how late I stay up, it's how early I manage to get up!

Hosch250

5:14 AM

Yeah.

One of my sisters seems to get along on just 6-7 hours of sleep.

If I get just 9 or so regularly, I get less done in the day at worse quality than if I got up an hour later.

Hi, @Quill

Phrancis

@Mat'sMug Why thank you, though there are probably bigger problems I don't see

Hosch250

All the Australians are coming in.

Phrancis

I think it's getting comfortably past lunch time in Australia, actually

Mat's Mug

@Hosch250 that's a sign Canadians should be asleep right?

Hosch250

I guess (and Americans).

Phrancis

5:18 AM

^me. 01:18 here

But hey, it's ~~Friday night~~ Saturday morning!

Hosch250

Yeah, Friday!

I'm out of school now too, so I can actually take a break.

Phrancis

@Hosch250 You must be on the other side of those fly-over states

Hosch250

But I won't - Rubberduck is calling me :)

Well, Saturday :)

Nah, 12:19 here.

Phrancis

Ah ok, Central time

Hosch250

Yeah.

@Mat'sMug You know how you have Find All References?

It would be nice to have a Go To Definition too.

Mat's Mug

5:22 AM

what about it?

Shift+F2

Hosch250

Oh, already built in?

Mat's Mug

yeah

Hosch250

OK.

Mat's Mug

what's missing is Go To Implementation on interface methods though

Hosch250

I guess I don't know the VBE...

Mat's Mug

5:23 AM

and yet you've just implemented 80% of a crazy ass refactoring for it

Hosch250

Refactoring for what?

Mat's Mug

lol

"reorder parameters" is a refactoring...

Hosch250

Yeah, I know.

You mean, refactoring a definition we can't get to?

Mat's Mug

huh?

Hosch250

I still don't get what "it" is.

Oh, the VBE.

OK, I'm next in line to get ready for bed.

See you.

Mat's Mug

5:27 AM

later!

Phrancis

So...

Maybe I'll go watch Top Gear for a bit now, then GTB :)

I'll say one thing real quick:

> Please clarify your specific problem or add additional details to highlight exactly what you need.

(VTC as unclear default response)

I think "specific problem" should be replaced with some better wording, since CR is not really about "specific problems"

Should I post something on meta?

Or has this already been addressed?

Mat's Mug

5:43 AM

@mjolka talk about simplified!

        private async Task RefreshAsync()
        {
            try
            {
                var projectParseResult = await _inspector.Parse(VBE.ActiveVBProject, this);
                _results = await _inspector.FindIssuesAsync(projectParseResult);
            }
            catch (COMException)
            {
                // burp
            }
        }

now all I'm missing is the cancellation mechanism

Duga

5:56 AM

Are you having a specific problem or error? Otherwise, if you're just looking for feedback on your (working) code you should ask on Code Review rather than StackOverflow. — hopper 52 secs ago

Phrancis

@Duga We're getting there!

I'm still here...

in TCG Creation, 2 days ago, by rolfl

stack is crack.

o.o

TTRGTB

Mat's Mug

6:20 AM

now all I'm missing is a cancel button :)

Jeroen Vannevel

6:31 AM

@RubberDuck: good issue! Will you work on it yourself?

My occupation yesterday

professional photographer with my cheap phone

Mat's Mug

4

Q: Adding SecureString support to Lib2GitSharp

A library that I use doesn't support SecureString in its credentials for connecting to GitHub, so I'm submitting a pull request to add it. I know it's not ideal to pull the actual string out, but the idea here is to minimize the amount of time the string is in memory. Also, allowing client code t...

c# security git

that issue?

Jeroen Vannevel

@Mat'sMug github.com/Vannevelj/VSDiagnostics/issues/35

Mat's Mug

oh

lol

WBTTGTB

skiwi

7:56 AM

Monking

Duga

I wonder if you couldn't vastly improve the js rendering time. Re-using the Float32 buffer and the imageData is one way, but more generally it could be interesting to post a stripped down version of your code on codereview to get advices on optimisations. — GameAlchemist 7 secs ago

Transcript for