I'm not familiar with MR best practices, but here are some JS-specific comments. Key Points DRY - that emit code is repeated all over the place and has only slight changes - parameterize what varies and put it all in a function You are repeating your loops - either do everything in one loop fo...

I think a way to make this code generally more efficient and predictable is to have your classes have a more defined role. For example, it seems like you're defining an instance of Guess as myGuess, then externally loading in a random number (RndNum), and the current guess (UserGuess = GetUserGu...

I have four methods like these (here are only two of them): def checkLeft(clickedIndex: Int): Option[Int] = { val leftIndex = clickedIndex - 1 if (leftIndex >= 0 && clickedIndex % field.width != 0 && isEmptyCell(leftIndex)) Some(leftIndex) else None } def checkRig...

What you did well Taking advantage of the shell to split your expression into tokens is smart. It saves you from the trouble of having to write a tokenizer. Beware, though, of a usability issue with Unix shells, where * and \ have special significance and need to be quoted or escaped. Bugs ...

It's very fast, but I wonder if hooking into the API (DirectX) and getting the buffer will be faster than this (I don't know how to do that, though). I don't know either. What you have here, probably hasn't been reviewed yet, because there's essentially nothing blatantly wrong with it. W...

The current code solves the issue I had when trying to use property injection. Problem: Every module must use constructor injection because of a circular reference that occurs when not using constructor injection with my factories and trying to use property injection Reason: A module requires a...

I've seen a lot of activity about graduation recently. What are the (possible) benefits (and disadvantages) of a graduated site?

Needed a quick stream to get JSON objects. #ifndef THORSANVIL_SIMPLE_STREAM_THOR_STREAM_H #define THORSANVIL_SIMPLE_STREAM_THOR_STREAM_H #include <istream> #include <mutex> #include <condition_variable> #include <vector> #include <curl/curl.h> #include <string.h> namespace ThorsAnvil { nam...

This is my first question at code review. Below, i have listed my solution to find out the count of nodes between two nodes in a circular linked list. Please provide your review about it. Thanks in advance. public class CountNodesBetweenTwoNodes { Node first; Node fifth; private class Node<...

I want to ask your opinion on how we should handle submitted question with code that is fine. I assume that will be the case for very view of the submitted review requests since everyone likes and dislikes other things and some will will have feedback that differs from "seems fine to be". What...

I like to quote instructions and comments from other sites in my answers. A lot of the time, these quotes will have code snippets in them. Right now the integration for them doesn't look right to me; here is an example. The small code snippets can't exist in the blockquote itself on their ow...

Things you did well: You used the function gets_s, which is a C11 function. Not many people use this standard yet because it is newer. I was surprised to see it in your code. Your organization of the prototype functions is good. You initialize your variables as soon as you create them in some ...

I'm hoping all that's missing from your code is Sub DoSomething at the top and End Sub at the bottom. That's a very lengthy procedure you have here, and aside from the length itself, one sign is the "need" to append numbers to your identifiers (conn0, cmd0, rdr0, insertQuery2, ...). Naming Gett...

The code looks good: nothing to add or remove.

A few random notes: FileNotFoundException is a subclass of IOException. Declaring both FileNotFoundException and IOException is redundant. The Sampler() constructor can be omitted, since it is just the default constructor that would have been implicitly defined anyway. Your sampler() method is ...

I'll first suggest you that the raw format that you use to store your data, use a different separator than a white-space. This will simplify the code since we are sure that we have unique separator. Your TreeEntry should encapsulate his fields in getter and setter. Public field in a class is not...

This takes a width specified by user and prints a diamond of that width. It uses only three for loops, but could I reduce that further? Is there a more elegant solution? public class Diamond { static boolean cont = true; public static void main (String[] args) { Scanner input ...

Short answer: yes, you need to delete all of them. Longer answer: In such a trivial application, it doesn't matter since the OS will clean up the memory anyway when the program exists, but in general, yes, you do need to delete the objects. You are not using a special memory system here, or ...

I previously attempted to make a C++ vector here, yet it was not very successful. Now I have made a basic reimplementation of it, so I'm checking that it is fine, and that I will not have to re make it again. Note: I also implemented an allocator class, but it works the same as the std:: equival...

I am writing a wrapper to Eigen QR for my personal use and I am wondering if there are any memory leaks or undocumented behavior in my implementation, especially in the function get_QR(). The answer is as expected. This is related to my previous question here. using std::cout; using std::endl; ...

I just started picking up Python (2.X) and here I'm trying to "isolate" useful data set from a file so that I can do calculation. I get to print out lines of data (numbers) by splitting the dictionary like this: for n in lines: mesh1=n.split()[3] print mesh1 I would get the da...

Things you could improve: Variables/Initialization: You shouldn't use global variables. *front = NULL, *rear = NULL; The problem with global variables is that since every function has access to these, it becomes increasingly hard to figure out which functions actually read and write these...

I have a few comments that are unrelated to the synchronous/asynchronous and/or header-only nature of the code. parameters bools I don't like passing bools as parameters. I really dislike a function like your SimpleSocketStreamBuffer constructor that take multiple bools. You need to do a fair ...

typedef struct dict_pair { void *key; void *value; struct dict_pair *head; struct dict_pair *tail; } dict; dict* NewDictionary(void) { dict *dictionary = malloc(sizeof(dict_pair)); dictionary->head = null; dictionary->tail = null; } int main(void) { dict *dictionary = NewDiction...

I've been a PHP procedural programmer for several years but I'm trying to learn OOP and I'm getting a bit confused with some patterns and principles. I would appreciate it if you could give me some tips and advice. interface LoginAuthenticator { public function authenticate(UserMapper $userM...