I think QueryBuilder can use constructor parameters, and that its auto-properties can be changed to be { get; private set; }. Otherwise the public setters seem to make an opportunity for some trouble. Actually I'd drop the auto-properties and initialize private readonly fields, exposed by get-onl...

The assignment is very open and we have only 4 things it needs to cover: File write and read Use a Struct Export into HTML format use a common sorting algorithm so I've decided to create a little "Library" with following features: read the input file "Library.dat" List the books on the cons...

BindingModelToHtmlEh - really, an Eh suffix for a delegate? public delegate object BindingModelToHtmlEh(object sender, BindingModelToHtmlArgs args); Wait a minute. This looks like an event handler, it's got the sender and EventArgs-derived args parameters, but it returns an object. This is r...

I'm writing a list of inputs and outputs for to be compared in unit tests. var equals = [ //input //output ["name:(John Smith)", "name:(John~ Smith~)" ], ["name:Jon~0.1", "name:Jon~0.1" ],...

JavaScript [160 bytes] The following code seems to be 160 bytes unformatted. ('l2v2l6v2'+ 'e1l1v3l2'+ 'v3e1v7e1v7e1v7e1l2v6e1l4v5'+ 'e1l6v4e1l8v3e1l7l3v2e1l9l3v1') .replace(/[lve]\d/g,function (c){return Array(-~c[1]). join({l:' ',v:'Love' ,e:'\n'}[c[0 ]])})...

Not a big deal, but this: var currentVal = property.CurrentValue == null ? "" : property.CurrentValue.ToString(); var originalVal = property.OriginalValue == null ? "" : property.OriginalValue.ToString(); Can be shortened to this: var currentVal = (property.CurrentValue ?? string.Empty).ToS...

Apart from the comments provided by @lol.upvote: The code as you have posted it does not compile for two reasons: htmlList is a private member of HtmlViewContext so HtmlViewResult cannot access it. I can only assume that HtmlViewResult is actually a nested class within HtmlViewContext (oin whi...

I am fairly new to web development, and would like some feedback. It is HTML/CSS, with some JS (button hovers, anchor scrolling and image sliders) from elsewhere. Comments on best practices and any other suggestions would be great as I feel I'm probably doing a lot wrong, but specifically: I us...

I had a look through the code, if it runs slow then it is most likely a network issue from what I can tell. I think you are caching the wrong thing. A better solution might be to change the design of the tiles and remove the coordinates from them. You have 6 types of tiles Sea, sTone, Mountai...

Not a big deal, but this: var currentVal = property.CurrentValue == null ? "" : property.CurrentValue.ToString(); var originalVal = property.OriginalValue == null ? "" : property.OriginalValue.ToString(); Can be shortened to this: var currentVal = (property.CurrentValue ?? string.Empty).ToS...

CSS Instead of having 5 different rules all saying the same thing for 5 selectors. You can group them like this. h1.light, h2.light, .darkgrey a, .darkestgrey a, .button.light { color: #fff; } body, .underline.light { background-color: #fff; } Use one line for margins. h1 { mar...

Here's an example of how to implement with sqlite3. You'll need to import the following: import sqlite3 from contextlib import contextmanager And define the following constants: DATABASE_PATH = '/tmp/my_database.db' SCHEMA = '''\ DROP TABLE IF EXISTS records; CREATE TABLE records ( id IN...

I've taken the code labeled as "final revision" in your question. Some notes: data = something and then data = another_thing. So data holds two different values, that's confusing (use another variable name). Spaces between lines: Vertical space is very valuable, don't insert blank lines without...

Case 1_a. Don't mix pure functions (sub) with destructive functions (sub!). Whenever possible use pure methods: zip_file = file.sub(directory, '').sub(/^\//, '') zipfile.add(zip_file, file) But can't you write simply? zip_file = File.basename(file) Case 1_b: I prefer to set variables. Givin...

Apart from the comments provided by @lol.upvote: The code as you have posted it does not compile for two reasons: htmlList is a private member of HtmlViewContext so HtmlViewResult cannot access it. I can only assume that HtmlViewResult is actually a nested class within HtmlViewContext (oin whi...

I don't think you should treat the units as disjoint entities between which you convert. You have started your post by saying Angle can be represented using following types But actually what you meant is "units". So the entity you are trying to measure is an angle. And code using it shoul...

You don't need the two definitions of book: typedef struct {..} book ; struct book {..} ; What I would normally do is: typedef struct Book { ... } Book ; This allows you to write either: struct Book b1 ; Book b1 ; and in both cases get a Book structure. it also means i can refer to a Boo...

An argument against table-style alignment in code Except when the editor/IDE helps maintain alignment with little work from the programmer, and all those who work with the code have that same facility, horizontal, table-like alignment in code is more trouble than it's worth, for these reasons: ...

In addition to what @lol.upvote already said: I don't really think the way you pass the column names and values around for several reasons: You basically pass them as a string which means that whoever provides and very likely already has a list of them need to concatenate them together and the...

Here's a two-line solution using some of the standard algorithms: first sort a copy of the string, then use adjacent_find to determine if any adjacent characters are identical. If there aren't, adjacent_find will return the end() iterator of the string copy, so you simply compare against that bo...

#define MAX_STR_LEN 256 #define MAX_BOOKS 10 #define DATE_LEN 8 How do you choose these numbers? Does you code ensure that data in the file doesn't exceed these numbers? In fact your readBookFile function has a bug: if the title of a book is nearly MAX_STR_LEN then the length of the whole file...

HTML <!Doctype html> <html> <head> <title>Welcome To DPS Raipur</title> <link rel="icon" type="image/png" href="logo.gif" /> <link rel="stylesheet" type="text/css" href="index.css"> </head> <body> <div class="wrapper" id="wrapper"> <div cla...

Here are some quick and non-exhaustive comments: Wrong usage of br Your use of br is wrong, you should use margin or padding for that. For example, to have a fixed menu just put the other content on a div, and give that div margin-top. (Or you could hack it with header+* { margin-top: 40px; },...

Updated answer: Thanks for clarifying the question, the examples helped. Here is my new attempt: (defn update-subjects [dict subj] (map (fn [[k {val :definitions}]] [k {:definitions (filter (fn [{s :subject}] ((into #{} (flatten [s])) subj)) val)}...

I am taking a very broad stab at this, answering your questions along the way but with additional comments on the code in general. public SearchInANAryTree(T[] items, int nary) { if (nary <= 0) throw new NullPointerException("The branching factor : " + nary + ", should be greater...

You could use jQuery.fn.serializeArray to get all of the values from your inputs at once (giving them all a common class), thus removing the need to select each one while generating the new row html. // build new table row from line item inputs var newRow = "<tr>"; newRow += $(".line-items tfoot...

I like your code, good use of the Revealing Module pattern. In only have minor observations: mtype could use a better name ( I know, jqGrid uses it ) autowidth -> autoWidth ( lowerCamelCasing ) gridview -> gridView rowList: [50, 100, 200] could use a comment as to what it does viewrecords -> v...

From a once over: Your indenting is a mix of 4 space and 8 space tabbing, please stick at all times to either 4 or 2 spaces. Looking at deserializeUser is aneurysm inducing. You have a ton of comments, which I like, authentication can always use tons of comment data[0] and data[1] both use a cr...

I recently noticed a number of articles from here ending up on a popular code shaming website: codecrap.com Now, I imagine no harm is meant, but I would just like to urge people against doing this. The purpose of this SE is to let people (who have a willingness to improve) show their code and a...

I'm having a problem Eager Loading my data using Linq to SQL First I've got a basic Repository Read() Repository Public Class EventRepository Public Function Read() As System.Linq.IQueryable(Of [Event]) Implements IEventRepository.Read Dim events = (From e In dc.Events ...

I have an ASP.NET application which uses a Service Reference to a (third-party, offsite) payment processor. The service reference class is generated automatically. Its implementation is a subclass of ServiceModel.ClientBase, which MSDN documents as, "Any instance members are not guaranteed to b...

Your code looks fine. However, you are not showing us much to review, definitely come back when there is more to review. Some minor comments: Having your db connection config through ./config/db is good You probably want to throw an exception if ( typeof cb !== "function" ) instead of silentl...

Assume a website with four pages: Blog, About, Work and Contact. For these four pages there are four different color schemes. The colors are used for things like headings and links. Of course using different color schemes on pages results in bloated CSS. I'm now trying to reduce the bloat. I've ...

from the SASS Documentation Syntax There are two syntaxes available for Sass. The first, known as SCSS (Sassy CSS) and used throughout this reference, is an extension of the syntax of CSS3. This means that every valid CSS3 stylesheet is a valid SCSS file with the same meaning. In additio...

It looks ok to me. As a few comments in a random order: I guess I don't have to tell you that writing a non-recursive function for this is quite straightforward. You could give tmp its final value as you define it : char tmp = a[i];. You could make it a tail call recursion by doing reverse(a, ...

Simple worked example of Anton's suggestion: void reverse_rec(char *begin, char *end) { if (begin < end) { char swp = *begin; *begin = *end; *end = swp; reverse_rec(begin+1, end-1); } } void reverse(char s[]) { if (s) reverse_rec(s, s+strlen(s...

In addition to what @lol.upvote already said: I don't really like the way you pass the column names and values around for several reasons: You basically pass them as a string which means that whoever provides them very likely already has a list and needs to concatenate them together and then y...

When ever you encounter multiple conditions that you see growing, that should be a clear indication that a strategy pattern could help. You start by doing the following. Create a simple enum for your status codes. public enum MessageStatusCodes{ case12= 12, case13= 13, case22 =...

One serious bug is that you open results.txt for each line of input. It's almost always better to open files in a with block. Then, you won't have to worry about closing your filehandles, even if the code exits abnormally. The with block would have made your results.txt mistake obvious as well...

Apart from the comments provided by @lol.upvote: The code as you have posted it does not compile for two reasons: htmlList is a private member of HtmlViewContext so HtmlViewResult cannot access it. I can only assume that HtmlViewResult is actually a nested class within HtmlViewContext (oin whi...

The easiest way would be to define a constant integer array holding the ids: private static final int[] ids = { R.id.kn1_radio_group, R.id.kn2_radio_group, R.id.pr1_radio_group, /* and so on... */}; And then using the same method as in my answer to your previous question. However, your naming...

Good code. Consider converting a const std::string& parameter into an iterator pair: no reason to not support std::vector<unsigned char>, std::deque-s, etc. You could add a template helper function to have the code run when passed a string s itself, not begin(s), end(s). On a pedantic note, if ...

You may want to look at Compass for generating your font-face information. Your media queries are a bit excessive here. Other than your font-face block, there's not a spec of code that exists outside of a media query. The absence of support for media queries is in fact the first media query....

The key insight is that if you already know, for example, the value of collatz(37), then collatz(74) is just 1 + collatz(74 / 2), and you can reuse the previously computed result. Therefore, your collatz() function should have access to the results vector — either pass it in by reference, or m...

I would modify your serial reading function in a few ways, firstly by changing its name to reflect what it does. I would also move the accumulation buffer into the function, making it and its position counter static (which means they stick around without losing their value between calls) . Also...

There is a fair amount of common code that can be extracted into a function. There is a common check in the while clause and the if clause. boolean CanAdd(LargeContentBlock largeContentBlock, ShapeList shapes) { return largeContentBlock.CanAddBlock(shapes.Peek().Size) && !la...

KleinFreund is right. if you want all the links the same throughout the header .header a { color: #fff; text-decoration: none; } and if you want the links throughout the entire page to be the same color than you want something like this a { color: #fff; text-decoration: none;...

The worst aspect of your code is the markup, not the CSS. Unless you need the div as an actual styling hook, you can safely discard it. After all, you're not styling it in any meaningful way (what you do have can just as easily be applied to the descendant tags). <div class="header"> <a hr...

Case 1_a. Don't mix pure functions (sub) with destructive functions (sub!). Whenever possible use pure methods: zip_file = file.sub(directory, '').sub(/^\//, '') zipfile.add(zip_file, file) But can't you write simply? zip_file = File.basename(file) Case 1_b: I prefer to set variables. Givin...

One year ago today, English Language Learners entered private beta. A week later, it opened to the public, and since then the questions and answers have been rolling in! So, what have we accomplished? We're getting 19.4 questions per day. Early on, this statistic hovered around the 15 mark, ...

Good code. Consider converting a const std::string& parameter into an iterator pair: no reason to not support std::vector<unsigned char>, std::deque-s, etc. You could add a template helper function to have the code run when passed a string s itself, not begin(s), end(s). On a pedantic note, if ...

The code in the OP seems thread-safe to me, but may not be the best solution. If the channel has many concurrent users, and if using the channel takes for example 100 msec, then 100 concurrent users would queue for up to 10 seconds before being able to use the (single) channel one after the othe...

Recently, this paper has received a lot of attention (e.g. from WSJ) since the authors claim that Facebook will lose 80% of its members by 2017. The authors based their claims in an extrapolation of the SIR model. They based their conclusions on the amount of Google searchs for "Facebook", and ...

Trying to build a case against this as we have a developer that likes to use class properties in place of methods. I think it's a bad idea. In some cases he is accessing the data layer inside the setter and getter. here is a snippet of code, what are your thoughts on this? private Dictionary<st...

Proof by [extreme] example. (based on a true story) Not too long ago, someone posted one of their employees' code and asked for it to be reviewed by the community. The OP wrote that based on the feedback we would give him, that he would decide whether to keep or to fire that employee. Would yo...

After finishing Project Euler 24, I decided to make a scrabble type of application using /usr/lib/dict as my dictionary what I cat that into a word file. It does take a few seconds, and the dictionary selection isn't that great. Is there any way I could make it faster, more effective, and with a...