@Mego is parent_comment the ID of the parent comment?

I mean in the POST /post/id/comment route

JavaScript: the interpreted language which takes longer to compile than C

@Mego Incorrect integer value: 'null' for column 'parent_id' at row 1

seems to not be nullable?

:|

any idea how to fix this?

frontend code is just this:

export default class Comment extends Request {
    /**
     * Gets leaderboard for a post id
     * @param {string} type - `post` or `answer`
     * @param {number|string} id - Id of post or answer
     * @param {string} value - Actual content of comment
     * @param {?number} parentComment - The id of the parent comment
     */
    constructor({ type, id, value, parentComment = null }) {
        super({
            path: `/${type}/${id}/comment`,
            method: HTTPMethod.POST,
            formData: {

I checked though and python does decode me sending a null to None though

> sqlalchemy.exc.InvalidRequestError: On relationship PostComment.parent, 'dynamic' loaders cannot be used with many-to-one/one-to-one relationships and/or uselist=False.

:(

I can't apparently do .comments.limit(x)

so not sure how to get comments from flask

though I can't reference PostComment from flask template

though I'd have to generate a super-weird array though and keep that correctly sync'd with the list/order of answers

So I was thinking if you want to link to a specific commen thread, you could then just do /comment/<comment id> and that'll load a seperate page with just the thread and ability to go up the thread

kinda like reddit

@Mego what is best way to nested comments in Python then, without creating a seperate class? In JS I would make an object

owow ok

@Mego why not tuples?

oh, nevermind

the outer one could be a tuple though no

@Mego when doing AnswerComment.query.filter_by(post_id=post_id, parent_id=None).order_by(AnswerComment.date_created.desc()).limit(5), is there a better way to know if they are more than 5 answer comments (so I know when to show "load more") rather than doing another query?

We are already doing a ton of DB queries for post/<id> so i dont want to add too many more

good news: basic comments work

ok two variants of comment:

this one has a line on the left

this one doesn't

which one is better? (I still have a lot to add so i am aware a lot of things are missing)

@Mego in the AnswerComment model, you have:

 'date': self.date_created,

but python datetimes are not JSON serializable?

has this to_json been tested, it seems to not be serializing ORM objects :/

Also @Mego this line: parent_comment = request.form.get("parent_comment", None) is giving a 400 when parent_comment is not sent

@Mego 10 hours later: github.com/PPCG-v2/PPCG-v2/pull/112

not ready for merging htough

@Downgoat imo the one without the leading line is better

hm, not sure about leading space with byte count

does it look fine as is?

btw whats the progress with the nginx server atm?

could I have access to sudo systemctl and /var/log to take a look?

oic

does the user running the app have exec perms to /usr/bin

@Mego could you run curl -sL https://deb.nodesource.com/setup_9.x | sudo -E bash -

and then sudo apt-get install -y nodejs

@Mego O_o are those unprintables suppose to be there

did you run the above commands?

they dont seem to exist in the actual file itself

@Mego The ubuntu default node version is 4.x so most of the js code wont even compile

$ ./node_modules/.bin/uglifyjs --help

  Usage: uglifyjs [options] [files...]

  Options:

    -V, --version                output the version number
    -p, --parse <options>        Specify parser options.
    -c, --compress [options]     Enable compressor/specify compressor options.
    -m, --mangle [options]       Mangle names/specify mangler options.
    --mangle-props [options]     Mangle properties/specify mangler options.
    -b, --beautify [options]     Beautify output/specify output options.

:|

ubuntu y u do dis

@Mego whats the CWD of the process?

@Mego could you try running now and see what output is?

>_<

i think nvm might have precompiled binaries brb

oh rip nginx is down

ah ok

hopefully this is cleaner

bug: When I click 'Sign in with Stack Exchange', it shows this message: Couldn't parse `client_id`