@Jan A quick read through and it looks good to me. It's similar enough to the other rewrite solutions I've built in the past. My biggest concern is that they're trying to integrate data from an external database ... when integrating WordPress with an external data source, you will almost always run into snags