VSDiagnostics

2:26 AM

[Vannevelj/VSDiagnostics] Hosch250 synchronized pull request #505: Close #172

[Hosch250/VSDiagnostics] Hosch250 pushed commit 20a626b1 to develop: Respond to comments.

[Vannevelj/VSDiagnostics] Hosch250 commented on pull request #505: Close #172

> I'll update the Readme when it gets merged. I think there are a couple others missing as well.

[Vannevelj/VSDiagnostics] Hosch250 commented on issue #525: Implement ReturnValueNotUsed

> Another test case would be var foo = "test".Split("e"); // value assigned to variable

[Vannevelj/VSDiagnostics] build for commit 20a626b1 on unknown branch: AppVeyor build succeeded

12:33 PM

@Hosch250 yeah, no problem

[Vannevelj/VSDiagnostics] Vannevelj [commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/EqualsAndGetHashc‌odeNotImplementedTogether/EqualsAndGetHashcodeNotImplementedTogetherAnalyzer.cs]‌(github.com/Vannevelj/VSDiagnostics/pull/…) of pull request #505: Close #172

[Vannevelj/VSDiagnostics] Vannevelj commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Arithmetic/DivideIntegerB‌yInteger/DivideIntegerByIntegerAnalyzer.cs of pull request #536: Implemented #236

[Vannevelj/VSDiagnostics] Vannevelj added label type - task to issue #537: Remove isEnabledByDefault argument when it's true

[Vannevelj/VSDiagnostics] Vannevelj added label priority - low to issue #537: Remove isEnabledByDefault argument when it's true

[Vannevelj/VSDiagnostics] Vannevelj opened issue #537: Remove isEnabledByDefault argument when it's true

> Several analyzers have isEnabledByDefault: true as part of their DiagnosticDescriptor rule. This can be removed considering analyzers are enabled by default.

[Vannevelj/VSDiagnostics] Vannevelj commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Arithmetic/DivideIntegerB‌yInteger/DivideIntegerByIntegerAnalyzer.cs of pull request #536: Implemented #236

[Vannevelj/VSDiagnostics] Vannevelj added label status - wontfix to issue #537: Remove isEnabledByDefault argument when it's true

[Vannevelj/VSDiagnostics] Vannevelj closed issue #537: Remove isEnabledByDefault argument when it's true

[Vannevelj/VSDiagnostics] Vannevelj commented on issue #537: Remove isEnabledByDefault argument when it's true

> False alarm. These are named arguments, not optional arguments. They're written in this named manner to make it clear what the true value actually means.

[Vannevelj/VSDiagnostics] Vannevelj merged pull request #536: Implemented #236 from divideintegerbyinteger into develop

[Vannevelj/VSDiagnostics] Vannevelj pushed commit 6b018ac4 to develop: Implemented #236 (#536)

[Vannevelj/VSDiagnostics] build for commit 6b018ac4 on develop: AppVeyor build succeeded

[Vannevelj/VSDiagnostics] Vannevelj added label priority - medium to issue #538: Cleanup Readme

[Vannevelj/VSDiagnostics] Vannevelj added label type - task to issue #538: Cleanup Readme

[Vannevelj/VSDiagnostics] Vannevelj opened issue #538: Cleanup Readme

> The diagnostic descriptions need some work done to them. Make sure that translates to the actual messages in the analyzers as well.

1:35 PM

[Vannevelj/VSDiagnostics] Vannevelj closed issue #236: Implement IntegerDivisionByInteger

2:05 PM

[Vannevelj/VSDiagnostics] Hosch250 commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/Arithmetic/DivideIntegerB‌yInteger/DivideIntegerByIntegerAnalyzer.cs of pull request #536: Implemented #236

8:20 PM

[Vannevelj/VSDiagnostics] Hosch250 [commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/EqualsAndGetHashc‌odeNotImplementedTogether/EqualsAndGetHashcodeNotImplementedTogetherAnalyzer.cs]‌(github.com/Vannevelj/VSDiagnostics/pull/…) of pull request #505: Close #172

@JeroenVannevel ^

9:04 PM

Hi.

11:11 PM

[Vannevelj/VSDiagnostics] Hosch250 [commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/EqualsAndGetHashc‌odeNotImplementedTogether/EqualsAndGetHashcodeNotImplementedTogetherAnalyzer.cs]‌(github.com/Vannevelj/VSDiagnostics/pull/…) of pull request #505: Close #172

[Vannevelj/VSDiagnostics] Hosch250 synchronized pull request #505: Close #172

@JeroenVannevel Check that out please.

[Hosch250/VSDiagnostics] Hosch250 pushed commit 4aec46c6 to develop: Fix bug when base class implements both but derived class only implements one.

[Vannevelj/VSDiagnostics] build for commit 4aec46c6 on unknown branch: AppVeyor was unable to build non-mergeable pull request

BUILD FAILURE!

The only thing I have a question about is that it underlines the entire class.

I'll read through your comments now

what do you mean with underlining the entire class?

[Vannevelj/VSDiagnostics] Hosch250 synchronized pull request #505: Close #172

[Hosch250/VSDiagnostics] Hosch250 pushed 10 commits to develop

[Hosch250/VSDiagnostics] Vannevelj pushed commit c93cc759 to develop

Make SwitchDoesNotHandleAllEnumOptions show lines on the expression. (#531)

* Make SwitchDoesNotHandleAllEnumOptions show lines on the expression.

* Fix cast in code fix.

[Hosch250/VSDiagnostics] Vannevelj pushed commit d7ec1215 to develop

Castingissues (#534)

* prepared tests

* Fixed some tests and solved all issues

[Hosch250/VSDiagnostics] Vannevelj pushed commit 6b018ac4 to develop: Implemented #236 (#536)

[Hosch250/VSDiagnostics] Hosch250 pushed commit 95661201 to develop: Pull from develop

[Vannevelj/VSDiagnostics] Hosch250 synchronized pull request #505: Close #172

[Hosch250/VSDiagnostics] Hosch250 pushed commit 29b646e0 to develop: Fix conflicting ID's

11:22 PM

I'll post a screenshot.

Just and an NRE.

[Vannevelj/VSDiagnostics] Hosch250 synchronized pull request #505: Close #172

[Hosch250/VSDiagnostics] Hosch250 pushed commit 7b3ed9e9 to develop: Fix NRE

OK, supper time now.

[Vannevelj/VSDiagnostics] build for commit 95661201 on unknown branch: AppVeyor build succeeded

Be back after dinner.

[Vannevelj/VSDiagnostics] build for commit 29b646e0 on unknown branch: AppVeyor build succeeded

[Vannevelj/VSDiagnostics] Vannevelj deleted branch divideintegerbyinteger

11:34 PM

@Hosch250 yeah no, I think we should just underline MyBaseClass

[Vannevelj/VSDiagnostics] Vannevelj [commented on VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/EqualsAndGetHashc‌odeNotImplementedTogether/EqualsAndGetHashcodeNotImplementedTogetherAnalyzer.cs]‌(github.com/Vannevelj/VSDiagnostics/pull/…) of pull request #505: Close #172

@Hosch250 can you also add the README entry?

[Vannevelj/VSDiagnostics] build for commit 7b3ed9e9 on unknown branch: AppVeyor build succeeded