Game Development

12:08 AM

"so RaycastCommands
these all have to be allocated"

by the way, thanks for that :D

12:19 AM

The RaycastCommands are structs, so wouldn't they use the existing allocation of the list, rather than creating a new GC allocation each?

user92578

I don't think it'd know to use the list memory for the temporaries?

user92578

But those should just be on the stack?

Arthur 'Gibraltar' Condino

i don't know, i tried to limit the allocations now:
[NonSerialized]public int MaxGCAllocsPerFrame=1000;
[NonSerialized]static int _currGCAllocs;
bool limitGCAllocs(int allocs){
_currGCAllocs+=allocs;if(_currGCAllocs>=MaxGCAllocsPerFrame){_currGCAllocs=0;return true;}
return false;}
//for every .Add
if(limitGCAllocs(1)){yield return null;}

and the spikes just go crazy, now

limitGCAllocs(int allocs) is a local function

they were like one big spike, now a lot of spikes with lower impact

"The RaycastCommands are structs, so wouldn't they use the existing allocation of the list, rather than creating a new GC allocation each?"

I don't know how unity deals with the memory because it's managed and unmanaged, something like that, i don't understand very well

"I don't think it'd know to use the list memory for the temporaries?
But those should just be on the stack?"

I just noticed I can changed the value of the command[i] instead of using Add(new)
I'll try to check if length is ok and just update the values or if it really needs a new add call

DMGregory

12:38 AM

Worth a try. It's still very strange to me that you're getting GC allocations from this code, but that could be a gap or misunderstanding in my own knowledge.

Arthur 'Gibraltar' Condino

i'm really careful with memory management because i had a lot of troubles with it before in unity, now i know better when to use local and global variables, and optimize the gc collect mode, and other cool things, but it still surprises me with weird stuff happening behind the scenes

DMGregory

Is it possible the allocation is happening, not from adding items to the list itself, but when you pass the list to the job that actually performs the raycasts? Maybe it copies it to a fixed-length array at that time - I notice the method signature takes a NativeArray.

Arthur 'Gibraltar' Condino

12:56 AM

yes, maybe. I'll try to slice the list before passing to the job after this next test i'm doing.

I already tried nativearray allocation with NativeArrayOptions.UninitializedMemory
and i changed to native list because i had to dispose the array everytime and create a new one
"Uninitialized memory can improve performance, but results in the contents of the array elements being undefined. In performance sensitive code it can make sense to use NativeArrayOptions.Uninitialized, if you are writing to the entire array right after creating it without reading any of the elements first. "

Arthur 'Gibraltar' Condino

1:18 AM

i gotta go to bed now, i've been working on this all day long, but i'll try tomorrow rewriting all this part of the code and searching for any instantiation that could be the culprit if not the raycastcommands or job scheduling which i'll try to find if are there any other problems.

Thanks for the help! :D
<3 <3 <3

0x00004

2:49 AM

@DMGregory i wonder why "variables" setting in " additional settings for linus projects"

couldnt find how to change variable in cmake project (vs environment) because of that

Nike Dattani

4:27 AM

Might be of interest. Does anyone play games on supercomputers?

23

Q: Supercomputers around the world!

For a matter modelling person, the most valuable resource is computing power. For many of us, computing power at hand limits the scale of problems we can solve. There are many national supercomputing facilities for academics. What are the resources available in each country?

Transcript for