Room for Chris Burt-Brown and Vogel612

Vogel612

15:07

so?

Chris Burt-Brown

so is this public? i have never used this system before.

Vogel612

yes it is..

Chris Burt-Brown

also: hi there

Vogel612

but probably nobody will ever see it again ;)

hi.

if we pass 20 messages, this chatroom will be saved,

everything written here is under CC-BY-SA license (like all other content on SE)

Chris Burt-Brown

cool

basically if you check out the original code there is no way that for example HITPOINTS would work in that scenario, in fact, almost nothing else would fit

Vogel612

15:09

that is assuming that hitpoints need to be doubles..

and that's not the case.

Chris Burt-Brown

not assuming anything like that

Vogel612

you could have hitpoints as ints.

Chris Burt-Brown

you're assuming that hitpoints would be (1 + level + (sum of equipment)) * Math.sqrt(level)

which to me is obviously not going to be right

Vogel612

> public int getAttack()

ahh that's what this is about...

question: why shouldn't they be?

It's totally irrelevant how OP calculates his hitpoints..

Chris Burt-Brown

the abstraction is only worth doing if the method of calculation is always going to be the same

Vogel612

15:11

if he does it consistently, it should be fine.

correct.

from posted code I had no reason to assume otherwise..

Chris Burt-Brown

to me even the fact that attack & defence are the same seems like a fluke

Vogel612

not everybody is a game-designer..

Chris Burt-Brown

yeah no problem

it's that 1+ and the sqrt which seems suspicious to me

user1306322

@Vogel612 you can never count on that

Vogel612

and if you want to be fancy you could even go for something like Map<Attribute, Func<T>> for calculating attributes.

Chris Burt-Brown

15:13

the OP was worried about DRY but in this case i think KISS is the more important value

Vogel612

@user1306322 damnit, you messing with me huh?

@ChrisBurt-Brown feel free to post a review.

You might actually be right.

but If OP continues on his quest for a nice game, he ~~might~~ will hit that wall sooner or later.

Chris Burt-Brown

well honestly I think @Ilmari Karonen's answer is the best

as in basically don't do anything lol

i think it's up to the op to change accepted answer or voters or just leave it

Vogel612

gimme a sec to read up ;)

Chris Burt-Brown

just wanted it on the record that's all

cool

Vogel612

lol tbh his answer is way above my level of understanding the problem

for the record, I am not proud of that answer...

Chris Burt-Brown

15:18

haha, well i am spending a great deal of my time untangling abstractions recently

i always value KISS because code that is the simplest possible solution is easy to change

Vogel612

@ChrisBurt-Brown may I refer you to one of my questions that might show you how tangled and broken my way of thinking is?

11

Q: More German overengineering™ - Class mappings and factories

Goals: So the plan was simple: Provide a factory to instantiate implementations of a certain interface (ModelConverter<T>), depending on what model-class you want to convert. The approach is relatively straightforward: statically map model-classes to ModelConverter implementations use that ma...

Chris Burt-Brown

sorry man, i looked, but i don't think i am on the level to help you, i work in games where in general the style of development is a bit different, so you would never have a ModelConverterFactory in the first place.

Vogel612

That's beside the problem ;) Did you read the answer on that?

Chris Burt-Brown

also my java is extremely limited

Vogel612

It says, your whole approach is dumb, use a map with instances instead of an enum with reflection.

Chris Burt-Brown

15:26

yeah i am reading it now

i don't see anything wrong with what he's saying, but like i say, my java is bad

Transcript for

Room for Chris Burt-Brown and Vogel612