VBA Rubberducking

1:56 AM

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5549: "Implicite default member acces" not recognised

> @MDoerner Nz would be loaded from the Access type library, works a bit like ISNULL in T-SQL; per docs it takes a variant first parameter and an optional (unless used in a query) value_if_null argument can be supplied.

2:51 AM

[rubberduck-vba/Rubberduck] retailcoder created pull request #5550: Completes #5343 to merge retailcoder/Rubberduck/doccls into rubberduck-vba/Rubberduck/next

> Patches #5343 to get all tests green. Creds to @IvenBach for this one, my commit is just a minor tweak.

Huh?

@IvenBach I pulled your PR and tweaked the test setup, everything's green

I was really confused till I looked at your PR.

Hm, reading the comments on the original PR I think the VB6 portion isn't handled yet

If you want to do the VB6 part, pull my patch into your branch

then when you push and your PR is merged mine becomes moot (you got my commit) - or I'll push to mine tomorrow, and your commits will merge from my PR

either works =)

3:06 AM

I don't have anything to test VB6 with. I need to re-read my work. I've forgotten most of what I did.

[rubberduck-vba/Rubberduck] build for commit e98959b3 on unknown branch: AppVeyor build succeeded

not much is left to do - the command is invoking IVBComponent.ExportAsSourceFile, but per the PR comments the VB6 implementation is currently throwing a NotImplementedException

wondering if it would be sane to just make VB6.VBComponent.ExportAsSourceFile defer to VB6.VBComponent.Export?

1 hour later…

4:41 AM

[rubberduck-vba/Rubberduck] MDoerner removed label bug from issue #5549: "Implicite default member acces" not recognised

[rubberduck-vba/Rubberduck] MDoerner added label status-bydesign to issue #5549: "Implicite default member acces" not recognised

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5549: "Implicite default member acces" not recognised

> Ok, based on that information, there is no implicit default member access in Nz(rsWork.Fields.Item("ID"), vbNullString). Since the parameter type is Variant. The function NZ gets the Field object passed as first argument. The access of the default member will then happens inside that function, if at all, which is an implementation detail of that built-in function. So, the inspection works as expected.

[rubberduck-vba/Rubberduck] MDoerner closed issue #5549: "Implicite default member acces" not recognised

M.Doerner

@mansellan Is there a specific reason why ExportAsSourceFile' throws for VB6 instead of forwarding to Export`?

5:01 AM

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5549: "Implicite default member acces" not recognised

> In other words `rs.Work.Fields.Item("ID")` returns a `Field` object, but because the `Nz` parameter type is `Variant`, the function happily receives a `Variant/Field` object reference, and the let-coercion *if* it happens, happens inside the `Nz` function and not at the call site when the argument is evaluated.

So while it's perfectly reasonable to presume `Nz` leverages the late binding afforded by the `Variant` type of its first parameter, flagging it as an implicit default member access

5:41 AM

I've uploaded my ContentUpdater app to GitHub, but it's a private repo for now (I don't mind handing out collaborator accesses) and I'm not sure how to deal with API keys and database credentials and source control all together, but here we are

I'm debating whether it should be under the org

for now I just removed the app.config and rebased

5 hours later…

10:39 AM

@MathieuGuindon there are some tools out there to put access keys and credentials into source control

stuff like StackExchange's blackbox

11:00 AM

[rubberduck-vba/Rubberduck] Vogel612 merged pull request #5550: Completes #5343 from retailcoder/Rubberduck/doccls into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] Vogel612 closed issue #5319: Exported doccls files include attributes

[rubberduck-vba/Rubberduck] Vogel612 merged pull request #5343: No longer include attributes for exported document modules. from IvenBach/Rubberduck/Issue5319_Exported_doccls_include_attributes into...

rubberduck-vba/Rubberduck/next

@Duga MAGIC!

[rubberduck-vba/Rubberduck] build for commit b6efda0c on next: 61.33% (target 0.00%)

press a single button and merge two PRs with it :D

11:18 AM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5524

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5524

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.0.5524

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.0.5524

[rubberduck-vba/Rubberduck] build for commit 9ed85e0a on next: AppVeyor build succeeded

2 hours later…

1:40 PM

I was going to sync my AssignmentNotUsed inspection PR. After changing to that branch, my local Git is showing that I have added Rubberduck.Parsing.xml (I merged the latest into the branch I was working on previously). This file should be listed in gitignore - right?

1:59 PM

@BZngr hm, is it not under the \bin folder? I think any build asset shouldn't be on source control, this is weird.

It's under Rubberduck.Parsing

Rubberduck.CodeAnalysis.xml is listed in gitignore...hence the question

yea, it should be in the gitignore

we don't want to version the generated documentation, considering that we're versioning the code the docs are generated from :D

To fix requires a PR to exclusively update gitignore (?)

nah, just roll it into the existing PR

OK...was just thinking that until it's merged (with some PR) - everyone will have to do the same.

admittedly, not a big task...

2:50 PM

> Rather than one GPG passphrase for all the files, each person with access has their own GPG keys in the system. Any file can be decrypted by anyone with their GPG key. This way, if one person leaves the company, you don't have to communicate a new password to everyone with access

that's awesome

getting that!

3:17 PM

@MathieuGuindon the setup is a bit complex, but it's explained pretty nicely

And I really like how they added an additional section at the bottom of that readme listing alternatives

Feeds

3:31 PM

Canada's travel restrictions on the US are 99% about keeping out COVID and 1% about keeping out people who say 'pod.'

Q: VBA Sort-Compile-Write data from multiple worksheet on changes

3:45 PM

[rubberduck-vba/Rubberduck] BZngr synchronized pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

Quack Exchange

I finished a code that sort and compile daily work datas into a weekly summary. Its trigered by a workbook changes so it refresh automaticly. Trying to respect "good code writing", and using my background in matlab i tried to split my code as much as possible. Its an intership projet for a compag...

4:11 PM

[rubberduck-vba/Rubberduck] build for commit 67dbca5b on unknown branch: AppVeyor build succeeded

4:36 PM

@MathieuGuindon it’s a quarter away but Hacktoberfest is coming. Prudent to proactively mark easy issues in preparation?

FreeMan

somebody wants his t-shirt

You gonna proactively queue up 5 PRs to submit them at 00:00:01+0? Since you're UTC-8, that's a convenient 4pm for you... ;)

#KnowsHowToGameTheSystem #ThatDoesntMeanHeDoes

Just curious, has anyone else noticed on the various SE sites they may (or may no longer) frequent, that the Post Review notification dot is almost always on, even if there are no posts to review?

In particular at Home Improvement, it always says there are low quality posts to review, but I'd say that less than 1-in-10 clicks gives me a post to review.

Is it just that people there are so on the review queue that by the time I click, they've all been reviewed?