VBA Rubberducking

12:01 AM

RELOAD!

[rubberduck-vba/Rubberduck] 1 issue comment.

[Zomis/Games] 5 commits. 2 opened issues. 1 issue comment. 72 additions. 23 deletions.

[Minesweeper] Games Played: 131, Bombs Used: 90, Moves Performed: 17353, New Users: 8

18 hours later…

5:56 PM

MVC routing is starting to make sense... but I don't like how I now have 6 identical .cshtml pages. Still have partial views to figure out I think

FreeMan

6:10 PM

hands @MathieuGuindon some paper towel to DRY up his HTML... :)

6:35 PM

should ObsoleteMemberUsage inspection be under RubberduckOpportunities?

^ not to populate this tab for the sake of populating this tab, but...

[rubberduck-vba/Rubberduck] retailcoder commented on RubberduckTests/Refactoring/RenameFolder/RenameFolderRefactoringActionTests.cs of pull request #5515: Rename folder CE command

[rubberduck-vba/Rubberduck] retailcoder closed issue #3745: Code Explorer>Rename Folder

[rubberduck-vba/Rubberduck] retailcoder merged pull request #5515: Rename folder CE command from MDoerner/Rubberduck/RenameFolder into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] MDoerner pushed commit f0cbd16c to next: Extract ChangeFolderRefactoringAction out of MoveFolderRefactoringAction

[rubberduck-vba/Rubberduck] MDoerner pushed commit 213bf1c2 to next

Fix handling of cancellation in CE move to folder commands

They did not catch the corresponding refactoring exception since the user interaction was not contained in the try-catch-block.

This also adds a user notification in case one of the affected modules is stale.

[rubberduck-vba/Rubberduck] MDoerner pushed commit 126ffa41 to next

Introduce RenameFolderRefactoringAction

It allows to rename the subfolder part of a folder.

[rubberduck-vba/Rubberduck] MDoerner pushed commit a4247f9e to next: Add UI for RenameFolder

[rubberduck-vba/Rubberduck] MDoerner pushed commit 082d93ea to next

Enhance CE Rename command to cover folder renames

It incorporates a new RenameFolderCommand.

[rubberduck-vba/Rubberduck] MDoerner pushed commit 53e2b494 to next: Fix minor bugs in RenameFolder UI

[rubberduck-vba/Rubberduck] web-flow pushed commit 97bdd9a6 to next

Merge pull request #5515 from MDoerner/RenameFolder

Rename folder CE command

6:58 PM

is there an article or more info on RD Fakes?

@SmileyFtW not really. my plan is to put that info onto the website, but I need to finish the admin site first =)

(the Fakes API being a "feature item" of the "Unit Testing" feature)

got it. I'm working on a project to read and write info to a worksheet about the (fundamental) properties of controls on a user form; the idea is to write to the worksheet things like the size and position, tag, caption, etc. Then by changing those values read them from the sheet and apply the changes. Is Fakes a tool to do testing on something like that?

That is: not have to actually create a user form to do testing

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5472

Nah the Fakes API is to hijack VBA functions that would normally make tests useless, e.g. MsgBox

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5472

7:03 PM

Ah, ok.

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.0.5472

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.0.5472

[rubberduck-vba/Rubberduck] build for commit 97bdd9a6 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit 97bdd9a6 on next: 60.96% (target 0.00%)

What you're describing would work well with mocks, I presume - but until we have a mocking framework we'll have to use stubs instead (explicit, test-only implementation of interfaces used by the class under test)

Thanks!

by the sound of it, you should be able to test that logic with a stub for the object responsible for interacting with the worksheet, and a test-provided model class that holds the values you would grab from the UI

Gonna have to bone up on stubs, it seems... That just sounds wrong when written down.. mental images being what they are.

Is there an article you've written on the topic?

7:13 PM

Hm, "how to unit test vba code" is pretty slim... not really

But basically a test stub is a test-only implementation of an interface that you supply as a dependency of the code you're testing

I slipped off and searched SO... I found this in part of an answer that seems to be a concise description: "Stubs differ to Mocks in that they are used to represent and test the state of an object, whereas a Mock tests its interaction."

So if I am wanting to change the state of a control on a user form (position, size, etc.) then a stub seems like the right path.

for testing.

8:05 PM

@MathieuGuindon ObsoleteMemberUsage is certainly an RD opportunity. BTW That tabbed interface looks amazing! I wish the code inspection window looked like that. It's too much vertical scrolling where tabs could help reduce vertscrol

8:33 PM

@HackSlash it's open source ;)

~wink, wink, nudge, nudge

1 hour later…

9:45 PM

Thanks, @Vogel612 I am aware. Last time I worked on the codebase I was instantly overwhelmed. I was able to contribute a tiny PR at one point. If I can ever find the part of the program I want to change I would try to contribute again.

@HackSlash yea, the RD codebase is a bit of a sprawling mess, but it's a pretty organized mess

if you want a pointer to somewhere, just ping one of the devs in here, we're always happy to help :)

Ok, where is the code inspection window?

Rubberduck.Core/UI/Inspections/*

primarily in InspectionResultsControl.xaml and InspectionResultsViewModel.cs

Thanks!

in the same folder there's a handful of Converter classes that convert values to simpler things that XAML can deal with

9:50 PM

If I stick to just messing with the GUI I think I will be okay. I don't yet understand how the parts of RD work together.

the GUI should all be in the Rubberduck.Core project

I'm not 100% sure it's all in the UI folder there, but the vast majority should be