12:00 AM
5 hours later…
4:45 AM
[rubberduck-vba/Rubberduck] retailcoder closed issue #4794: IO work needs to be abstracted out into an internal API
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5591: Move all usages of System.IO into System.IO.Abstractions or limit the using from bclothier/Rubberduck/io into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] bclothier pushed commit b59425a3 to next: Update IoC registration for the filesystem
[rubberduck-vba/Rubberduck] bclothier pushed commit bd36ed47 to next: Refactor the usages of System.IO.
[rubberduck-vba/Rubberduck] bclothier pushed commit 2e78a132 to next: Include a simple analyzer to prevent use of System.IO and redirect accordingly.
[rubberduck-vba/Rubberduck] bclothier pushed commit 3a7b4a77 to next: Fix missed System.IO usage for FileExistenceChecker
Update the serializer's ctor to take a IFileSystem and make the MockParser new up a MockFileSystem instead.
MockFileSystem can be then implemented in a future PR. For now, it will be real filesystem.
MockFileSystem can be then implemented in a future PR. For now, it will be real filesystem.
[rubberduck-vba/Rubberduck] bclothier pushed commit 505991d8 to next: Get rid of FileExistenceChecker and use FileSystem in its place.
[rubberduck-vba/Rubberduck] bclothier pushed commit 6192b168 to next: Removed the now failing test that should have been failing since PR #5170
[rubberduck-vba/Rubberduck] bclothier pushed commit 2fb1eaaf to next: Add a comment about the injectable property.
Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck into io
# Conflicts:
# Rubberduck.Core/Settings/HotkeySettings.cs
# Conflicts:
# Rubberduck.Core/Settings/HotkeySettings.cs
[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5603: Enable user-defined templates for use in code explorer
[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5605: QuickFix/RefactoringAction to infer Explicit AsTypeNames for Implicit Type declarations
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5656
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5656
5:12 AM
[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #5636: False positive "Procedure not used" in Outlook "ThisOutlookSession"
[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #5636: False positive "Procedure not used" in Outlook "ThisOutlookSession"
5:46 AM
[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5598: New Code Inspection - Invalid Sorting
> I think we have a number of very useful but rather niche / specific inspections, and that would be perhaps another one like them. I'm not against the idea, but I suspect
Cells(1, 1)
or some shenanigans involving Range.Offset
would successfully corrupt the sort keys as well; if that's the case then it would be cool to be able to not just catch identical sort key arguments, but arguments that evaluate to identical sort keys... not sure how realistically feasible that is though.
[rubberduck-vba/Rubberduck] retailcoder added label enhancement to issue #5598: New Code Inspection - Invalid Sorting
[rubberduck-vba/Rubberduck] retailcoder added label feature-inspections to issue #5598: New Code Inspection - Invalid Sorting
[rubberduck-vba/Rubberduck] retailcoder added label library-specific to issue #5598: New Code Inspection - Invalid Sorting
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5603: Enable user-defined templates for use in code explorer from bclothier/Rubberduck/templates into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] bclothier pushed commit 665aa821 to next: Update the template to avoid weird blank lines when creating a predeclared class
[rubberduck-vba/Rubberduck] bclothier pushed commit 76061217 to next: Make changes to the view model to avoid loading the collection twice and simplify the loading of collection.
[rubberduck-vba/Rubberduck] bclothier pushed commit defb7b8c to next: Enable reading in the user-defined template and support reading in the caption & descriptions for user-defined template using the key attributes.
[rubberduck-vba/Rubberduck] bclothier pushed commit 79b51f79 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into templates
[rubberduck-vba/Rubberduck] bclothier pushed commit 2f85e273 to next: Change extension from .rdt to .template. Also, improve handling the cases where user defined templates are renamed or moved during a session because the templates are only loaded
[rubberduck-vba/Rubberduck] bclothier pushed commit 73fde358 to next: Update the verification test to ignore menu resources that was added.
[rubberduck-vba/Rubberduck] bclothier pushed commit 1741a26b to next: Remove a test that shouldn't have been resurrected in the merge.
[rubberduck-vba/Rubberduck] web-flow pushed commit 7e2d5b5b to next: Merge branch 'next' into templates
[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5606: Enhance ExtractInterfaceRefactoring with implementation options
6:12 AM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5659
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5659
[rubberduck-vba/Rubberduck] retailcoder closed issue #196: VariableTypeNotDeclaredInspection could try to infer the variable's type
[rubberduck-vba/Rubberduck] retailcoder closed issue #3225: Inspection for implicit/explicit Variants that can be set to explicit type
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5605: QuickFix/RefactoringAction to infer Explicit AsTypeNames for Implicit Type declarations from BZngr/Rubberduck/VariableTypeInference into...
[rubberduck-vba/Rubberduck] BZngr pushed commit e4e3f095 to next: Add ImplicitTypeToExplicitRefactoringAction
[rubberduck-vba/Rubberduck] BZngr pushed commit 5b7e35e3 to next: Merge branch 'rubberduck-vba-next' into VariableTypeInference
[rubberduck-vba/Rubberduck] BZngr pushed commit 26b689c7 to next: Merge branch 'rubberduck-vba-next' into VariableTypeInference
[rubberduck-vba/Rubberduck] BZngr pushed commit 2d583f49 to next: Register ImplicitTypeToExplicitRefactoringAction by convention
[rubberduck-vba/Rubberduck] BZngr pushed commit 91baa35d to next: Merge branch 'rubberduck-vba-next' into VariableTypeInference
[rubberduck-vba/Rubberduck] web-flow pushed commit 1e33a0ae to next: Merge branch 'next' into VariableTypeInference
6:33 AM
6:45 AM
[rubberduck-vba/Rubberduck] retailcoder closed issue #5542: ExtractInterface Refactoring can provide implementation options
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5606: Enhance ExtractInterfaceRefactoring with implementation options from BZngr/Rubberduck/ExtractItf_RefactoringOptions into...
Improve InterfaceName validation conflict detection
Also adds text resources for the Implementation Options Combo box
Also adds text resources for the Implementation Options Combo box
[rubberduck-vba/Rubberduck] BZngr pushed commit 4c09fcaf to next: Merge branch 'rubberduck-vba/next' into ExtractItf_RefactoringOptions
Add ExtractInterfaceConflictFinder
Moved interface name conflict detection out of the viewmodel to a
dedicated class/interface so that the detection capability is available
to both the viewModel and the Refactoring when it initializes the model
and sets the new interface name.
Moved interface name conflict detection out of the viewmodel to a
dedicated class/interface so that the detection capability is available
to both the viewModel and the Refactoring when it initializes the model
and sets the new interface name.
Allow refactoring action to modify impl choice
When used without the ExtractInterface UI's protection, it is possible
for a calling refactoring to specify the option that removes the
existing Object member when not appropriate - resulting in uncompilable
code. Rather than fail, the refactoringAction modifies the option to
one that can be executed.
When used without the ExtractInterface UI's protection, it is possible
for a calling refactoring to specify the option that removes the
existing Object member when not appropriate - resulting in uncompilable
code. Rather than fail, the refactoringAction modifies the option to
one that can be executed.
[rubberduck-vba/Rubberduck] BZngr pushed commit b3fd4ce1 to next: Merge branch 'rubberduck-vba-next' into ExtractItf_RefactoringOptions
Revise RefactoringsTests to avoid Pass/Fail due to Indenter changes
Refactorings use CodeBuilder which uses Indenter settings. Modified tests to avoid failing due to changes in Indenter settings
Refactorings use CodeBuilder which uses Indenter settings. Modified tests to avoid failing due to changes in Indenter settings
Modify ReplaceObjectMembersWithInterface option behavior
Only deletes members with no external references. Retained members calls are forwarded to the associated (new) Interface member.
Only deletes members with no external references. Retained members calls are forwarded to the associated (new) Interface member.
[rubberduck-vba/Rubberduck] BZngr pushed commit 61d644b9 to next: Merge branch 'rubberduck-vba-next' into ExtractItf_RefactoringOptions
[rubberduck-vba/Rubberduck] web-flow pushed commit 254c67c4 to next: Merge branch 'next' into ExtractItf_RefactoringOptions
Merge pull request #5606 from BZngr/ExtractItf_RefactoringOptions
Adds implementation options to Extract Interface refactoring.
Adds implementation options to Extract Interface refactoring.
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5661
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5661
7:16 AM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5662
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5662
3 hours later…
10:24 AM
[rubberduck-vba/Rubberduck] majkaz added label bug to issue #5639: Inconsistent handling of continuation lines by Indenter
[rubberduck-vba/Rubberduck] majkaz opened issue #5639: Inconsistent handling of continuation lines by Indenter
> **Rubberduck version information**
Version 2.5.1.5557
OS: Microsoft Windows NT 10.0.14393.0, x64
Host Product: Microsoft Office 2016 x86
Host Version: 16.0.4266.1001
Host Executable: WINWORD.EXE
**Description**
Indentation is not consistent in case statements with multiple conditions
**To Reproduce**
Indent following code using the Indenter:
```vba
Select Case True
Case Foo = "No Bug" And Not Bar _
And Not Baz
Case Foo = "No Bug" And Not _
Version 2.5.1.5557
OS: Microsoft Windows NT 10.0.14393.0, x64
Host Product: Microsoft Office 2016 x86
Host Version: 16.0.4266.1001
Host Executable: WINWORD.EXE
**Description**
Indentation is not consistent in case statements with multiple conditions
**To Reproduce**
Indent following code using the Indenter:
```vba
Select Case True
Case Foo = "No Bug" And Not Bar _
And Not Baz
Case Foo = "No Bug" And Not _
3 hours later…
1:31 PM
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5617: Create resource file for regex assistant from IvenBach/Rubberduck/AddRemoveReferences_Issue4541_resx_cleanup into...
[rubberduck-vba/Rubberduck] IvenBach pushed commit 9ffa5b91 to next: Migrate RegexAssistant_ resources
Remove unused resources
No results returned when searching for RegexSearchReplaceScope_
and RegexSearchReplace_. Checked several individually and none
had a result.
No results returned when searching for RegexSearchReplaceScope_
and RegexSearchReplace_. Checked several individually and none
had a result.
[rubberduck-vba/Rubberduck] IvenBach pushed commit a7be6dc5 to next: Merge remote-tracking branch 'upstream/next' into AddRemoveReferences_Issue4541_resx_cleanup
1:53 PM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5663
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5663
3 hours later…
« first day (2366 days earlier) ← previous day next day → last day (814 days later) »
Transcript for
Nov26
Nov '2027
Nov28
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ