VBA Rubberducking

12:01 AM

RELOAD!

[rubberduck-vba/Rubberduck] 1 issue comment.

[Zomis/Games] 1 opened issue.

[Minesweeper] Games Played: 136, Bombs Used: 77, Moves Performed: 18380, New Users: 11

[rubberduck-vba/Rubberduck] BZngr created comment on issue #4100: Revisions to Declaration.cs and related classes/enums like accessibility

> In general, the RD codebase has a minority of classes defined without an associated interface. The design, implementation, and use of Declaration is part of that minority. As a result, Declaration and the codebase loses out on the opportunities afforded objects that conform to the Liskov Substitution Principle. There's a lot I do not know about RD's history and discussions (formal or otherwise) surrounding the Declaration class. So, if this is a previously resolved discussion/questio

Duga

1:29 AM

[rubberduck-vba/Rubberduck] Vogel612 created comment on issue #4100: Revisions to Declaration.cs and related classes/enums like accessibility

> Historically declarations are read-only because we don't have a rewriting mechanism that can deal with declarations.
Additionally the Nature of declarations allows for certain guarantees that may be lost when an interface exposes writability.

That being said the current state of declarations is not something that we want to have, if only because `Declaration` deals with so many concerns at once

Duga

3:29 AM

[rubberduck-vba/Rubberduck] BZngr created comment on issue #4100: Revisions to Declaration.cs and related classes/enums like accessibility

> My intent is that IDeclaration would match the default interface of Declaration exactly. All read-only properties remain read-only. The notion of writable properties are for imagined scenarios like IDeclarationProxy : IDeclaration where the proxy interface extends and overrides IDeclaration to provide read/write mutators and functions for the purposes of creating a proxy for specific scenarios like a new or renamed Declaration.

Duga

9:02 AM

[rubberduck-vba/Rubberduck] famasoon starred us

2

Duga

2:11 PM

[rubberduck-vba/Rubberduck] chrisdaniels opened issue #5615: Microsoft Smartscreen blocking betas on Win10

> Microsoft Smartscreen is blocking installs of betas on Win10 because the publisher is "unknown".
On my companys new Win10 install, there is no option to override this due to security.

[rubberduck-vba/Rubberduck] chrisdaniels added label bug to issue #5615: Microsoft Smartscreen blocking betas on Win10

[rubberduck-vba/Rubberduck] Vogel612 created comment on issue #5615: Microsoft Smartscreen blocking betas on Win10

> That's a known issue we unfortunately can't really fix, especially considering that all our releases are automated. Basically each change that goes into the codebase has its own beta release.

Similar issues apply for various antivirus software vendors. The effort to fix this across the board is prohibitive, especially for predeceases.

[rubberduck-vba/Rubberduck] Vogel612 closed issue #5615: Microsoft Smartscreen blocking betas on Win10

[rubberduck-vba/Rubberduck] Vogel612 added label support to issue #5615: Microsoft Smartscreen blocking betas on Win10

[rubberduck-vba/Rubberduck] Vogel612 added label status-declined to issue #5615: Microsoft Smartscreen blocking betas on Win10

[rubberduck-vba/Rubberduck] Vogel612 edited comment on issue #5615: Microsoft Smartscreen blocking betas on Win10

> That's a known issue we unfortunately can't really fix, especially considering that all our releases are automated. Basically each change that goes into the codebase has its own beta release.

Similar issues apply for various antivirus software vendors. The effort to fix this across the board is prohibitive, especially for prereleases.

Mathieu Guindon

3:06 PM

@Duga predeceases ha

Vogel612

@MathieuGuindon something something auto"correct"

Duga

[rubberduck-vba/Rubberduck] bclothier closed issue #3041: Limit which projects get and how much gets parsed.

[rubberduck-vba/Rubberduck] bclothier closed issue #1520: Parser Ignore Projects

[rubberduck-vba/Rubberduck] bclothier merged pull request #5604: Excluded projects from parsing from MDoerner/Rubberduck/ExcludedProjectsSelection into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] bclothier pushed 11 commits to next (only showing some of them below)

[rubberduck-vba/Rubberduck] MDoerner pushed commit 5832a0c6 to next

Move IgnoredProjectsSettings to Rubberduck.Parsing.Settings

This move is necessary because Parsing is referenced by Core and there cannot be cycles between projects.

This makes it necessary to add a ParsingSettings property to Rubberduck.Parsing to satisfy the needs of the config provider base class.

[rubberduck-vba/Rubberduck] MDoerner pushed commit 947b2b2c to next: Resolve ignored projects from user com projects instead of parsing them

[rubberduck-vba/Rubberduck] MDoerner pushed commit 9cfa1c5e to next

Add IgnoreProject and UnignoreProject commands for the PE

There are no menu items so far, since the PE ones need some rework.

[rubberduck-vba/Rubberduck] MDoerner pushed commit 6b4ccf73 to next

Add PE context menu items for Ignore/Unignore Project

Also separates all command menu items in there from the other instances and introduces a dedicated enum for the display ordering.

[rubberduck-vba/Rubberduck] MDoerner pushed commit fd093b9a to next: Fix issue with modified enum in UserComProjectSynchronizer

[rubberduck-vba/Rubberduck] MDoerner pushed commit 1d6920c0 to next

Stop unnecessarily setting the display order in a menu item base class

Addresses a review comment to PR #5604.

[rubberduck-vba/Rubberduck] MDoerner pushed commit a8c48730 to next: Merge branch 'next' into ExcludedProjectsSelection

[rubberduck-vba/Rubberduck] MDoerner pushed commit a28d7ed7 to next: Merge branch 'next' into ExcludedProjectsSelection

[rubberduck-vba/Rubberduck] MDoerner pushed commit 15aa74e2 to next: Merge branch 'next' into ExcludedProjectsSelection

[rubberduck-vba/Rubberduck] web-flow pushed commit 7927c076 to next

Merge pull request #5604 from MDoerner/ExcludedProjectsSelection

Excluded projects from parsing

Duga

3:44 PM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5631

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5631

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.1.5631

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.1.5631

[rubberduck-vba/Rubberduck] build for commit 7927c076 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Romukas starred us

2

SmileyFtW

4:25 PM

@MathieuGuindon - Reading through the MVVM articles and downloaded the files from GH. In the CustomErrors module you use a declaration I've never seen before: Public Const CustomError As Long = vbObjectError Or 32. What is that doing?

Mathieu Guindon

5:27 PM

@SmileyFtW vbObjectError is a built-in constant that theoretically should be used whenever we throw custom errors - it basically serves to offset the error numbers so custom errors don't conflict with the built-in ones; makes it easier to switch on an error number if needed.

The Or 32 is just a bitwise operation (that 32 should probably be a prime instead, but makes little to no difference), kind of a "base offset", and then using an enum for the custom errors ensures each custom error has its own number

In other news, I managed to boot the server this weekend, but a lot is going right now and couldn't do much more than that. Hyper-V still down, but now I can access the share where the content updater build is located, so I'll give it a nudge after work

> Rubberduck.Setup.2.5.1.5557.exe (4.45 MiB) - downloaded 4,596 times. Last updated on 2020-08-23

re: lots going on - long-time friend of mine isn't taking well getting dumped after 20 years and 3 kids, am sheltering the mom and her youngest at my place... rough weekend.

BigBen

wow that is tough news

Mathieu Guindon

yeah

#ItsComplicated

IvenBach

@MathieuGuindon Remember to #Breathe.

Sorry to hear. Separations are tough on everyone.

SmileyFtW

6:08 PM

@MathieuGuindon Sorry to hear about your friend. Good to have you to pull up some slack, though.

@MathieuGuindon I've never seen Or used that way... I am unclear, under the covers what happens?

Mathieu Guindon

6:29 PM

@SmileyFtW all "logical operators" are a giant scam: they're really just bitwise operators, but when they work with Boolean values it makes them read differently.