RELOAD!

[rubberduck-vba/Rubberduck] 4 commits. 1 closed issue. 1 issue comment. 178 additions. 54 deletions.

[Zomis/Games] 1 issue comment.

[Minesweeper] Games Played: 59, Bombs Used: 32, Moves Performed: 9010, New Users: 7

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #5586: Update InnoSetup installer

[rubberduck-vba/Rubberduck] build for commit b6e33b19 on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #5586: Update InnoSetup installer

[rubberduck-vba/Rubberduck] build for commit 594c8f4a on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.CodeAnalysis/Inspections/Abstract/ImplicitSheetReferenceInspectionBase.cs of pull request #5587: Super types for document modules

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.CodeAnalysis/Inspections/Concrete/ImplicitContainingWorkbookReferenceInspection.cs of pull request #5587: Super types for document modules

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.CodeAnalysis/Inspections/Abstract/ImplicitSheetReferenceInspectionBase.cs of pull request #5587: Super types for document modules

[rubberduck-vba/Rubberduck] Vogel612 merged pull request #5588: Fix PermissiveAssertClass from bclothier/Rubberduck/variant into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] bclothier pushed commit 017b8aa6 to next: Refactor the Variants namespace, allowing classes to share the exported functions for DRY's sake. Also introduce VariantComparer class to implement the comparing of 2 variants.

[rubberduck-vba/Rubberduck] bclothier pushed commit 587aeae9 to next: Revamp the PermissiveAssertClass to actually work. The original implementation was broken as it would have passed assertions due to incorrect branching. Furthermore, make the com

[rubberduck-vba/Rubberduck] bclothier pushed commit 1b793d57 to next: Unit testing for the permissive asserts.

[rubberduck-vba/Rubberduck] bclothier pushed commit e71328c2 to next: Clean up the asserts tests, removing the comments that no longer applies and reorg the helper routines.

[rubberduck-vba/Rubberduck] web-flow pushed commit 136889f4 to next: Merge pull request #5588 from bclothier/variant

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.1.5585

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.1.5585

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.1.5585

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.1.5585

[rubberduck-vba/Rubberduck] build for commit 136889f4 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] SaulNunez starred us

[rubberduck-vba/Battleship] Alexey0795 starred us

[rubberduck-vba/Battleship] Alexey0795 forked us into Alexey0795/Battleship

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #5586: Update InnoSetup installer

[rubberduck-vba/Rubberduck] build for commit 68269175 on unknown branch: AppVeyor build succeeded

found this: public static readonly ILogger _Logger = LogManager.GetCurrentClassLogger();

this should be private, right? NLog doesn't need it to be public?

yeap

@MathieuGuindon when you last worked on the analyzer, did you have problems with nugets or running tests?

did you rebuild meta?

yeah..

IIRC there were nuget package updates, but I don't recall any problems...

well, I did install the updates

but it then stopped working and wouldn't pass all tests

Hm

so I reverted the updates and now it's working.... but the new analyzer seem to not be running, unless I'm doing it wrong.

something somewhere in the build process wants a particular specific version of innosetup and can't find it?

no, that's a separate issue

tbh I haven't digged into the failing builds

I've given up on innosetup versioning for now and am focusing on improving the installer itself. But this analyzer is for a different issue altogether

going to try and re-rebuild meta just to be super duper sure.

ah, my unit test for the new analyzer is a dud

wowzer, writing an analyzer is way hard than it should

at least it's working

[rubberduck-vba/Rubberduck] bclothier created pull request #5591: Move all usages of System.IO into System.IO.Abstractions or limit the using to merge bclothier/Rubberduck/io into rubberduck-vba/Rubberduck/next

> Closes #4794 Partially addresses #4533 (mainly the point 3) This is a first step toward refactoring out the IO work in all classes into a testable abstraction. For now, the changes are simplistic; substituting out the System.IO with either the System.IO.Abstractions or a qualified using for objects like Path or MemoryStream where no direct filesystem access is involved. This also adds a simplistic analyzer to guard against accidental unqualified usage of System.IO. To support...

classes that are not a part of the CW's container, a FileSystemProvider is given to allow for property injection of the provider so that those classes can be also test-united using a mock filesystem. The PR does not yet implement a mock filesystem. This will be for a future PR.

[rubberduck-vba/Rubberduck] bclothier added label PR-Status: Review Requested to pull request #5591: Move all usages of System.IO into System.IO.Abstractions or limit the using

[rubberduck-vba/Rubberduck] build for commit 2e78a132 on unknown branch: AppVeyor build failed

BUILD FAILURE!

@Duga weird, ran unit tests locally after a rebuild and didn't get this. Ran rebuild again and I did get it. At least I know analyzer's doing its job....

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #5591: Move all usages of System.IO into System.IO.Abstractions or limit the using

[rubberduck-vba/Rubberduck] build for commit 3a7b4a77 on unknown branch: AppVeyor build succeeded

Good job @this!

[rubberduck-vba/Rubberduck] BZngr created pull request #5592: Add MisleadingByRefParameterInspection to merge BZngr/Rubberduck/MisleadingByRefParameter into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] build for commit 9ba28b2e on unknown branch: AppVeyor build succeeded