RELOAD!

[rubberduck-vba/Rubberduck] 22 commits. 2 opened issues. 4 closed issues. 6 issue comments. 8189 additions. 3987 deletions.

[Minesweeper] Games Played: 105, Bombs Used: 81, Moves Performed: 15273, New Users: 20

It didn't arrive until v4, which was a proper version bump unlike 2->3.5, so perhaps its (way) more involved than that...

the problem with static type analysis is that the space is rather large

Unrelatedly: newer C# features are allowing closer access to the hardware, which could potentially help with our memory consumption. Thinking of Span, Memory and ref structs in particular, which can minimise the amount of copying and allocations...

@Vogel612 I can imagine... Polymorphic type systems must be bad enough, add generics and it goes to another level...

Or, you could take the opposite approach and just say, "Meh, do whatever..." glares at JavaScript...

polymorphic type systems are actually comparatively boring...

if you want to get funky, stuff like higher-kinded types are really useful

alternatively for someting closer to what C# can do: discriminated record types are a feature in F# AFAIK. Getting those to be actually performant can be ... challenging

uh, cool... whoosh. This is why I don't design type systems :-)

@mansellan that can be applied toward the typelibs’ addressable variables.

i'm too high level to really understand it properly, but afaics they allow you to stop copying blocks of memory all over the place, and just look at a mapped view of what's already been allocated and filled

which is exactly what the AddressVariables does

github.com/rubberduck-vba/Rubberduck/blob/next/…

whoa...

> I'm too high level

:-)

Mind you, C# seems to be getting closer to C every release. Just by following along, we'll all be asm developers by net 6 :-)

seriously though, it's kinda cool that managed code is getting proper access to memory views, without having to leave the safety net behind.

that's kind of a lie, unfortunately.

just because we can access memory directly doesn't mean we can do so safely.

oh... go on then, burst my bubble...

That's why that particular class is in the Unmanaged folder --- most of the types there are unsafe

heck, even outside the Unmanaged, the "safety" is questionable. If you don't unwind correctly, you can easily corrupt the stack and everything comes tumbllng down, and all king's men and horses can't help you out.

ok, but I was talking about, for example, Memory - it seems, um, semi safe? couldn't see any pointers or mallocs?

from what I read, it's lecturing me about ownership

the very same topic that I'd expect to be reading were I in C or C++

so... it's still unsafe.

well, yeah. you still have to let go of it when you're done, so...

meh, I don't know anything like enough to critique given that I've never done unmanaged, and I don't know if or how it's different.

in the end, it's no different from using Declare in VBA/VB6

ah

creating a Declared function gives you access to the wonders that you can't have within the walled garden but it can let in gremlins and demons in if you are not careful.

oh sure, btdt. Declare ICopiedThisFromTheInternetAndNowIGetGpfs As Any

yeah, pretty much. All of that stuff in C# are variants of that.

All I know is when my work colleague tried to use Span in a business app, it went badly wrong.

But hey, its new. Maybe I just need to understand it some more.

I'm hoping that, ownership aside (through IDisposable?), at least it might protect against some of the uglier problems like overruns?

otherwise what's the point? Might as well drop in a CPP module...

probably. I'm sure there's some safety

it's just a mistake to think it's now 100% safe that's all

I do know that if you mess up one method sig in the chain (omitting an in keyword), it stops being a view and goes back to copying. At which point, all benefit evaporates. With no compiler assistance...

> mocked.Drives
null
> mocked
{Castle.Proxies.FileSystemObjectProxy}
    Drives: null
    Scripting.IFileSystem3.Drives: {Castle.Proxies.DrivesProxy}
    Interceptor: {Moq.Mock<Scripting.FileSystemObject>}
    Mock (Castle.Proxies.FileSystemObjectProxy): {Moq.Mock<Scripting.FileSystemObject>}
    Mock: {Moq.Mock<Scripting.FileSystemObject>}
> mockFso.Object
{Castle.Proxies.FileSystemObjectProxy}
    Drives: null
    Scripting.IFileSystem3.Drives: {Castle.Proxies.DrivesProxy}
    Interceptor: {Moq.Mock<Scripting.FileSystemObject>}

yes, yes, makes total sense to me....

At this point, it seems to be exclusively for low-level use - frameworks and (massively tested) libraries, rather than general consumption. But given how low-level the analysis bit of RD are, I thought I'd mention it...

(note: dynamic mocked = mockFso.Object)

heh... null ≠ null. obvs!

@mansellan technically, null ≠ null = null

= null

With the FooBarFormatters taking over the IExportable interface should I plan on removing it from ToDoItem and InspectionResult to isolate the finctionality?

ttgtb

gn

gn

@IvenBach yes

I got some news....

Firstly...Github has adapted new version of Git 2.23 which contains more easier use of commands namely switch and restore. Source: infoq.com/news/2019/08/git-2-23-switch-restore/… and github.blog/2019-08-16-highlights-from-git-2-23

Lastly... Microsoft .net team had finally recognised how challenging managing different repositories and now consolidating their 55 down to 5 and planned to become one. Source: infoq.com/news/2019/08/mcrosoft-consolidate-dotnet-repo/…

Had a chuckle that “...but StackOverflow engineer Nick Craver warned that the cost of contributing to a repo while it is being merged into another may hamper contributions from the community until things settle”

> A unit test that takes 1/10th of a second to run is a slow unit test.

That gives me a benchmark to compare against.

3-5ms now seems like a good speed for unit tests.

@IvenBach Most unit tests for RD are slow and some glacial.

Using the mack parser already pushes most to about 0.2s.

Loading the Excel type library usually pushes the test to a runtime between one and four seconds.

So, if not absolutely necessary, do not load those huge libraries.

[rubberduck-vba/Rubberduck] Cosimo13 starred us

[rubberduck-vba/Rubberduck] SystemsModelling created comment on issue #2912: Error accessing file. Network connection may have been lost.

[rubberduck-vba/Rubberduck] SystemsModelling created comment on issue #3041: Limit which projects get and how much gets parsed.

> Just checking - it's still the case that to suppress parsing addins or indeed any other workbook open at the same time as the workbook under test I need to protect their VBProject with a password?

[rubberduck-vba/Rubberduck] Greedquest created comment on issue #5110: Sunsetting Rubberduck.API?

> Oh shoot, I'm developing something with it right now

[rubberduck-vba/Rubberduck] Greedquest edited comment on issue #5110: Sunsetting Rubberduck.API?

[rubberduck-vba/Rubberduck] Greedquest edited comment on issue #5110: Sunsetting Rubberduck.API?

[rubberduck-vba/Rubberduck] Greedquest opened issue #5111: What are the Reference Settings?

[rubberduck-vba/Rubberduck] Greedquest added label support to issue #5111: What are the Reference Settings?

[rubberduck-vba/Rubberduck] rubberduck203 created comment on issue #5110: Sunsetting Rubberduck.API?

> @Greedquest, may I ask how you’re using the API?

[rubberduck-vba/Rubberduck] bclothier created comment on issue #2912: Error accessing file. Network connection may have been lost.

> Thanks for reporting back! Since this seems to be no longer an issue, I'll close the issue. Your other question seems better addressed in #3041.

[rubberduck-vba/Rubberduck] bclothier closed issue #2912: Error accessing file. Network connection may have been lost.

[rubberduck-vba/Rubberduck] Greedquest created comment on issue #5110: Sunsetting Rubberduck.API?

> @rubberduck203 Just toying around with inheritance, using RD to look at what methods different classes have as an alternative to using interfaces, very much a WIP.

[rubberduck-vba/Rubberduck] bclothier created comment on issue #3333: Do not parse other addins, only the project under test

> Closing this in favor of #3041

[rubberduck-vba/Rubberduck] bclothier closed issue #3333: Do not parse other addins, only the project under test

[rubberduck-vba/Rubberduck] SystemsModelling added label bug to issue #5112: Set var=function() raises incompatible NotAnObject inspection

[rubberduck-vba/Rubberduck] SystemsModelling opened issue #5112: Set var=function() raises incompatible NotAnObject inspection

[rubberduck-vba/Rubberduck] bclothier created comment on issue #3041: Limit which projects get and how much gets parsed.

[rubberduck-vba/Rubberduck] bclothier created comment on issue #5110: Sunsetting Rubberduck.API?

[rubberduck-vba/Rubberduck] Vogel612 created comment on issue #5110: Sunsetting Rubberduck.API?

[rubberduck-vba/Rubberduck] Vogel612 edited issue #5112: Set var=function() raises incompatible NotAnObject inspection

[rubberduck-vba/Rubberduck] Vogel612 added label inspection-false-positive to issue #5112: Set var=function() raises incompatible NotAnObject inspection

[rubberduck-vba/Rubberduck] Vogel612 added label feature-inspections to issue #5112: Set var=function() raises incompatible NotAnObject inspection

[rubberduck-vba/Rubberduck] Vogel612 added label duplicate to issue #3333: Do not parse other addins, only the project under test

[rubberduck-vba/Rubberduck] Vogel612 added label feature-reference-explorer to issue #5111: What are the Reference Settings?

[rubberduck-vba/Rubberduck] Vogel612 added label feature-settings to issue #5111: What are the Reference Settings?

@Duga hmm the history doesn't go back far enough - did anyone ever try taking a CW instance from an internal provider?

Rubberduck.API is a different entry-point

it would need a "separate" configuration root

No, there's an APIProvider class already

it should be able to reference an internal provider that takes the CW-injected instance.

and pass that along. Right?

we don't have any CW in there..

we're newing up our CW in AddIn.cs

Correct, hence the internal provider to link it?

and since we can't guarantee the AddIn is actually run (or loaded) when the API is called from VBA code, we can't rely on it

Yes we definitely want to defer it as much as we can possibly.

BTW, I think it'd be more rather a factory than a provider, really.

[rubberduck-vba/Rubberduck] rubberduck203 created comment on issue #5110: Sunsetting Rubberduck.API?

my suggestion would be to basically ship CW with the API and split the RubberduckIoCInstaller to allow configuring only a part of the dependency graph to expose it via the API

i'm not sure we can actually use CW in a COM visible API

why wouldn't we be able to?

primarily because CW works mainly via ctor-injection

and COM objects cannot have parameterized ctors

the CW would only be responsible for internally wiring up and resolving the parser in the APIProvider

The COM calls will need to take the place of AddIn.cs

so the APIProvider news up its own instance of CW implicitly, resolves the parser, and return it?

yes

or even better: since we're managed, we can cache the resolved parser instance in a Lazy that's accessible to all the API exposed methods

I think that's what I was getting at with my earlier suggestion (only that I didn't mention Lazy, only a provider/factory)

[rubberduck-vba/Rubberduck] bclothier created comment on pull request #4681: Introduce mocking framework

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5112: Set var=function() raises incompatible NotAnObject inspection

> Thanks for reporting this. I will have a look at it tonight.

Hi, guys.

I had an interesting interview yesterday.

that sounds good?

Kind of.

so you've got a new job soon?

I think it's a no-go, though (I'll get to that later).

So, the coding part of the interview was:

- Implement a method that takes an int[] and returns an int of the sum of the items. Linq .Sum() FTW.

- Implement a method that takes a string and returns a string without any duplicated characters.

string.Join("", input.Distinct())

The guy said he'd never seen that solution to the problem before :D

welp

the secone one can be a bit more "non-onelinery" if you require preserving order

not sure whether Distinct does that. it should, though

Then I had to fix a few unit tests, one of which was throwing a divide-by-zero exception. I slapped an [ExpectedException(typeof(DivideByZeroException))] on it, but then he asked me to change the data in the test, which was easy enough.

@Vogel612 Yes, it does.

I noticed immediately they didn't specify that, though. I didn't mention it, but I was prepared.

Then they had a few SQL questions around querying, joining, inserting, updating, etc.

I finished the whole test in time without the internet. They said it was rare for people to finish even with the internet.

One of the unit tests was to sort a list by A, then B. I used ThenBy which was also new to him.

He was extremely interested in Rubberduck VBA, though--he started programming with VBA.

He was much impressed when I told him about the mocking feature.

I did call out that I hadn't worked on it, but that was where the project was at.

that's because it is extremely impressive :)

I know. I can barely believe it myself.

@Hosch250 Nice! Thanks for sharing!

Now for the bad news:

They use TFS. In single-user mode.

So if one person edits (and maybe even opens) a file, nobody else can touch it until they check their work in.

@Hosch250 FWIW, were I the interviewer, I'd have asked you to implement the Distinct() & Sum()` yourself, mainly to demonstrate that you know how to write a method that will at least perform OK. Otherwise, how do I know that you're not just jargon-spewing zombie?

@this LOL, they didn't :D

@Hosch250 Welp, time to bust out the 8 tracks, then.

The guy said it's mainly the choice of someone who's been there 25 years, and they can't get him to agree to switch.

@Hosch250 I assume they're not using the git integration, huh?

No, LOL.

I told him if I accepted the job, I'd run a Git server locally and sync it.

He said "Fine, but don't tell anyone else."

so they don't want to deal with an employee of 25 years not keeping up with the times, huh?

@Hosch250 you don't actually need a server for local git version control

The other thing is, they have a hard deadline of the end of January and want feature development "done" by the end of December.

they shouldn't hire for that deadline right now...

@Vogel612 True, but it basically treats it like one.

And I'm not available until the beginning of November.

like... software management 101: adding people to a late project makes it later

@Vogel612 Oh, no, it's not even started.

@Vogel612 I doubt many people even know about the Mystical ManMonths

I'd be the primary dev on it.

They are finalizing the specs and UI mockups, and want a dev to start ASAP.

Still, 1 month worth of dev from zero in a new environment? That's pushing it, esp. if the project is significant.

if you're only available from november, you're only available from november..

It's a data input form.

To process requests from companies to see things like credit reports, driving records, court records, etc.

They provide data to insurance companies, especially car insurance.

@this FWIW, if I was going to do that, I'd do a foreach loop for the Sum one and just sum them up.

For the second, I'd create a HashSet<char> of what I've seen so far.

Then if I found something that wasn't in there, I'd append it to the string and the hashset. Otherwise, I'd continue.

I did a 6 week contract a while back, hooking up a website to a payment processor. It went OK.

(slightly more complex than it sounds - they didn't own the website source so I had to adapt an existing interface)

@Duga that is a good question. Especially since I think this is the first time I've seen that dialog

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5112: Set var=function() raises incompatible NotAnObject inspection

@this LOL

@Hosch250 If you are only dealing with ASCII characters, a bit mask or even a list might be faster.

Hashing takes time.

@M.Doerner I bet chars hash is just the backing int.

That would actually make sense.

Then, it essentially works like a bit mask.

  public override int GetHashCode() {
      return (int)m_value | ((int)m_value << 16);
  }

Yep.

I have disabled automatic code-inspection on parse. If I manually kick off the inspections, does it force a parse or does it only parse if the code is dirty?

it might actually force a parse, though that should only parse dirty modules, soo ..

Also, If I use a quick fix it does seem to parse, but I'm not sure that it then runs the inspections, which it should, no matter what the auto-run setting is. After all, if I'm working through inspections, I want them updated each time I fix something...

Nope, when I run a quick fix, I'm left with a blank CI window

interesting ..

I'd say that's a good enhancement request

it should boil down to setting a flag when quickfixes request a reparse

I don't think CI & QF are using anything besides normal parser events

which would not be adequate in that case, I think.

meaning, CI has no way of knowing that it was a QF that triggered the reparse

#TIL rummaging in VBA/VB6's private stuff is 4 steps away from dementia and Alzheimer's. Which is probably why you don't hear anymore from original developers who worked on VB*:

@Vogel612 well, I was wrong ... inspection refreshing is triggered by the InspectionResultsViewModel if either the refresh is triggered from the window or the automatic refreshing is enabled

Ugh.

So, my work locked in a work/school account on my computer. I can't remove it (reasonably enough...

Their password reset policy came along, and I reset my password.

I CANNOT get into any Office app now.

welp

It says "Password needed" and pops the box.

I enter my email address, and the box closes.

It's not the password box, but the box to add a new account (I removed the old one to try to fix the issue--before the box would just insta-close before I could put anything in).

The web says the only reliable way to fix it is remove the account and re-add it :(

what about going to the microsoft account apge directly?

@this Online?

I did that, and did sign-out-everywhere.

Didn't help.

Apparently our IT has a solution :D

turning it off then turning it back on?

No, doing the motivactionllc.onmicrosoft.com address.

Then it fails to sign in.

Then you do the "log in with another account" and do the normal one.

Then you restart the apps, and they work :)

Big issue, though.

We do bi-monthly all-employee meetings.

You're supposed to attend, but nothing has happened before if you didn't.

We had one scheduled today at 1PM.

Now we just got an email "MANDATORY all employee meeting at 10AM".

Not sure what in the world is going on.

^^ uh oh...

IKR? That's what QA said...

probably to wish someone a happy birthday

LOL :DDDDD

I wonder...

What if the owner died suddenly?

The president owns 15% and runs the show, but what happens if the 85% owner/CEO died without a clear succession plan?

Or maybe he sold the company.

Last time something like this went out, they had just fired our IT director.

But it was called department by department.

Not full-company.

Somebody big just quit or they're announcing layoffs. Slim possibility they're announcing corporate bonuses.

Nope, bonuses go out at Christmas.

good luck!

I said slim...

Hmmm, idea.

Yay! Today's the day... The window guys are here - new windows all 'round the house.

Our CEO is almost NEVER in.

He's been in every day.

@FreeMan that would just go via email, actually

no use in making a fuss

@Vogel612 sadly, they can't install windows in our house via email.

eh???

true, but you don't need to call a mandatory company wide meeting to tell people there will be new windows put in

@FreeMan But why do you want to install windows in your house? Normally one does that to a computer...

maybe if you were saying that you're replacing all windows with linuxes, but...

We're replacing leaky old Win286 with <adverb of your choice> new Win10.

Actually these windows far pre-date Win286

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5111: What are the Reference Settings?

> IIRC it's paths that are used to track "recent" references; track references not added by Rubberduck would make a reference to a library/project in these paths, added to "recent" refs, even if the reference was added via the VBE's own "add/remove references" dialog.

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5112: Set var=function() raises incompatible NotAnObject inspection

> @MDoerner does it enter the index expression pipeline with Set PT1 = ResultsPT instead of Set PT1 = ResultsPT()? The parentheses shouldn't be needed here, this looks like it could be an edge case.

yippee, it's cowboy-updating-prod-db day

#WhatCouldPossiblyGoWrong

9 minutes :D

I don't know what's more exhilarating. The wait or the actual announcement.

[rubberduck-vba/Rubberduck] daFreeMan added label enhancement to issue #5113: Initiate CI run when a Quick Fix executes and triggers a parse.

[rubberduck-vba/Rubberduck] daFreeMan opened issue #5113: Initiate CI run when a Quick Fix executes and triggers a parse.

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5113: Initiate CI run when a Quick Fix executes and triggers a parse.

> Indeed. Nice catch!

@M.Doerner They do in Excel

@IvenBach Not doubled, yes exact match (aside: is there ever a scenario when non-exact-match is appropriate? I'm struggling to think of one).

Though I do have a filename that begins "--Foo"

@Hosch250 Or the wait to find out what you've found out.

Which would fail in Excel, if it hadn't already failed in the system that produced the CSV file that got sent to me.

@Kaz you have a chain of 57 stores and their historical Fall/Holiday sales, and you want to "cluster" them - "C" stores are doing between average minus half a std.dev and average plus half a std.dev; "B" stores are doing between average plus half std.dev and average plus 2 std.dev; "A" stores are doing better than that, and "A+" stores are your upper outliers - now you have [Store][Sales][Cluster] and lookup/match the [Cluster] column value

with non-exact match, all you need is to sort your lookup table such that the stronger cutoffs are at the bottom

@MathieuGuindon Interesting, I'l have to bear that in mind (though I feel like I'd probably go about getting that result differently).

there's probably different/better ways to do this - but it's how my then-boss taught me 15 years ago :)

although, it's nice having the cutoffs in a lookup table, so you can tweak them directly and see how it affects the distribution of stores per cluster - we were after that "more or less bell curve" distribution :)

seems having one formula to do all that would be... harder to play with

@MathieuGuindon Always ^^

My personal rule is that you're allowed at most 2 formulas per cell. 1 is preferred.

of course when he taught me we were doing everything manually... by the time I left, there was an Excel macro automating most of it

and then you loaded the seasonal buy and it would generate an allocation tool to distribute the units amongs store clusters, using the per-cluster sales budgets to drive everything

[rubberduck-vba/Rubberduck] SystemsModelling created comment on issue #2621: Don't bother reporting no Option Explicit on empty sheets

> I'd like this to be suppressed for EMPTY sheet modules, but enforced if there is any code present.

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #2621: Don't bother reporting no Option Explicit on empty sheets

> Agh, I had a fix for this, but ended up dropping the PR. I wonder if [the commit]( github.com/retailcoder/Rubberduck/commit/…) can be cherry-picked into a new PR.

or, you know, tick the "require variable declarations" box in the VBE settings

[rubberduck-vba/Rubberduck] SmileyFtW created comment on issue #4985: Auto generate Model Code

@Duga would have been nice to export the code files though

@kaz With They do not separate words. I did not mean not visually, but for typographic purposes.

No automatic line wrapping will happen on a non-breaking space.

@MathieuGuindon "It looks like you're writing VBA code without ticking the require variable declarations! Can I help?"

it was already suggested though.

@this That or they've forgotten they ever worked on it.

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5112: Set var=function() raises incompatible NotAnObject inspection

SE go down?

There it goes. Nope

@this Clippy? Is that you?

@Kaz First time ever seeing that kind of behavior where 0 as last argument would error barf when the value is within the list. Good to know.

[rubberduck-vba/Rubberduck] Vogel612 added label feature-inspection-quickfixes to issue #5113: Initiate CI run when a Quick Fix executes and triggers a parse.

@FreeMan I think that's more of a Quacky:

a slightly more sarcastic version of Clippy, it looks like.

I like that!!

He could have Dynamic Snark Levels™ based on how many and what kind of inspections trip. Missing Option Explicit? go easy on the n00b. One Hungarian Notation? go full on abusive! :D

[rubberduck-vba/Rubberduck] MDoerner assigned MDoerner to issue #5112: Set var=function() raises incompatible NotAnObject inspection

Didn't have time for RD last night Mug. I do want to get back to the DependencyProperties for the SearchControl. Maybe Thu/Fri evening?

sure :)

:googly-shiny-eyes: I haz foundz a new VS trick. Shift+Enter will place cursor on line below current one without dropping the rest of the contents onto the next line as well. public string FooBar(string duk|) will leave ) after duk. This will be used extensively. SoMuchHelpful!

huh, that's something RD-AC could do too

not quite AC, but still

I thought RD's AC was inspired by that feature.

@MathieuGuindon Make it so Numbah One!

This may become one of my top favorite keyboard shortcuts.

@IvenBach @M.Doerner If you didn't already know.

@this lol it that was the case it would already be implemented :)

One of my guesses was correct. I can't tell which for another week.

@MathieuGuindon I thought smart-concat feature worked for nonstrings, too?

no, it's actually bailing out if it finds out you're not inside a string literal

right, ignore me then.

@Hosch250 Do tell ... we're all eagerly awaiting!

for some values of all

[rubberduck-vba/Rubberduck] MDoerner created pull request #5114: Hot Fix for Resolver to merge MDoerner/Rubberduck/HotFixFor5112 into rubberduck-vba/Rubberduck/next

Per yesterday, I'm still getting only XML formatted data back when I'm requesting JSON formatting. I've not yet heard back from their tech support on why.

Is there enough similarity in handling the two of them that it's worth investing in starting to work based on XML, then switch to JSON when that becomes available, or am I going to be wasting time going down one rabbit hole only to jump into a different one?

based on the assertions here that JSON is easier/preferred over XML

Is JSON that significantly better that it's worth waiting for a resolution to the issue, or should I just go with XML and call it good enough?

nah. Pepsi v. Coke, basically.

I'd be more interested in what is better supported & easier to work. In VBA's case, that's XML.

In JS's case, that's JSON.

(why JS never had any native XML handling is beyond me...)

While both are overly sweet, Pepsi is way too overly sweet to me, so it does matter. :)

OK. Guess I'll just dig into some XML code & figure it out from there. If they ever get back to me on the JSON issue, maybe I'll do something with it for practice...

Of course, one of the API calls is timing out, so I have to wait for feedback on that one no matter what

@Duga that was fast! recalls that "tonight" in Germany is much earlier than EST #timezones

[rubberduck-vba/Rubberduck] bclothier commented on RubberduckTests/Grammar/ResolverTests.cs of pull request #5114: Hot Fix for Resolver

[rubberduck-vba/Rubberduck] build for commit 49cacb36 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] bclothier commented on RubberduckTests/Grammar/ResolverTests.cs of pull request #5114: Hot Fix for Resolver

[rubberduck-vba/Rubberduck] IvenBach created pull request #5115: Consolidate copy command logic to merge IvenBach/Rubberduck/Issue5109_Consolidate_copy_command_logic into...

rubberduck-vba/Rubberduck/next

> Close #5109. This has some cross-commit contamination from PR #5095.

Paying back what I can one commit at a time.

My commit messages have improved.

@this iced tea

pepsi and coke both leave a nasty bitter aftertaste

            <employee_id>2715</employee_id>
            <staff_screen_name>
                <![CDATA[Nurse]]>
            </staff_screen_name>

Why does one have ![CDATA[]] and the other doesn't

does that indicate string data?

seems to be the case based on evidence of what I'm seeing in the data.

I guess they were worried that there'd be funky stuff in names and they don't want to have to deal with malformed XML

e.g. Mr. & Mrs. would need to be encoded as Mr. & Mrs.. With a CDATA, no change is needed.

which may also indicate that they aren't using XML library, and is doing it by hand.

But gosh, they better hope that there's no poor soul named ]]>

lol

[rubberduck-vba/Rubberduck] build for commit 9227d594 on unknown branch: AppVeyor build succeeded

holy mother of goto-jumping white rabbit

@MathieuGuindon at least he didn't use GoSub...Return?

years ago, I ran across a random guy who actually argued that it was better to use GoSub.

@this shhhh, don't give 'em ideas!

[rubberduck-vba/Rubberduck] MDoerner commented on RubberduckTests/Grammar/ResolverTests.cs of pull request #5114: Hot Fix for Resolver

#StoleIt

come to think of it, I wonder what happens if you GoSub, then GoTo out of the section. then GoSub again or do a Return...

#ThunderCode

@MathieuGuindon Never was mine to begin with. You're welcome to all of my bad ideas. :-p

uh, more like #SpaghettiCode, quite literally!