VBA Rubberducking - 2019-06-02

« first day (1822 days earlier) ← previous day next day → last day (1358 days later) »

12:01 AM

RELOAD!

[rubberduck-vba/Rubberduck] 1 closed issue. 4 issue comments.

[Minesweeper] New Users: 17, Games Played: 96, Bombs Used: 54, Moves Performed: 10725

19 hours later…

6:46 PM

[rubberduck-vba/Rubberduck] Vogel612 merged pull request #4938: SettingsProvider smoothing from Vogel612/Rubberduck/fix/persistence-debt-downpayment into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] Vogel612 pushed commit 15896d99 to next: Replace inappropriate Persister references with ConfigurationService

[rubberduck-vba/Rubberduck] Vogel612 pushed commit 09c8bc3d to next

Overhaul IConfigurationService and IPersistenceService API

This also adjusts how the specific File of the two XML persister implementations is
specified while facilitating code reuse

[rubberduck-vba/Rubberduck] Vogel612 pushed commit 61fd569e to next: Set up IoC registration to provide Default settings

[rubberduck-vba/Rubberduck] Vogel612 pushed commit 7d9d6c2a to next: Correct Docstring for IPersistenceService

[rubberduck-vba/Rubberduck] web-flow pushed commit acf3ff18 to next: Merge branch 'next' into fix/persistence-debt-downpayment

[rubberduck-vba/Rubberduck] Vogel612 pushed commit 2b2eb3a7 to next: Fix compilation issues stemming from incorrect conflict resolution

[rubberduck-vba/Rubberduck] web-flow pushed commit cfecdabc to next

SettingsProvider smoothing (#4938)

SettingsProvider smoothing

[rubberduck-vba/Rubberduck] build for commit cfecdabc on next: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] Vogel612 created comment on pull request #4963: Added ExcelHotKeyAnnotation Class

> Hey there, I'm currently working on getting Rubberduck ready for Release. Could you please get back to me about when / whether you can fix the comments given by MDoerner and the failing unit test?

If not, I'm happy to take this across the finish line with your approval. Thanks!

@IvenBach hey there, what's the status wrt the comment(s) I added to your "Test Explorer filtering" PR?

Mathieu Guindon

@Duga rebuilding

we really need to get some more of the currently open PRs merged

I dislike that I pulled the trigger on mine, but I marked it for review and didn't get any comments for quite a while.

The issues it enables us to adress are too big for me to tackle anytime soon, unfortunately...

[rubberduck-vba/Rubberduck] Vogel612 created label heisenbug

[rubberduck-vba/Rubberduck] Vogel612 added label bug to issue #4858: RD misbehaving with VBIDE on opening VBIDE

[rubberduck-vba/Rubberduck] Vogel612 added label heisenbug to issue #4858: RD misbehaving with VBIDE on opening VBIDE

[rubberduck-vba/Rubberduck] Vogel612 added label discussion to issue #4670: Mocking framework architecture & discussion

[rubberduck-vba/Rubberduck] Vogel612 added label bug to issue #4684: Code inspections are not finding unused variables inside subs/functions

Mathieu Guindon

@Vogel612 looked good to me, I should have asked if it was ready to merge... sorry :/

7:00 PM

[rubberduck-vba/Rubberduck] Vogel612 added label feature-inspections to issue #4684: Code inspections are not finding unused variables inside subs/functions

no worries :)

[rubberduck-vba/Rubberduck] Vogel612 created label inspection-false-negative

[rubberduck-vba/Rubberduck] Vogel612 added label inspection-false-negative to issue #4684: Code inspections are not finding unused variables inside subs/functions

@Duga I kind of want to close all issues that are heisenbugs ...

@M.Doerner is the PR-Status label on the "Cache user COM projects (infrastructure)" PR up to date?

[rubberduck-vba/Rubberduck] Vogel612 edited label inspection-false-positive

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.4.1.4728

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.4.1.4728

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.4.1.4728

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.4.1.4728

[rubberduck-vba/Rubberduck] build for commit cfecdabc on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Vogel612 added label bug to issue #4766: Code explorer cutting off search icon

[rubberduck-vba/Rubberduck] Vogel612 added label user-interface to issue #4766: Code explorer cutting off search icon

7:15 PM

@Vogel612 haven’t made time for them.

[rubberduck-vba/Rubberduck] Vogel612 added label enhancement to issue #4709: Suggestion: Find / List VBA Breakpoints?

[rubberduck-vba/Rubberduck] Vogel612 added label status-declined to issue #4709: Suggestion: Find / List VBA Breakpoints?

@IvenBach okay cool :)

sidenote: I'll turn off labelling notifications for a bit..

I'll be mass-classifying closed issues without labels for a bit

unfortunately that also turns off notifications for everything else relating to issues directly, which is a fcking pain

So little time for RD dev.

It makes sense why Mug stays up so late to get his coding time in.

7:42 PM

@Vogel612 Is a heisenbug a bug that can't be observed?

it's one where the repro is only probabilistic... sooo basically, yes

down to below 100 unlabelled issues

github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Core/… Has a callback. Is that used by the client/callin code to update the dependency property?

that specific callback is used to update the UI state when the language changes

so we don't have explcit calling code for it, but the XAML should define a callback in the binding, IIRC

note: not the SearchBox.xaml, but the xaml that instantiates / uses the SearchBox

TBQH I don't really grasp it that well myself

Mkay. I think I’ve understood what’s written then well enough.

67 issues left

"Open All" from Github refined is a lifesaver

7:57 PM

@Vogel612 UI invalidation I’m not fully clear on. Does it seem inappropriate because all the UI doesn’t need to be updated?

I don't quite follow?

github.com/rubberduck-vba/Rubberduck/pull/…

ah ... right.

the issue is that the Filter itself does not change the Tests backing collection

so it shouldn't raise a PropertyChanged event for it

now if you remove that line, does the filtering still work?

Since it’s only filtering, and not actually changing the contents.

exactly

if it doesn't, I'd add a comment, stating that removing it breaks the filtering behaviour, but I'm pretty sure it's not necessary

May 15 at 18:57, by Vogel612

@IvenBach I think the ICollectionView Tests should be modified in the constructor not only to have SortDescriptions but also FilterProperties. That should change the way you wire up the filtering a bit...

8:02 PM

I don’t remember if it’s explicitly needed or not. I think it is but either way I’ll explicitly check and add a comment as to why it’s there if required.

^^ I also rambled a bit in chat

These are all things I’m playing with and don’t fully understand so yeah...

If you want to look into what I dug up, feel free (not that I fully understand them either).

if you don't want to look into them ... well I guess we just need a WPF expert to show up and fix/do the UI for us ;D

There’s bound to be improvements in any code I write. Future-Iven may be the one that does the rewrite. Who knows.

[rubberduck-vba/RubberduckWeb] rubberduck203 opened issue #68: Website should have a favicon and title

> > Name
> Justin Dearing
> Email
> [redacted]
> Subject
> I suggest making your title tags say "Rubberduck - "
> Message
> Having a tab with no favico and the title Home makes me unable to know whats in this tab on my browser without clicking on it. Can you change e.g. Home to "Rubberduck - Home" and so on. Also, can you make the ribberduck icon the favicon.ico?

8:08 PM

yeah yeah...

I moved that over..

and it's closed :D

8:21 PM

@Vogel612 The labels on my PR are up to date. I do not intend to do anything further in that PR unless I get more review comments.

Aight, I'll be merging it in a few minutes

@MathieuGuindon @this speak now or forever remain silent: I'll be merging github.com/rubberduck-vba/Rubberduck/pull/4535

Mathieu Guindon

@Vogel612 go ahead =)

[rubberduck-vba/Rubberduck] Vogel612 merged pull request #4535: Cache user COM projects (infrastructure) from MDoerner/Rubberduck/CacheUserComProjects into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] Vogel612 pushed 29 commits to next (only showing some of them below)

[rubberduck-vba/Rubberduck] web-flow pushed commit 254961ae to next

Merge pull request #3 from bclothier/CacheUserComProjects

Prevent null exceptions from VBA class typeLibs for UserForms

[rubberduck-vba/Rubberduck] MDoerner pushed commit e5029be2 to next

Merge branch 'next' into CacheUserComProjects

# Conflicts:
# Rubberduck.Parsing/ComReflection/ReferencedDeclarationsCollector.cs

[rubberduck-vba/Rubberduck] MDoerner pushed commit 76877554 to next: Merge branch 'next' into CacheUserComProjects

[rubberduck-vba/Rubberduck] MDoerner pushed commit b57c05ab to next: Merge branch 'next' into CacheUserComProjects

[rubberduck-vba/Rubberduck] MDoerner pushed commit 034e80cb to next: Only load and process user com projects if LOAD_USER_COM_PROJECTS is set

[rubberduck-vba/Rubberduck] MDoerner pushed commit 0eb4f71b to next: Make minor refactoring to address comments to PR #4535

[rubberduck-vba/Rubberduck] MDoerner pushed commit 38dab3df to next: Refactor further to address comments to PR #4535 by Vogel612

[rubberduck-vba/Rubberduck] MDoerner pushed commit 61ba7dd8 to next: Merge branch 'next' into CacheUserComProjects

[rubberduck-vba/Rubberduck] MDoerner pushed commit 6a23b640 to next: Merge branch 'next' into CacheUserComProjects

[rubberduck-vba/Rubberduck] web-flow pushed commit 99e90943 to next

Cache user COM projects (infrastructure) (#4535)

Cache user COM projects (infrastructure)

Co-authored-by: this <bgclothier@gmail.com>

user image

[rubberduck-vba/Rubberduck] Vogel612 assigned Vogel612 to issue #4684: Code inspections are not finding unused variables inside subs/functions

8:34 PM

good... reinstating the issues hook worked

@Vogel612 most of the issues assigned to me are kinda large and beyond what I can easily push in between Uni work ...

oh well. They're not running away :)

8:48 PM

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #3004: VBA-Dependency overview

> Note that we already collect which module depends on which other module in the ModuleToModuleReferenceManager.

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.4.1.4729

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.4.1.4729

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.4.1.4729

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.4.1.4729

[rubberduck-vba/Rubberduck] build for commit 99e90943 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Vogel612 created comment on issue #4684: Code inspections are not finding unused variables inside subs/functions

> I can not reproduce this off the current next with the code you graciously made available. I assume this has been fixed at some point prior to me rechecking this.

[rubberduck-vba/Rubberduck] Vogel612 closed issue #4684: Code inspections are not finding unused variables inside subs/functions

[rubberduck-vba/Rubberduck] Vogel612 added label stale to issue #4684: Code inspections are not finding unused variables inside subs/functions

9:48 PM

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ImplicitByRefParameterInspection

10:06 PM

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ImplicitPublicMemberInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ImplicitVariantReturnTypeInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ModuleOptionsNotSpecifiedFirstInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ParameterNotUsedInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page UnassignedVariableUsageInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page VariableTypeNotDeclaredInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ParameterCanBeByValInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page OptionExplicitInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page OptionBaseInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ObsoleteTypeHintInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ObsoleteLetStatementInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ObsoleteCommentSyntaxInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page ObsoleteCallStatementInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page NonReturningFunctionInspection

[rubberduck-vba/Rubberduck] MDoerner edited wiki page MultipleDeclarationsInspection

^ ### requires a space following it in order to be recognized correctly.

10:25 PM

yeap. That's violating the "standard"

insofar as there is something like that for markdown in the first place

[rubberduck-vba/Rubberduck] Vogel612 assigned Vogel612 to issue #4980: Code Inspection doesn't see anything yet

11:02 PM

@this Status update on my leaderboard thing you helped me with (the no-SQL db thing we discussed).

I have it working, and I can load 24k rows with 4 columns each and calculate a fifth column off the other columns in the upload in less than 1 second.

I can retrieve the data in an aggregated format and a raw data dump in 1.2 seconds.

« first day (1822 days earlier) ← previous day next day → last day (1358 days later) »

Transcript for

Jun '192

VBA Rubberducking

This chat has moved to Discord: discord.gg/MYX9RECenJ

antlr com-interop parsing rubberduck vb6 vba whiskey-tango-foxtrot

join this room
about this room

00:00

06:00

12:00

18:00

all times are UTC

site design / logo © 2024 Stack Exchange Inc; legal

mobile