> CodeExplorerTests.Count += 253 This also fixes (or greatly mitigates) an unrelated issue I stumbled across when I was live testing in Excel - there's apparently a race condition between the parser state and the disabling of the refresh button in response to the EvaluateCanExecute binding on the ReparseCommand. You could occasionally get it to execute while the parser was busy by mashing repeatedly on the refresh button in the CE. It's possible this is also an issue with other UI linked...
commands that check the parser state in their EvaluateCanExecute function.
Version 2.3.1.4445 OS: Microsoft Windows NT 10.0.17763.0, x64 Host Product: Microsoft Office x64 Host Version: 16.0.11126.20266 Host Executable: WINWORD.EXE
**Description** Dim my_fso As Scripting.FileSystemObject Set my_fso = New Scripting.FileSystemObject <code which uses my_fso for checking date modified of files> Set my_fso = Nothing
The code inspection result is 'Assignment not used' The code line highlighted is 'Set my_fso = Nothing'
if display name is all it needs, why not cache the string?
I would prefer that classes like declarations or QMNs do not actually tote any SCWs but rather have a method to retrieve a SCW at the time it is needed.
@this the redirect was just a "temp" thing - in a dream world all calls to RPS.AllUserDeclarations should be rewritten to query the declarations finder instead, so that the RPS obsolete method can be ultimately removed - yeah, it's [Obsolete]
@M.Doerner I think I'm missing something. The provider uses a ReferencePriorityMap which is a Dictionary<string, int> where the string is the ProjectId while the int represents the priority... but it does not tell me what the reference is actually?
then the unused assignment should be the = New Thing, not the = Nothing
but it is used though
Dim my_fso As Scripting.FileSystemObject
Set my_fso = New Scripting.FileSystemObject
<code which uses my_fso for checking date modified of files>
Set my_fso = Nothing
the point is, an object is created, then used, and then set to nothing - the inspection is complaining that the "set to nothing" assignment isn't used, and IMO the OP is correct in that this inspection shoudn't be tripped. Using the Nothing assignment would be RTE91.
now whether the Nothing assignment is needed or not, is another question
IMO OP is correct, AssignmentNotUsed shouldn't issue a result when an unused assignment is Nothing - BUT we could conceivably have another inspection that flags these assignments as redundant, with a QF that removes it
would be nice if the inspection could figure out whether the object is local; if it is then another QF could be offered, to ditch the variable and replace its refs with a With block
@MathieuGuindon I don't think that should be too hard. We already have a couple inspection that determine whether the object is passed in via a parameter.
I'm using RubberDuck to test an Excel Workbook, and Excel crashes when running the RubberDuck test.
A sheet in the workbook contains a Worksheet_Change event that prompts the user for a password when changing a particular cell. If the user enters the correct password, a MsgBox saying "Correct P...
> **Rubberduck version information** The info below can be copy-paste-completed from the first lines of Rubberduck's Log or the About box:
Rubberduck version 2.3.0.4227 loading: Operating System: Microsoft Windows NT 10.0.17763.0 x64 Host Product: Microsoft Office x64 Host Version: 16.0.11029.20108 Host Executable: EXCEL.EXE;
**Description**
I'm using RubberDuck to test an Excel Workbook, and Excel crashes when running the RubberDuck test.
> 2019-01-20 10:18:44.7753;WARN-2.3.0.4227;Rubberduck.Inspections.Rubberduck.Inspections.Inspector;System.NullReferenceException: Object reference not set to an instance of an object. ... 2019-01-20 10:18:46.3588;INFO-2.3.0.4227;Rubberduck.Parsing.VBA.RubberduckParserState;RubberduckParserState (9) is invoking StateChanged (Busy);
Is it possible that the inspections are still running?
I think normally we get message Inspections ran for {N} seconds when it has finished inspections, no?
> Thanks for reporting; for the record the SO question was fine too =)
The `Fakes` API objects are meant to be very short-lived, i.e. the duration of a single test. Here they're alive from before the first test runs, until after the last test finished.
These are hooks into the VBA runtime, intercepting internal function calls: them being alive for longer than they're needed is definitely not helping.
Another thing is the very nature of the test itself: unit testing isolates functionalit
2019-01-20 12:48:35.5587;TRACE-2.3.1.22570;Rubberduck.Common.Hotkeys.Hotkey;Hotkey for the associated command Rubberduck.UI.Command.TestExplorerCommand was registered with id 49256;
2019-01-20 12:48:35.6039;ERROR-2.3.1.22570;Rubberduck.UnitTesting.TestEngine;Unexpected COM exception while initializing tests for module VBAProject.TestModule2. The module will be skipped.;System.Runtime.InteropServices.COMException (0x800A9C68): Exception from HRESULT: 0x800A9C68
at Rubberduck.VBEditor.ComManagement.TypeLibsSupport.IDispatchHelper.Invoke(IDispatch obj, Int32 memberId, InvokeKind invokeKind,…
Note that I was able to catch that while the parser was running.
I think not reporting an assignment of Nothing in AssignmentNotUsed would only be consistsnet. In VariableNotUsed we also ignore assignments of Nothing.
Btw, there are legitimate uses of an assignment of Nothing, e.g. when breaking open a reference cycle.
I'm working on fleshing out the the unit tests now, but I should be done by tonight. Agreed that it needs more "live" testing though. AFAICT we've only had one real "victim" so far.
yes, but i was not seeing how to map the project declaration to the priority from the dictionary
but if the projectid is actually the external library's projectid, rather than vba project's then i would be able to use the projectid from the project declaration, right?
> This PR closes #4719. This is a redesign of the ParameterCanBeByValInspection, which was implemented in a confusing way. Now, the parts for interfaces and events use the same base logic to determin whether a parameter of an individual member could be passed by value. This logic also has been redesigned heavily. Now, it really looks at the references to the parameter and evaluates whether these references correspond to assignments or ByRef parameters. This PR also fixes that the...
inspection ignored that in VBA an implemented interface can have an implementation of its own.
I'm using RubberDuck to test an Excel Workbook, and Excel crashes when running the RubberDuck test.
A sheet in the workbook contains a Worksheet_Change event that prompts the user for a password when changing a particular cell. If the user enters the correct password, a MsgBox saying "Correct P...
VBA Rubberducking
VBA Rubberducking